From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A30D444101; Wed, 29 May 2024 13:40:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F56740649; Wed, 29 May 2024 13:40:43 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 4CEE2402B9 for ; Wed, 29 May 2024 13:40:41 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44T9QjU3015558; Wed, 29 May 2024 04:40:39 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ye1r10cmd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 May 2024 04:40:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fDlm5Q44+iCdPDrZDGy32zIk/I7pWpvZUNeuMIS0J2rCSPpiXU+38J0a5OqgmIL96Xcd5QcW+01JwXh7U2XuVsFIksNlh+Zi1EO9fISI1O0yA0ntgPlndcQAKM3t22O76S0L2Virhjh3S8sCV2zqJrZcMMKH/RJgvu2EnlYkJsLLvEs6iKISx2pMyFxHfHkTOHSM29vVr3Ah/gXEyo2hKP5cwZk824eTqn8kyx9/IyXMiTjF6w6qJKizdTCWq2Xcn4hu5gZhhrNGTRlsAubRYcJ4sOGhDfcNGymwplTDf9N0rDiPFo7KNHBR6OgVboqAk0+QH0uz6STP1ijqI5WJNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nE1KE9DZm6Cse8XesKm1DeZuStDU+/sTykNWBQxJJJw=; b=Tjbe5RXhC7EhycjN/NXIdUWv16wGqPs5WKTii9BwtGKL+zQUvh28T7LHnRKV38LNxVYGBl0IeuG7kHZhHTazWD0R4qKiSSIBWepp1iSyiYovuwgzLo67Om0pY/CxJm4bdeDTI6nZ9G4ii/wCQ8JyB8LyNrCVfiABdyKqPGyhSN/jEJkwqnoQme7ipgK17mA+VOU+XfCtCkmu/QLGzA7g2rns9mxcRxzWOl8K3zROJE3dgxRv0aCh7OSMRnC1tgmYr+5KEfJ9go4ifLCbOFnCCsejRliWPgAOHvUDftWCz31fuTbeJb+AM9R+YkaWw2WPLzYOD+AZyxrLp7NjtrWgRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nE1KE9DZm6Cse8XesKm1DeZuStDU+/sTykNWBQxJJJw=; b=f/cXtFyZ4VHtcorD6F3XZQt7rwdInKjOBC3GEtGTT+RLD6/qNcXUcWdwAMbSmwUVt7BAivCCU/wdL3t1y7top2L4cRA2ywZ6fzjuw6Koh4pEgnUzQUF4+D9CO3B+1R9LEoHGvJtFsn4JhMPqZZOKs15ca2ro8lY5y0dNojyL/kY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MN6PR18MB5444.namprd18.prod.outlook.com (2603:10b6:208:47b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Wed, 29 May 2024 11:40:36 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d%4]) with mapi id 15.20.7611.030; Wed, 29 May 2024 11:40:36 +0000 From: Akhil Goyal To: "Kundapura, Ganapati" , "dev@dpdk.org" , Ferruh Yigit , "thomas@monjalon.net" , "Richardson, Bruce" CC: "Gujjar, Abhinandan S" , "ciara.power@intel.com" , "fanzhang.oss@gmail.com" Subject: RE: [EXTERNAL] [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined Thread-Topic: [EXTERNAL] [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined Thread-Index: AQHaj9XTIO40MUrBWka2XFvYjOzk6bGuJHyQgAAZK4CAABwbcA== Date: Wed, 29 May 2024 11:40:36 +0000 Message-ID: References: <20240416081222.3002268-1-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|MN6PR18MB5444:EE_ x-ms-office365-filtering-correlation-id: 7102394d-1e76-468c-9ce1-08dc7fd42828 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?ZSLRg7L5zMCqSxNT2DPlWOrkJN5XzKU2f1cFPNydLVwEAmD3BrILn+tMA+9I?= =?us-ascii?Q?YiBKRJoOZFaxyHtGRKwzXZeKr8iB+sEETdoQanxAe3vyWLIlGiUx8EKWPcyQ?= =?us-ascii?Q?bTselWU0WOwGkjFUTAYqbF2X8SB/ahD7tfmtKdDL5Dhm5r6/dtbf7j8mnAwW?= =?us-ascii?Q?RRrp1zRElsoiwl0d70ShCeqXeEm2/kd0leiN4Ai4uwmFE1KTEvONNccnLh2y?= =?us-ascii?Q?RhbvbxPGamh72K1WqXS00birsl367CH6vycbtx7nnSVR9+O5mGrUvgHmJn3T?= =?us-ascii?Q?Ho98wwlsbUrv4ANf7uXj70RbUUIWIYaIrSbFU8Vr6JKV108phKkKk4aNwPnI?= =?us-ascii?Q?LK/t5oWEdWV5FGRSuiGM9VFVcC1tr7Xd7sDs6YeE+TjHfnZ5GpuFoIwV8p5C?= =?us-ascii?Q?oVgiMX64w15Tpc0wSumgoaCpg8xhKQWJKuUYu2rzLSuW1cL6zJUq833vjMLp?= =?us-ascii?Q?NxkLvSYuLUcJrv1IVjk5ep8srU9qogGlt9T3ZBlDsPa1x1PYBGXlnFC0Uayt?= =?us-ascii?Q?uyrG9rcdYaWAKjl+6+4NTIr93tpS2vNnX2olw2euXFYmZc6vjhk0YNQk3iz1?= =?us-ascii?Q?hqe/QVmX377dUyaiEkmeUdy1pAGTDwJ2QBVi60SIlTGuaj7XCLguokxiruTU?= =?us-ascii?Q?mMAtAm1qQFEYZJ8dIeFnx7C+WWtB/fUoDvw1hyOrr0hEYcSGWfd3hNxCgKl9?= =?us-ascii?Q?5eqKwCkoAOvIRl+bqqP9/xZsMzwSckjtCjG4hntqUoqqiezV8OSjCENmmw0d?= =?us-ascii?Q?qh3koDY+9jVYB8v1Zwqc+jFfg2xgXVBK7AHs9yvYL2QAPs9szoIRbMpaTLYx?= =?us-ascii?Q?aF+txzOnmnEUPwP0B8Qm/2Q2sM63zSGxRlYd4Ve78+xuOoPM4z5lpQt3O2Iu?= =?us-ascii?Q?JlMRfA6V+OUNMJYg4hlJxBo2cXQlmfQpuxgfc4zC7wWiMj8gvwxrJqM6hFtH?= =?us-ascii?Q?rXzKegNMhvLjNQ95uRMvxp64Jl+Qo0AMnLADHGHjErMD/cnjtfbC94BNNW/S?= =?us-ascii?Q?kY1k68CQ8pUosSXGwkhhmxBD9k0GrOWv/H3ieRrK41TbSdcv2HVHxnRlZN8F?= =?us-ascii?Q?lWSvTDA/aoL3mheKWoYASBN+S6F1K9q62ik1Bz5M/5sKlRSzD1QNCnqCIhW0?= =?us-ascii?Q?CN4m8cLTF/O9cCzsWWC6ZFQ51PYlipYQDThgKGm/mwUHFM0vnyjPXToq5bbp?= =?us-ascii?Q?9f0KeFa2uOjYW+51QlDkKVvB6OqdP2VZo/Fp6iEzKU30x3Jr6uFusdYZ4NkF?= =?us-ascii?Q?6nI8CsU8Mx4a/3XMXLP1hfJ3F42McWQa06Dvoxiprp/hQ2cjU3zLJlb2s5So?= =?us-ascii?Q?ZXzDiHtj+uWlwoWQLOy7EDUEATKnFbxP2g56KIhVo+XMIw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SEBJfDcufDSdxFwbvZqPG5HRzh5a/sYBcgMHv/FFbL0clELq/AMAXt85i6qN?= =?us-ascii?Q?4pUBWvF4fsvxHnpF3PJNNzerM5xXZ0qJ0mbGflmYC9JFecYWabrjLF+ZWDPY?= =?us-ascii?Q?63dM86rQPELYsDcScmBX3xkfjOBCYqLlpnkR8BUijFs4yK4dWrHvzLiuJ2Ut?= =?us-ascii?Q?rw+bI27ogUwEQgdfiFGLYaH8NqMTKlDSF8NK0/Pun2NpHh7txsLrB4E8ZCEa?= =?us-ascii?Q?6zxtwcKTLbf/eg5/DypdOc4otCmysU6AGYakW5iCH9cLi1V/bCrcF4gUlvAS?= =?us-ascii?Q?w/HE7Uyj9Oi31j/PPTDZUPKktj4bCLmN66X3Yu4rIIi7YyQQmyxLL0Vmd85r?= =?us-ascii?Q?4IYmlb7NvhX5G3RPuCxxYLFq9omZU5eNpCIopXNkmLEC6H5Xozx0X/0CYjyk?= =?us-ascii?Q?OGRdzrDpZnQL6pcwKm5UuHBF/EfI4UcgmfX9kOy1Sd72DJbM4AZxsHbQfmih?= =?us-ascii?Q?XY/SHSbt/Oyh4+hW1YeXQR9sz3rTFQs2zLjNbrBEZ+hC3Byz6cpLGc6n6gTv?= =?us-ascii?Q?DpY3ubZAVsAvdhMWqoaG8+Gq3ZpNUcsxA91IFb/LG7RjGveAOQEfnXOH5k9A?= =?us-ascii?Q?kdZTlE1/AVMtOL104ctETcOAHfTSmkCM0XHfpFqUDtyjb+4V1+08h81JJF8f?= =?us-ascii?Q?xJD724HB6BkxownK+8jWekom9m0QBlsqFIPk1O1RiROE/bseKwWRoEXHHJUE?= =?us-ascii?Q?dmp6qcH4x9FhRyeSsMFsbEJ/J5ODs5CID2m2+DcCbfUlPvjADtWhbGtTPRmk?= =?us-ascii?Q?dzFw4FvgU6TCv8+DmbqvFWbH4Hx8caLG+JXLqQJ05W7o4AleFq2o3XS09dS4?= =?us-ascii?Q?0RjRkkDBidlFbVYHETFAIfGDIHsbvRU3hetaFvEbrTD1V0hSK8Wu7TYKriwK?= =?us-ascii?Q?PQKIPL8MwqwZ8vtPULl2w4va+B/kHK2R5Ym/iqquCb7mZZx6xTOALP9qzDNf?= =?us-ascii?Q?mWdDTtVtys6YU2nTzpfRs4mfa+qOzh+7qMLJCy0oDUs0J1+UfcEe4vI5ngEY?= =?us-ascii?Q?1KMZ8SpVaW4WbLv95geOjctOdB4qoz4CRShrCNv3X4QYa7x+TRrwUznOlGJo?= =?us-ascii?Q?7vDztQRUKQ1THir+rEvhf8fwRznzN1+XbHiynWM+o7UkJ/q1Z8gm04CqYUqD?= =?us-ascii?Q?yeSKJw06qKdlrMzhV6MPhsu+moZauKN4CDfRBd1g1V4SgYOieqIJCPzft/Ww?= =?us-ascii?Q?q+yVrjEt3WbwNXxxJ/Npj6qpqn+6yb+b7s2oBTwC+P9Om4kA3rw5PBJEEtRL?= =?us-ascii?Q?GergFabJHobgcOMzB8oGbYzgVB4jZwE66oLxMr5PDY54HX1k0qg1PS6q9UGb?= =?us-ascii?Q?aPqQam+uAEF3uakxu+M0FSmVccYYdMxqeLm010nY4ofnYqQqUKFsxTBgpgqt?= =?us-ascii?Q?DAcqILYsupCctFzs9o0CORGOz3KW05PLCs+s81OaoBNeIuXPCTqG1IfD7+ns?= =?us-ascii?Q?/k2zJJBU1whmEuxbMxrMAcb2aOWhwDuT02NhQ3FxZBCMrgVzYlVDFutrTfwk?= =?us-ascii?Q?aoSvYTRlhdOkFl73+F0x+D5Z5hwXB52B3GHHf463ydo9CuMZnK2udVtbDDM7?= =?us-ascii?Q?mM0sSLe/cockXK3OjAdaLsY96fmvGNmltF/qNAXE?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7102394d-1e76-468c-9ce1-08dc7fd42828 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 11:40:36.2993 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jGqktE9NNaTlEseOuoYBdGoDGMgwxgqSNJw8VvWvUgWtrB4XI9j1EQvT6qI2zAuv0aBAeTUFYLwQYPoz5F1kTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR18MB5444 X-Proofpoint-ORIG-GUID: worU0h1TlMTgD3BKf470eAFMqE09KKar X-Proofpoint-GUID: worU0h1TlMTgD3BKf470eAFMqE09KKar X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-29_07,2024-05-28_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Subject: RE: [EXTERNAL] [PATCH v1] crypto: fix build issues on crypto c= allbacks > > macro undefined > > > > > Crypto callbacks macro is defined with value 1 and being used with > > > ifdef, on config value is changed to 0 to disable, crypto callback > > > changes still being compiled. > > > > I believe we can use #if instead of ifdefs. > > It seems convenient to enable/disable in my opinion. > > We can use both, but whatever we use should be same as that for ethdev > > callbacks. > > > Using #if requires check for equality like > #if RTE_CRYPTO_CALLBACKS =3D=3D 1 for a macro defined with value 1 No If it is set as 0, it will be disabled, else for any other value it will be= enabled. No need for check. Right? >=20 > > The same issue would be for ethdev callbacks too. > > Ferruh, can you check?