From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 320B9A00BE; Tue, 19 Apr 2022 12:14:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0A634068E; Tue, 19 Apr 2022 12:14:11 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 391D540687 for ; Tue, 19 Apr 2022 12:14:10 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23J7Y9F7003034; Tue, 19 Apr 2022 03:14:09 -0700 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2047.outbound.protection.outlook.com [104.47.57.47]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fhemwtm4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Apr 2022 03:14:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GkMFwgH4WH13qRzw5bOktQVfeDyoq3qx1dLFuWtAb1Ez7mmk94IOZDa61iX9NMZI5Lc7Ztd/cd3dzmIJtkg4PYmyoaZxWI+TIFklWjI702rCxNefEnFoz0b+bYfVdKkOOWf9vyRyLxht4KQSGHO01YOd4RUOvGraOJdHIegDbqFfiCIqJ4p8fg27Dm5CxlQOlUpAHpx5H7vLrWi1w5hneXPp8TolD8vwee5u+90x2bWGy8cb68fkpFQZx/r90FPchHxEKVW1drUzy6QCd+ONLnla6zS6JlgC6IVYWYwxFrmoF/M/CCguaHTKmio7AMeOI1EZRJOI0/z3HrFW3nlbNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RbOFCvajL43UhApPkIeSUDtNnetlzuGhht8f8ZSCEqM=; b=IeoDt6jWP8Dj+swRRgtS9wJxtPJujXmGgLp8rbRbdOXOQ/6NArepT3F2AJh1/pS5RjTwFjel4TD6am+JTP+XNRI/zsz+fHTdiLqD/aV4SIw5vR/5n3tAB2A4Tj8EjuF0eiIEXR1GjhBkwKzfX8HcSydM8WxhCg2zeUGGbvTONlWWLkkx8RSleI4Jz8xF+lH7aWQbUqx/QGO8w5StjTI3fp0gz8c3PE92YCA2tsVGvtYWcyz1H6tBHF5wfIqEqO4r4Scgk7clJJhkWggrCfqbSTjw3ksSrvR7rj104CJRFIe1ZTWZ9g2UYeAn02e4M/Jr6uMD4HtdgWzJH9XTQXyHIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RbOFCvajL43UhApPkIeSUDtNnetlzuGhht8f8ZSCEqM=; b=N5zQtydtglJNNcQ5YanzLIa7OxpSGznASXoK8AUDNvCp51iBmiP2njZMC8lKgH6NVH0agPiTbbBuFUEgzxVSjlIug7ZH/Te0dUQBdmO8iGExM/98ctSNYm0RtQnMYiDTGF18THkdI3DLAQGOCfcPB+PB6gRHNf+fDsbFr137CZo= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SN4PR18MB4987.namprd18.prod.outlook.com (2603:10b6:806:21b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 10:14:06 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338%6]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022 10:14:06 +0000 From: Akhil Goyal To: Thomas Monjalon CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "konstantin.ananyev@intel.com" , "ciara.power@intel.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru Subject: RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Thread-Topic: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Thread-Index: AQHYU8uwM2cgSOHVbk6YmCEbondN/qz2/x5g Date: Tue, 19 Apr 2022 10:14:06 +0000 Message-ID: References: <20220217172341.607360-1-gakhil@marvell.com> <20220416192530.173895-1-gakhil@marvell.com> <20220416192530.173895-8-gakhil@marvell.com> <11961195.O9o76ZdvQC@thomas> In-Reply-To: <11961195.O9o76ZdvQC@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76269b42-3621-4cfb-9216-08da21ed5635 x-ms-traffictypediagnostic: SN4PR18MB4987:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bBGtl931AaPoG83mMA16zNEpMRn/Zkl7e+5R720GX/KCX3cLgDygcb3aTGkqhQRKkTNqz4qeWK41T0SU6Mh6vNcljIbrQ1DBxXbfVgo1xsY8+1hzkyFldyOI7Ejivsd2p5ylG/o4vvR1y52EqWYYAqhsSNLLQNsYGVHnOOzVqNw8+mNN/8NonsTXJWiwLx0X6dLWq/vZvZFwhMh4acNA9YY/qP+cqNlYON/VILcRRXVjYNzQzWPLNAurgwy9z2Wha6RQFROOjcSBjmdWRyNG4s32ZKc2XuN86WQ8jcE9SoQgVrV0n55JGCYhT+raCrBbMr7hwU+Z7NOYYv8mmkjGv78BzLL5124/RzRJpnvqoVIaJItv14R41g0ul4j14RTOLRWOJIw2rP5ReDHtYiT3IjbRcOJx9ezeVWYh6S/yA24LKzsnlNNOtmeGmkSn85P2hnhxLaMiEeMkw0AA5o/bjy9nN5Z/w5gIehxQGhd1qE3SLkacWU+6QcwsUXGAZz1gVd1kD8bXTEpggnq9pLIw0lfpsKQtvt+C68jnsAP7EUtFHfvrMSr12U0Qs25GblN8H8s2WI++bV+8fkNAU6PMxn6TrpHTHEiXWdRu93fyp8xb0rrASx2Nji1kwXSi+GiYbf/s95p9RUt+CSiYm47wua/cpzuoD6/8/THnYUQ9pwlSRdsY9MZ85ZkzstJIGbWvljvu7Hv9XFDgUevur5FnRvdK4giUlnVM+QS3skF8n3OqwA2gRBe2d3Z9cvUCbd8Ty5l5GKHVV6gEKGXHtppe3c83YDnl9Gzt7/0LMUFK8Jc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(76116006)(2906002)(5660300002)(66946007)(4326008)(66446008)(55236004)(316002)(7696005)(6506007)(966005)(54906003)(6916009)(8676002)(8936002)(122000001)(71200400001)(508600001)(33656002)(38070700005)(55016003)(38100700002)(66556008)(66476007)(64756008)(9686003)(107886003)(83380400001)(52536014)(186003)(86362001)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7AugJeybvra0mE6+8hy8hx9AL7ceUcg5v12ntIl23MrpH6Jmez53MtQZjXW1?= =?us-ascii?Q?8KDBE9D0OeYoXVT5/Sicc74Nja/zsweR+cZXf+Z+oZWxAVTLwHePx+VEhSN+?= =?us-ascii?Q?U3FU1d47PejGx84fS9yLpGYwz0Q/VpnfBrmSjwJ4OErDseoGeKollfD18ZSj?= =?us-ascii?Q?o+zLvvSRB4tATKRufQe31rh/xv94A1LLN0axiRQ9J3Z6iEyvcadH9C9c/ybG?= =?us-ascii?Q?dFnZv/VpJ3YJ0JFk6WyfflSJo8WrAagM7+/MR/Cpr6jZwNT/nerkI4BQ7l8U?= =?us-ascii?Q?SPqkjFLdqjaP9Mf9LeLcqODrVLOYCa3B8alQKqm/X75S3vxrOqvhri8RxLfR?= =?us-ascii?Q?GSW880hohZHPF2ISo4KwC2/yC+usTLxXyhBFuM5eGntFtTj8hJIn47LoH3UY?= =?us-ascii?Q?OSOASdfTZALk5BJ0Z8dJtD3W/SiL/L0ApgBbSkSudy+O8EO2WWn1OyzSt9d4?= =?us-ascii?Q?RF5BPjLNYEQVP405NTpzo4uz/JJe2EIEerlYHYC27iUdT2CjM9QNd0DzaRu0?= =?us-ascii?Q?vPbItExJvJJ3g+FEYtdz71isa4gtcdPcU3XqRxiOT5UQtexixGqlXIGUpFqS?= =?us-ascii?Q?4n+ztKTrWjfWo0nmcMSf+fYRXmoBa/HBAceySoIkN7GlLzcjM0DrvTtCkzGV?= =?us-ascii?Q?Ctg1iNXGLi5pzyH71Z5zWrDL5CgpMa6tLaePTFgWSTU0vkjthuXLqweFbfMI?= =?us-ascii?Q?0KEylsLmiDYne8apIzjJPZKOv3BgKzLV8jOdx3/d+VvOHk1UNf0KjV80gfnk?= =?us-ascii?Q?7cfMpjkUtv51TgWGYKw9HLYrqAtGAUn7ix79kHOdHR3f4OnoG5KK4tYR+VZg?= =?us-ascii?Q?+AcrG79VesRxlUOhXHWU/7IHf7dFAfjXYy7+JBku3AVbxdQTS2tC8qlzVQNQ?= =?us-ascii?Q?0sFiBkdqPwHeLvEhcrTums4e9OmCuqLMuFr7kvilWQYJDtQSORiu5pt79vyp?= =?us-ascii?Q?iiIYBQ/D087LYV3qyeImh8RG15FXJN6vj77LGLOlryE+jxOfa6M/Gn1WOHIO?= =?us-ascii?Q?BzBh6GDS8AYYThF/XdIUDw3SpvtrRKMMiCucRkSBuPNIs6kOxISJB7lvfbVW?= =?us-ascii?Q?vnF7+LYI7Yl1muU/mfx0hK7qk32BvSc1NY1wuMTphDiRbaIM2tEgHLDf2X1Y?= =?us-ascii?Q?P6/KrAkQokEOdfKI/oNuEBc5h62SfsfX1BWdffdx9mQJ1ehO55piRbgGsvoo?= =?us-ascii?Q?aR1ERFfVamUjEbm3Vp2l1YcmAJF7lHNIairAx/7yI1sfL0mShoCY4k9ZUD9q?= =?us-ascii?Q?8PZwn76/RMr+XggftJPB+4SKQWjxd9b78lZe2rktj27p4ESY0D5oIH/gpqjM?= =?us-ascii?Q?gbdGT2aT0mT8jW4anl3PRcPRRRw3Ccjd0dYmMZ46Y8SFK4KaKcdJBjTBmsCv?= =?us-ascii?Q?T7KF5xHRPSPWyAl82rj4VDsaZWY7jmZJ16yIpTEyzLpmnus5xBtz+/N0/EAW?= =?us-ascii?Q?NRNKapiX+CPIKKYllQjrAzT7hLlDwXg4h1f933e+ORxqd2yHAhZoIPpLNUZa?= =?us-ascii?Q?cyggOYOb8ts+WAPGENW/m7raiKnaiqUKZvxOsuS0oQuRNsP+7WkbzfS23X86?= =?us-ascii?Q?6vNmfH6KQA8qwnv+gIHbDuCXYta+NBwMAE+NuelrszCXcPCGrIIiLErEm5Sk?= =?us-ascii?Q?zucxPbNKOCdj/G1v4JJMgyBbq8FzDPkrWJ/R2M9DDnjzCtGhkzWXzpdvFTuP?= =?us-ascii?Q?5Lpc9OM6gOyuql+7TWWGHDBeboDhFhQOoxuvMYzggRUQas2qZR1+5p5Rp2ug?= =?us-ascii?Q?I5kooQDnkA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76269b42-3621-4cfb-9216-08da21ed5635 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 10:14:06.2570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FRWqH+mEnNBW+irdclUNvUA513jATBlriXFKZKqZ+TQ3uXHtjIqDR1damt/F8hX+x7eHIgW22myC/P/J/Oh8ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR18MB4987 X-Proofpoint-ORIG-GUID: LlLV-2t7_culOaNnUBOJUQr4-E7E73Fp X-Proofpoint-GUID: LlLV-2t7_culOaNnUBOJUQr4-E7E73Fp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-19_04,2022-04-15_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > 16/04/2022 21:25, Akhil Goyal: > > --- a/lib/ethdev/rte_ethdev.h > > +++ b/lib/ethdev/rte_ethdev.h > > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > > /** Soft byte expiry of SA */ > > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY, > > + /** Soft packet expiry of SA */ >=20 > Is there a reference explaining what exactly is a "soft packet expiry"? SA expiry is a very common procedure in case of IPsec. And all stacks must support this feature. You can refer https://docs.strongswan.org/strongswan-docs/5.9/config/rekeyi= ng.html For details. Time expiry means after x seconds SA will expire. Packet expiry means after x packets processing SA will expire. Byte expiry means after x bytes of packet processing SA will expire. > I think you should also mention what should be done > in the event handler. I believe this is quite obvious as per IPsec specifications. Application need to start rekeying or SA need to be created again. >=20 > > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > > + /** Hard byte expiry of SA */ > > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > > + /** Hard packet expiry of SA */ > > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, >=20 > Same comment for the 3 events. >=20 > > /** Max value of this enum */ > > RTE_ETH_EVENT_IPSEC_MAX > > }; >=20 > What is the impact of this "MAX" value on ABI compatibility? I see no issues reported while running ABI check. There is no array being used inside library based on MAX.