From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94C45454FB; Wed, 26 Jun 2024 08:52:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D3EA402B5; Wed, 26 Jun 2024 08:52:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5A7B040264 for ; Wed, 26 Jun 2024 08:49:32 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45Q0jWtC002931; Tue, 25 Jun 2024 23:49:31 -0700 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2040.outbound.protection.outlook.com [104.47.57.40]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 4008qt8vwk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jun 2024 23:49:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OaFCQWeteu+ey8M/amQVsZeknILdF/KtdaP2pdif/nrxE03XbKp+fHjuFkveVrP9Fq65cY3dr/L0/mECKBytXVmJHcZoABcdIvHnG+8Y5iI67ABIzbikuj0JEVd0ucm/z5PY6AKq18OJLh6NKPZ0ft5gknVxMgKCS7C3H2ymCVLm/rtTD/Ji7jPCtcyH+ikJqlYPyeqg7ICokte9pJQax7nzxQPX3Cc2UOLQ9rEMmlARfttEg/EXjnPnmWxPxappuE5PvsBR/raChuH6t2vDG+TYW6piTIYBPw3rErRYZHLKkAJGEt5AwhU3ooycY5kG3/vcPATJgtmS5WIzLIjTDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+E/vOWSjkABF1OYJ7UogoiSVLw+pJ1qGcKQfcf1xZl8=; b=oTNq1vKc+XUiBYM27TNaVRDwtFda6IzMLrsHXpb8eqmTFMbZEzfa83vT1heTnxJfif+TpiOwLl96rFFe3IJ0zjDu/zmM3bkqzKl8IpR/p+RHSowipz5wLg9UAwcHw8btqwDTh4qKhqYViio5VSwxGIpNqrFqaKlBkVtp9G60H50pWFOMwkwO6Z32EHAD42xtQbOGyYSzOuYcvOkrmgynbsccyYBWq44FVpct51qSTtsrSeqxy8xFdQepigriIoZ6p3HCVNAsavpaMsqxWpS/1TYEEFgU80ZHg0m/ZfGK04NX6LF56AjmHBpLnh5Y1Q9o+0xsUX5GMntgpxKS/4AJiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+E/vOWSjkABF1OYJ7UogoiSVLw+pJ1qGcKQfcf1xZl8=; b=oFFAhrNAl8MSiw8PRnbPQLSuAuM6PF9HoZVLVE7wFdK3AdOZ+SPokf6wTZO14FsZrvP8H8CFn5MoDrJlXaD81+IJW/HnOSE/J7cCxhTcvHLYWD9zcneAfVxslQ4Bvn7ai0UEDBsOwxpdw2eRpDwQa2EuMGCHlaGe4juDn57TLnM= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB5820.namprd18.prod.outlook.com (2603:10b6:a03:436::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.28; Wed, 26 Jun 2024 06:49:27 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d%6]) with mapi id 15.20.7698.025; Wed, 26 Jun 2024 06:49:27 +0000 From: Akhil Goyal To: Suanming Mou CC: "dev@dpdk.org" Subject: RE: [EXTERNAL] [PATCH v3 0/2] crypto/mlx5: optimize AES-GCM IPsec operation Thread-Topic: [EXTERNAL] [PATCH v3 0/2] crypto/mlx5: optimize AES-GCM IPsec operation Thread-Index: AQHaxhdZFzu1P9PUzUmjFQuqQWnJbLHZnbOQ Date: Wed, 26 Jun 2024 06:49:27 +0000 Message-ID: References: <20240530072413.1602343-1-suanmingm@nvidia.com> <20240624091651.2295533-1-suanmingm@nvidia.com> In-Reply-To: <20240624091651.2295533-1-suanmingm@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SJ0PR18MB5820:EE_ x-ms-office365-filtering-correlation-id: 4ee5136c-8798-4403-5362-08dc95ac1fb9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230038|366014|376012|1800799022|38070700016; x-microsoft-antispam-message-info: =?us-ascii?Q?pWqIO3YrW/oleD0NqY1GOFcJX+MIw8uwUNPa8AyJbpNZ5NKnq+CWggNYMkaB?= =?us-ascii?Q?9Fi80XpIcuQpQr+DfARmAfMI2krkOxIL1UVU9YLEe/marfmnUIbZm/h/Yeua?= =?us-ascii?Q?yhLhF29jqJMn24f1D1VqAI/XBGJDF/KqkhdOe6H99PyNgF/Ag7iDYl6JY17t?= =?us-ascii?Q?jN0ezpf6vojSIV4s5ODkZSqKmM5szKjkLH2DoPW2cxU55qi65rsXiO9GQSRW?= =?us-ascii?Q?RpVWT9Bje1cvZOlltbMBdeynj3jYgXUmFz/Yf91v2VZATka2dPDoPudRF4XM?= =?us-ascii?Q?MiT6dYePol6GoI0+DlImbkIRrV1LQbALMFFRvsh47eoP5MR9s127Tp8Opl1y?= =?us-ascii?Q?wLNnf73XdRzD9IuurmvA2do8dRH67KWif7oqV7pAmp7RaPLrDXtflby4wc4H?= =?us-ascii?Q?+KcLwwbwGO0IGWKdK7ImcZIks5s41N/HEpNt2c6vdrG19wvEPWG3wM1o6ciV?= =?us-ascii?Q?3Y68r939UssRp7saw/8U8W6AXsV2l7hSTr6MV/Tvn8DMQEzuJfeTOxm9D/cv?= =?us-ascii?Q?5WqDZjdKAWZlotGZOV/ABaMv8T65Azbo3EOOTlvBqoYMhAVSrG63kFVzrwqT?= =?us-ascii?Q?bQejcT536MTWjbYgcJec8osuFCyJJzUBb9zTHeOxt7gloCkyfeK6qHUt5Mqs?= =?us-ascii?Q?d32dXi8c1iW0WEJZIjaVDdzsYUNTwVvp9rAmw2tqUbn8gB+VgLCiuzm8j2vO?= =?us-ascii?Q?+S9HJXktnARxL9sFQnP6rqCV/AzGDywN4q0XcTZNPRyN4xt+N6WFBjwPx8Bw?= =?us-ascii?Q?HGnjLeYe3fSTpn1M0q8NJznxQBZjXtHGvjFicBCjpG9nMyqTcqHWS0Clt2ZW?= =?us-ascii?Q?3mjXP23K7yF4hWclnCViiKrh+TVMRCT7+exBg+VeLELXGqnfciEKOREPZjKk?= =?us-ascii?Q?6RvI0NUTFEDUVoD1/n6a1BC1HufoZOj+6LGAC3HEPqnc6kU8BAVOb1vobCjH?= =?us-ascii?Q?lOyB3ZJMK3bUDUTZ4rPQkRWXXhyVDUcHnmK6Ojw/jsKqlS93Y5oDa0xE5X7U?= =?us-ascii?Q?6cuS/yeRJSd21Qu6YCeVG/bFt/lAvF7OHhnquVi1B56Kd2NqWMy2vpuVxE7f?= =?us-ascii?Q?2Oc2RLhV3k52YApzxJ6XF92BNi0/qJ9uRWeRik4LxX/mwh/RYXjcHsv6rBCI?= =?us-ascii?Q?TT+rA708QpcT/zXo3+cyDt4TmbdCtORadAXI371sjU36/gzH+Lv0hPTfIw7a?= =?us-ascii?Q?BsWQr0KzdOkoXFV+kYUzEE/LOz9nJ2LU02GApPxIhHweywWE8kwC2ZW/PyQc?= =?us-ascii?Q?sqnPGhfJEJXw+Ob4Gvt6Ov0X07LeqprzWgddk+dchQNK9V5gZcR7RiiB3Utq?= =?us-ascii?Q?AW1OR/spox1BQ9dV+OjTXgca2rnEwhWac8+/zK6UUti71YByXMCJGVYm+bbC?= =?us-ascii?Q?SB3HwvG88xiUBKfl2e0+IXpVJhMJzJlZOpMqOMLr55L8o5bL9A=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230038)(366014)(376012)(1800799022)(38070700016); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EktbCy7xF4a11/FsMPpi9tnxLb5QtfHbFNrrUtKEVCd9AraeZXinuz49qZsw?= =?us-ascii?Q?bJppAtWvJS65tCK/bzKQIpduI55PRgGxRvF0fU6/RD14f8nzG3qgKhLMIExR?= =?us-ascii?Q?LQ+mvB+DsxCrQjnKLoYPHuOkeeGgo7lgkEN9/OPeNVCBgAMNDA/fNy2Son+3?= =?us-ascii?Q?/zLI/dXCd/NxKJX7smyT1dwUC+nKZwLDO63r8xfO0dquCW6qOGk270KS/RUw?= =?us-ascii?Q?kiCGM4em+PjtCUP1JNe0Z7f0YBQzju9m7wU2kOcUTELvXdL1C8lp9zNe8+g9?= =?us-ascii?Q?hA6L5DAl+vprbx+kebn50DtLsjmtarg8dOBzETaumS9CSaN6GA8zNe7by2UB?= =?us-ascii?Q?hMC7E1OYFEuARc/K8Zf4NJG/XECQn06TSAfcLsQR+BO5K/eX/oKKJxVz3o8A?= =?us-ascii?Q?CAkmL/w5Y8+8HXkHlRVSiCDmgAPte4In/OEL1WVsqtF5TVg/dCeKCRVW0NHe?= =?us-ascii?Q?uso7FfJHAYzNmwDRwQ6sATebDb6Ta0wBxS84dGx1lwqSaho8SRqh4Kc0ojP5?= =?us-ascii?Q?43b/BNLN9AoeWm5x624Z0ET4awHe19MhIaAIop6norSWd3zIU04FbyPUwV+0?= =?us-ascii?Q?Oe9hTnZqaYfv9MtUxKmAESbEArx+qHh2q5f6rfv7v6H5UDyXS1XjOzhlo3xo?= =?us-ascii?Q?HPjPHvMA9kKPIwC3k1NlhsYvGCTJ3EA7yx5pgPFXjVtfKFZ7ok81l45dxmTm?= =?us-ascii?Q?8830AEL5OosXNbNywXPfGlpyEf4lTxrYhciFuRMixI7PV3tMeIQ1xSZXGP9t?= =?us-ascii?Q?GdP5owRxJzc+DMiEvxg+aMfSeuc73CKP8YRLEmZ46hGY/tOYpd+NUVi9cCki?= =?us-ascii?Q?tLOsGMD6L6yt5d6bursNEfV++jwhj1uKb3CKHM9sLzmQJt1Rqaml+J6+QOQr?= =?us-ascii?Q?4HZ2joFD9XvBVmnkVfrHc7m1TVcUvaIDUB6t2InsYcsy2rU8uetpQhxm/AQJ?= =?us-ascii?Q?D6uit3GvfCjLu+rALnr9dGOYERVGtkc9Nxk7yEcz2fTzVZLPEJol9nMgEkKX?= =?us-ascii?Q?xjuG9LdDlAqbyHrPow/5Cbqj/G0ROqK1wxOKNSg6thTmewdUbmsnWvUjkBKQ?= =?us-ascii?Q?/AWCfy+QEHf2cBQb7Iqk+tQ5bs7SFvSo3H98gXGCKRPLkITuiH/OF+XXx60p?= =?us-ascii?Q?Qk0zz6Uc3SJxrqf9+BhwhDX3f3N8b65jFoPfuzCcFXApMbKm4k7A+07qgLJP?= =?us-ascii?Q?ZKUjQje1umJVd56g9iGsFVy/llp/2Iz/G0usHr1sSmDFU88FHlHXAL+7zIVI?= =?us-ascii?Q?70lYYDIHToOdoNFxP9DqO0NzYyO7GgtL8NdwOYIN71Xn+QVNCLje+87tClyf?= =?us-ascii?Q?OzQJ1A21kAYW2kOgxKYgl5Obg0HHGnvXpxRYnSx779CGIeG44uo9hrvuiTXK?= =?us-ascii?Q?SU6V0U47iTPp0RDiM08ycceC7lpLXMIAj25Z7pcIOWXbzGSYAijrGBCp69Yp?= =?us-ascii?Q?1IlApzQIy4NyDO5ksyEVcV33NEu2A4zj/nc8dIZnrHkdTSHw3jS0KFZwB35u?= =?us-ascii?Q?hyRUXcO4w5DPbN9UvIoSCI3UC6oN0bhUImULuh4bVP0n9G13fosQgTaEseVE?= =?us-ascii?Q?z1wFbEYTfn43b2Phcy0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ee5136c-8798-4403-5362-08dc95ac1fb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2024 06:49:27.8871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w7HifeLcSk+aHkOeRtMIpNgU6DCQn4vHh9GDlb8YZphU/Yzyvo9uE06WnKxKjfp+Nnn2WkobX4tYQbDSbop4GQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB5820 X-Proofpoint-ORIG-GUID: F4lBM927M-Kvt9KBypJxoCR0iTHdI9t3 X-Proofpoint-GUID: F4lBM927M-Kvt9KBypJxoCR0iTHdI9t3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-26_03,2024-06-25_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > To optimize AES-GCM IPsec operation within crypto/mlx5, > the DPDK API typically supplies AES_GCM AAD/Payload/Digest > in separate locations, potentially disrupting their > contiguous layout. In cases where the memory layout fails > to meet hardware (HW) requirements, an UMR WQE is initiated > ahead of the GCM's GGA WQE to establish a continuous > AAD/Payload/Digest virtual memory space for the HW MMU. >=20 > For IPsec scenarios, where the memory layout consistently > adheres to the fixed order of AAD/IV/Payload/Digest, > directly shrinking memory for AAD proves more efficient > than preparing a UMR WQE. To address this, a new devarg > "crypto_mode" with mode "ipsec_opt" is introduced in the > commit, offering an optimization hint specifically for > IPsec cases. When enabled, the PMD copies AAD directly > before Payload in the enqueue_burst function instead of > employing the UMR WQE. Subsequently, in the dequeue_burst > function, the overridden IV before Payload is restored > from the GGA WQE. It's crucial for users to avoid utilizing > the input mbuf data during processing. >=20 >=20 > v3: add limitation for non-contiguous inputs. > v2: rebase version >=20 > Suanming Mou (2): > crypto/mlx5: optimize AES-GCM IPsec operation > crypto/mlx5: add out of place mode for IPsec operation >=20 > doc/guides/cryptodevs/mlx5.rst | 24 +++ > doc/guides/rel_notes/release_24_07.rst | 4 + > drivers/crypto/mlx5/mlx5_crypto.c | 22 ++- > drivers/crypto/mlx5/mlx5_crypto.h | 19 ++ > drivers/crypto/mlx5/mlx5_crypto_gcm.c | 245 > +++++++++++++++++++++++-- > 5 files changed, 293 insertions(+), 21 deletions(-) Applied to dpdk-next-crypto Thanks.