From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5F02943C9E;
Wed, 13 Mar 2024 11:02:56 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 018F540A84;
Wed, 13 Mar 2024 11:02:56 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
[67.231.148.174])
by mails.dpdk.org (Postfix) with ESMTP id 154384069D;
Wed, 13 Mar 2024 11:02:53 +0100 (CET)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id
42D9WgRM022023; Wed, 13 Mar 2024 03:02:53 -0700
Received: from nam12-mw2-obe.outbound.protection.outlook.com
(mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40])
by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wu9kvr2pt-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Wed, 13 Mar 2024 03:02:53 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=QnEVpr5oLrbpYZ2AxtFYI3nUcrl7e//oRx2Dh2KfX8UfzjybKL1WdHLwaZdWw6YeSISkqGd3CUFEL81xy0L/UZqAIZrgMau8RPUcRxlyyxahpbpDORW/NWEyhc3m9sGS+dKrqlKn1lZx3NKcZJDwd2pVS2L9j1yDHRgPJCg6CgRjFHjkiejhCUIWFN4NN+QBLQu0hOGENwsPrCjas6SO8/LNzC/VDQqvEqeQ6E7xDh5TR8ZL8tsPZTRPxnqLCUmubV53Y6SWG4PmMcBm7JlEHP+mKr2zrvv+s5G+8ZLtx3/EUckyw7l/oa4MpogsF+NpQp3pIrwS7LT7ARZXRLIUCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=3L0sQhRHH36q2dzYAfz/pRpOCZjQXFfLLameYImh5P0=;
b=jT7gILeAdVYCukG7Mz22i/NbKVUx4P6E4wmTZ08dOY4Eo5ZtMrEKG8/fZj6rhLiz9ZHfr90VggMxztO/jhsEdukVrbHvmFs4pAdp+47eTUUnW1tlymkHHTt+qbBGq/+XmxU7O1DIjEykH1DtPJLld0zSQoUW0wRRn0NzUJmluiDvP/00sbE348/G72BYR2/i7IJHcb+ESwRCS6wxJRICYvNY6WWK6/ECNgxYCqkc6LPYXG8eGrSpfis8LXHFeZY8Bq/VnVDUTp2nEKU2w9+JjeV0tVHpc/m5d0+TwKS4OuPCmg41LX9aZlZhKDMkcPaQdZXc9W8fUHZo3m7bEVF5LQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=3L0sQhRHH36q2dzYAfz/pRpOCZjQXFfLLameYImh5P0=;
b=KLDID6wS6yCVvKJlqk8KlSzwR34TQDH60NZfLNCnT0QwnLpDLilbHsqM8tBA5D0Jg7P9ewwgGy0Hg4rLi4Nq1pFFF+82Fs97C4c+LuTyK+sjDZObzQdhDuyz4YlWs1+obiKPTGk19cmN6LK3liHO8uTeiYimhZLiA7RsAPKYwCc=
Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by
PH7PR18MB5574.namprd18.prod.outlook.com (2603:10b6:510:2f0::16) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Wed, 13 Mar
2024 10:02:47 +0000
Received: from CO6PR18MB4484.namprd18.prod.outlook.com
([fe80::4e74:4cf3:63b6:b149]) by CO6PR18MB4484.namprd18.prod.outlook.com
([fe80::4e74:4cf3:63b6:b149%4]) with mapi id 15.20.7386.017; Wed, 13 Mar 2024
10:02:47 +0000
From: Akhil Goyal <gakhil@marvell.com>
To: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>, "dev@dpdk.org"
<dev@dpdk.org>
CC: "ciara.power@intel.com" <ciara.power@intel.com>, "stable@dpdk.org"
<stable@dpdk.org>
Subject: RE: [EXTERNAL] [PATCH v2] app/test: fix rsa tests in qat suite
Thread-Topic: [EXTERNAL] [PATCH v2] app/test: fix rsa tests in qat suite
Thread-Index: AQHadSbHAi1w6/DOOU6+l+z76rmoOrE1cIrw
Date: Wed, 13 Mar 2024 10:02:47 +0000
Message-ID: <CO6PR18MB4484A6203A3FD226EE8B4BDCD82A2@CO6PR18MB4484.namprd18.prod.outlook.com>
References: <20240308081750.5157-1-arkadiuszx.kusztal@intel.com>
<20240313091347.25207-1-arkadiuszx.kusztal@intel.com>
In-Reply-To: <20240313091347.25207-1-arkadiuszx.kusztal@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|PH7PR18MB5574:EE_
x-ms-office365-filtering-correlation-id: c70ceeaa-5196-4f13-cf87-08dc4344bc6c
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: dYIU7HYCGRLyeOjbPyGHiGMl6In9IUA+K31ymbcmTUh3isPa438xYAu1HYQfT4L+HG525aEZ5qnVsyINteiiyFoXv5nwhpf8oVzk8vhAbeyImyYI43RcaNc+h0lCSJIUeDqUO/DcYMZvwSfQZ0N6H2kSfOPtaMVA5LMgSXUkCfalZOeyFxYbzikQ7NeIU2eKUWo1f5N4ISTmSik/vvCr69pnKH06DXpweWsJSTnxpxkIYqigG+dqW7SjONCCXCFWMlSCyptd51WKKzMIwpOXn7hzeZEisjU5L5IH8X3b0MTksSi3QjDSjTO0B52GuTtR2/fyMk4ZlWbk9iajA/3jjAvLp1GFaicFzRnCEVfi7EI5lebkNy7w+iLcnmrCzYdjj24oEG4Qn1RuZgEKBjOrgrBkXjwr0gHjEDs/mlvI1mzeMhFlbYpE3ezoZJ79mMPYmIKbXuG/5OKikOCJGrtjY3SukSa8ccHZy9Zpoy/r0LqlGunE7N8exHu7GdMSPsUMNNUjWIf8ogn+zmV6H19s5swMT8+kBCeWfKihUWUB9gB9t0VV8kagLWf2rNzbWf5JQmW4EYwsYsIt0+XOvnsHOWE9dVjhDFXxBKhT2hOaJShmixw2mvxLXpw7XQolsIKWZSAOJB5RZEBNehBNR2gSaUdIEOcf5ivnb7Mn12pb5NEnBS2hwiMr1pkY5FtVwTWOeusN2rYIP9EUVWLAj+3VuEXayP6KcgK7UjAkPAPoT1I=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230031)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IP2g/pUD2KmjKOYOLVfxKsE0gpz5kxBVhIKzpu8jFvtAS0qA7kDc/AHLgLb9?=
=?us-ascii?Q?JkTt0WWFTvc9oB+4MVYPOiSF/JuQbjtOzAdwHLCRWkOIUmcdq4MkoXmCjk4i?=
=?us-ascii?Q?xGKW8FfG7QcdKpEKlrOFXwiAeHIa86uX18Or7C1rx59KYP2a7ZlQI0xzaSky?=
=?us-ascii?Q?6NRRGjuxYpSvl5YAAAC8vZu5oNoFO1EMX3TBAHXbBhzbsGwY2g+sEV1R/yat?=
=?us-ascii?Q?bVpN/hFO6fhbvBvLA9eAXtSGDSS249FApZiyNAGpDZxR+QMV9lP2QT5ZVNwv?=
=?us-ascii?Q?D7JVmAc1Rbho+Cnt8/rCt8MgVLI/C+NSJFmnC0G+eoW/zNrLcFdpQ0MDmFyK?=
=?us-ascii?Q?Ns8V92sWsfSCKWwsBQ/A/ZtSUHyYC/di7YOsvTnb+Un4lKv6y2aUN6WKJbR7?=
=?us-ascii?Q?aV3h6bHhHolL3NmX6AwBVIvaPVQffFgvXHXKW44saSB2lmjrqFsUMCWsEvhV?=
=?us-ascii?Q?QkNsaCuBVR+CeQK/j44M+HO6QYiNqkNtaQJtIUibOi6uHZkeTcEYLqmbXO/5?=
=?us-ascii?Q?L0AXO5USHsjaKTLkPbkrlfbNgwJ3wzeiftOQPcWg+XYBhTEn3SwyPqX+25qy?=
=?us-ascii?Q?3rsO59FMm2hXvb10q7s5WllaZt417AwynrvIG/Yyk+lztMFA2jjVDc1DcMxP?=
=?us-ascii?Q?KQL+IbMKzlcjChb19Q4CByOD69sHLBVdyVCxKQMjxEmOERaBCWJNerrJSeWI?=
=?us-ascii?Q?P2UvWnKrrgBABFIiiLZ3P0GBaq1mVO9Mou+UTY3kcTfEA6Nf9VveCzbvBEfS?=
=?us-ascii?Q?MXUY1tZ4awxiI8zp7mhMJ7xEm8JZ/R/wNMTL0rJXKe+rt0jT97dhimrq8KbU?=
=?us-ascii?Q?Gb5FoNrT0Jzd1AWYpQ2OHHUdD6x6KrgHsNDnAE8bZlMwEPPwAj/oOIBW5jrO?=
=?us-ascii?Q?mBCjbKgLc/8zeBt5DMLtfvVe0p3Y1rjLdJDA1LlYn23na9Pcydg904dlFrFO?=
=?us-ascii?Q?MCv24MjODcM8F6fNB30Yrsg7HBHboK26ZRI5ztkZgHU5WQoCGyA+NhGi7/C8?=
=?us-ascii?Q?fV8Uc+4TxTqWYzVDWnK2WE6wSe2k2+hR9R0S94CMtP/WOAOQwZp0kXhBDofz?=
=?us-ascii?Q?9p1K5NzUQSGNrCNWZb+BXf2ZIMWTD/Yx20wh7DtvOrl0wCLwTm56Ogs2mJM4?=
=?us-ascii?Q?0K0puQErBONEUE1CccebTWjNy+OFaa/MXFSsV09RHtVgcUGcnJN/36F3F3kt?=
=?us-ascii?Q?znNlyBWNh/v66lc4gjD7VV33r3yVTD9n3DBLd2MqC0qR89MKHZTI6QMDjqua?=
=?us-ascii?Q?OGWlcJoP/tGUSeYEaF2qmKjc8LiCmsEZSoUAzDQZMWJ0r3qIv46naOBQbXSA?=
=?us-ascii?Q?qeWdh8YIfOhAh9eFeVXmTeH1IGhmdk+JURdnt2XKaA19zBWzmVvl891m9fKm?=
=?us-ascii?Q?BU2Y7rnLVcOmeLXC2xNw6j4Jz/AuSdLw6nKBODXOm3U+v8p3tMiud1c2r32X?=
=?us-ascii?Q?AdWBcZ76C++ZbDD2UOlDO49dAUQ24Lqs85hupK52BoUZyqO3eNjGVu87xPTC?=
=?us-ascii?Q?R6hvTzi0SWwnyQU6OMt6UMsei2ZfgmE1sk6yNSjHgOMrNyx85ZOWd0njFFd+?=
=?us-ascii?Q?N6qxSuOdHsCqLIENsg0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c70ceeaa-5196-4f13-cf87-08dc4344bc6c
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 10:02:47.7730 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e6J9se2s4vWK1ZCvlAxxmoT0ssz18FsvW3fHgXUgdBO7K63epktITTgRrJ04JznLuVg6+UBij7LPiERT+mPiIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR18MB5574
X-Proofpoint-GUID: ej6DgKWQyzpQFGIgjfRtltahVbSAgh1m
X-Proofpoint-ORIG-GUID: ej6DgKWQyzpQFGIgjfRtltahVbSAgh1m
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
definitions=2024-03-13_07,2024-03-12_01,2023-05-22_02
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
> This commit fixes incorrectly set keys in the
> QAT testsuite for the RSA algorithm.
>=20
> Fixes: 9b5465867fb8 ("test/crypto: add RSA none padding cases")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> v2:
> - removed camel case
Removing camel case should be a separate patch
Or update the patch title description appropriately.
>=20
> app/test/test_cryptodev_asym.c | 102 ++++++++++++++---------=
------
> app/test/test_cryptodev_rsa_test_vectors.h | 2 +-
> 2 files changed, 52 insertions(+), 52 deletions(-)
>=20
> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy=
m.c
> index 17daf734e8..2c745a7f7c 100644
> --- a/app/test/test_cryptodev_asym.c
> +++ b/app/test/test_cryptodev_asym.c
> @@ -3292,11 +3292,8 @@ modular_multiplicative_inverse(const void
> *test_data)
> arg.qt.coef.data =3D coef; \
> arg.qt.coef.length =3D vector->coef.len
>=20
> -typedef void (*rsa_key_init_t)(struct rte_crypto_asym_xform *,
> - const struct rsa_test_data_2 *);
> -
> static int
> -RSA_Encrypt(const struct rsa_test_data_2 *vector, uint8_t *cipher_buf)
> +rsa_encrypt(const struct rsa_test_data_2 *vector, uint8_t *cipher_buf)
> {
> self->result_op =3D NULL;
> /* Compute encryption on the test vector */
> @@ -3314,7 +3311,7 @@ RSA_Encrypt(const struct rsa_test_data_2 *vector,
> uint8_t *cipher_buf)
> }
>=20
> static int
> -RSA_Decrypt(const struct rsa_test_data_2 *vector, uint8_t *plaintext,
> +rsa_decrypt(const struct rsa_test_data_2 *vector, uint8_t *plaintext,
> const int use_op)
> {
> uint8_t cipher[TEST_DATA_SIZE] =3D { 0 };
> @@ -3335,41 +3332,14 @@ RSA_Decrypt(const struct rsa_test_data_2 *vector,
> uint8_t *plaintext,
> return 0;
> }
>=20
> -static void
> -RSA_key_init_Exp(struct rte_crypto_asym_xform *xform,
> - const struct rsa_test_data_2 *vector)
> -{
> - SET_RSA_PARAM(xform->rsa, vector, n);
> - SET_RSA_PARAM(xform->rsa, vector, e);
> - SET_RSA_PARAM(xform->rsa, vector, d);
> - xform->rsa.key_type =3D RTE_RSA_KEY_TYPE_EXP;
> -}
> -
> -static void
> -RSA_key_init_CRT(struct rte_crypto_asym_xform *xform,
> - const struct rsa_test_data_2 *vector)
> -{
> - SET_RSA_PARAM(xform->rsa, vector, n);
> - SET_RSA_PARAM(xform->rsa, vector, e);
> - SET_RSA_PARAM_QT(xform->rsa, vector, p);
> - SET_RSA_PARAM_QT(xform->rsa, vector, q);
> - SET_RSA_PARAM_QT(xform->rsa, vector, dP);
> - SET_RSA_PARAM_QT(xform->rsa, vector, dQ);
> - SET_RSA_PARAM_QT(xform->rsa, vector, qInv);
> - xform->rsa.key_type =3D RTE_RSA_KEY_TYPE_QT;
> -}
> -
> static int
> -RSA_Init_Session(const struct rsa_test_data_2 *vector,
> - rsa_key_init_t key_init)
> +rsa_init_session(struct rte_crypto_asym_xform *xform)
> {
> const uint8_t dev_id =3D params->valid_devs[0];
> struct rte_cryptodev_info dev_info;
> - struct rte_crypto_asym_xform xform =3D { };
> int ret =3D 0;
>=20
> - key_init(&xform, vector);
> - xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_RSA;
> + xform->xform_type =3D RTE_CRYPTO_ASYM_XFORM_RSA;
>=20
> rte_cryptodev_info_get(dev_id, &dev_info);
> if (!(dev_info.feature_flags &
> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT)) {
> @@ -3377,7 +3347,7 @@ RSA_Init_Session(const struct rsa_test_data_2
> *vector,
> "Device doesn't support decrypt op with quintuple key
> type. Test skipped\n");
> return TEST_SKIPPED;
> }
> - ret =3D rte_cryptodev_asym_session_create(dev_id, &xform,
> + ret =3D rte_cryptodev_asym_session_create(dev_id, xform,
> params->session_mpool, &self->sess);
> if (ret < 0) {
> RTE_LOG(ERR, USER1,
> @@ -3388,17 +3358,23 @@ RSA_Init_Session(const struct rsa_test_data_2
> *vector,
> }
>=20
> static int
> -KAT_RSA_Encrypt(const void *data)
> +kat_rsa_encrypt(const void *data)
> {
> uint8_t cipher_buf[TEST_DATA_SIZE] =3D {0};
> const struct rsa_test_data_2 *vector =3D data;
> - int ret =3D RSA_Init_Session(vector, RSA_key_init_Exp);
> + struct rte_crypto_asym_xform xform =3D { };
> +
> + SET_RSA_PARAM(xform.rsa, vector, n);
> + SET_RSA_PARAM(xform.rsa, vector, e);
> + SET_RSA_PARAM(xform.rsa, vector, d);
> + xform.rsa.key_type =3D RTE_RSA_KEY_TYPE_EXP;
> + int ret =3D rsa_init_session(&xform);
>=20
> if (ret) {
> RTE_LOG(ERR, USER1, "Failed to init session for RSA\n");
> return ret;
> }
> - TEST_ASSERT_SUCCESS(RSA_Encrypt(vector, cipher_buf),
> + TEST_ASSERT_SUCCESS(rsa_encrypt(vector, cipher_buf),
> "RSA: Failed to encrypt");
> TEST_ASSERT_BUFFERS_ARE_EQUAL(vector->cipher.data,
> self->result_op->asym->rsa.cipher.data,
> @@ -3408,17 +3384,26 @@ KAT_RSA_Encrypt(const void *data)
> }
>=20
> static int
> -KAT_RSA_Encrypt_CRT(const void *data)
> +kat_rsa_encrypt_crt(const void *data)
> {
> uint8_t cipher_buf[TEST_DATA_SIZE] =3D {0};
> const struct rsa_test_data_2 *vector =3D data;
> - int ret =3D RSA_Init_Session(vector, RSA_key_init_CRT);
> + struct rte_crypto_asym_xform xform =3D { };
>=20
> + SET_RSA_PARAM(xform.rsa, vector, n);
> + SET_RSA_PARAM(xform.rsa, vector, e);
> + SET_RSA_PARAM_QT(xform.rsa, vector, p);
> + SET_RSA_PARAM_QT(xform.rsa, vector, q);
> + SET_RSA_PARAM_QT(xform.rsa, vector, dP);
> + SET_RSA_PARAM_QT(xform.rsa, vector, dQ);
> + SET_RSA_PARAM_QT(xform.rsa, vector, qInv);
> + xform.rsa.key_type =3D RTE_RSA_KEY_TYPE_QT;
> + int ret =3D rsa_init_session(&xform);
> if (ret) {
> RTE_LOG(ERR, USER1, "Failed to init session for RSA\n");
> return ret;
> }
> - TEST_ASSERT_SUCCESS(RSA_Encrypt(vector, cipher_buf),
> + TEST_ASSERT_SUCCESS(rsa_encrypt(vector, cipher_buf),
> "RSA: Failed to encrypt");
> TEST_ASSERT_BUFFERS_ARE_EQUAL(vector->cipher.data,
> self->result_op->asym->rsa.cipher.data,
> @@ -3428,17 +3413,23 @@ KAT_RSA_Encrypt_CRT(const void *data)
> }
>=20
> static int
> -KAT_RSA_Decrypt(const void *data)
> +kat_rsa_decrypt(const void *data)
> {
> uint8_t message[TEST_DATA_SIZE] =3D {0};
> const struct rsa_test_data_2 *vector =3D data;
> - int ret =3D RSA_Init_Session(vector, RSA_key_init_Exp);
> + struct rte_crypto_asym_xform xform =3D { };
> +
> + SET_RSA_PARAM(xform.rsa, vector, n);
> + SET_RSA_PARAM(xform.rsa, vector, e);
> + SET_RSA_PARAM(xform.rsa, vector, d);
> + xform.rsa.key_type =3D RTE_RSA_KEY_TYPE_EXP;
> + int ret =3D rsa_init_session(&xform);
>=20
> if (ret) {
> RTE_LOG(ERR, USER1, "Failed to init session for RSA\n");
> return ret;
> }
> - TEST_ASSERT_SUCCESS(RSA_Decrypt(vector, message, 0),
> + TEST_ASSERT_SUCCESS(rsa_decrypt(vector, message, 0),
> "RSA: Failed to encrypt");
> TEST_ASSERT_BUFFERS_ARE_EQUAL(vector->message.data,
> self->result_op->asym->rsa.message.data,
> @@ -3448,17 +3439,26 @@ KAT_RSA_Decrypt(const void *data)
> }
>=20
> static int
> -KAT_RSA_Decrypt_CRT(const void *data)
> +kat_rsa_decrypt_crt(const void *data)
> {
> uint8_t message[TEST_DATA_SIZE] =3D {0};
> const struct rsa_test_data_2 *vector =3D data;
> - int ret =3D RSA_Init_Session(vector, RSA_key_init_CRT);
> + struct rte_crypto_asym_xform xform =3D { };
>=20
> + SET_RSA_PARAM(xform.rsa, vector, n);
> + SET_RSA_PARAM(xform.rsa, vector, e);
> + SET_RSA_PARAM_QT(xform.rsa, vector, p);
> + SET_RSA_PARAM_QT(xform.rsa, vector, q);
> + SET_RSA_PARAM_QT(xform.rsa, vector, dP);
> + SET_RSA_PARAM_QT(xform.rsa, vector, dQ);
> + SET_RSA_PARAM_QT(xform.rsa, vector, qInv);
> + xform.rsa.key_type =3D RTE_RSA_KEY_TYPE_QT;
> + int ret =3D rsa_init_session(&xform);
> if (ret) {
> RTE_LOG(ERR, USER1, "Failed to init session for RSA\n");
> return ret;
> }
> - TEST_ASSERT_SUCCESS(RSA_Decrypt(vector, message, 0),
> + TEST_ASSERT_SUCCESS(rsa_decrypt(vector, message, 0),
> "RSA: Failed to encrypt");
> TEST_ASSERT_BUFFERS_ARE_EQUAL(vector->message.data,
> self->result_op->asym->rsa.message.data,
> @@ -3535,20 +3535,20 @@ static struct unit_test_suite
> cryptodev_qat_asym_testsuite =3D {
> TEST_CASE_NAMED_WITH_DATA(
> "RSA Encryption (n=3D128, pt=3D20, e=3D3) EXP, Padding:
> NONE",
> ut_setup_asym, ut_teardown_asym,
> - KAT_RSA_Encrypt, &RSA_vector_128_20_3_None),
> + kat_rsa_encrypt, &rsa_vector_128_20_3_none),
> TEST_CASE_NAMED_WITH_DATA(
> "RSA Decryption (n=3D128, pt=3D20, e=3D3) EXP, Padding:
> NONE",
> ut_setup_asym, ut_teardown_asym,
> - KAT_RSA_Decrypt, &RSA_vector_128_20_3_None),
> + kat_rsa_decrypt, &rsa_vector_128_20_3_none),
> /* RSA CRT */
> TEST_CASE_NAMED_WITH_DATA(
> "RSA Encryption (n=3D128, pt=3D20, e=3D3) CRT, Padding:
> NONE",
> ut_setup_asym, ut_teardown_asym,
> - KAT_RSA_Encrypt_CRT, &RSA_vector_128_20_3_None),
> + kat_rsa_encrypt_crt, &rsa_vector_128_20_3_none),
> TEST_CASE_NAMED_WITH_DATA(
> "RSA Decryption (n=3D128, pt=3D20, e=3D3) CRT, Padding:
> NONE",
> ut_setup_asym, ut_teardown_asym,
> - KAT_RSA_Decrypt_CRT, &RSA_vector_128_20_3_None),
> + kat_rsa_decrypt_crt, &rsa_vector_128_20_3_none),
> TEST_CASES_END() /**< NULL terminate unit test array */
> }
> };
> diff --git a/app/test/test_cryptodev_rsa_test_vectors.h
> b/app/test/test_cryptodev_rsa_test_vectors.h
> index b4982014a2..89981f13f0 100644
> --- a/app/test/test_cryptodev_rsa_test_vectors.h
> +++ b/app/test/test_cryptodev_rsa_test_vectors.h
> @@ -72,7 +72,7 @@ struct rsa_test_data_2 {
> };
>=20
> static const struct
> -rsa_test_data_2 RSA_vector_128_20_3_None =3D {
> +rsa_test_data_2 rsa_vector_128_20_3_none =3D {
> .description =3D
> "RSA Encryption Decryption (n=3D128, pt=3D20, e=3D3) EXP, QT",
> .xform_type =3D RTE_CRYPTO_ASYM_XFORM_RSA,
> --
> 2.13.6