[PATCH 1/1] doc: notice to add new ipsec event subtypes

[PATCH 1/1] doc: notice to add new ipsec event subtypes

[Vamsi Attunuru]

Based on discussion in below email thread, the new event subtypes can be
added in 22.11 release with fixing any compatability issues mentioned in
the mail thread.

https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c53d..83da1c62ac 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -107,6 +107,11 @@ Deprecation Notices
   alternative is implemented.
   The legacy actions should be removed in DPDK 22.11.
 
+* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to add
+  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
+  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
+  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
+
 * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and
   ``rte_cryptodev_asym_session`` to remove unnecessary indirection between
   session and the private data of session. An opaque pointer can be exposed
-- 
2.25.1

RE: [PATCH 1/1] doc: notice to add new ipsec event subtypes

[Akhil Goyal]

> Subject: [PATCH 1/1] doc: notice to add new ipsec event subtypes

Title should be
doc: announce addition of new IPsec event subtypes
> 
> Based on discussion in below email thread, the new event subtypes can be
> added in 22.11 release with fixing any compatability issues mentioned in
> the mail thread.
> 
> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
> gakhil@marvell.com/
> 
Description should be 

New event subtypes need to be added for notifying expiry events upon reaching
IPsec SA soft packet expiry and hard packet/byte expiry limits. This would be 
added in DPDK 22.11.

You can give the reference to patch after --- so that it is not visible in git log

Adding more people for acks.

> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Other that this
Acked-by: Akhil Goyal <gakhil@marvell.com>

[PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

[Vamsi Attunuru]

New event subtypes need to be added for notifying expiry events
upon reaching IPsec SA soft packet expiry and hard packet/byte
expiry limits. This would be added in DPDK 22.11.

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
More details on new event subtype proposal discussion are in below email thread.
https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/

v2: rephrase title and git log.
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c53d..83da1c62ac 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -107,6 +107,11 @@ Deprecation Notices
   alternative is implemented.
   The legacy actions should be removed in DPDK 22.11.
 
+* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to add
+  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
+  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
+  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
+
 * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and
   ``rte_cryptodev_asym_session`` to remove unnecessary indirection between
   session and the private data of session. An opaque pointer can be exposed
-- 
2.25.1

RE: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

[Zhang, Roy Fan]

> -----Original Message-----
> From: Vamsi Attunuru <vattunuru@marvell.com>
> Sent: Monday, June 27, 2022 6:30 AM
> To: dev@dpdk.org
> Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
> ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
> mdr@ashroe.eu
> Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
> 
> New event subtypes need to be added for notifying expiry events
> upon reaching IPsec SA soft packet expiry and hard packet/byte
> expiry limits. This would be added in DPDK 22.11.
> 
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> More details on new event subtype proposal discussion are in below email
> thread.
> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
> gakhil@marvell.com/
> 
> v2: rephrase title and git log.
> ---
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

[Jerin Jacob]

On Wed, Jul 6, 2022 at 3:19 PM Zhang, Roy Fan <roy.fan.zhang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Vamsi Attunuru <vattunuru@marvell.com>
> > Sent: Monday, June 27, 2022 6:30 AM
> > To: dev@dpdk.org
> > Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
> > ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
> > mdr@ashroe.eu
> > Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
> >
> > New event subtypes need to be added for notifying expiry events
> > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > expiry limits. This would be added in DPDK 22.11.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > More details on new event subtype proposal discussion are in below email
> > thread.
> > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
> > gakhil@marvell.com/
> >
> > v2: rephrase title and git log.
> > ---
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>

Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

[Andrew Rybchenko]

On 7/11/22 17:53, Jerin Jacob wrote:
> On Wed, Jul 6, 2022 at 3:19 PM Zhang, Roy Fan <roy.fan.zhang@intel.com> wrote:
>>
>>> -----Original Message-----
>>> From: Vamsi Attunuru <vattunuru@marvell.com>
>>> Sent: Monday, June 27, 2022 6:30 AM
>>> To: dev@dpdk.org
>>> Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
>>> ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
>>> mdr@ashroe.eu
>>> Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
>>>
>>> New event subtypes need to be added for notifying expiry events
>>> upon reaching IPsec SA soft packet expiry and hard packet/byte
>>> expiry limits. This would be added in DPDK 22.11.
>>>
>>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
>>> Acked-by: Akhil Goyal <gakhil@marvell.com>
>>> ---
>>> More details on new event subtype proposal discussion are in below email
>>> thread.
>>> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
>>> gakhil@marvell.com/
>>>
>>> v2: rephrase title and git log.
>>> ---
>> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

[Thomas Monjalon]

27/06/2022 07:29, Vamsi Attunuru:
> New event subtypes need to be added for notifying expiry events
> upon reaching IPsec SA soft packet expiry and hard packet/byte
> expiry limits. This would be added in DPDK 22.11.
> 
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> More details on new event subtype proposal discussion are in below email thread.
> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/
> 
> v2: rephrase title and git log.
> ---
> +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to add
> +  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> +  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> +  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.

While at it, would you consider avoiding future ABI breakage
with RTE_ETH_EVENT_IPSEC_MAX?

RE: [EXT] Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

[Akhil Goyal]

> 27/06/2022 07:29, Vamsi Attunuru:
> > New event subtypes need to be added for notifying expiry events
> > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > expiry limits. This would be added in DPDK 22.11.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > More details on new event subtype proposal discussion are in below email
> thread.
> > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/> >
> > v2: rephrase title and git log.
> > ---
> > +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to
> add
> > +  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> > +  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> > +  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
> 
> While at it, would you consider avoiding future ABI breakage
> with RTE_ETH_EVENT_IPSEC_MAX?

For MAX values there is already a generic notice. Do you want to mention this here as well?
IMO, it is not required. We can work on it, but do not need explicit mention here.

Regards,
Akhil

Re: [EXT] Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

[Thomas Monjalon]

12/07/2022 17:30, Akhil Goyal:
> > 27/06/2022 07:29, Vamsi Attunuru:
> > > New event subtypes need to be added for notifying expiry events
> > > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > > expiry limits. This would be added in DPDK 22.11.
> > >
> > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > > ---
> > > More details on new event subtype proposal discussion are in below email
> > thread.
> > > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/> >
> > > v2: rephrase title and git log.
> > > ---
> > > +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to
> > add
> > > +  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> > > +  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> > > +  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
> > 
> > While at it, would you consider avoiding future ABI breakage
> > with RTE_ETH_EVENT_IPSEC_MAX?
> 
> For MAX values there is already a generic notice. Do you want to mention this here as well?
> IMO, it is not required. We can work on it, but do not need explicit mention here.

OK I forgot we had already a generic notice.

Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

[Thomas Monjalon]

> >>> New event subtypes need to be added for notifying expiry events
> >>> upon reaching IPsec SA soft packet expiry and hard packet/byte
> >>> expiry limits. This would be added in DPDK 22.11.
> >>>
> >>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> >>> Acked-by: Akhil Goyal <gakhil@marvell.com>
> >> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Applied, thanks.