From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E091A0093; Tue, 23 Aug 2022 15:12:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11D1440DDE; Tue, 23 Aug 2022 15:12:24 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id DE95D40DDA for ; Tue, 23 Aug 2022 15:12:22 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27NBZbKR022330; Tue, 23 Aug 2022 06:12:18 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3j4x5h0b3w-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Aug 2022 06:12:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nnIXdxfKyFkhPYwfBjE/qQKyoiA8AzLQZRK5HQ7eAZprWLRTRYJijlxCvx3gvVCkYEXCwh9NKG/MjY3DXTslaI/gIsud/pg6q21VRRlRe9jOOyb6zo/o10UT6ARiXHST3e5D+pQCXlGhpKgOiZoc/6jX87JMkpR13UgS4ySEzF1FSVI4bMmkFTWxKzriBzEKLnK6R20P262fByyfs5No5f9NM6B7r85t23o25lsTrc5NY4/xj8O9CyJLwxN3WYJ/2fzEWc4IC18GcmbTTDwrfzP1Efglir3DGUr1MoYjxay4MRNUDGECJVpQXI1H115L+VZrFHmZZLJQHcYxvuaqvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gJ2OjoK/amhSyBqaMnPOL5MlGfZu2ss98UHJPC6H+Ls=; b=nuRmyfv1gFxmyNPjarnXbTNYi2Ahsy5WhoJ3Ywd8a/sQDTft8Fea5v5hdLzHTpDd2LA6gHdR2ygeoQe4L82NzA3QytHHAazjBY5cfj3Sy3m2rA6fk9MZEUMJBerDG4qVlNPGVUWP/HFE3ocDTZ2IWRFHWBjqifWw1cBEQ+HvxKs0ODfu8JlnwH+U/1QsERm9xjIyq9EpaRigumyseBUANaBi8/6VZ1Vo1pXkvX3LmJ0CjXv7wFSssayhYGa8lzpmITpGo2yx+mwMBDcrNMmpHtvK37h4/VVEFnn1qrsHLWQyQE8ojck9oe3ML9WBOnQ8FswsfByKprwu+skPko+KAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gJ2OjoK/amhSyBqaMnPOL5MlGfZu2ss98UHJPC6H+Ls=; b=qRMh9zjsjyC7H8RhCGIeSkYIzw740D/xBVc6mdRll6EhndPzz1GltDNUPziEWKruDmqiOuQTMbWWwKl3mz+5GxwETtHThnFDFUmjZEzYyRPLM3/0qzooqMUbAPCOOerMgx+2oy3MefwsZzEuGH6lpNrKWNefQIJ6WPrqPBcCF7U= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SN7PR18MB3999.namprd18.prod.outlook.com (2603:10b6:806:107::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.24; Tue, 23 Aug 2022 13:12:15 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::b0e9:25a1:1aea:4382]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::b0e9:25a1:1aea:4382%9]) with mapi id 15.20.5546.024; Tue, 23 Aug 2022 13:12:14 +0000 From: Akhil Goyal To: Amit Prakash Shukla , Ruifeng Wang , Radu Nicolau CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Amit Prakash Shukla , "stable@dpdk.org" Subject: RE: [PATCH 3/3] examples/ipsec-secgw: compilation fix for GCC-12 Thread-Topic: [PATCH 3/3] examples/ipsec-secgw: compilation fix for GCC-12 Thread-Index: AQHYtt9I4wGuqPhwm0erUUdMJiL3rK28dVeQ Date: Tue, 23 Aug 2022 13:12:14 +0000 Message-ID: References: <20220823105742.2276506-1-amitprakashs@marvell.com> <20220823105742.2276506-3-amitprakashs@marvell.com> In-Reply-To: <20220823105742.2276506-3-amitprakashs@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a38b830f-cb06-4956-cf34-08da85091907 x-ms-traffictypediagnostic: SN7PR18MB3999:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cLG3Y/7mqGgjJwHqZGhiizhJ3z7DM1sDP4Q5M0hdO1lnEQyo2UHdS1nofZ7tqVYXNRqlmpVJIxsqo5wee9lKsOL9ShAIIzUBmIoL8XidYN2JASS0vACymMKcjaoio6OzAoZDEdFLmLbd/yriF/rACWTNu55OxYPC068NlPcQrOfIKM+er3fq3mrk5yMUrb4EmcNwYpMsS3C41t6d1kYR68Xevw3nnNIuxOXJY4zikRm9/w8zaVcfj7HJJX7crgbYuM1V4fVkj6MXokjXu+c31r/dHuO62TeLaVsETovQXqKpZ7puzDgtcNHm1ihWx+axOB6vrCg0Y0s5TwBeMGOQ8JmzxX28DhjNuwP3G5D2uAQc8C7me5UULzjlfxQrN6qZAEWRmkARRpim4IQMqWcC3THAWfWqLGqhpyf9TBZBnYRBQcI1YmLxenUq9+aX/Zjah8EExggOx11UtS6ivpJjEu9JpEyssMEzr1hMQschpWSBZ0xW1zP6kcMN2iYk+TIj/NGPkP0/43j9ASScQJyTm85B9chshFMF6ODc8+aol0i4EulXbZYYFL/A57OarKiPVVP7Xk8RGyLFSgIaabRSivlQIThQFdpts+xOKzb9tisW24D5hQfVO6AI3g0YErHEL9/2q4j/jLrTH11poMnYxyLmiuMpq0Pf7dPsTz3vtR5O+GvY6Ia38AKFJRHzIxzucLYsnSTf0ca22rqPgktqlk/PgyKD2l+R9mGWaCcXthwAoCxePMpEcy7xSrekNZL3k8MRSJ0+1SYtdrLNjDzJWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(2906002)(55016003)(76116006)(52536014)(8676002)(66446008)(4326008)(66556008)(66946007)(64756008)(66476007)(33656002)(41300700001)(54906003)(110136005)(71200400001)(478600001)(9686003)(6506007)(7696005)(55236004)(316002)(26005)(38070700005)(86362001)(186003)(83380400001)(122000001)(8936002)(5660300002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DkpEFqylpd1PvRIKI+/p0Z3K00gjLvjJ668Tv3gZoH/z1h332s2hOAmsv6Iz?= =?us-ascii?Q?c1QgEDRDjVKMGFz14Uk1nmTBOG4u1hy8RtcRWRBFf2trWPybcJ2P68pn3IdL?= =?us-ascii?Q?z7qdWuFcct4Ve21UCXcuSSfXAafk+uaq+Nf7Ypw1+PGK/hynF+xJA+WIaywB?= =?us-ascii?Q?xdLIsBK/RL/V9Y4agjg5VXp4K/pV9Ud2FT2oQyM2CByDQ1nzh8vK+5YyDZ1s?= =?us-ascii?Q?0hM5kZA3vbhmxftUYBW2dr1M+J+83WlvEciW7uwcjFbcpHijdMmnQPRRPFO6?= =?us-ascii?Q?6LZ5xsYDG6dccyqbdBVPgFKLoiQtEg8ogZlcVLDQ2nF7iAVr3z53RQFO1mTK?= =?us-ascii?Q?dNtmmeQCbGPiCDk6VdtqsOXcwTfF7Vfa9dTPBNP53Dp5UUzx/+pfV4iX1On+?= =?us-ascii?Q?nijeEfCoXWSh0QKhQOvzdbQ8R6+Do9XpFQyOR4/udETcf5jbf7WB0b+7FEf/?= =?us-ascii?Q?H5iIYMAFU1aJHqfMEm+mvNgrbcA031uE4c1YZj9v+gcM2BU7coq4WyYfYl6O?= =?us-ascii?Q?7qH0QwkMn5pxGs24LWvswvSi2PrpZwvT1reNBr5ET3hve3/TfRwlYGajg0dM?= =?us-ascii?Q?whIy94QXk1f3Hnq2F+EvFjPHj+VLmpksgCV3pkI48ETKMTL8RNZrP+ElQTxG?= =?us-ascii?Q?/J2FknQDOf+MqD+GAedflkA++HSuIIZ0kiSqjmGU/Isoq5yVGDQ38jC7uqZC?= =?us-ascii?Q?YZbJ/SGzvYHuJoJX1vGqPQfCyvM9lHXQKKpvOEHImlO2bBYjPqwvvDII8Y+l?= =?us-ascii?Q?9kvknVDZCuLuK9vtielVCCG4HT2V2C5jHArIKMdzuL8AS0F9RMgBgeRn7lgB?= =?us-ascii?Q?RxUcEhoOynbktSj3vRlJYyzAKKz/pBrgrafqYg1giTr7N8x0XFi0phLknDGI?= =?us-ascii?Q?8PxqcWzPir8iefFVyKMad1XAsi5HB+TDvEHfkPgvLV3Iu8ZTCUuBhZ5HKDEh?= =?us-ascii?Q?CkIWw9HPnMSJ1BOwfKVIZPdUHos284RVXOwNk0BCJJAgyiQPPuTBUg8x+yOU?= =?us-ascii?Q?vLLpfO0CltKlVrqAuNI1opRGKL9znhADkWyMkSxN7E3lrkyorVCHv+ize3vp?= =?us-ascii?Q?43BTEOdb7OSupAV3Rz/xRQ150B9/+UJkWrMPnh8mLCW980ftOfjlnOI59gLO?= =?us-ascii?Q?BFKOrqinSvCSdAif+BvIWG9yTvso5CK+ZIiRwyIrWyEoZy3AQ+jZFHJb1a2j?= =?us-ascii?Q?3hMjmSBTSWfmCrqHgzbYAzOiDXmsWtPyTJKU0aA2/6y0E0pW5LXPYktRWRL3?= =?us-ascii?Q?at07Gd0f4Uv365sb2RQSbSh8qUgGBICDXadG2FJmtGtIhyWLJYcz1dZkEo00?= =?us-ascii?Q?eog3jBzBC+8ao4uxtkbsisvfDFYLwJCRfpyn1/grUAXMvdQFlAaXydSFgers?= =?us-ascii?Q?m1J+bHzHvsD9iAj8pcZz1402pWXCeDq7iTOANF6efDVU58ul+q+M49kwIME/?= =?us-ascii?Q?MwVKPQZdxuo8ONv/LI0uBbsvAZy/C3W1XyKm0GKWPWrVJ596bJM6bn3PeZLE?= =?us-ascii?Q?Jhb54Flsf5p9W32YKD6T3s6OPREsBlNClX94ISHuF+PtSOxeHdPuba2ou6zO?= =?us-ascii?Q?e/za+OpQJyiWKLQqo0k=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a38b830f-cb06-4956-cf34-08da85091907 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2022 13:12:14.7332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LegOcKNzl0d69mJMmkGM5GUSmY9Y7zmCc8w74WQ16UKQWMNJyDT48MxYy6dA3X/rg136HpZlrQlnaA/6CiM+Hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3999 X-Proofpoint-ORIG-GUID: Fwh7-8uNp1GvrshkoK935VTylZQSnDR1 X-Proofpoint-GUID: Fwh7-8uNp1GvrshkoK935VTylZQSnDR1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-23_05,2022-08-22_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > GCC 12 raises the following warning: >=20 > meson --werror --buildtype=3Ddebugoptimized --cross-file > config/arm/arm64_armv8_linux_gcc -Ddefault_library=3Dshared > -Dexamples=3Dall build > ninja -C build >=20 > In file included from ../examples/ipsec-secgw/ipsec_lpm_neon.h:9, > from ../examples/ipsec-secgw/ipsec_worker.c:16: > In function 'send_multi_pkts', > inlined from 'route6_pkts_neon' at > ../examples/ipsec-secgw/ipsec_lpm_neon.h:170:2, > inlined from 'ipsec_poll_mode_wrkr_inl_pr' at > ../examples/ipsec-secgw/ipsec_worker.c:1257:4: > ../examples/ipsec-secgw/ipsec_neon.h:261:21: error: 'dst_port' may be use= d > uninitialized [-Werror=3Dmaybe-uninitialized] > 261 | dlp =3D dst_port[i - 1]; > | ~~~~^~~~~~~~~~~~~~~~~ > In file included from ../examples/ipsec-secgw/ipsec_worker.c:16: > ../examples/ipsec-secgw/ipsec_worker.c: In function > 'ipsec_poll_mode_wrkr_inl_pr': > ../examples/ipsec-secgw/ipsec_lpm_neon.h:118:17: > note: 'dst_port' declared here > 118 | int32_t dst_port[MAX_PKT_BURST]; > | ^~~~~~~~ >=20 > Fixes: ce23f7ceec6b (examples/ipsec-secgw: add support of NEON with poll > mode) > Cc: stable@dpdk.org >=20 > Signed-off-by: Amit Prakash Shukla > --- > examples/ipsec-secgw/ipsec_lpm_neon.h | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/examples/ipsec-secgw/ipsec_lpm_neon.h b/examples/ipsec- > secgw/ipsec_lpm_neon.h > index 959a5a8666..25f0abcaf3 100644 > --- a/examples/ipsec-secgw/ipsec_lpm_neon.h > +++ b/examples/ipsec-secgw/ipsec_lpm_neon.h > @@ -115,7 +115,7 @@ static inline void > route6_pkts_neon(struct rt_ctx *rt_ctx, struct rte_mbuf **pkts, int nb_r= x) > { > uint8_t dst_ip6[MAX_PKT_BURST][16]; > - int32_t dst_port[MAX_PKT_BURST]; > + uint16_t dst_port[MAX_PKT_BURST]; > struct rte_ether_hdr *eth_hdr; > struct rte_ipv6_hdr *ipv6_hdr; > int32_t hop[MAX_PKT_BURST]; > @@ -157,17 +157,15 @@ route6_pkts_neon(struct rt_ctx *rt_ctx, struct > rte_mbuf **pkts, int nb_rx) > pkt =3D pkts[i]; > if (pkt->ol_flags & RTE_MBUF_F_TX_SEC_OFFLOAD) { > /* Read hop from the SA */ > - dst_port[i] =3D get_hop_for_offload_pkt(pkt, 1); > + dst_port[i] =3D (uint16_t)get_hop_for_offload_pkt(pkt, > 1); > } else { > /* Need to use hop returned by lookup */ > - dst_port[i] =3D hop[lpm_pkts++]; > + dst_port[i] =3D (uint16_t)hop[lpm_pkts++]; > } > - if (dst_port[i] =3D=3D -1) > - dst_port[i] =3D BAD_PORT; get_hop_for_offload_pkt is returning -1, can you also return BAD_PORT from = that if there is error. And you would not need to typecast it explicitly to uin1= 6_t. > } >=20 > /* Send packets */ > - send_multi_pkts(pkts, (uint16_t *)dst_port, nb_rx, 0, 0, false); > + send_multi_pkts(pkts, dst_port, nb_rx, 0, 0, false); > } >=20 > /* > -- > 2.25.1