From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 847AAA00BE; Thu, 10 Feb 2022 23:37:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ED58410E5; Thu, 10 Feb 2022 23:37:20 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 03BEA4013F for ; Thu, 10 Feb 2022 23:37:18 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21AInnM8007540; Thu, 10 Feb 2022 14:37:14 -0800 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2107.outbound.protection.outlook.com [104.47.70.107]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3e50ucb2fm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Feb 2022 14:37:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lMSP5upk8X9D6EQF6p6Ja9p/Vdaa8ixxopWzWOp5HCnuL/ml3HZUjDkuVXWhz1Iuv7/tB/lm/+D9WRyjU8v9L1SGC/B3UClYglGUOs1lX19J13qTAuDd7/8bBfReiU8Hsyr4hl6xYXns8HdmzBl+jpve/P1tsyBK/C9wDMcL4X65bmQHKCkSpyjsD3Gw+QwYRBAME3I9x29dX4YjAUFqroaPt9MwhwnCNCYaHtFYsnD6ZH0F4CilNa5x5HNItIvGIB2cHIBtfnUQciUS+LlCohyAo2T+BMx6bosjysrGrJObe4ox/WxDn372viPjb7ZYOt5dXsQj2DViwGrlY+4+GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tSMiYkYC9tdRRog0E8bsZrs9NmlmQrW/CZ8JrtTBXjs=; b=nYundnym1mgqVUEhprv5/ywh/LrtHKmGui0xcP8jdkL4/mfNUxURSNrJ4PS8TXyP5X0H/X7jCsAwfNe+ZxcZ1gGwhnr7eVbeaEJtV0Scf41/yAMgoIBfs67lRY7A/GkqPIJrmgYSWQBNkl5eEJvRRjMlRGU7gTHlEo9BoCGrw9qY22yNGHb/nfbSCHQsUJIcccwy7smdTkM6tGmrm7AGfd0iJRGRlAWC1Lj2CBFlYjKETi2/4UkLxSW3AHfJoQ1DekJzQfJSHES5EhQ5vnE3v5C98uZa4TeWEnQF5QQuQGKRep2pQImxbxfxsXJqDpta/PsN0YF+yLdkWjAgZ9gAIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tSMiYkYC9tdRRog0E8bsZrs9NmlmQrW/CZ8JrtTBXjs=; b=dFDMnaMXHSfmkV8MsFnx8w1JwgkXxB2ewNRQ36skSheX0ymOGYauRlDmrEAoKSpBGQQ49L5MjVzMiyDmfc/uvBVOpNpSDsh2sTMkom5Z7em6w1pTWOf03kqrgrqcEoYdZog7JPmrC+Y4NUsHbusrCiM8mX7m9XZ4vqtoh1SgLE8= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4915.namprd18.prod.outlook.com (2603:10b6:a03:40e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.14; Thu, 10 Feb 2022 22:37:11 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::d4c9:8800:1431:88e1]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::d4c9:8800:1431:88e1%5]) with mapi id 15.20.4975.014; Thu, 10 Feb 2022 22:37:10 +0000 From: Akhil Goyal To: Ciara Power , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" , Anoob Joseph , "mdr@ashroe.eu" Subject: RE: [EXT] [PATCH v6 0/5] crypto: improve asym session usage Thread-Topic: [EXT] [PATCH v6 0/5] crypto: improve asym session usage Thread-Index: AQHYHpZy5BfBh0DUU0mc3ZVNK9shgayNYApw Date: Thu, 10 Feb 2022 22:37:10 +0000 Message-ID: References: <20220209153854.2740455-1-ciara.power@intel.com> <20220210155404.3598576-1-ciara.power@intel.com> In-Reply-To: <20220210155404.3598576-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b221bd7-59d1-4bd2-279b-08d9ece5e086 x-ms-traffictypediagnostic: SJ0PR18MB4915:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zpPHAwyg8izdrqSWU+C90+ISdjcE8VV+LJLEtpGatLOc+ZR5F8NAkob/OLNttSqgnXaGZR6/eee5ZfRSJApNjbnPAfv/jCAyJLzJS+sU/dMLjUrvdkCifoZ53sBEIWgnnsq3XKatkTyrHTc7OmEJMv1h74vznsN3hC953M6gnQeRYb79qD3rIYcmiWKr64vLEI6F4BmBSXYUbrT/Hn8rWay3Gfgwnjoi9CAQGj5CHkL+31KY/9Nmtmt5ar4TblwS0zmmdPsHL/TcW9V2XcFDODVgwXoXRbRDPWqavhO4zQ73f3kfgGzI2L5NP1O1t+MOdcfns4PO5e+Uh6OsFRB7v3RAlTO9qeIjpAN8XXN9VT49KE2dMP+kNTVQPcsrJmCDzRxFgQO8nH1jfwJneITzSeedycVfV6ed8G9JhtchpR10Q92kpH6/xSfBozU/M1JFafegMQTwfOoF4/3jpXCZZBwrzJPYBvmtNJ2N9eBUAh77mQcSQ6i4oTwx8Y186Ez3PWlBDUpYJ4xkFnRBVk8oQuMq1rafJRSyBTYCQGJhTyC4xorTXLQOkPeomasFEtrr2yfEOHXGfWLadbzOaU/WgG+ajI+CVLn8jBi6M4Zg7du15ozGHE09U/PdLjqKUtray1BgYcKyQmDGO0FExXlj/hPXWUXLkqOWzpjAYQSFAYwlWoHoMWkZlKSoedNWQjgtzeFU0pSM+cdsq/tpxSn5GA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(83380400001)(122000001)(71200400001)(55236004)(2906002)(26005)(7696005)(52536014)(76116006)(38100700002)(508600001)(33656002)(55016003)(110136005)(54906003)(38070700005)(316002)(6506007)(66476007)(86362001)(66446008)(5660300002)(9686003)(66946007)(66556008)(64756008)(4326008)(8676002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GWST2IxhCGHn8D2HBJ6OgREkueacAD6NLcohyUzanNrK+o0Ri0CWSBwnIX0r?= =?us-ascii?Q?U7Q7YBh1Ux2lp9kie1w8zteZ0XD3JjHXsf2SOzQhKEa88PFAOvv+8l9pWb2C?= =?us-ascii?Q?V2dYA6RMNUv/cKd/W+JQecfORi2BGKdy1v4kCW6uIOxXhlT24fXibieHYXpj?= =?us-ascii?Q?YXSeXTVOX1VhQFGfB2+7rVH9qk8vknuPUV9TdAskmSoly5PSOI4R2qTCrHQ+?= =?us-ascii?Q?m54YTnxQXW882xbLUXh/DlpQBI3AiNQxwsJfH5ay5uyF2VeEDQhpmx+SA5Sj?= =?us-ascii?Q?4YDUZHbtbDscZDfrYIKHXDHPRbB0eEO/Ldncqz95pnJiUj9LhBft9kc0Xh+x?= =?us-ascii?Q?Th4REhMACPsrJEjYloggjBl7BvfJzrtbyXNHC0YOf96UJetElMpWkSSYpvtp?= =?us-ascii?Q?0igYR5voJRGj/rfLP3cm81mBuYX/SPWsdMus8aDIBYWQRZ2yVruS7RYz2QS0?= =?us-ascii?Q?H4b8k2bLy6OoR7P8DWv31GTwXqtH8Kh1eWezqrPuY3uwo9Hla6LDHlthKpck?= =?us-ascii?Q?jbzCZdeVf1RmcJ4q7nE4huD8F8rGzslPgCjvZ9xmCBMPYJ4BfDJ+nGB9Px03?= =?us-ascii?Q?4OCojZMeXSHeu5JNjMzDebWs890kgDKjY1xGJrBuGDBrR6PQkhL5g6xVbGTX?= =?us-ascii?Q?0L2nBstl7pOKFmDpNPJ8e0GfQdOK/M3MJ90BkzmwzK3PnLQ/Syvw9xG6tgPE?= =?us-ascii?Q?fuNVisdMvXlpqsj7PVkqkSd8s0FJKlvUVfHXCvEp/4oHHIUhM0pefL79QiWX?= =?us-ascii?Q?RfwTXvYyzSAjLHzZixeo0FeemYGal46jgLuq0iaYDvO73NU/zrrqyU8+s2O0?= =?us-ascii?Q?P0Mx8jtLy4NJEhF7Gt85KPA9C62Ek7ChlvFQGJfZ2ZSB4xUQ6lVrHJVuDaMH?= =?us-ascii?Q?duxtxuH9EA9mofw02uobulHC8ABm43/Z/tP7sABdqN0gJvU4LweOIMDij4DH?= =?us-ascii?Q?R9Yy3+aD5Q/0f7hkJa6lH8bxbGBF5ysQx/jNfKbJmLKihx1wRKAwQHdN7wAs?= =?us-ascii?Q?wfEH/Hoqd4ofakfvp1HySpkzqiYMEwTqp1MXRTM9Bm1oadsVQtGNOuFSUUPS?= =?us-ascii?Q?SWawrH5XdVBx06Kj2tS2C3ywxQBpS5JPaIaMlOmWrn5+Xg0gJ3Z4OZrAho+I?= =?us-ascii?Q?e832EOo2W1Hn1SBFeWYxfYpZzCwOZqQra37YGK+O27pW6CSGXCu8eR5ICHMK?= =?us-ascii?Q?WQvKb2cMRWyAfCLObnUHFPYY8295FIjqA5BkTGGwSVLk84C5b0t1mTAFExNk?= =?us-ascii?Q?VP274PP5UhOdScgK8yj+c2MDcSA7Ztz5YWOx3O5hc8u8lnCcSldSfk3BbcPn?= =?us-ascii?Q?6YXlb3KC983peICThcwEzK9d1pYNsb49yHZjCz6DrN4FtuNRwTptXbE+mbyE?= =?us-ascii?Q?3Ph5Ts2Q4t0MKm2pFRhE+MCONae1S4SZzZJ6/O1cK/2TrQzy3h0ZZVAWsSq1?= =?us-ascii?Q?WbMr2ONDDfE976/FtXIXh0zPOpgXb6hxCjdtHmIRBoGyEHEtWvJ/FkCRmiEj?= =?us-ascii?Q?gnCYR2+HDIXbn7vG+ud984+kPz4XJ5mKPP6o2k1FVg+Hof/OvvA9RPWqDuUw?= =?us-ascii?Q?+cValM7AtsWhSc5+3f8sMqBQU3IlN7ggmbyYl4JKqhurNMc9mTV+ax+f3GYZ?= =?us-ascii?Q?sM8jM2WVP0W51n8bT3ZWYAk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b221bd7-59d1-4bd2-279b-08d9ece5e086 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 22:37:10.6928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R59k83iSFgkTwBxhRQn59gVK60Cj26pKFdwxAOn6/zyJNI6cPBqpMfRhAf6g4bf7ubKm3UeZv9IOsmQ4hI7AlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4915 X-Proofpoint-GUID: JIeEQ1Wk3SX5R6w0xoVenufg_ATWCbF2 X-Proofpoint-ORIG-GUID: JIeEQ1Wk3SX5R6w0xoVenufg_ATWCbF2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-10_10,2022-02-09_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > This patchset includes improvements for the asymmetric session. > The main change is to the session structure, which is now a single > mempool object, rather than having pointers to private data elsewhere. > This session structure is now hidden in an internal header, > so the app will never use it directly. >=20 > Some other changes include adding a user data API, and modifying > the return value for the create session function. > This create session function now also initialises the session, > and subsequently the clear/free functions have been merged into one. >=20 > Sample code in the programmer's guide that showed basic steps for > using Asymmetric crypto in DPDK has been replaced with literal includes > in the first patch of this patchset. This ensures all subsequent code > changes in the patchset are automatically reflected in the documentation. >=20 > v6: > - Reordered variable declarations to follow cnxk file format. > - Added fix for crypto perf app asymmetric modex operation, there > is no longer a need for private mempool, and the > rte_cryptodev_asym_session_pool_create API should be used. >=20 > v5: > - Modified which patch the sess parameter is passed to session create > trace function. > - Reworded create session function description. > - Removed get API for session private data, can be accessed directly. > - Modified test application to create a session mempool for > TEST_NUM_SESSIONS rather than TEST_NUM_SESSIONS * 2. >=20 > v4: > - Added new patch to add literal includes usage in programmer's guide. > - Merged asym crypto session clear and free functions. > - Reordered some function parameters. > - Updated trace function for asym crypto session create. > - Fixed cnxk clear, the PMD no longer needs to put private data > back into a mempool. > - Renamed struct field for max private session size. > - Replaced __extension__ with RTE_STD_C11. > - Moved some parameter validity checks to before functional code. > - Reworded release note. > - Removed mempool parameter from session configure function. > - Removed docs code additions, these are included due to patch 1 > changing sample doc to use literal includes. > - Initialised session variables as NULL. > - Added possible error return values in user data API comment. >=20 > v3: > - Added documentation in relevant patches. > - Fixed setting user data size. > - Fixed hiding structure, it should not be hidden from PMDs. > - Fixed some other small formatting issues. > - Increased size of max_priv_session_sz to uint16_t. > - Removed trace for asym session init function that was > previously removed. >=20 > Ciara Power (5): > doc: replace asym crypto code with literal includes > crypto: use single buffer for asymmetric session > crypto: hide asym session structure > crypto: add asym session user data API > crypto: modify return value for asym session create >=20 > app/test-crypto-perf/cperf_ops.c | 22 +- > app/test-crypto-perf/cperf_test_throughput.c | 8 +- > app/test-crypto-perf/main.c | 26 +- > app/test/test_cryptodev_asym.c | 380 ++++++------------- > app/test/test_cryptodev_mod_test_vectors.h | 4 + > doc/guides/prog_guide/cryptodev_lib.rst | 212 +++-------- > doc/guides/rel_notes/release_22_03.rst | 14 + > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 8 +- > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 8 +- > drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 22 +- > drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 3 +- > drivers/crypto/octeontx/otx_cryptodev_ops.c | 32 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 4 +- > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 24 +- > drivers/crypto/qat/qat_asym.c | 54 +-- > drivers/crypto/qat/qat_asym.h | 5 +- > lib/cryptodev/cryptodev_pmd.h | 36 +- > lib/cryptodev/cryptodev_trace_points.c | 9 +- > lib/cryptodev/rte_cryptodev.c | 258 ++++++++----- > lib/cryptodev/rte_cryptodev.h | 136 ++++--- > lib/cryptodev/rte_cryptodev_trace.h | 38 +- > lib/cryptodev/version.map | 9 +- > 22 files changed, 526 insertions(+), 786 deletions(-) >=20 I see following warning in compilation ../app/test-crypto-perf/main.c: In function 'create_asym_op_pool_socket': ../app/test-crypto-perf/main.c:72:36: warning: unused parameter 'dev_id' [-= Wunused-parameter] 72 | create_asym_op_pool_socket(uint8_t dev_id, int32_t socket_id, | ~~~~~~~~^~~~~~