From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93FFEA0C43; Fri, 8 Oct 2021 20:57:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BB7D4068F; Fri, 8 Oct 2021 20:57:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id EAFB04068E for ; Fri, 8 Oct 2021 20:57:41 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 198G8x6r014835; Fri, 8 Oct 2021 11:57:41 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2107.outbound.protection.outlook.com [104.47.58.107]) by mx0a-0016f401.pphosted.com with ESMTP id 3bjs8nrju9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Oct 2021 11:57:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/T0XCJB8cMVRFKxZboWL8901B+CXtbmPeMIPBrREgsw69Bh6JiZChtgeY8XjcUcrqTj6VYsVzCWI5xEiEI2TgnhLAse3lZQ7pdgaOxSX21hiEcS5x8lw8b8nbLzKfvwOldP3XrpkK8JLLItP5A6hCIB3Jn1OVca89pJrg4b+5vOpOL9bUHQpUqBVitKf7cvBXq5DjfZCri5DE055zg9YZbU+Hn3xYNjpuXz9bb9xcP1TZFkGW6dCbDsPswZFpDe/DV4Fvt7A3hlhJptyaMTRKOkRFRoIvN/w/FAITybV5kClFWk2F4u/X5mNModjuhqS7tX71rTJGQ98tP62ft2PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RKYSzZuQqxaeYcgWt1qCBFH68yCBCm0XoRkQqBO76js=; b=K0ff5asAIwxVG0lockV56diPCgWBtqe8PdFLORGtA1HSbeFG4SeAoKy/XgeSaIjEJiEXxDxIFx5ccb1m5IrrZS1UbdwMCgN+luKlYOWi7Do6nIi16pUxYZx5/Pwq5NhwacokRXSa5T77FHN5NxltpoThIQq2/bUIGxs9LuLFwQ8oxcEkl8+FKLdkETQJXYxeYNGoqpGTth86O832ORquh9uNI4RP2hWXK55yqGDlQ1Z3Y4UrgGVdjw6UU9fp/KMbgFkdvA1DoZztLXQVQ66nmzUVy2aAheQh6HTGL8ZVG4Bu/Esji1txyrnfhQJBekqmqzTKh4fhRL8MJvzOeZpaIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RKYSzZuQqxaeYcgWt1qCBFH68yCBCm0XoRkQqBO76js=; b=AJ8mbem21N93teT7NdFFwi9Gcdb5LGF2S9pxvZ3AbqL87W3L0p9pFYbNhNa1HxvbGKCSKhTnQ/iYSsjpCJJOS5eAYQNI6avAoYuItGv7upDGErnmE7fd5tJvRcmR4vY0F7m1BUe9oGQJ3MVngyeEc+dGDZczdJyLbgnG+dhsCso= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4795.namprd18.prod.outlook.com (2603:10b6:303:ee::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 8 Oct 2021 18:57:39 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 18:57:39 +0000 From: Akhil Goyal To: Radu Nicolau CC: "dev@dpdk.org" , "declan.doherty@intel.com" , "hemant.agrawal@oss.nxp.com" Thread-Topic: [EXT] [PATCH v3 6/8] examples/ipsec-secgw: add support for defining initial sequence number value Thread-Index: AQHXtqu4v8tXjmB3WE+NqX3dB+eCbavJfdJQ Date: Fri, 8 Oct 2021 18:57:39 +0000 Message-ID: References: <20210903112257.303961-1-radu.nicolau@intel.com> <20211001095202.3343782-1-radu.nicolau@intel.com> <20211001095202.3343782-7-radu.nicolau@intel.com> In-Reply-To: <20211001095202.3343782-7-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c7afdf1f-c9e6-463c-f67e-08d98a8d8019 x-ms-traffictypediagnostic: CO1PR18MB4795: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:765; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J3JqWq/QHbf4Nvy63JFPj8b0bbqtrvWj3se+tr4W7MVmQ9sQ6kgjlsJ+r939+TooVceAaQ8wLKbcXgIzUz8837PhvuSJIRP15qFg/HvQAQn55j+Bq9f67+T/a75O2FWCm+giicmAHyTFsRm2vitsWI1738xcvSapIsf/1gnR9NsVXUoM+XsAnpBTpeothjEzWrWbReeRVAYH4SKbPUba001TbnuRfHkbcMjfcM4ahkhyDldLdjV8teXoEymdGcBt4Z3X1lLwh3vMatGdTsu048oymQAjY0zFEYxl3ad8qGiIJzi7lJOv5Old/GJKLbPHUzg8DQPGlZfUb5dveAVjDiZnu1m5aXh0DvoxYqGrhE0sSUv64hfMsqqF+5qPzd/hlDtlGh+G4VWcKFLPBkDB2BwKNaW9sRjTzKWSuCzTrOYMU9R9DRM87mHKW/bdVh8teBDakc2LgkGMCgqzx9FmiNtpbb7uDxceP+9DYm4/P3rr7HGn4x91A65pBE0IQJmJ7RPm1sD+YZeSiZOFqQ2WGn0kd0Xwax/lQ8sYFTS93U1MrmvGFOPGgjwU+mWdWoxMGA78vIzwylu93C0XQv3o8nechTHAi3ZggKbkQtU+HSI2AMSWSc/eMqwU4TDwimGGjbsWCtNCtq6dWSp7AoxpHNG+LtlX9QaZiXC4SOKzKlxkkcteT1M2ZfskQbjvixa4OMd23vBM071ZBtxVlzqTQg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(2906002)(38070700005)(6916009)(6506007)(64756008)(55016002)(66556008)(66476007)(4326008)(26005)(52536014)(66446008)(86362001)(186003)(76116006)(7696005)(55236004)(508600001)(316002)(9686003)(54906003)(8936002)(38100700002)(122000001)(33656002)(71200400001)(8676002)(83380400001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bPwMAEbIsTjyiAkuMH8oUQN8KLvhnBBfw3WxPkKbsd62fT3a0WcSWXk3/vYE?= =?us-ascii?Q?pwmZyBskm9xuJQ622Jpi0csX3Hzp245qFplx06qFsH7mTMhQN/9H6EDQRBo8?= =?us-ascii?Q?Fx0Q57c1VPhaeHukSSlWwgeLykrd8DnkmT6q7wsAWmXfiL8Lxw0JFv113IeT?= =?us-ascii?Q?zymRxmfFrXTpRq704PtALbo+jgj7NFT4WK2e3Pr2m+VFmA4+4dOKz+1S3TMY?= =?us-ascii?Q?2aGXRRPu+cqMR5j8U+VYV25pfybRtjk2SeArHaZy1s4smNjTfjBgwJflGT6J?= =?us-ascii?Q?9YarKmDkZs3ozQtHJlrmylss2EJrL+VWieSTAogC47jeNURDkwCerePEDyZE?= =?us-ascii?Q?wEQyonPq4qL2JCeEXmLwG0woabO9UiH0nDS7qZWUt3RMatZT0pArnRYZQWo3?= =?us-ascii?Q?GdtmE9v2xIgEn2mq9oSWDvD4Pe0ZCznROw82TvNuvTtQlPx9JnMlnytJv3Vp?= =?us-ascii?Q?HwA5nItbltgxoQzLl0YBWyjzAAFzDq845YJqiSrjtF2efmgef5oIwoDhWqRv?= =?us-ascii?Q?UXMHnHHZRAY/TmpdIINHOWaqav5ed/uXsnLjlhyswIJnWIuGVuDbUIKxEjux?= =?us-ascii?Q?v6CAHWTnr36eQ1YPcEs2myXiEouxA4rYo2mBINUNsXJTc6wYahd3qC1bj7X+?= =?us-ascii?Q?UDuZlYJxdYKXk6JJEmY3XsSXpy63N/EMjstNyeymwkKIO/Iun41C0WqNjSD5?= =?us-ascii?Q?aIAZth6R0SvnZyBBQ/PCH6W8d2wkvDsy9PO6w6Keq3KpKglr6z0VUyrx6LsC?= =?us-ascii?Q?DQIo96F2HE0ROs0OaEBtd1GhzhMS8mwQoTOR/8XlShcHrXoc7MnO57CVplk7?= =?us-ascii?Q?EsKrSPPS6n1iW2VAvK0qcyMGov5o4PO/hgrIxXiO9fuiFm8kqeHXaAXYfpx5?= =?us-ascii?Q?RuVexaEgD5oUVfyG5wmzP+2FkSKqsj9D9yzKOmO4Inr6F7IZc5bqVx9JUwD0?= =?us-ascii?Q?fxHWbhLBISG/jVYli0A9igftNRrgxVyx/4ncCw3Su957/kgaWl7tUiuxqkSd?= =?us-ascii?Q?Yr56Uu56uONOpVRzYBYR3OU8QSSc7qU3JmxwzAKBeT1fySeKPSqJ4JNdeqL5?= =?us-ascii?Q?QWMXzytmGR1Z4Xhu+iqRsDHVT0f4uwZhLXwMy/vhZlJ2GUtQAVjZeU/i6xFl?= =?us-ascii?Q?pu0lqxLGzYlX7zZthveu8Ez4Dl8cILnMUgmu1OdRxdJ60GtuFVHRvYKa6C2E?= =?us-ascii?Q?9hxqWXUgTUa9Xk4HIeSdxTGohWWO8ev9jd7/K1oDEJ+SEIeErZM9fGJ9scch?= =?us-ascii?Q?uvtzwMNU0lATLoV28/uUQx2V3g7iUzRD1bR7bF6oGNAqntjJW5hZbOsr5vZu?= =?us-ascii?Q?n6w5vDfP2k7ZVyQKTwALWSKN?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7afdf1f-c9e6-463c-f67e-08d98a8d8019 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2021 18:57:39.2807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FD+OxqeYLLrB94CIVigtk5Mq0su58qBWFaZRMkCIU5X9RrkiybUBh2qjV6I6gmhdvI+n823wTOac7q2CQpW8Iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4795 X-Proofpoint-GUID: KEp6aGURVuvZt578qcR7bRVFj13nr1JD X-Proofpoint-ORIG-GUID: KEp6aGURVuvZt578qcR7bRVFj13nr1JD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-08_06,2021-10-07_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 6/8] examples/ipsec-secgw: add support for defining initial sequence number value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [EXT] [PATCH v3 6/8] examples/ipsec-secgw: add support for > defining initial sequence number value >=20 Subject too long. examples/ipsec-secgw: define initial ESN value > Add esn field to SA definition block to allow initial ESN value The commit description should describe the new option added in the app. Only a one liner comment is not sufficient. Please check other patches as w= ell. >=20 > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > doc/guides/sample_app_ug/ipsec_secgw.rst | 10 ++++++++++ > examples/ipsec-secgw/ipsec.c | 6 ++++++ > examples/ipsec-secgw/ipsec.h | 1 + > examples/ipsec-secgw/sa.c | 10 ++++++++++ > 4 files changed, 27 insertions(+) >=20 > diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst > b/doc/guides/sample_app_ug/ipsec_secgw.rst > index 54c96ddb58..0e08c30248 100644 > --- a/doc/guides/sample_app_ug/ipsec_secgw.rst > +++ b/doc/guides/sample_app_ug/ipsec_secgw.rst > @@ -746,6 +746,16 @@ where each options means: >=20 > * *telemetry* >=20 > + ```` > + > + * Enable ESN and set the initial ESN value. > + > + * Optional: Yes, ESN not enabled by default > + > + * Syntax: > + > + * *esn N* N is the initial ESN value > + Print_usage() update missing. > Example SA rules: >=20 > .. code-block:: console > diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c > index 3bee2ec2d3..0026b16041 100644 > --- a/examples/ipsec-secgw/ipsec.c > +++ b/examples/ipsec-secgw/ipsec.c > @@ -228,6 +228,12 @@ create_inline_session(struct socket_ctx *skt_ctx, > struct ipsec_sa *sa, > sess_conf.ipsec.udp.dport =3D htons(sa->udp.dport); > } >=20 > + if (sa->esn > 0) { > + sess_conf.ipsec.options.esn =3D 1; > + sess_conf.ipsec.esn.value =3D sa->esn; > + } > + > + Extra line > RTE_LOG_DP(DEBUG, IPSEC, "Create session for SA spi %u on port > %u\n", > sa->spi, sa->portid); >=20 > diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h > index f18c97959e..8a76405ad9 100644 > --- a/examples/ipsec-secgw/ipsec.h > +++ b/examples/ipsec-secgw/ipsec.h > @@ -146,6 +146,7 @@ struct ipsec_sa { > uint8_t udp_encap; > uint16_t portid; > uint16_t mss; > + uint64_t esn; > uint8_t fdir_qid; > uint8_t fdir_flag; >=20 > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > index 8cd5309517..d52dd94056 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -694,6 +694,16 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > continue; > } >=20 > + if (strcmp(tokens[ti], "esn") =3D=3D 0) { > + INCREMENT_TOKEN_INDEX(ti, n_tokens, status); > + if (status->status < 0) > + return; > + rule->esn =3D atoll(tokens[ti]); > + if (status->status < 0) > + return; > + continue; > + } > + > if (strcmp(tokens[ti], "fallback") =3D=3D 0) { > struct rte_ipsec_session *fb; >=20 > -- > 2.25.1