From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDDB0A0547; Wed, 8 Sep 2021 14:48:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E99341140; Wed, 8 Sep 2021 14:48:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A17D040E25 for ; Wed, 8 Sep 2021 14:48:34 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1889TZdO030893; Wed, 8 Sep 2021 05:48:33 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by mx0a-0016f401.pphosted.com with ESMTP id 3axtka8m3f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Sep 2021 05:48:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8KXo0r8doXzMda/c8j3q/THqUJpUVJUsFo2pDZUnZu3ZgZpD1QfizvXTsBy5IpCWcxKQfo/F4e/Cc6pQgZqmwVa61ce8kr1NiqbRBeoFSeUqA1zG9OOk2WfKxRexR+qn6jbLcjJHaoE++83SqfpmVCIuFS3VlAihAPUhv1cfqUkV0PLvXHmX4CEiutIBN+dQU8IHklKkxX3ABdo/3YjLdLp6yIUjz4/3Z1ZlKEy+egOHZKgMaiJ4HRVdu5DewPl4izEOjxDSE+CPQIoNx6Ci9l63MsBTeNWgXRxwrnZVNjPfQYIbRPNP80vDxJonTYMfkntth4kSTfHhscWg0/1IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OlzbcAfQ8LvKI9lFpHGONRNFWXPAxNQVf5gmlmiYdiw=; b=mfy/h1mFCFa4/tsYBJmQHL5XwSrIjuz3rOgh/GrZwQ62/npbGJzeaq8Z5B8i9QvN+hJlhgFb78nu2l6tL1aEKXLMUUyhuZj/TVzBk1PJGNKBm1hKyZ5rT0L0ON34se/t1h15DUiw+DnPdDNduoYRJxAi0ZkF45E8ZsgE/BC7CdKsM9h0lc+OGywrQu37ew8TN/wCBgeLiWkD6VW4wfCyFOYV9yhPThgNIs5Jtm+tvS3xe8uJ6bMoIY+3TAQQyaqldcaOPUSAQPxOOGwjkeQzsWUKYWOxBM0N9uMfHdqcFxPRXtq8pSe693/ENLh/wFpMcp6FPtRQwvAdA+t9hS3eFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OlzbcAfQ8LvKI9lFpHGONRNFWXPAxNQVf5gmlmiYdiw=; b=JfDjTik+0nPoIKiaY4btouDAZBwZ8EEnF9wMhUqvROPT4XPtGKScxtETslgVB/2BfRJNBRILkdCqSDWeGuwxYw8yyuGKYN3SsiPOPOOYt/uwIA28+1YRB6/8hkR58J5LKMG10Kae0Qm/c4zMKYRLBZ31Lpay97IMO403L+mOvds= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4420.namprd18.prod.outlook.com (2603:10b6:303:139::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 12:48:30 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29%3]) with mapi id 15.20.4478.026; Wed, 8 Sep 2021 12:48:30 +0000 From: Akhil Goyal To: Radu Nicolau CC: "dev@dpdk.org" , "declan.doherty@intel.com" Thread-Topic: [EXT] [PATCH 1/7] examples/ipsec-secgw: add ol_flags support Thread-Index: AQHXoLbjiYVeR/XEgk6ackLSbV8dMauaHbHw Date: Wed, 8 Sep 2021 12:48:29 +0000 Message-ID: References: <20210903112257.303961-1-radu.nicolau@intel.com> <20210903112257.303961-2-radu.nicolau@intel.com> In-Reply-To: <20210903112257.303961-2-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6f069196-ff66-4737-3529-08d972c6f5a7 x-ms-traffictypediagnostic: CO6PR18MB4420: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nMImqjK9lTIn+A18aCdKqAP6J6t6Y5e0RIVW3oMNxZCO2CmW6EQI2piZZYtj7QI3W05QeFaioEZPnfwPJpZ842VpIbt0UqZ3Ke1F7xMkq0NzNiSkcUHUd45Gh86kU3Yd7AutZoqdS80sifOc6jcr9CiQ22/vBkB3bv0yG7Xp4zAqSZaUcoMYogOZRrgKB6Lq8RJdsiOj2JZ3+ITZeQoAfyTqJt1PjIffI5O9kRGA4GXUbOqXKoB9EDKo845WwFQAfVFz4HcvxyHdqKPf7Xst2U0Rm0WSgQBDdWmcLhT/IH+J+uEUN+lIIPgpDSzFoZEl5fWkOXKCskpHzvIUfgwIzadeG/8I1G7i0TdrS+iqVcv9YV5l9cQ3/YLsgG+CZjC8jAnil4gtTTD4aqEmgx6T0xjtV/dXwFqg6zLjcHJte/z7w89x3XBK81jBGW+qWawhw1CdQAxvwB+/ev0yZe14zvNtBTwVaGqy+l+ThhPFqyRjKMaMyNHjVPiQvRcsqO2ASMfwko/4p0WakvaYfyWjoFvxftYj/UoWOgFxu6tHgAuL6ohwSaUC4zhNKbr1zj5FFdQcvofq4EipMYrfTBscjqeNucfsUT2pKe6EyKLG874u9iA7F0PVjgoj+vR+iaZuG2wenktzIdmVCOBRejgAkVb/5v/0Y8V3u2U+JY4Egqvo4qvENMTq1QaZ6zD4tzYvQDnJlpEzVZRwiDaINyT2zg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(396003)(366004)(376002)(186003)(26005)(2906002)(83380400001)(86362001)(55236004)(6916009)(6506007)(316002)(33656002)(38100700002)(5660300002)(52536014)(122000001)(71200400001)(64756008)(66446008)(66946007)(8676002)(55016002)(54906003)(7696005)(76116006)(66556008)(66476007)(38070700005)(8936002)(478600001)(9686003)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D1V5TI6HySpiIl5bTzu4wQrU4aNBiQpdmZ6ClVXGOxPFxRvwjgDrh6aHT74B?= =?us-ascii?Q?RWJe/0lstFG9eedzjzhwLYyN15YKq4xOUDt+066K4k2U/aNZHSta6zUGUra5?= =?us-ascii?Q?6r31Env9H5gNpieQrZV4fJI2IcleL+U0mxIvMD645U4gisVubVIU0rciUMTW?= =?us-ascii?Q?payscoWHbtG7uj0Yvur0w+sIKAN2GrH/7Dgzhsx7H+l1SqXjmAPq/CGvXbmW?= =?us-ascii?Q?ETHv7LiVcFv5Fa5BO/bkJ6TAqVRGi+yN+TdpC3yHn/j44nVDvwpYA43lCX1h?= =?us-ascii?Q?s8+Phg3KO2HWtZmQ6sqGspCC0IoriWtlc7KLBiQSxHJ0KhJKj/sBkXEnIiyT?= =?us-ascii?Q?kZj0YBHAjasIm4K6C9m1EDnnMtVV/R7NF9BQNLM2tW9yvre5Oc+oY1kA/Lao?= =?us-ascii?Q?jE9Sm2X4qor3jvOuYcXG02cGeI3FPkbifrt1oVWq5zVg/MTdqjMeHfu8V0ez?= =?us-ascii?Q?SSKP17eIbRTKyzxoJOhwQgWelavmtkDgPUSv1DvVVbKeG2KOWxE9GG66SrfZ?= =?us-ascii?Q?LnIYhFFjsjs0d+RpHRgGq7l2nJRQI1ZKiPKNb8mSHeQ8uwPvi99cZ5IQBfME?= =?us-ascii?Q?0RLhrGVY73ARudIZSk/ILQ96o/kI6hZI4sNVMAdfQVqFmR85u4U6I490+9xr?= =?us-ascii?Q?sCv9/twvioBu3GWHBlfv3z4nw2qTRY9oxJfyateNptOvckOThvXyFFGp4Tot?= =?us-ascii?Q?xp1At2Kjytkhmhow7oD2zX98Df6imKfP87R3GC2bHINFdWa7SsS7Yl8JRfyn?= =?us-ascii?Q?gAZ19zCXTu72IYgrUdHknE3cSJ5e4vJLjNp5jVTkUYcdN7JPsoUsedZid3vJ?= =?us-ascii?Q?6psZHNd29N9FUeTB7MjelcPNeRyWEcNO/0ytjO53P6rWHxzI1FfXS6Tc2HFI?= =?us-ascii?Q?pu3PbGTNErZhZ40w8E67AgC9Bw1/Ln56Q5vGsuylEOP/z/Eiveo8akp8FIdp?= =?us-ascii?Q?zP1wyVRYqBgtZ9QOhcaj/xn7VUNIQkWu5Mir5PhRnlycQwYHvUzUdpRotGet?= =?us-ascii?Q?/93SzlD9YNCd8lm+E7rVZh7OXt7qRpx8qCTxcNqhoygPgSAzag6ObNIR7DrO?= =?us-ascii?Q?C0rd9hRTEN27pNTe14eef2/0YMLANdt8CZT8oN5UnjYaqMz+CcO93VULppgt?= =?us-ascii?Q?KJB+i8Gc/1JdLm9ZwLXoAMWzrhinbI31xYMXFhxIpCALI4tYGtL3PX3FFFnJ?= =?us-ascii?Q?tMFSZ8+yOXpuZ/JSHRiaxQlorceqIaeL2VcplCgzJclxl1fUob3ymOwTuCbQ?= =?us-ascii?Q?AAVJx00Zfv/U4mhvdj//Q+iCxC+w1el1UbYpxiY87QkY+Gl1AemvqnyOAplM?= =?us-ascii?Q?0VNqhiS2yFAjBtxYQsR4Ufqq?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f069196-ff66-4737-3529-08d972c6f5a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 12:48:29.8340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gzFe4L5pw7vHjGSsQYQthwKbRgRvUYclJbByb7isqh9qJcjdtFW2HnMI4fTdLVk3/dd++dVfolzSFfgDSeYW7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4420 X-Proofpoint-GUID: pl4E18J-BDWxeE8vPZyCuOZ8N-AKW_CG X-Proofpoint-ORIG-GUID: pl4E18J-BDWxeE8vPZyCuOZ8N-AKW_CG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-08_06,2021-09-07_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH 1/7] examples/ipsec-secgw: add ol_flags support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Add support for ol_flags to the IPsec GW sample app. Description is not appropriate. ol_flags are supported to do what? How the existing code was not good and what benefit do we get from this patch? >=20 > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec-secgw.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) >=20 > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- > secgw/ipsec-secgw.c > index f252d34985..6d516e2221 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.c > +++ b/examples/ipsec-secgw/ipsec-secgw.c > @@ -515,7 +515,7 @@ prepare_traffic(struct rte_mbuf **pkts, struct > ipsec_traffic *t, >=20 > static inline void > prepare_tx_pkt(struct rte_mbuf *pkt, uint16_t port, > - const struct lcore_conf *qconf) > + const struct lcore_conf *qconf __rte_unused) > { > struct ip *ip; > struct rte_ether_hdr *ethhdr; > @@ -526,20 +526,17 @@ prepare_tx_pkt(struct rte_mbuf *pkt, uint16_t > port, > rte_pktmbuf_prepend(pkt, RTE_ETHER_HDR_LEN); >=20 > if (ip->ip_v =3D=3D IPVERSION) { > - pkt->ol_flags |=3D qconf->outbound.ipv4_offloads; > - pkt->l3_len =3D sizeof(struct ip); > pkt->l2_len =3D RTE_ETHER_HDR_LEN; >=20 > - ip->ip_sum =3D 0; > - > /* calculate IPv4 cksum in SW */ > - if ((pkt->ol_flags & PKT_TX_IP_CKSUM) =3D=3D 0) > + if ((pkt->ol_flags & > + (PKT_TX_IP_CKSUM | > PKT_TX_OUTER_IP_CKSUM)) =3D=3D 0) > ip->ip_sum =3D rte_ipv4_cksum((struct rte_ipv4_hdr > *)ip); > + else > + ip->ip_sum =3D 0; >=20 > ethhdr->ether_type =3D > rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4); > } else { > - pkt->ol_flags |=3D qconf->outbound.ipv6_offloads; > - pkt->l3_len =3D sizeof(struct ip6_hdr); > pkt->l2_len =3D RTE_ETHER_HDR_LEN; >=20 > ethhdr->ether_type =3D > rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV6); > -- > 2.25.1