From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FB85A0353; Fri, 21 Jan 2022 12:29:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D854F42754; Fri, 21 Jan 2022 12:29:07 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 858DC40042 for ; Fri, 21 Jan 2022 12:29:05 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20LAUpTu015267; Fri, 21 Jan 2022 03:29:04 -0800 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2172.outbound.protection.outlook.com [104.47.57.172]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dqhytstd1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jan 2022 03:29:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eQ3zL8rj/cOTyk0y3ytajU60ePC5p2Twxqw+xf0npIs1TgTA5WQl5DvkIS8PNgoNri9eA647k+Gp/yq6cz8bkFlEIgNColY/M1ZoCwT2zoZ4gQQJYMD/ErVIygXyw6kwwcl+jP38NPhT3C3Af+08G9YnbFGZQXkyhgm/irra/m786bYx9GHeBL6kHSBuxL5m0PaT0sRj+O3QDNcanfzIVlK7lGFKuK+1u3nOQsc4Hl0TC0Ek+BEopPXDDLEbW9cx1PbJCwCOjz6kDEgynH48JnVG4DIzSw84tv6yyIoXw4ZCVdTkMeyWo3W5FIGw+EE0D632Vx/B/3vje14HAyHCJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mGCjD7HdyPtOPh03g+SBcGUK5eYIGdgpF5U1lnn1dco=; b=aVDYsyLTs2lqfHjgOkq/xCfm72WqgNq7No1fuucuE9UiPMJfhgedUgN/FnrwfniQx4aRpaNGoWA60ssYYF0XMKvlrz1XLACZWH7Vlq+Yo7QjDeOkjgRQLskoahcVUhPMe3YCPx7l1qUqHYejmhOA00dLByH102vh3WeIPKnDw9BZT9qCkOpcAkaq0Ew5IqPOr0sDB8Km6v376EAwAvTxLkdfQ0C99u7WRYH/OcAIn0Jr7cAag2nQSTquBjNN9mRTTUt6vSv30ikKYwfyq0UUg8hGD8OPvui5Fh2zEIj9BOthydG6h07JUj5+LWziDheWRMmc5NudlSe4YEO7UyQueQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGCjD7HdyPtOPh03g+SBcGUK5eYIGdgpF5U1lnn1dco=; b=EBti0U6VugK1px2+RG+X2xhF3imD6E0/UMJ5YBWUW7NbOkqzIX8RdeJebvmW6FIQsdIwM6Z9x16uYi2yUadhHVJ/m+YbYQbxq5V0Z/wUAlfQAZ7qgvMFvY2YPm4htxSyGmBgxRRDp7nr0fU1FVTPJ302CgljvWxsm4X9xrf9E3c= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4811.namprd18.prod.outlook.com (2603:10b6:303:ee::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.12; Fri, 21 Jan 2022 11:29:01 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780%8]) with mapi id 15.20.4909.012; Fri, 21 Jan 2022 11:29:01 +0000 From: Akhil Goyal To: Gagandeep Singh , "dev@dpdk.org" CC: Akhil Goyal Subject: RE: [EXT] [PATCH v2 4/8] crypto/dpaa2_sec: support AES-GMAC Thread-Topic: [EXT] [PATCH v2 4/8] crypto/dpaa2_sec: support AES-GMAC Thread-Index: AQHX+8rq/GgSKlDq2UGRrF235HHz56xteyiw Date: Fri, 21 Jan 2022 11:29:01 +0000 Message-ID: References: <20211220102710.3083370-1-g.singh@nxp.com> <20211228091058.3620177-1-g.singh@nxp.com> <20211228091058.3620177-5-g.singh@nxp.com> In-Reply-To: <20211228091058.3620177-5-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a71aaee4-c518-4971-b494-08d9dcd138f1 x-ms-traffictypediagnostic: CO1PR18MB4811:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5ehx3EQEqTmu/rD+zeUfor2aKImvkMbiNvrIrF26LKpZAUQdwyanKqAHxNGsRMAmxMScz2YiHJiTw+lQTo6GuFDdgVPuxUo4Uxy2yrFRiVz56nnehAHn+88JcYxjehzuEA98YxzNAEbqjYztpmgimXdSrAt+DwKml4UwlUTUNYjIjlZmuo0UluWj9zFMJ8yry+Jnop6OHP0Af7JdXaZgKJwRnrsKr+PFOnv3G554t4c6Qbtr2RxQ1SBXBqkQ4IVV/oNbgCZqPFPBdqDDHtHx+OoIhsiLttO6xM+m5rAj0AOy84q9dM8BR6EXbujmqE7LtF28eh3EdKw+baGlnBtMxlvQjst7duwb7cdmZdpbYqeJrza/aUTpsTqvYbfSKbHXnLKb36Uf/VcRHEq2LsWEJEKylI0tSwDAJ+++pWu5cO1Mxbp8EIV2xE2cuHr/YTE3j1KvmG2saPeebG+3+rHGPtZib/m7WReB8jVLgLdKpAXQQykQgT/ha8ATHNWBDSkw0RAoM6PeIjY1rnoEGDahlzOkeNVJhDsC6p0wrM7wyTTp0q8XWZLSeVi4x3ZxNmQuadaymFMpthh13r7YEnOpyOTi4mMd/pXxmCrSLYtemsk40tE7UyAowRowRj0TmdqkaTRigoYIUy2z/RGSnTLZ6U4KLOVdkCB6iUnA8G5+S60dlfvQnbg6cuMVLCJj8rA4NUEm6ifQBE7i13iGUK4PCQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(110136005)(38070700005)(4326008)(71200400001)(55016003)(86362001)(83380400001)(6506007)(186003)(55236004)(316002)(7696005)(38100700002)(52536014)(2906002)(122000001)(26005)(9686003)(66946007)(64756008)(66476007)(508600001)(66556008)(66446008)(76116006)(5660300002)(33656002)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Blyy8ZJpgkYHUmHsXNBTtgtArS3H72yTVIV2dbbYjcP6nD15H7dPywGXb0Ut?= =?us-ascii?Q?pe4hY8eg8eJZF4aD0dec9MvrTqDw6knt5osZTt5WJFUiv50qFEsk3EkHOaG+?= =?us-ascii?Q?XWERXJ3l7kh4v1D22YvPrSZk0VEPQS7onTt5F1c9ywyrq9EhDMop1FYSaChF?= =?us-ascii?Q?fUNZU9d5GWU/V9sEI8jOwZwJkn6IUBrjJSOXUTytI/UA/6H498hH+AjI34p6?= =?us-ascii?Q?i0mBX1mzRgrEBrfzoyOPL+VeI3PTvucisDnpxmiV8x4LAgtYNvIvzBurwCgy?= =?us-ascii?Q?m67fTm19UZoTLtzseCaX/8SILyG1RGvmbUiQWjzByEeWoa0FOwlmTLBzBXyI?= =?us-ascii?Q?v0+p4onDsFv9dzqwNHsPvT1Ls1f8mgsAHPpRU/iukEbDU+CI6yDI0QHo+1r9?= =?us-ascii?Q?z/U1RLg+nuRGEdpUDHxOXwUsmzbOtVpIsZPH7mqXUSTBBkSMjU0msflgQDiw?= =?us-ascii?Q?voK7T4gBMI54fBuP/oObzrNzuNTMxrbWvtYSf3LrEUi3fnC7yltVVjqmddCB?= =?us-ascii?Q?Y617w9uYiN2riHgKJJe0rrGvhmLVvZ7c9Z9NitWj4Gf5ZATa7COr/F0yOD/d?= =?us-ascii?Q?9Ug9n1zT9U5f6Wlg8Lak3IHiibzdGCsg3jtBZ5+Gx7T2E4A6iiYK2w8EPSyk?= =?us-ascii?Q?QQMvEP+6T40StC/qvK7Vi1em4+709Vf4HjqYeUnLFCgIg9g7kfJxjGItgimW?= =?us-ascii?Q?ND8jGk08NbRqQfS7QyRNWwN4RdP6WvtDOdaP/poQBGn7PHq9iWa12VfpKTwb?= =?us-ascii?Q?OkJ9SAWz6+HzuUnEaZ0DhRQDfuSG5onPpxgDZKsRlGv9HGAh8f4RrSKQX8tZ?= =?us-ascii?Q?Z97ZjuujdIAlDvx975dDqcyiHZobNt6WIHLF+Y894wFB9nae/JiNB6DHPa3v?= =?us-ascii?Q?ADrdvAOqNYjkWmaNvrEv1LsqTx5rGBCvc6Hwz8r0+pOjX/+6ir8Ycda3HkVF?= =?us-ascii?Q?sJpxtcALl732HqDNg6Vh20Uu2OXzFEjBRN6VhGm1v2QA6UFd2wybD5Kh5oBq?= =?us-ascii?Q?JzybXI3mkoPGySI1kt4MmasMMeWH9ZWAM0bYyerS+JauM79vFgOvZRzODHHy?= =?us-ascii?Q?LGDXI73Wkf+bdTKNTfYhp2vJg8G6JjOnZ7007o5A6qLpS3LbDHEAA6/PZVeC?= =?us-ascii?Q?GpPKlkmXV/q1Bc+4O/gT+TxfQb3nh5PDUULGH23XXe3g+d6cezbl7SC1hCdX?= =?us-ascii?Q?KuVRG9wae59WrMo6VoPv4LYZVrTPZ8rFDEEuQLyNAtH5sk6sc5x6sKtcOfxj?= =?us-ascii?Q?7jeD51OZb4WKFslxAukvhwFPI30ufW1xT8ywx8ppPCK/LGWlov9/3GQo6ZzC?= =?us-ascii?Q?H5S0vo+km67WZjxor2tRie/KZfukM4/Ax7pRlpK6E6EX1DlAHkiqqlMYzGE5?= =?us-ascii?Q?hLAsyyVF06Ft/Ea7AHfFQFIIV7I8LG5WEV/sjqd9wRrlXB4QNMCJqJdccCq9?= =?us-ascii?Q?GNMayN9dQiWhPyApP5wUxJ/zlLhuDtMT0PKBDVFiqv4mJqY25pk8bH0IWUCR?= =?us-ascii?Q?EvaFdwnvdY3fiCF94Gc7lTUBASIleTCg+CjtBsGcTH6rxMbvP0Nod1aqLiV1?= =?us-ascii?Q?IJf4vQvESOploHdhxTyoWEcxJDrkip4ysYU83o3DkorO2EHRmufa8ej7aTaJ?= =?us-ascii?Q?GQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a71aaee4-c518-4971-b494-08d9dcd138f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 11:29:01.0182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B1p1XZvW1aPSQ2p1+j2I/X+L+UkMKMldFRhXSrk2dMOjUn4p3D/ULfd5N1xHQ5dhcXMqTEr5oYvR5urBxZMhcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4811 X-Proofpoint-ORIG-GUID: uDGZdR5qI_We7v1E3AMPvJeN00wBgx2D X-Proofpoint-GUID: uDGZdR5qI_We7v1E3AMPvJeN00wBgx2D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-21_06,2022-01-21_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Akhil Goyal >=20 > This patch supports AES_GMAC algorithm for DPAA2 > driver. >=20 > Signed-off-by: Akhil Goyal > Signed-off-by: Gagandeep Singh > --- > doc/guides/cryptodevs/features/dpaa2_sec.ini | 1 + > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 14 ++++++++- > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 30 ++++++++++++++++++++ > lib/cryptodev/rte_crypto_sym.h | 4 ++- > 4 files changed, 47 insertions(+), 2 deletions(-) This patch should be split in two - cryptodev change should be separate pat= ch. > diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sy= m.h > index daa090b978..4644fa3e25 100644 > --- a/lib/cryptodev/rte_crypto_sym.h > +++ b/lib/cryptodev/rte_crypto_sym.h > @@ -467,8 +467,10 @@ enum rte_crypto_aead_algorithm { > /**< AES algorithm in CCM mode. */ > RTE_CRYPTO_AEAD_AES_GCM, > /**< AES algorithm in GCM mode. */ > - RTE_CRYPTO_AEAD_CHACHA20_POLY1305 > + RTE_CRYPTO_AEAD_CHACHA20_POLY1305, > /**< Chacha20 cipher with poly1305 authenticator */ > + RTE_CRYPTO_AEAD_AES_GMAC > + /**< AES algorithm in GMAC mode. */ > }; AES-GMAC is also defined as AUTH algo. It may be removed but that would be ABI break. Is it not possible to use AES-GMAC as auth algo?