From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB246A00C2; Tue, 27 Sep 2022 10:12:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D4CA41133; Tue, 27 Sep 2022 10:12:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 64A57410D0 for ; Tue, 27 Sep 2022 10:12:05 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28R4L71x016204; Tue, 27 Sep 2022 01:09:56 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jt1dp91rb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 01:09:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kA036zBU1ye6FytahG/Bl1pVkpfZ4B5H/T06v3SL7kYNRsH7xg0wJQh5v7z8Om2AzBdUwrJ1Xd5mc1s2SnChLZxqcOcHtjgpXkg2PlQmSIIw3n0Lo8bg6iK4LM/+FuNP1U+EMqfa4LGVSuUCwS/6VcsYt9U+kkttyTYWG2HfFv+bLKQMitqEslouVyo+Vz9hohFANcomvB+XVBKWeC5tmhhFhLihUPQxbI55QVTyK+toLvJvpIDmtijJygWe3WzEGJRhDwy8eYdNxf9ZNzeqVDrVWNLnJuf0fsL2GH16B0yxrM5LfqS3rjInKNbYn713K0SIyeOBQN05ytgVM/9RlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fgX2lCOIrRYpatVFkRS6+YtbBmFHBnxWnwVJMJ3Y43s=; b=To0e/uGVik9r+qrLt467KV5/zwZ44e8325vKHsED5TcS/6dCs/si2mZGKusI8Rbq2GvEOCeUPbEH4PP9fR3Wgo95vOYIAVOcgY4UFa41RMDwOIZbihDlddgz/Vw+PjA4GFqRCCtGM9SYbYYfvuGwZBiKmGw3F33D77OaoSKQj4nr0y0UHoLYRzPzqW5R4WnpYueZmVm3jWBxNSyiJhTwT6giJ/WxFQKVIvBTFYwKfh+x7Fgcrw6w1srryyXktGuCVRPdzjdaUBFMF7hohlYt8R2RRPfkApfzzrlDzJsotJYS1LwTVxVMkYjaS2hYw5ZjIpRhaawWMsTUfTEN86mKTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgX2lCOIrRYpatVFkRS6+YtbBmFHBnxWnwVJMJ3Y43s=; b=JvTjEL67YTHn+Y0hmPue1ZNCmjs1sSZd8wvYSns3iYwVogi4xLBiZA1Z+eCNPzSFqB10k154IGEG9We9f5F+U99tlKTbJYZtC4EVjiaXsyWzFnpICaHoeps5ZtlAd52IZs5wISUeOFca44xzJC498G3cn8LWMzV++iC3SFa1NgY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH0PR18MB4890.namprd18.prod.outlook.com (2603:10b6:510:119::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 08:06:56 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e%9]) with mapi id 15.20.5676.015; Tue, 27 Sep 2022 08:06:56 +0000 From: Akhil Goyal To: Amit Prakash Shukla , Fan Zhang , Ray Kinsella CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Amit Prakash Shukla Subject: RE: [PATCH] cryptodev: add trace points Thread-Topic: [PATCH] cryptodev: add trace points Thread-Index: AQHYyfJXGD51B7clhEycdPxgjePt5q3y+oZw Date: Tue, 27 Sep 2022 08:06:55 +0000 Message-ID: References: <20220916173227.27758-1-amitprakashs@marvell.com> In-Reply-To: <20220916173227.27758-1-amitprakashs@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|PH0PR18MB4890:EE_ x-ms-office365-filtering-correlation-id: 3da711d1-72c6-45df-2338-08daa05f3eab x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9wbPhJf4eTE2kglBT12CXKL/2MwOMlnLinHd6xiccQ7O+gN/WZ476i13FZoMnUPolp8XPTjfTl+86AY1PWhNlDgE7UAl9YgynrhBXMz5QfpKwDo2ZlnhGatDx1BSUHboys9xoytqzyaIjnIdzXe36tk7urGubl6G5EOcaxgm0egUF2ab/JGn7iPJtSQTguAe5hWVrejphT2r1flakiQgYPm/06nwH9FLfxdbz0jUPu8DLu0TiJ0aW5MZETuqKUVamBqhiz3dK1M72wpGkhyCPQGUqHo56n6O4R+AEq6GSPq4n3iw62QYZFE9Lqx6N8qUJidWhnAphkiC2B3PMKD0dv5+ja9xo81QPVA1NqspbxxMpUgg5j63a9yBZCOpC92b4w+nvGzbhr/DXaS9k7yQPbOHQS1Qqm3Bnv7pA6fQ/0pJtU2ew4A9KXhYw25KRJecsncuJPmZyMaWMvt30pju1weZEe0++ja+29rYqgwICkYr6NfhsnT/fdkaclRf4DfZlYgLPmgcERdg1bi3BhqmGHR8OIQzk2At+WDTIf1RZs1ZxRUMLpG2YdBHrze1pTjdMNB5IuPeIdKi2YwQs4GVfNvXOZz534pF7sCHEAVl7DfPrV8Yahh81UV3mcSkGq/UvWHjXak2y3vGSJgJ2YWcfba08tlf7zHU6XFNFx8tofCt0PTZMWl+85n2UF1+LxwTtw+3rjx05ZRtAkQWaxG5TfmbnJ9S2ftkea8miog861PdYCe5IXEzwj4kkPzBgF67p0Jv3WGGGpjjLLpSPBVuYw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199015)(122000001)(110136005)(5660300002)(33656002)(2906002)(186003)(86362001)(8936002)(52536014)(66556008)(64756008)(66446008)(41300700001)(4326008)(55236004)(26005)(76116006)(38070700005)(66946007)(8676002)(9686003)(66476007)(316002)(54906003)(7696005)(107886003)(6506007)(478600001)(38100700002)(71200400001)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FInun7LtZeU8N6A5j07N3Bf014qbdg1pQXUVvjajrxX+BSDgqLT1VvSv8PBD?= =?us-ascii?Q?qw/6RLoyfq86wJQD9P+Thiy7IAKNdoyysSmfqdRC42oA/m29odQZkIBu66PM?= =?us-ascii?Q?rkvo9LnMmV2jXXRVMG1DtH0mxw6n6/v451fDQOe+FQqvfoeGoEIQVBpxe3H3?= =?us-ascii?Q?Cvb8igzajyCN6yf/gTKZ0Rs4EHQP3K2yJQYEV/KzwWcFdOvNiNO6lqWXJtfI?= =?us-ascii?Q?6i83lbP2M4H+kOHwfGHdZACHEOnq3EqZhO6OYv283zTRE1CMb/e+HTWOiWi4?= =?us-ascii?Q?1MaQSzYZBH+XBDtnK3GIA4uZXaa0IYceh6f0KRDbRrHu3o6VPJXo5YUJve24?= =?us-ascii?Q?vYV0MwI+O97VkCSCaK+BUYLPy58xER3YbhlbkjaynbV8pkFoCZVTXK/2jm1U?= =?us-ascii?Q?IjovWt7CO49xCkRPzTub1chUi9TM3CB9GI8hCi+Iw0w3VgAwSeCP8OB6RNGI?= =?us-ascii?Q?Si0ftQSpU70m0UN7iO0HZ3TfavKtEkpy7HNnzyiOCq2YnwgMuinP78Sw4l4I?= =?us-ascii?Q?VW1KX3FpQC/dWTG5JAsTk6YLRJiZiXAnk+kP0cxMnMtyWDV27K76H+upZWqP?= =?us-ascii?Q?/d/TrDgisGCT+MYLfe/idUcv67gvEHct9n6QtXouN3vO6tijDci8/0O09AyD?= =?us-ascii?Q?PiwsAGfoDxPm+fzxc51+KqJcP+0q16uKnc8mIfxkLlIJgo72vxA9N8bNJ4KY?= =?us-ascii?Q?QdeK/kRC2eBdcHs0s19myjzxyhqgGAZ7hXSjas+396Z4O+FroSV6sK4p9yzd?= =?us-ascii?Q?yi/kzM6r0A1o0v99ldQTTqsndcfz538zS2FQjocCrrvymLWMcYWN4vuFfb6N?= =?us-ascii?Q?XgDUYq/sqOarJbYFrEcThAoRRoUODLiA6p1tA6nAQ6fiPRNgzmaxFobv6o72?= =?us-ascii?Q?NR+za1AWkRLQCWxXXYTtH0BUCZ0JHEX78J+WyiHTqj8o9j6pDyDqKwpK++Ty?= =?us-ascii?Q?cdGSLoe5w8xgdshLmVjJa1xydBdhwAUd5iT40DqA0gmHHLP4+B2IAEqoIMhX?= =?us-ascii?Q?jvELlxuyqS9LCjLtrqRoEkKletTYvvWGulsJZIRavSmDowPrUHD+umo5IxI7?= =?us-ascii?Q?Tu0H/OpFgaAT7LuOl2CARZbSGHRTbVCzGmTM5XfsK/paZ/EG35Jo6INTZ5IV?= =?us-ascii?Q?6UJcAnQIfGvX2Xqex7gwyw+5MHwF1M2m6ki/es5b8Nmel8w1HhchkNyrWu3A?= =?us-ascii?Q?TwyL9a3Bc4siCudj5RXUX6++xqPyAx9qzzrSua2VBMkfBs7kSaFfsB/9Fto5?= =?us-ascii?Q?UEh+ccTG8/HevIT/G6X+CN3cBygFo8XLsENSL1fCnNH7n8T/xkDQvdDcgLjz?= =?us-ascii?Q?5KfJUaaApc/qUK/vpNSFwKPlr/iz9d8A8ElJI2Dcw087IC2PyrNG7iqud5Wq?= =?us-ascii?Q?tZzTdhVMIbjVILQ/xaDRTKWijJ10sl/jo/KC0d+7Byr0oZcsDvNaIxDWWFk+?= =?us-ascii?Q?9AkwaGuCfTaUA6J4xlKeSfOEw/24F2ad1rOT4mAl83u+Jd48S7ZUQ7GIqzAQ?= =?us-ascii?Q?dQW/F9FqFBm4OpKH4PvPwOmAOXCgNYfhqUqxqcevYvFI0054QDXG3hJOWot/?= =?us-ascii?Q?e4/BOIqZKepYEYLsXTc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3da711d1-72c6-45df-2338-08daa05f3eab X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 08:06:55.9773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DQ1DDJPq3pYSRxnCsDCmaFAT9szFXTQxcywL9hrz9kND1mrOPURWvhclmAI073lHHgv/7QFs2sFgy0tHf6iAkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4890 X-Proofpoint-ORIG-GUID: lBpqjTnzLnjXkbsJU_C9hfcCXe32o5RP X-Proofpoint-GUID: lBpqjTnzLnjXkbsJU_C9hfcCXe32o5RP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-27_02,2022-09-22_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > diff --git a/lib/cryptodev/rte_cryptodev_trace.h > b/lib/cryptodev/rte_cryptodev_trace.h > index a3f6048e7d..84991c5b0a 100644 > --- a/lib/cryptodev/rte_cryptodev_trace.h > +++ b/lib/cryptodev/rte_cryptodev_trace.h > @@ -18,6 +18,7 @@ extern "C" { > #include >=20 > #include "rte_cryptodev.h" > +#include "cryptodev_pmd.h" We cannot include library internal header into external header. We can either have a have a separate file for pmd specific APIs And hide it from user or do not allow tracing for pmd APIs. > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map > index 5aee87c6f7..a788185229 100644 > --- a/lib/cryptodev/version.map > +++ b/lib/cryptodev/version.map > @@ -109,6 +109,63 @@ EXPERIMENTAL { > #added in 22.07 > rte_cryptodev_session_event_mdata_set; > rte_crypto_asym_ke_strings; > + > + #added in 22.11 > + __rte_cryptodev_trace_pmd_allocate; > + __rte_cryptodev_trace_pmd_callback_process; > + __rte_cryptodev_trace_pmd_create; > + __rte_cryptodev_trace_pmd_create_dev_name; > + __rte_cryptodev_trace_pmd_destroy; > + __rte_cryptodev_trace_pmd_get_dev; > + __rte_cryptodev_trace_pmd_get_named_dev; > + __rte_cryptodev_trace_pmd_parse_input_args; > + __rte_cryptodev_trace_pmd_probing_finish; > + __rte_cryptodev_trace_pmd_release_device; These can only be internal or just remove these.