From: Akhil Goyal <gakhil@marvell.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"fanzhang.oss@gmail.com" <fanzhang.oss@gmail.com>,
"mb@smartsharesystems.com" <mb@smartsharesystems.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [EXTERNAL] [PATCH v3 1/3] lib/cryptodev: avoid implicit conversion to 64 bit number
Date: Thu, 6 Feb 2025 12:08:38 +0000 [thread overview]
Message-ID: <CO6PR18MB4484B42B259445B151F41804D8F62@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1738006389-17193-1-git-send-email-andremue@linux.microsoft.com>
> MSVC issues the warning below:
>
> ../lib/cryptodev/rte_cryptodev.c(623): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
>
> The code would be better off by using 64 bit numbers to begin with.
> That eliminates the need for a conversion to 64 bits later.
>
> This patch actually fixes a bug present in previous DPDK versions
> because the last of the hash enums RTE_CRYPTO_AUTH_SM3_HMAC in
> rte_crypto_auth_algorithm has value 32.
>
> Fixes: 6f8ef8b68edb ("cryptodev: add hash algorithms in asymmetric capability")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
V2 of this patch was already applied to dpdk-next-crypto.
Now the other patches of the series are also applied.
Thanks.
prev parent reply other threads:[~2025-02-06 12:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 1:53 [PATCH 1/2] " Andre Muezerie
2024-11-28 1:53 ` [PATCH 2/2] lib/hash: " Andre Muezerie
2025-01-22 16:12 ` Bruce Richardson
2025-01-22 21:36 ` Andre Muezerie
2025-01-23 7:55 ` Morten Brørup
2025-01-23 17:42 ` Andre Muezerie
2025-01-25 12:56 ` Morten Brørup
2025-01-22 16:15 ` Medvedkin, Vladimir
2025-01-08 10:28 ` [EXTERNAL] [PATCH 1/2] lib/cryptodev: " Akhil Goyal
2025-01-27 16:03 ` [PATCH v2 " Andre Muezerie
2025-01-27 16:03 ` [PATCH v2 2/2] lib/hash: " Andre Muezerie
2025-01-27 17:16 ` Morten Brørup
2025-01-27 17:14 ` [PATCH v2 1/2] lib/cryptodev: " Morten Brørup
2025-01-27 19:36 ` Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 1/3] " Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 2/3] lib/hash: " Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 3/3] drivers/crypto: use RTE_BIT64 in initializations of hash_algos Andre Muezerie
2025-01-28 7:45 ` Morten Brørup
2025-01-28 7:49 ` Anoob Joseph
2025-02-06 12:08 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB4484B42B259445B151F41804D8F62@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).