From: Akhil Goyal <gakhil@marvell.com>
To: Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"selwin.sebastian@amd.com" <selwin.sebastian@amd.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH v2] crypto/ccp: bug fixes for ccp device probe flow
Date: Sat, 11 Mar 2023 18:47:59 +0000 [thread overview]
Message-ID: <CO6PR18MB4484B44DF1ACEEF6F4C3B1BED8BB9@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230306125837.94671-1-sunilprakashrao.uttarwar@amd.com>
> Subject: [EXT] [PATCH v2] crypto/ccp: bug fixes for ccp device probe flow
> - Rebasing patch([v1] crypto/ccp: bug fixes for ccp device probe flow)
Please write a meaningful patch title and description
Also add fixes tag.
Add Cc stable@dpdk.org so that fix can be backported.
>
> Signed-off-by: Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>
> ---
> drivers/crypto/ccp/rte_ccp_pmd.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c
> b/drivers/crypto/ccp/rte_ccp_pmd.c
> index a5271d7227..5d1a4445de 100644
> --- a/drivers/crypto/ccp/rte_ccp_pmd.c
> +++ b/drivers/crypto/ccp/rte_ccp_pmd.c
> @@ -19,7 +19,6 @@
> /**
> * Global static parameter used to find if CCP device is already initialized.
> */
> -static unsigned int ccp_pmd_init_done;
> uint8_t ccp_cryptodev_driver_id;
> uint8_t cryptodev_cnt;
>
> @@ -192,8 +191,6 @@ cryptodev_ccp_remove(struct rte_pci_device *pci_dev)
> if (dev == NULL)
> return -ENODEV;
>
> - ccp_pmd_init_done = 0;
> -
> RTE_LOG(INFO, PMD, "Closing ccp device %s on numa socket %u\n",
> name, rte_socket_id());
>
> @@ -278,10 +275,6 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> .auth_opt = CCP_PMD_AUTH_OPT_CCP,
> };
>
> - if (ccp_pmd_init_done) {
> - RTE_LOG(INFO, PMD, "CCP PMD already initialized\n");
> - return -EFAULT;
> - }
> rte_pci_device_name(&pci_dev->addr, name, sizeof(name));
> if (name[0] == '\0')
> return -EINVAL;
> @@ -300,7 +293,6 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> rc = cryptodev_ccp_create(name, pci_dev, &init_params, pci_drv);
> if (rc)
> return rc;
> - ccp_pmd_init_done = 1;
> return 0;
> }
>
> --
> 2.25.1
next prev parent reply other threads:[~2023-03-11 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 13:56 [PATCH v1] " Sunil Uttarwar
2023-02-27 18:29 ` [EXT] " Akhil Goyal
2023-03-02 11:53 ` David Marchand
2023-03-06 12:58 ` [PATCH v2] " Sunil Uttarwar
2023-03-11 18:47 ` Akhil Goyal [this message]
2023-03-14 10:49 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB4484B44DF1ACEEF6F4C3B1BED8BB9@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=selwin.sebastian@amd.com \
--cc=sunilprakashrao.uttarwar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).