RE: [PATCH] common/qat: fix incorrect size in the parser

[Akhil Goyal <gakhil@marvell.com>]

> > Subject: [PATCH] common/qat: fix incorrect size in the parser
> >
> > The function `strlen` returns the size of the string without a terminating null-
> > character, therefore a request to allocate memory space for a parsed argument
> > is too small by 1.
> >
> > Fixes: 99ab2806687b ("common/qat: isolate parser arguments
> > configuration")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> >  drivers/common/qat/qat_device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/qat/qat_device.c
> > b/drivers/common/qat/qat_device.c index bca88fd9bd..746d8a28bb
> > 100644
> > --- a/drivers/common/qat/qat_device.c
> > +++ b/drivers/common/qat/qat_device.c
> > @@ -226,7 +226,7 @@ qat_dev_parse_command_line(struct qat_pci_device
> > *qat_dev,
> >  	if (!devargs)
> >  		return 0;
> >
> > -	len = strlen(devargs->drv_str);
> > +	len = strlen(devargs->drv_str) + 1;
> >  	if (len == 0)
> >  		return 0;

Once len increased by 1, above check is redundant.
You should increment length after if check


> >  	/* Allocate per-device command line */
> > --
> > 2.34.1
> 
> Acked-by: Brian Dooley <brian.dooley@intel.com>