DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Adam Dybkowski <adamx.dybkowski@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v3] test/crypto: check if RAW API is supported
Date: Mon, 19 Jul 2021 15:25:20 +0000	[thread overview]
Message-ID: <CO6PR18MB4484B95A914104B580E6A064D8E19@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210719123718.15960-1-adamx.dybkowski@intel.com>

> This patch adds checking if RAW API is supported at the start
> of the test command "cryptodev_qat_raw_api_autotest".
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  app/test/test_cryptodev.c | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 31201d93e1..43c05ed3d8 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -14766,7 +14766,39 @@ test_cryptodev_bcmfs(void)
>  static int
>  test_cryptodev_qat_raw_api(void)
>  {
> -	int ret;
> +	static const char *pmd_name =
> RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD);
> +	struct rte_cryptodev_info dev_info;
> +	uint8_t i, nb_devs, found = 0;
> +	int driver_id, ret;
> +
> +	driver_id = rte_cryptodev_driver_id_get(pmd_name);
> +	if (driver_id == -1) {
> +		RTE_LOG(WARNING, USER1, "%s PMD must be loaded.\n",
> pmd_name);
> +		return TEST_SKIPPED;
> +	}
> +
> +	nb_devs = rte_cryptodev_count();
> +	if (nb_devs < 1) {
> +		RTE_LOG(WARNING, USER1, "No crypto devices found?\n");
> +		return TEST_SKIPPED;
> +	}
> +
> +	for (i = 0; i < nb_devs; i++) {
> +		rte_cryptodev_info_get(i, &dev_info);
> +		if (dev_info.driver_id == driver_id) {
> +			if (!(dev_info.feature_flags &
> +					RTE_CRYPTODEV_FF_SYM_RAW_DP))
> {
> +				RTE_LOG(INFO, USER1, "RAW API not
> supported\n");
> +				return TEST_SKIPPED;
> +			}
> +			found = 1;
> +			break;
> +		}
> +	}
> +	if (!found) {
> +		RTE_LOG(INFO, USER1, "RAW API not supported\n");
> +		return TEST_SKIPPED;
> +	}
> 
Can we make it a generic function which may be used by other PMDs as well
to check if feature flag is set or not. You can call the function from
test_cryptodev_qat_raw_api(). The function can take pmd_name as input
similar to run_cryptodev_testsuite.

>  	global_api_test_type = CRYPTODEV_RAW_API_TEST;
>  	ret =
> run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
> --
> 2.25.1


  reply	other threads:[~2021-07-19 15:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 12:37 [dpdk-dev] " Adam Dybkowski
2021-07-19 15:25 ` Akhil Goyal [this message]
2021-07-20 13:11 ` [dpdk-dev] [PATCH v4] " Adam Dybkowski
2021-07-20 13:14   ` Zhang, Roy Fan
2021-07-20 20:48     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB4484B95A914104B580E6A064D8E19@CO6PR18MB4484.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=dev@dpdk.org \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).