DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
	David Marchand <david.marchand@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
	Fan Zhang <roy.fan.zhang@intel.com>,
	Brian Dooley <brian.dooley@intel.com>,
	Brandon Lo <blo@iol.unh.edu>
Subject: RE: [EXT] [PATCH] examples/fips_validation: fix link to libjansson
Date: Tue, 21 Jun 2022 10:22:35 +0000	[thread overview]
Message-ID: <CO6PR18MB4484BB4828A2C7C99BD9FEAFD8B39@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CO1PR18MB47144B8BCE1A0BB5DFFF82C0CBA59@CO1PR18MB4714.namprd18.prod.outlook.com>

> > When compiling this example out of DPDK, linking the executable fails
> > with:
> >
> >   ## Building fips_validation
> >   /usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_init':
> >   fips_validation.c:(.text+0x7ab): undefined reference to `json_loadf'
> >   /usr/bin/ld: /tmp/ccQjeHBg.o: in function
> >      `fips_test_parse_one_json_vector_set':
> >   fips_validation.c:(.text+0xc2e): undefined reference to `json_object_get'
> >   /usr/bin/ld: fips_validation.c:(.text+0xc36): undefined reference to
> >      `json_string_value'
> >   /usr/bin/ld: /tmp/ccQjeHBg.o: in function
> > `fips_test_parse_one_json_group':
> >   fips_validation.c:(.text+0xd00): undefined reference to `json_object_get'
> >   /usr/bin/ld: fips_validation.c:(.text+0xd14): undefined reference to
> >      `json_integer_value'
> >   ...
> >
> > Code in an example can't rely on RTE_HAS_JANSSON, because it only
> > indicates that the jansson library was available at the time of dpdk
> > compilation.
> >
> > Prefer a local build flag (like what is done in vm_power_manager).
> > And add linking to libjansson, if available.
> >
> > Fixes: f556293fd58e ("examples/fips_validation: add JSON info to header")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Acked-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Applied to dpdk-next-crypto

Thanks.

      reply	other threads:[~2022-06-21 10:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 10:02 David Marchand
2022-06-07 12:28 ` [EXT] " Gowrishankar Muthukrishnan
2022-06-21 10:22   ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB4484BB4828A2C7C99BD9FEAFD8B39@CO6PR18MB4484.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=blo@iol.unh.edu \
    --cc=brian.dooley@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gmuthukrishn@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).