From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A72DA0555; Thu, 26 May 2022 11:40:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21BE040E78; Thu, 26 May 2022 11:40:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 28F0B40DF7 for ; Thu, 26 May 2022 11:40:43 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q9BMCt025529; Thu, 26 May 2022 02:40:42 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty852b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 02:40:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T6vwjMb0QG+6qvch3fdcL+UjnNEnuPkXU8j5OwCkoc3TCXD92ZhuivOUy1cyi2hcTfZMii1JFHB2vAlxuuZ8lBGPoeFVepnHLuhvVfeKw+Cmdb8Prx6O596mP2rYmrkRiDLggmqEBXXlqAxZb42eWRb7ijqVxMwLVfXPP2eODWCw9BLALviMZRCO6Ifj3p4OnJBDFahlwN2MfsYB6PPPrPkB5sbALJALr4+H2c+KmQYWHL0Ac6RgnGcz5mFI09HbggMfjEWyqblLSEGRLd1UgHcVYsX0hjE6Retc2sYEZzxSyZ3RdXOfjkY7gJ8zwUV2X2GtG2mWeRKNahhNgGAzsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5NabN8RtE7pJkekcU/9nUgzGb5lMCvKkPudVT5vQvQw=; b=axvQSpBDUI6zobjK55INMNZOT9I3LXqC17WiuiKRf8ioOhqy5e7+JpuXK61pBWFOvngeI3ahFL72ZnX/KUhGdjKEZ0kLX86vmxAPgpQ3oFIRUoDAJxrtFMQYiYqRvfkcgLh6SV29pbDQP1MNM1ikuD8LhgK5V7lXAOgl12NqTkFqQlxa3wDRlPw4bvelYGaLB6rRVlnz+e3jMv535SrbJaMbLy3jIoE4iNeh68lxehAyY/aaDZCeZ7DnGn2Mfk1O38rl8yqPg2tIoEL5DeZGVGJGj8Eo1SWF6qUwJLb7XIronYG7gLU1axpa/CbOLA2xlBPwjv2pvMTZxSMKP8OplA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5NabN8RtE7pJkekcU/9nUgzGb5lMCvKkPudVT5vQvQw=; b=tMEO0vlNZYOoWm0zoPIYIzZgoaXPSw3V9qH1rzjFNxmZEBWnl9hwYZ4adNQ5tzHumxwbKm8wSRgLX8Yi6E8D2uhunBMjxbMNY8IRDSTCxgMZ1Kf6Mkj2KZqdyFkpMvId6n3oREK0RD4LXdBQFd1txbKw5sdb5H0Lz9LUhQnF3WU= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CH0PR18MB4244.namprd18.prod.outlook.com (2603:10b6:610:bb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 09:40:40 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 09:40:39 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 01/14] cryptodev: redefine ec group enum Thread-Topic: [EXT] [PATCH v2 01/14] cryptodev: redefine ec group enum Thread-Index: AQHYcFloDEkuj05wjU68sziyyF183K0w521Q Date: Thu, 26 May 2022 09:40:39 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-2-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-2-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2609257c-b52f-4a58-29bb-08da3efbcb8d x-ms-traffictypediagnostic: CH0PR18MB4244:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XL0fa+vQWSOw4gPPGDtSxeRWqj5ZtZ6xCq1bKHN5nIVQZbFoS1tw+e25y663s22HwI/ZIOKHbz4esr7LikHajxwzJnD/YFfQspFunUKZrrbYi8hrG7a4lBzKF8O83IYyqmJNhFR0BRm7AdUkzu/TVxlguL4231nCC6MQAvlLLDYOPtoPQgHHa6Q9+7EoaGvG5/RnXTt/JShSssjdOdIekCjO2UIqmaXGjY6lyEfGZX2Bm83jV9jc+icgSbWNSHC6Q77LU9LytuupB9d3gctqoCjUEdtTJTQeE+xhXVPJm6vXhowPd/vfuXtNXJv8ULW5qr2kOh+HMVL3LAjktIoU2wIQk/0YAj60o976imPWaWQwLVlyuEHyL/gSncZrfzH0PBOj6UXaVC8JWD0FmDPtetgJYiXATGEfmD1A3XBHbd0vJpGVKWCkxeQbXPzeNykBHAG6hw3fxQCB725agjWgEBcemTas/qdpFNoValPDk/qe7XX0eAQV9cnXVTwC19SosRoSpToQ6PYZhhVI1pNHO/gp5P1jPIeHDNJNvz9Ifel/ccbKhhJBxPq64dlehf8E5+jcIlqlyp1AW150I/g/icyY3VlViZgRG1hwuMJ8NcIiTsS4VugEEV6YXq0i4pD7JaTubgO4wedaA1JKwvDkirv3/wmBbk9JLdkO0NhPOYPKw693Is4eVhmmcdyXCEjhvcRv/d8nv/XU+uvlcB8P8xWcUbtypsos+cVVbOj8xvk0sOzRoiEhSutUTmxnQN9rXtSqblogBwUzUrUtUSQqUnYiy992TUPsBShvelA2qrQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(5660300002)(26005)(7696005)(2906002)(38070700005)(38100700002)(186003)(9686003)(55236004)(83380400001)(966005)(86362001)(71200400001)(8936002)(55016003)(122000001)(52536014)(33656002)(4326008)(64756008)(66476007)(66446008)(508600001)(110136005)(66556008)(8676002)(76116006)(66946007)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S9iWIBM+FIqp52nD0iyct9PVDH1aFvpjFSdvMyCbYpZvgHpJCTZUsxCFhd+U?= =?us-ascii?Q?B2Mdkqv2MbjOrArVkm3oYfvYPvGGOV+pAp4ktJE2ZixXzVjNm+9XKsW+CMnF?= =?us-ascii?Q?xyMcH52bgJe8+2BOtjvyUWhaQTpNC6P5UiiO64Bf0ekYVEateSvb5EFPZGB9?= =?us-ascii?Q?+vs/VWPn7JinJDoGS6kDN5egtsmgJzqH+MvR7lKIT1V5dafVlYrTRon37vmK?= =?us-ascii?Q?AkN9EnfvhVIcNr2RBN1kP8h0jPFh/d8awPaImWMxHDNhGwjdXhaNk8MM2ZY8?= =?us-ascii?Q?NXUyi9mWI8xbvziJswNxgLd+2UXDD3CxnPypj0EHXQBLbmoQBEHC/8SEDxFN?= =?us-ascii?Q?RR2vXoi7t8SeV8r4cTDobQ7ROSpyDStnAu/Rdq2PijVqWQTctZN0RqLIas/M?= =?us-ascii?Q?92xpomuvJIyx3Zjm3MJKzfhyaBKuDKp4YsY1YZH1Wk2gDJ7PQYcaqGGwXqJY?= =?us-ascii?Q?T6a0IOLhvsCKEwypTQoWs/6jEZHpXuyIvMbhucx93KGmq/4bgMvxTcXUDw1u?= =?us-ascii?Q?jALV8nJWG6D2hE4VWNGdUUxmQR7npvMui3M+HRgxyyh+r/0Lhq/svLqCc8dh?= =?us-ascii?Q?M5usFLkfslLWcAF/MNqrUzLfI+pvCXh47rmh97bz9tw5g2re3qOI8/Mm/cCX?= =?us-ascii?Q?8nTtX+MzZYdInBhlfW7DRC3p/qNGtii07StHpmHWy5tgcjeay2g9JmvrZ5X4?= =?us-ascii?Q?hn14/+UR+r2TYKt+Q1DxqyHBOmakP9o204pIO+YbHe/Sq/x1s7vwD0N8wG1j?= =?us-ascii?Q?HkN9DjrCPiWqBY+lEi7v+dQ9zK+KIF7f/3l7z+BQqhAmIYo/mf9mdD/f8hVd?= =?us-ascii?Q?8MZAMiMlJ208Td+iSsgVPIyE3jZCphJx+ibl8piJIVdBRh6r6dXUZhEWprcr?= =?us-ascii?Q?STZH8qI1pLc46AFmjhQJDBn0Ce+5e/fCX5hBC4SLPUzVwhn87UX+4spJ0eUY?= =?us-ascii?Q?LTElpv20K0KLyFzIxUTLV54p7elnffORSR8vvbjUqe0D39p3GJ45JXyQ5058?= =?us-ascii?Q?dpb6IYmOzzJidozzU8jdkycKwFMrHy/MXNioWiEOFw16j8AV1VNpkpTk/DTS?= =?us-ascii?Q?Ro0BOASn0WfJE7imc5knr7daQ+gGgYh9mSEWFNwZpm27L9B8CHL22B275zMQ?= =?us-ascii?Q?iO597WD504JmH9cL87cSmZfuYPivPBBGFZ9hW+0bbn/izBGSNOwSjZlql8ab?= =?us-ascii?Q?OKJLL7V++yG/S0PNz+nKwbfFXA4iBOC9J//RjSJami2syfN9i/5M93rA0GH5?= =?us-ascii?Q?YXDhPXzEQgyhdlPwULimtQA0E73B/A262s7nXnKJ+hD95YJSuDV/dLPPMB3X?= =?us-ascii?Q?Z0wGehi6i2y7SdPJOM4HBvwOGYdhwhys7VKxvyQULcGlrSQ6Dsicv5sPS1J1?= =?us-ascii?Q?+1kMRkmHle5b2EGjlwhvVJ1H3EmpJTYLRIv4gfefwV60uVY+vhLAVWTRNtPq?= =?us-ascii?Q?ow6Go2tORTfu4ZufGEztMpeGx1V78q5uBAeukH6bk4Vh4wUoVL4EVHATpzhO?= =?us-ascii?Q?VmR4LE+QniVomsID58t0mOsE2QdJccg3kMsTtkbfV1y/TPnIMukYU/JpsowK?= =?us-ascii?Q?M9esHAePurAPQpf5ad6Tunb0Cli/BVNJJLaOxGSuNPAPkl3x3DFG2s28osOg?= =?us-ascii?Q?G9xk0FcTSMTzHPrc6EUWyKbVknagEAClmtgyhbbCIyFiIPfJ5UsxMcQWOpcv?= =?us-ascii?Q?W1iI7/WMuAUJKNqgvXihcam2dalo+RztsT2T/e0PwGrS1QBhI0oCZq+Dh2lX?= =?us-ascii?Q?ENY2GKen7Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2609257c-b52f-4a58-29bb-08da3efbcb8d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 09:40:39.8773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yx9vXcbGh/7SavSAkK7OtzzdBmp9JZADonvOazjM3UDN7QQzzaD5FpIQVfD7NXzC+rEcDazLgxcaSblT85ioXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4244 X-Proofpoint-GUID: 1-W-PKEvB0fSV6F-r7xtcC57v0mQRYCy X-Proofpoint-ORIG-GUID: 1-W-PKEvB0fSV6F-r7xtcC57v0mQRYCy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_03,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - EC enum was renamed to rte_crypto_curve_id. > Elliptic curve enum name was incorrectly associated > with group (it comes from current tls registry name). > - Clarified comments about TLS deprecation. > Some curves included are deprecated with TLS 1.3. > Comments to address it were added. > - Clarified FFDH groups usage. > Elliptic curves IDs in TLS are placed in the same registry > as FFDH. Cryptodev does not assign specific groups, and > if specific groups would be assigned by DPDK, it cannot be > TLS SupportedGroups registry, as it would conflict with > other protocols like IPSec. > - Added IANA reference. > Only few selected curves are included in previously > referenced rfc8422. IANA reference is added instead. > - Removed UNKNOWN ec group. > There is no default value, and there is no UNKNOWN > elliptic curve. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index cd24d4b07b..7206652458 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -38,16 +38,20 @@ extern const char * > rte_crypto_asym_op_strings[]; >=20 > /** > - * TLS named curves > - * https://datatracker.ietf.org/doc/html/rfc8422 > + * List of elliptic curves. This enum aligns with > + * TLS "Supported Groups" registry (previously known as > + * NamedCurve registry). FFDH groups are not, and will not > + * be included in this list. > + * Deprecation for selected curve in tls does not deprecate Minor nit. tls->TLS=20 With this fixed, Acked-by: Akhil Goyal > + * the selected curve in Cryptodev. > + * https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml > */ > -enum rte_crypto_ec_group { > - RTE_CRYPTO_EC_GROUP_UNKNOWN =3D 0, > +enum rte_crypto_curve_id { > RTE_CRYPTO_EC_GROUP_SECP192R1 =3D 19, > RTE_CRYPTO_EC_GROUP_SECP224R1 =3D 21, > RTE_CRYPTO_EC_GROUP_SECP256R1 =3D 23, > RTE_CRYPTO_EC_GROUP_SECP384R1 =3D 24, > - RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25, > + RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25 > }; >=20 > /** > @@ -294,7 +298,7 @@ struct rte_crypto_dsa_xform { > * > */ > struct rte_crypto_ec_xform { > - enum rte_crypto_ec_group curve_id; > + enum rte_crypto_curve_id curve_id; > /**< Pre-defined ec groups */ > }; >=20 > -- > 2.13.6