From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9957A00C5; Thu, 15 Sep 2022 09:23:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA75D40223; Thu, 15 Sep 2022 09:23:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id B55E940156 for ; Thu, 15 Sep 2022 09:23:43 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28F0bp2Q006353; Thu, 15 Sep 2022 00:23:36 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jk6995mbw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 00:23:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gmBylmPc9vM9xL4Y2AbpH7AKT4i5xm6OYKi1Bf9f591P1lmFLegmnpsonBTu1Q+JISDcCMuXjsh5ZxAQ4f/xENfeZdXyKqAa+0GMSwjU30+Z9bBnOfLP/QHB1iWLwbUNfBgOG1cbJPebm88e9mQto9o97tOpd5W/2lmVyfcXuphgNyCMIyZiSPkXMG5yIxXABQ9R1j7VHygT7f2WZypHhRM/QPIu33gEDQei+DNUZ5uzIvsa7ARVzZ/nNOCrUPzUQ1GHNOr6jxwQ9JPHruiAPDBAMdJlTTJtYUW9GH2CxVn1ZkoV4yG7G/uRikVX6U0my0n46xud6XKVAG2nRXGedg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NEc41aU7Crw+7v5lkpm1mPRjXU5t/U9bl/2FZcKw1lA=; b=ZdZWZfb4N/Bsy4wV+n1NNKHhvkyRoqcsCCahrjtvwLpsuRDHoGQUi+Rf+uw+wVlQFm7saQ+wiRvIeXjn/Tmz76l9WOeoJai5pRwK0YbP3N6FGwegcVaf6u6d7z3zcY6twYH9QKMa1PMROfyE3KScfjnPBZKa2hcfUBSVysZa22rIp3mgV7FQYutXoL2iL5KOGWNeqi/96LLSSNOJCQWGa2Yk8ceQ1BzQNFWtoadMjthCjV91abNJ1w9kIJ0qISNg7zUCNTvfXBPlcL3YBNOYugAbGiYcR1BYYKxQhz23oGiqDkLYBkjK15+drMhQrxNZwTYWBvax4BYh4RQTP/AgRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NEc41aU7Crw+7v5lkpm1mPRjXU5t/U9bl/2FZcKw1lA=; b=mmKUhBmv6yHj7VNe0MuTs+Bq/jv8ZjrB6JtNE0xyq7XPIPBhc9jeW5KH9gWqrJFSBV3wXklbRH3SHJo2tE5K4ljUDxr6Y/glYlYHLxwYwbwiqfvsYI/8VUCV+5+wut+LLt47/FvLo/EMQJzVaMnTachgLZIK4HXSh9cTWnp+yG0= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4464.namprd18.prod.outlook.com (2603:10b6:a03:3bb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 07:23:33 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::6d7f:3f2f:935d:7319]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::6d7f:3f2f:935d:7319%9]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 07:23:33 +0000 From: Akhil Goyal To: Fan Zhang , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "chandu@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , Anoob Joseph , "pablo.de.lara.guarch@intel.com" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" Subject: RE: [EXT] [PATCH 2/3] crypto/scheduler: use unified session Thread-Topic: [EXT] [PATCH 2/3] crypto/scheduler: use unified session Thread-Index: AQHYu8Mz3wMq6dPRQ0GxTja9il7ud63gK1jQgAAE0uA= Date: Thu, 15 Sep 2022 07:23:33 +0000 Message-ID: References: <20220829160645.378406-1-roy.fan.zhang@intel.com> <20220829160645.378406-3-roy.fan.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SJ0PR18MB4464:EE_ x-ms-office365-filtering-correlation-id: 800772ca-4a0f-48c6-fd13-08da96eb3247 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3sTIXlg0XAf/mm1Pm1xNNX5Y9Ua+EEJYnYYtKRLPGQE7wpMxPjbugDIi7RL5GJD60MZdIQ+VvnnepfA8HOdOk0sah3OQDIX00pEni+bFZwelOBZExdxzN7tEpzDU+rk6ky51hXXN+eJRjBLSiscyzyiI83S5NUNhdPFDWl+8jCEKpusZKN8FgRVq1VhAK0pJrO2pL6IVs1qx5D1MoOsL4vOdTFckKiUkR83bTBsfoBLQH0ok+JDq5EGhLqC9DqArWFOFq9TFQAwLdZaSr7A26AGN5xKY5l6liyzhI7MFuzm//xAbdkmjG7hu1AXkMBO0jEALY6wcBlVaOqar7GMHRh9wYdbjhfzlzRUZ2hHifkK4YjRn/XPzbCwUUFCNVwuoqSE0G8+7NRGsZ6+FIY5/7kZMJrBr/VnOmaDK2ZnOxYf2Mtx+M8VmAqvwEwght3cXJWy+kZ6mUyTfStjVr3qCHVSc0SaFvG/FnakgLBFgp8DWpu9OS+0WsV83ZL4Uo42vkEUBLriPGloSjq+QBWyQSfYkYGVBfoTTESJBCfxVEjguedz+0Zud169uojgjfXeUrBdVvlmHA3RW8dji7PaqcCm5Q7FsNL4C7bhOCKNuMdcFf1tSOqo6o4jeRe/RAkApmCnpRRtRKYyrss8e5N+hlG/H4WH8e29UL99ofLly6EZzicJAOXI9F1TceFIQ5XdmhzvL9VqesBzyUScCJMZXyxYfx4F+DTWjI+yBEYnL6SaOGJvtya3YctvONw7FJDpXK2zArPFZbBKAx75dF2v/VA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199015)(122000001)(5660300002)(4326008)(52536014)(8936002)(55236004)(64756008)(76116006)(8676002)(66446008)(2906002)(316002)(55016003)(66946007)(38100700002)(110136005)(71200400001)(41300700001)(33656002)(86362001)(54906003)(66556008)(6506007)(66476007)(186003)(7696005)(2940100002)(38070700005)(83380400001)(7416002)(478600001)(26005)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g8kAq9zara4pkDd/nUTeYNx13R+y6jJ6VSodPX5LfIEyJLHv0BnjmTp9dVsq?= =?us-ascii?Q?paGqkewI6fIysGtYfGKy600m83hxBRJJrIsof58EKqtIBNXZer/FHKd1ii+H?= =?us-ascii?Q?CVmkhB9pE4BbikujqcMq8hmAyu+GTxeqHI4a1JmKGTwK8ilzFgnNS//Eaxof?= =?us-ascii?Q?KOjec6xdS3a7nDLoe/7WQgABXN3LYSAYaT6Do3ruOpBcbyv6LOdxNQ2B3cPz?= =?us-ascii?Q?RCG3od7E9fmKZfWglkrM+CEmw4xbYoSv0ow1g+ICb2RUNJBa8DBm6oMVPeWg?= =?us-ascii?Q?A0+ajHUV5zcPHF5F86NAur2cRM8U3LF9byBu7Pexl1gfx+GpfMM1ftvuOvyE?= =?us-ascii?Q?omCWoD6UxN63tuWCzgz6HS5pCNCIjQVaM7r2qZcUDmPYvTRmmhfyDRsApqLZ?= =?us-ascii?Q?5wrenDIMsyPGZgC9etFFVl5aK0gqCPKDB462Eol4E4qYMDLhanSXnjdUl/JK?= =?us-ascii?Q?IbbpQPYZfPg2RYTb3UCnL24SXklVsASDqr1/cYklIjelChOJ57/Qp8iK25HO?= =?us-ascii?Q?369wSJO+sqVUCB24AxRfL4REp3oA6V0x1sazUYC/mTtk48SSVoF32I7qOXH9?= =?us-ascii?Q?SwqGQBXFQcNnxu+p4oyy8ErLlPErZwcBxxed0GTi86k5QvZKmR2OgmJY6GRL?= =?us-ascii?Q?WHDE3lszKYHs6bGTjSJExPXiPsNDf+f0OLNWYHcSqbxbibrxZn80CrwiZQgO?= =?us-ascii?Q?W7fw/dDESRGNPXGOIy5YVkmYE2ClaYq24YrStQL/pjzeTNPq/XOBXKIPFGLc?= =?us-ascii?Q?kZkB/cLND4LDLD96LOEdoUrTHIENmC4cfe4KdGcFDPVJtEf3ptF/BLw85Gy1?= =?us-ascii?Q?Y1EzbTvn5Xn41Ld6YwNtuDII/MrOgO7IaJf0O5MV2QxFAI0OrDq5jGdrrvKc?= =?us-ascii?Q?ms3DDciS1KzZ6m8HuPSlnSvSfPxVx8YA1aexdsjySAaXUYd86KA1oEhMdV0S?= =?us-ascii?Q?EJUMSX80fFh2DEKN8uhwaw4MksO7ydHPWRAU/byURr3fLPQSvLnmaulO9XJ8?= =?us-ascii?Q?hbxt/MHg3Z2dBN+OYd/GOUnRg42tUXG6CyDNp9PRm6izDy/J35F6GzK9r6tJ?= =?us-ascii?Q?8JJuJ+OQvxFtncEXCo2jx3+IV0AXUTmnNBPb0E+5kQvmETMKJ0sVCbCAQgq4?= =?us-ascii?Q?p3fgGgNk8p38wQrmfWRm6PpMr+H8Y84MD76yGOYfibrUfuVkjQ0CdaQB4KuV?= =?us-ascii?Q?IMObMbpP+l6RgbyZ/8/TKJN4JCXflQoven8udzeGUPPBo0udvMR4zGjwYHJy?= =?us-ascii?Q?eLV2N6cJuH8xXdKzH8Vg86JhpfUQOjoIxcSvCwMmLslVtmvfebQ98RlnFvUe?= =?us-ascii?Q?B+GgvvWMx99slKNvXPSgEaEUzMb6MkOO5/flUAR9RTxewoR9hchxccxXio+O?= =?us-ascii?Q?4GNeQdhtMNl9FzXRnkKKbk8IFFTL0A0NBAfNS3WXmw26CXhaqR+42mwdNo08?= =?us-ascii?Q?dI2ogpRPE5pNr3XykugIslpX/5uXpbK9KIg9zlJ/cHHuYVYuw77PnMyfX61F?= =?us-ascii?Q?pHnDiB5s+KVyGDM3MTIuwQlqg5YpIeOoyNB31l+5VrleiPwdNRMhWQRyieJ9?= =?us-ascii?Q?+Eo+4FHWp4tQNDkGG+tdF9PxgrqvakA841+X9L8H?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 800772ca-4a0f-48c6-fd13-08da96eb3247 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 07:23:33.1249 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 54Oj3nxAQWxfE7pXe8QZwrEyyVvqBYq6Wq15TSYJI8vrlfqpo9BUzt7EGOZSfwTgpAiM7Q1NDWaH+HNvdDXCdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4464 X-Proofpoint-ORIG-GUID: EgDy2ert8XnWL_Bgcu0_egY1YxiTrcSA X-Proofpoint-GUID: EgDy2ert8XnWL_Bgcu0_egY1YxiTrcSA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-15_04,2022-09-14_04,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Hi Fan, >=20 > Are these patches getting compiled at your end? Are these a working patch= set > on Intel platform? > For me it is failing for each of the patch >=20 > 'drivers/a715181@@tmp_rte_crypto_scheduler@sta/crypto_scheduler_schedul > er_pmd_ops.c.o' -MF > 'drivers/a715181@@tmp_rte_crypto_scheduler@sta/crypto_scheduler_schedul > er_pmd_ops.c.o.d' -o > 'drivers/a715181@@tmp_rte_crypto_scheduler@sta/crypto_scheduler_schedul > er_pmd_ops.c.o' -c ../drivers/crypto/scheduler/scheduler_pmd_ops.c > ../drivers/crypto/scheduler/scheduler_pmd_ops.c: In function > 'scheduler_pmd_sym_session_configure': > ../drivers/crypto/scheduler/scheduler_pmd_ops.c:525:1: error: label at en= d of > compound statement > 525 | next_worker: > | ^~~~~~~~~~~ > ../drivers/crypto/scheduler/scheduler_pmd_ops.c: In function > 'scheduler_pmd_sym_session_clear': > ../drivers/crypto/scheduler/scheduler_pmd_ops.c:569:1: error: label at en= d of > compound statement > 569 | next_worker: > | ^~~~~~~~~~~ You can try this fix=09 diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c b/drivers/crypto/= scheduler/scheduler_pmd_ops.c index f8aa10af64..2bc3f5dd27 100644 --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c @@ -493,15 +493,19 @@ scheduler_pmd_sym_session_configure(struct rte_crypto= dev *dev, for (i =3D 0; i < sched_ctx->nb_workers; i++) { struct scheduler_worker *worker =3D &sched_ctx->workers[i]; struct rte_cryptodev_sym_session *worker_sess; + uint8_t next_worker =3D 0; for (j =3D 0; j < n_configured_sess; j++) { if (configured_sess[j].driver_id =3D=3D worker->driver_id) { sess_ctx->worker_sess[i] =3D configured_sess[j].sess; - goto next_worker; + next_worker =3D 1; + break; } } + if (next_worker) + continue; if (rte_mempool_avail_count(mp) =3D=3D 0) { ret =3D -ENOMEM; @@ -522,7 +526,6 @@ scheduler_pmd_sym_session_configure(struct rte_cryptode= v *dev, configured_sess[n_configured_sess].dev_id =3D worker->dev_i= d; configured_sess[n_configured_sess].sess =3D worker_sess; n_configured_sess++; -next_worker: } return 0; @@ -553,20 +556,23 @@ scheduler_pmd_sym_session_clear(struct rte_cryptodev = *dev, for (i =3D 0; i < sched_ctx->nb_workers; i++) { struct scheduler_worker *worker =3D &sched_ctx->workers[i]; + uint8_t next_worker =3D 0; for (j =3D 0; j < n_deleted_sess; j++) { if (deleted_sess[j].driver_id =3D=3D worker->driver= _id) { sess_ctx->worker_sess[i] =3D NULL; - goto next_worker; + next_worker =3D 1; + break; } } + if (next_worker) + continue; rte_cryptodev_sym_session_free(worker->dev_id, sess_ctx->worker_sess[i]); deleted_sess[n_deleted_sess++].driver_id =3D worker->driver= _id; sess_ctx->worker_sess[i] =3D NULL; -next_worker: } }