From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 42F9FA00C2;
	Mon, 30 May 2022 08:04:25 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 21EAB40A89;
	Mon, 30 May 2022 08:04:25 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
 [67.231.156.173])
 by mails.dpdk.org (Postfix) with ESMTP id 5FDF140A82
 for <dev@dpdk.org>; Mon, 30 May 2022 08:04:23 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
 by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24TNVmWk015426;
 Sun, 29 May 2022 23:04:22 -0700
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174])
 by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gbk8n48sg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sun, 29 May 2022 23:04:22 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oY1HF0+v6JdoxkVjBFNRMyUD1W+xWIwoCLNF+V3dhpyJ1kQK1TOjApJXoE+KQYEPiySmTqsU3iArK/iNb+26WZR/luG6+Cb1IzPivHKzgb//86pNKYSz+AmOFPanG6KKPbaGTaHOHc5BrYnlXbHfq3UrRgQ0XUAK1kPGTfzdzgWKccPv38rtyzrkLlQhQXadfx7Tl8GucY70rh0r4FYP6H6ofTbGzgygBMPUiGwkTTr39o0o4ZHmBxQ/E5sbqyNcw7qn4YBWJ6A+3HTMEBXlLlLVXBaNwVln85kLQ4xl+tjGNyAAE1dngjd4tz/pZoWx1rcZ0sI5dZ63tnQYSFrhyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mSpRtTU3dCqVCR7NaiO50y6U1UVqmsu5xGLrM7fI/LA=;
 b=PSZLppTW5S3k6vcSlisaCuchygN0LIc3G7kaVAKVyoqNPQ3zSbs+wfNkP1hP2Qc9SgOLywXxsNdz2Wn8wYTQZUUq89vcOuXPv8uA3zJ5sNfq4ORWTvCa62/Db+Z8ALoTXrdp3yuiVSMd6LUGhby8EykDDCQYK9bL3Ett22Qug/mM4ZpcmsH8pzgi550jphbi/1b0A6BWt9HNMZY2XygXQk3NrOeIBpF72x9/VnY5Y0kU0lrcWFUcJUvFm7vaE2AwH1ntKG9VSqeIOSd013D5AupYoVtq8NdRfKB8kTx+MvfRA7kkJUdn8Vg+aYv2iUJw5/fBAjcAc07uYh/CCNM0Fg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
 dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mSpRtTU3dCqVCR7NaiO50y6U1UVqmsu5xGLrM7fI/LA=;
 b=A0F3cLoiR4kdKSIP6hFB8JIVDBQopZCMsY5SANiEwhharkhUENLZqbfubeaf++fAdb75qRM6pASIK6AZXFodBJu0bCuWLbSi15obnsnRFhIst/LZjQQ7RrjV6h0muNJoIiojz+ggAR4YzRhy8UpoTm5CVwjPgC8LeC0qMS0VpMk=
Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by
 BN8PR18MB3059.namprd18.prod.outlook.com (2603:10b6:408:73::32) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5293.19; Mon, 30 May 2022 06:04:18 +0000
Received: from CO6PR18MB4484.namprd18.prod.outlook.com
 ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com
 ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022
 06:04:18 +0000
From: Akhil Goyal <gakhil@marvell.com>
To: Gagandeep Singh <G.Singh@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP
 operations
Thread-Topic: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP
 operations
Thread-Index: AQHYbAEVPTFjFIBZi02ZoEOjCcZ9xq0xN4vggAWswwCAABlDQA==
Date: Mon, 30 May 2022 06:04:18 +0000
Message-ID: <CO6PR18MB4484C2E4341CD38CC68C2AA0D8DD9@CO6PR18MB4484.namprd18.prod.outlook.com>
References: <20220517033858.40394-2-g.singh@nxp.com>
 <20220520042104.3784908-1-g.singh@nxp.com>
 <20220520042104.3784908-2-g.singh@nxp.com>
 <CO6PR18MB4484785FCD879C27FB9CFB88D8D99@CO6PR18MB4484.namprd18.prod.outlook.com>
 <AS8PR04MB819881F5AA3E533F6307A45AE1DD9@AS8PR04MB8198.eurprd04.prod.outlook.com>
In-Reply-To: <AS8PR04MB819881F5AA3E533F6307A45AE1DD9@AS8PR04MB8198.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ab77a5e7-cfc1-4045-70dd-08da42023b9d
x-ms-traffictypediagnostic: BN8PR18MB3059:EE_
x-microsoft-antispam-prvs: <BN8PR18MB30596D85D0DD26BAF37F474CD8DD9@BN8PR18MB3059.namprd18.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: u1+l94aOCJk/z0V7PIOdFCfN9CkyX4DjXIxYdHA1eH8KcChP2JQoXyPgcNIcGJfOBdBLLM582fx2Uh5OfYYCwCbC9MlEv8LFUamN+cQ/yV88smh+21vGAZc5pLvofJGBBsW/qDA9olIxKE8XHI4rGiEjrH9B2j7L7yj4Ksgbo6ypgKY4AaOSsINSizPFLuSJgsVM1f9tdBfpOkdkupef7lHZIMVXPodDcGj/I89eexA1Nf2lSWmyUuzoGN5YaYpnzSXFgh3u5UaxRt+pJABuLRQB+X9voJRuG5LwLHbcOaVuFj2WpYEsZUCiRWh8YmauNeGs4CANZYKJT3ixmIJxgtM4nMBJWKxb8glkbQlHu47yUjkSdzPTjHWJt0198uDY2tTNmIyY6j0kamH7nriWUIHgB/hzdKn9hDvP8RrAICyFWBtKTpKD6fmEE9eFEknrs7dpJm2hMhpa0rrz490HMiPA7lJmc+FZa6FtaSnrD419SE47v2lwIAZCldxrOosX6Vng00MWPhrpA6LsBo2wvbS1vzK8tYLtDtJNJ7zRzMD4pfxEXJgS+dt3XrBatFEnVggVSrrx3/vGlME1ZPD1xpvu65cXA+Auu629hPS1TB//Zxiu/TM/zt15M72JgmUfAS0FIhKsAM9lpfe3tlRFJh9iDoVSsolJx55SOFMRwAYLM4cUi/p0kapTiwBw/aYbcGr5tN5v1oD8Bs+VVUsnGg==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230001)(4636009)(366004)(186003)(55016003)(26005)(508600001)(52536014)(5660300002)(71200400001)(8936002)(6506007)(7696005)(55236004)(9686003)(2906002)(33656002)(86362001)(38070700005)(38100700002)(66446008)(8676002)(64756008)(66556008)(66946007)(66476007)(122000001)(76116006)(316002)(110136005)(83380400001);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KuNgve8vZMpeOMGrmRf2Bs2Hubwvg7X14d/y2NaPHOc0W39/fXnUTSkMswEQ?=
 =?us-ascii?Q?9ic1lnmRpW2a/G7zEBGy3SYYsUrcy/oM9mtE8wSOSkH0/YpD4UwEY30Wclr0?=
 =?us-ascii?Q?Hu5rRmNqCTBxvBn7yWVWHh0sXOI8LNDNik5BvuG9/yB8m3PdurEkJ2njaD38?=
 =?us-ascii?Q?lYlN4K1m7ErtY1R2GsQBV+0sAjbGqN8Rs4rc5Xcz9CI3acE2t74bTGwBu93K?=
 =?us-ascii?Q?rgFLfJSlQq0+HhzxWhPjRUXR1jr3i2k+OL74NaA9HqO7N43RFVnmWSvXtwes?=
 =?us-ascii?Q?ZVX4+ZSupXvt1zjCEWZGfEdOA6NMWaOhq3n7hgraOCVaHfZPvhtO5d3S/n4j?=
 =?us-ascii?Q?9sm5AvU7Oc9L4UnlUnJUxn+zEdb5JoXYcSZcfWqdNuFQxq+t+qxHTxVLcccg?=
 =?us-ascii?Q?Q11RQa9AwsGEuJ4wZMmxGUU59vYBelQd88l0HxX3vergfkWO+WdeCfnUctua?=
 =?us-ascii?Q?Aadfb6mLK8oqgkBFI2atWT3UAdsWNkJbiRDJ4GUwQ49o3rdoRUEQpx2fo4py?=
 =?us-ascii?Q?94Y/DaheT9DDYkyoEKsHljg2vdk+uKa5h70awHRgNefLiNhQVDM0GYX/Ltyy?=
 =?us-ascii?Q?NRWrc78TOw/cOMH0wTZ9xWKB2q4qmUCMCh1XsOpsYHu87s1xF/RGrla15kr6?=
 =?us-ascii?Q?7yALG7HXGsepyR/DsGOjcwI6Chr5do+btpHHvBhInhiOo/ssloCOYlOVsKEN?=
 =?us-ascii?Q?iN7kyyf0tC5Jnac/PsNvN8UlspSLFES46/qc18imsUExGqpo0sZU7d1agLn1?=
 =?us-ascii?Q?WO1uNPOefrNy2SlFUFsDVBN+Z9hqKrW4lW9v2s0xABReH5MUBdbhUNK71ogB?=
 =?us-ascii?Q?jkJ4WuoSPzG7/g7pYWyjhDzUdDMOrcb6ZPXzpeh2AJ/GbOeHJg0B6AVW8jSV?=
 =?us-ascii?Q?JPsjuPTWlocUBs7pPCepO3jYG5eLfpoZEY7KhQiEt5I9RQR75A9oSWVHMcTL?=
 =?us-ascii?Q?P0v37bPN2bRIJsoG+c61oHKM8ep8u4efugwVPPrBkhg9mxlMAB7aNSiJ9bG2?=
 =?us-ascii?Q?5MuE9+0+kBQ7ZBrAwF2bcz0xS2WwuIX9mNANeJ9VjldfRzcv6UsnavreR8V+?=
 =?us-ascii?Q?52F9NOivUnWOO3QgxwUh+lMa5EWSbCdOcEyCewrKLNhdOtD06vUiGRt5PnpJ?=
 =?us-ascii?Q?ibGLutOpVbjByz8rEqkf1DnW15F1CWrfXqcUApfYhQnvaNOXjgODomlSUmST?=
 =?us-ascii?Q?c9cnluJRFakVDBhA6MpamUPYYakmM2nP9UXQsdB4F2NRSabQ28IoFu8almY0?=
 =?us-ascii?Q?QBsQjGF+gXQUNn93Y6mjlyAzpKpwJz3WNAPby5t0WMU5aYFpLvPobomJ6SJF?=
 =?us-ascii?Q?ABUbqhR8b2PHflyeDXguXeTjm6L5/uRZOr7jhc8/TmAasZJUOBUVJxkkCLy/?=
 =?us-ascii?Q?XHb6jMUu9xF2ZxGl7NYm1ZSx7N4d+rTd3pQ7L6fpsLemYvi53RHziROeO3zx?=
 =?us-ascii?Q?CfSc0xFCv0cGObZGgh4N8lZ+aKFzfp62kbpBVhmrIAzcjtg5PAi/MBhqcnYi?=
 =?us-ascii?Q?8ZXBQ+gMKDGzfeIY8pworXSblipq1gqplklgzV/RGIcNWCq3mEi7qd722/1U?=
 =?us-ascii?Q?v1Ex516ddwPqCiw1FxF2FaY4/CHm5ZvE09VyNobAyYg10vqgiqIcTikDSNpj?=
 =?us-ascii?Q?ww5CbHJViLH1LgfcfdYoWXidTup/j72769UGH2nejnvGR8Vz9ZU+nmfAE6Xf?=
 =?us-ascii?Q?hKSVFHkYHZqejLkLbFpe9coRwT3TtI6EqZgJ/lysufq+ONGM5EDRN2AOkPOs?=
 =?us-ascii?Q?Ae4iPu2rZQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab77a5e7-cfc1-4045-70dd-08da42023b9d
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 06:04:18.3575 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b59UxFYes+IGA5WGMEDRAonJJCC786siTrWGh7K55FD1Ygs6kdMT4eugIZg2/GSd0ukNSwAGRSnkUc6tydcjYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB3059
X-Proofpoint-ORIG-GUID: isE_XUgRZU5NJ744ETGjGKY2gcL4_laM
X-Proofpoint-GUID: isE_XUgRZU5NJ744ETGjGKY2gcL4_laM
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-30_01,2022-05-27_01,2022-02-23_01
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> > > Add a command line option "--enable-sdap" to enable Service Data
> > > Adaptation Protocol.
> > >
> > > example command:
> > > ./dpdk-test-crypto-perf -c 0xc  --log-level=3D8 -- --devtype
> > > crypto_dpaa2_sec --optype pdcp --cipher-algo aes-ctr --cipher-op
> > > encrypt --auth-algo zuc-eia3 --auth-op generate --auth-key-sz 16
> > > --ptest throughput --total-ops 100000 --burst-sz 64 --buffer-sz
> > > 64,390,1512  --pool-sz 4096 --silent --pdcp-sn-sz 12 --pdcp-domain
> > > control --enable-sdap
> > >
> > > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> > > ---
> > >  app/test-crypto-perf/cperf_ops.c             |  1 +
> > >  app/test-crypto-perf/cperf_options.h         |  2 ++
> > >  app/test-crypto-perf/cperf_options_parsing.c | 12 ++++++++++++
> > >  doc/guides/tools/cryptoperf.rst              |  4 ++++
> > >  4 files changed, 19 insertions(+)
> > >
> > > diff --git a/app/test-crypto-perf/cperf_ops.c
> > > b/app/test-crypto-perf/cperf_ops.c
> > > index cbefce8d6c..4295656a0b 100644
> > > --- a/app/test-crypto-perf/cperf_ops.c
> > > +++ b/app/test-crypto-perf/cperf_ops.c
> > > @@ -861,6 +861,7 @@ cperf_create_session(struct rte_mempool
> *sess_mp,
> > >  				.hfn =3D options->pdcp_ses_hfn_en ?
> > >  					PDCP_DEFAULT_HFN : 0,
> > >  				.hfn_threshold =3D 0x70C0A,
> > > +				.sdap_enabled =3D options->pdcp_sdap,
> > >  				.hfn_ovrd =3D !(options->pdcp_ses_hfn_en),
> > >  			} },
> > >  			.crypto_xform =3D &cipher_xform
> > > diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto-
> > > perf/cperf_options.h index 09caefde22..613d6d31e2 100644
> > > --- a/app/test-crypto-perf/cperf_options.h
> > > +++ b/app/test-crypto-perf/cperf_options.h
> > > @@ -14,6 +14,7 @@
> > >  #define CPERF_PTEST_TYPE	("ptest")
> > >  #define CPERF_MODEX_LEN		("modex-len")
> > >  #define CPERF_SILENT		("silent")
> > > +#define CPERF_ENABLE_SDAP	("enable-sdap")
> > >
> > >  #define CPERF_POOL_SIZE		("pool-sz")
> > >  #define CPERF_TOTAL_OPS		("total-ops")
> > > @@ -129,6 +130,7 @@ struct cperf_options {  #ifdef RTE_LIB_SECURITY
> > >  	uint16_t pdcp_sn_sz;
> > >  	uint16_t pdcp_ses_hfn_en;
> > > +	uint16_t pdcp_sdap;
> > >  	enum rte_security_pdcp_domain pdcp_domain;
> > >  	uint16_t docsis_hdr_sz;
> > >  #endif
> > > diff --git a/app/test-crypto-perf/cperf_options_parsing.c
> > > b/app/test-crypto- perf/cperf_options_parsing.c index
> > > 09c98121c8..28680347f1 100644
> > > --- a/app/test-crypto-perf/cperf_options_parsing.c
> > > +++ b/app/test-crypto-perf/cperf_options_parsing.c
> > > @@ -64,6 +64,7 @@ usage(char *progname)
> > >  		" --pdcp-sn-sz N: set PDCP SN size N <5/7/12/15/18>\n"
> > >  		" --pdcp-domain DOMAIN: set PDCP domain <control/user>\n"
> > >  		" --pdcp-ses-hfn-en: enable session based fixed HFN\n"
> > > +		" --enable-sdap: enable sdap\n"
> > >  		" --docsis-hdr-sz: set DOCSIS header size\n"
> > >  #endif
> > >  		" -h: prints this help\n",
> > > @@ -548,6 +549,15 @@ parse_silent(struct cperf_options *opts,
> > >  	return 0;
> > >  }
> > >
> > > +static int
> > > +parse_enable_sdap(struct cperf_options *opts,
> > > +		const char *arg __rte_unused)
> > > +{
> > > +	opts->pdcp_sdap =3D 1;
> > > +
> > > +	return 0;
> > > +}
> >
> > You should also set a default value of this flag.
>=20
> Default functionality is disable SDAP. Application is defining the cperf =
options
> with all values 0s in its main(): "struct cperf_options opts =3D {0};". I=
s n't it
> sufficient?
It would be good to initialize that with other options. It will help in deb=
ugging and
Improve code readability.
Please add it in cperf_options_default() as it is done for other PDCP optio=
ns.