[PATCH] crypto/ipsec-mb: fix qp setup for secondary process

[PATCH] crypto/ipsec-mb: fix qp setup for secondary process

[Ciara Power]

If a secondary process is using a queue pair that has been setup by the
primary process, we need to reset mb_mgr pointers.
This commit removes an error return in this case, allowing secondary to
do the remaining setup for the existing qp.

Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler")
Cc: kai.ji@intel.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
index bf18d692bd..62be68a917 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
@@ -273,9 +273,6 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
 			return ipsec_mb_secondary_qp_op(dev->data->dev_id, qp_id,
 						qp_conf, socket_id,	RTE_IPSEC_MB_MP_REQ_QP_SET);
 		}
-
-		IPSEC_MB_LOG(ERR, "Queue pair already setup'ed.");
-		return -EINVAL;
 	} else {
 		/* Free memory prior to re-allocation if needed. */
 		if (dev->data->queue_pairs[qp_id] != NULL)
-- 
2.25.1

RE: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process

[Ji, Kai]

Acked-by: Kai Ji <kai.ji@intel.com>

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Friday, November 4, 2022 9:43 AM
> To: Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; pablo.de.lara.guarch@intel.con; Power, Ciara
> <ciara.power@intel.com>
> Subject: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process
> 
> If a secondary process is using a queue pair that has been setup by the primary
> process, we need to reset mb_mgr pointers.
> This commit removes an error return in this case, allowing secondary to do the
> remaining setup for the existing qp.
> 
> Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler")
> Cc: kai.ji@intel.com
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> index bf18d692bd..62be68a917 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> @@ -273,9 +273,6 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t
> qp_id,
>  			return ipsec_mb_secondary_qp_op(dev->data->dev_id,
> qp_id,
>  						qp_conf, socket_id,
> 	RTE_IPSEC_MB_MP_REQ_QP_SET);
>  		}
> -
> -		IPSEC_MB_LOG(ERR, "Queue pair already setup'ed.");
> -		return -EINVAL;
>  	} else {
>  		/* Free memory prior to re-allocation if needed. */
>  		if (dev->data->queue_pairs[qp_id] != NULL)
> --
> 2.25.1

RE: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process

[Akhil Goyal]

> Acked-by: Kai Ji <kai.ji@intel.com>
> > Subject: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process
> >
> > If a secondary process is using a queue pair that has been setup by the primary
> > process, we need to reset mb_mgr pointers.
> > This commit removes an error return in this case, allowing secondary to do the
> > remaining setup for the existing qp.
> >
> > Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request
> handler")
> > Cc: kai.ji@intel.com
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
Applied to dpdk-next-crypto

Thanks.