From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 98077A0C52;
	Fri, 16 Jul 2021 21:43:38 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 69CA64067B;
	Fri, 16 Jul 2021 21:43:38 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
 [67.231.156.173])
 by mails.dpdk.org (Postfix) with ESMTP id AD58940151
 for <dev@dpdk.org>; Fri, 16 Jul 2021 21:43:36 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
 by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id
 16GJepK6002958; Fri, 16 Jul 2021 12:43:36 -0700
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174])
 by mx0b-0016f401.pphosted.com with ESMTP id 39udxggj37-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 16 Jul 2021 12:43:35 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EAz7C/laNnxxEoK7FLF2ymG578pHbIHS5l0TuObAtBHkl7lDxvfEMCISs8RufyP5fUUI2u8s7ata2sGPNTBDMwra/yFM6cNeeaUg5m3Px33NDw9YU1zo3bizCYgJXXWcnfALEUyNnlfTiticooM//vIvDhj/ibPTlh4pA8CymAjbsojcQLiQSZ+dVHuihVwh80WdD+p1MVqToYGnOmwiektpWbds+zGGVx++zMYMWMEVY1dZExyLxG5VQDsG+gzvejMJxXOxl3HuCENVDb9Y0xiKiPfr9n6eNsRF0w3OFO/aZguHmx6fVcIgBtB0aPuEgJED2u5AmPWt4XpaZjeqIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=l1+VTZNhNFX3m9bXp1kAQJvdbHoFthXcuxHgPVHwgWY=;
 b=n3XUFGMeri8V5F15J/Pz6+7ihkec7+wUSr6i0VVGydDCMWrzOsooQhJ0iPCpRUaEbC5yOLqOTELb769X2Pa9oka0bbBou/LBqCAhTUqVIW0ExzzippGuMNH0hxgEJNUf6EPFqtM9c+qvaEhFak+8fOmMSJR8DE66Cts4G1mE9c38rdWY3YHEuy5xp3PLI2ux+JTR38L8/N1UWxVUUndlrZWD4cidfQtvkLOrvfaTJiylGJn8HH8AK74mz97o8CZw2MshUP/YzjF8qO3DGz25jMR8ngcjaPg5oHVBhUs4EWIzVZi5vvaHtucK9XusHEVp+ea4HiBvHnTRLms9ZNy9lg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
 dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=l1+VTZNhNFX3m9bXp1kAQJvdbHoFthXcuxHgPVHwgWY=;
 b=XVvZk4U5TqpV/yBu59rHoJpcIO6sppsfxIA85J405xS4+xtl5M98PWAz32RDP5I4rayuuamhHiJ2A0+35Ar8tjiEqsjrYUrAqcuYSPY+YpUGop4qyq8UDTMpQqD+rCpJx5l6ln4RZHvKmn5Pg7gy91txZqXTKDNvW3sDIzxJkxQ=
Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by
 CO6PR18MB4387.namprd18.prod.outlook.com (2603:10b6:5:342::24) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4331.23; Fri, 16 Jul 2021 19:43:33 +0000
Received: from CO6PR18MB4484.namprd18.prod.outlook.com
 ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com
 ([fe80::1455:9a67:a6e7:e557%6]) with mapi id 15.20.4331.028; Fri, 16 Jul 2021
 19:43:33 +0000
From: Akhil Goyal <gakhil@marvell.com>
To: Shiri Kuzin <shirik@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "matan@nvidia.com" <matan@nvidia.com>, "suanmingm@nvidia.com"
 <suanmingm@nvidia.com>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>
Thread-Topic: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations
Thread-Index: AQHXeZhbnCd1uXT6C0q3QumS/R7iw6tGAc7Q
Date: Fri, 16 Jul 2021 19:43:32 +0000
Message-ID: <CO6PR18MB4484D024A35DA88C45921EE8D8119@CO6PR18MB4484.namprd18.prod.outlook.com>
References: <20210715150817.51485-1-shirik@nvidia.com>
 <20210715164126.54073-1-shirik@nvidia.com>
 <20210715164126.54073-4-shirik@nvidia.com>
In-Reply-To: <20210715164126.54073-4-shirik@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: nvidia.com; dkim=none (message not signed)
 header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dea747ec-7467-4b2b-9f39-08d94891feb3
x-ms-traffictypediagnostic: CO6PR18MB4387:
x-microsoft-antispam-prvs: <CO6PR18MB438708A074A844FA60D8642BD8119@CO6PR18MB4387.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: I77jbMIqH/p3EMthtSCR109SZTtYAmmCjTDDy41p3x2E7AAHLnJ1mkW5Ueh1ZnQ2ryPqeMOHl72OerTxt2GvoigWKavfCQh0pUBWAVmkmJ7wm2hj1MgwFTMuX+BbgSvkNfW9xOIxmogwWJmPOP0uyCbkrodwGahvutKhHt/oot9XdEvAayKhZNw91klPa88tBO49JyiJqXs8rVKk00LX4C+E+If7TOk3SNuSc5KAI4pGijdpezgYbWGivFnMfCYqmbe1yQgWvQBIhRSQcW/O/LHitDAu0D17lqXY5rvPmsONjLeyODHM/c5OYhJ3zN3H8fomkUXMcdIJforlh/OZOhefkZk8zgq6b8WanC7gXVIKqdwQJXBnLOn8HusbAtXpa40oCcgNPHlIg4UzaobmviFoPPJkyy6h1Kg0dH5ZVgsClz+WJO5yy+XLsaFVXAqrAAWLXBD43ww/c+J7cd3I0PX3lzYd0NGCNuuStrDvqsKgYQsOVsBfUzNxH/ItAC29hgUQi7fr13c8IePnC2vy0aDBLX+ppb8OYSUtQhtoYn7UtzeR+bbrUQy8a3rlDgz9v9NVohePAebZ80EbL7LzynAem9lWnImgPCG2fogiwoScRqmaJKwfggnKpPDpATH6TGE1XZ6+TcjPTnVPGuTWyt7SezcPbmKoU6JJJYGPIgJFGTWW/nR9NHZVaOxRVyxLU1tOxx8KcJhQ0FjDrL0CQw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(39860400002)(376002)(136003)(346002)(396003)(366004)(7696005)(66446008)(5660300002)(6506007)(478600001)(33656002)(66476007)(66556008)(8936002)(186003)(64756008)(2906002)(8676002)(110136005)(26005)(122000001)(55016002)(4326008)(86362001)(83380400001)(38100700002)(76116006)(9686003)(71200400001)(66946007)(52536014)(316002)(54906003)(38070700004);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q12/WpCLkyZ0rxCl1Yunas6tTbnbSBwyzk3dt+cFcRQmx6Kue1glM5oFig5K?=
 =?us-ascii?Q?7hF4LgWqMq5VrIEWhjTI45BkAThRLdm8Q+kdc1M9M/vjP4v8vVW5iTRyxMyv?=
 =?us-ascii?Q?asTXayBb3o6du4Sv6Tk6BxJ5Zsu26NoPFrgVtfwYgQQgC5k1XgSlsf5X06dl?=
 =?us-ascii?Q?w5WSWfo1VFrMUsncyREszh9luIW5ND+0q8VeEYkmZbniu3NNIMF+FiofgCZB?=
 =?us-ascii?Q?HGvhGGv3iIxRXuD0gE01LK4hts2fu+J5QZ9ERyBC/9/VSaOo3stN0f2tDOk1?=
 =?us-ascii?Q?NJ2Koc8A9nPROlZW/XngVd1vX98vQOhsgWN2+8qOhRia6zNjiomNPiqrBcfr?=
 =?us-ascii?Q?5u4X1y/WOuNIPBm8/v2sFrA8kkAS/ZMj4tTD/q6syAOqQEQPB1XkGCrM06l+?=
 =?us-ascii?Q?zmeqvpaizfX1aNPShBTse4pyonEvtfg6oVuZLlrsKaqKl4ZviKvI2so8raoP?=
 =?us-ascii?Q?jG4JmY91CJ9f9IgXW+kq2av6IUHCrAZeeRS3jtmvWB5tyy1jM7ihUNSyI7o6?=
 =?us-ascii?Q?PJ5uh1+gwl3d87UBix0g3GzoIxhlPs1NAl67roZaHkz+ewD9qevzjuWL3gY+?=
 =?us-ascii?Q?d+XNZqLPQyuOtNEpIxG+9sxqHPy6VVR3sXULtjBlG4acPUdI6JJA7WWGOaJe?=
 =?us-ascii?Q?OK1dsbXy6mhqBHJCmDHtAhct0bXA26ZKBe7hRliU3zEaicmUA1yI0DIk5Rau?=
 =?us-ascii?Q?P2NxXbU50nStSf64JtAKhFvCWsNHHLSgqoTWpG6op3sl9QMs8D0QWpBhs/QH?=
 =?us-ascii?Q?nhy92PxpmQwFf5MxFkCsI4ppLmh0f39GiDABUL3DX3FOWRK2LASBZlX6SjzL?=
 =?us-ascii?Q?H2CJaa6jvOwvAwFNrWSOwaQWrYpFWvKKZZ8e9u7yTt5i9jLomy4nBnUPEyLA?=
 =?us-ascii?Q?5mqIgvmUfIug4Tm94gFsREdEw0NY1WoKraGoS80RVsrnVIzYwY4Lx1M7j3Ol?=
 =?us-ascii?Q?8IonrWaR+I2p0JBrUh1r/v5lCfobfem5XBesH9u23QdsOeBvShsm+mEFHqs/?=
 =?us-ascii?Q?h4EtswpRmn99ScXn09UbzNpESRJHszBJ9zvl55SAK6183DRcdnaYAwUmsZiy?=
 =?us-ascii?Q?Qig2sCmFYWBkOJiofo4m/nt+cF8d6tAGdEyUIETTQfw7eW6nmpjodwuSS/Bc?=
 =?us-ascii?Q?JD5fxmrT4doT18DZEajCTmiYPH6YFhuEvlsNWkZrIi/nqaHRH5pqa9GVLwzx?=
 =?us-ascii?Q?wmVooIoVSEbYP9Kr+GoCiUw5EZbdyxL/p58nqoIR0WlraCt5EElzq7TuplSf?=
 =?us-ascii?Q?Mxkujt2UpD3xr3hL7j2i3upoyuj6ON3E3Ahf4bEJF1gYsYLnhMx4GY4Xcr6r?=
 =?us-ascii?Q?qC4=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dea747ec-7467-4b2b-9f39-08d94891feb3
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2021 19:43:32.9790 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XBN0EcHZnTWOguVMkOtAV8teigN4nmYaTuUhNCC3MjQ5kUOemcaDVChMWckTGcWj975JDKn3Z3l3mstfEzAgQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4387
X-Proofpoint-ORIG-GUID: k7KbFVwekVaE9zOQFBSllnuNXP840kBX
X-Proofpoint-GUID: k7KbFVwekVaE9zOQFBSllnuNXP840kBX
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790
 definitions=2021-07-16_09:2021-07-16,
 2021-07-16 signatures=0
Subject: Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session
 operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Sessions are used in symmetric transformations in order to prepare
> objects and data for packet processing stage.
>=20
> A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct,
> bsf_size, bsf_p_type, block size index, encryption_order and encryption
> standard.
>=20
> Implement the next session operations:
>         mlx5_crypto_sym_session_get_size- returns the size of the mlx5
> 	session struct.
> 	mlx5_crypto_sym_session_configure- prepares the DEK hash-list
> 	and saves all the session data.
> 	mlx5_crypto_sym_session_clear - destroys the DEK hash-list.
>=20
> Signed-off-by: Shiri Kuzin <shirik@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/cryptodevs/features/mlx5.ini |   5 +
>  doc/guides/cryptodevs/mlx5.rst          |  10 ++

Documentation update is done in 3/16 which means the feature is complete.
But basic operations and queue pair initialization is done later.
This is not good. Please move this patch after QP additions.
Please take reference of other drivers for sequence of patches.

>  drivers/crypto/mlx5/mlx5_crypto.c       | 172 +++++++++++++++++++++++-
>  3 files changed, 182 insertions(+), 5 deletions(-)
>=20