From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B121A00C5; Thu, 27 Oct 2022 12:55:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDA6441153; Thu, 27 Oct 2022 12:55:48 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9E1FE410FB for ; Thu, 27 Oct 2022 12:55:47 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29R88m4T020412; Thu, 27 Oct 2022 03:53:42 -0700 Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2046.outbound.protection.outlook.com [104.47.51.46]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kfp7agfd0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Oct 2022 03:53:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CcsGJEFHzyEhhdIa8zJOG0UY4Zp2g6FPEWOX2RWx/SBBhEEU4bUXzX5XeA037sYvDgkT1mDMwQHlMZtI8wZWNWF7YFhLJQ0yc2ULXNg5x35XShVpjPwrmti7GSh6UNF+cpNWYm6DayQN7pII1TsI2ZOq6EJuWLG8kSeBAiqoFvNnaSJWQzo7+XIMkGQVIfe/PxttVbccstcI0Dop9nP2aquE7x4iY9l98ca/GhOGZSUjC/a3rSnTg3/es/+jdK7P7ptjZNl+iNCI3Vyp1vtAmsqe0AOGvhNFStF1THmdGQQ3Oe6S5O1pvBLkcs16QrdPlQrRlk33BW7v6Msw8jfs0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4rexjAIgOlzwXw+Gbx0yB6gLTSUwdYWu0S+Pxkpuf0=; b=IImI81owkxhbx7WNn0ZcpsAktqG6whfQMC4A8RxW+UQa5edShwPHswhixTy4gh0Dzb0hvRp2IeOCSX9ZQCIGFFCfdy9TDFP6oxg1cQHAB8MEXUcRG6XqJorkeoSLvK5v5FdWDTAiu1Dsa0cZ0vdARRZIRYDcGQ/b2uZb4+HPvfuUvHGwA23Eux5KTrHokK88lg/N1V1Gq2DsCzJ+eTpTnehktNP1B7ff5LkA/ylfckimCJ+XeSnlK/hzPtNvDfdRiTFn/I2COl2p/mWFXHdzHC1SHy2ZIDA30nfRgNrkeEHeiAOHfW3i8c6snye/tuigOUi0RyuL4OkougKJo6bKbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4rexjAIgOlzwXw+Gbx0yB6gLTSUwdYWu0S+Pxkpuf0=; b=GfoLNLVaSyN4QV+Uot40fJ73Qb5Nif6fD/pC3iRHMBjkdjmT1w6UwoiA181P13jhrwf0PgghYaw9wIMJZq07Jj1op7T5x+wR7s6MpT1r9dzSICjbosGP0omNRopri46pSnt3866pyo3TUIplI1vRbfZsMfCXkzMIgG+Ugpeg0HQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB3884.namprd18.prod.outlook.com (2603:10b6:a03:2ee::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct 2022 10:53:38 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::8c4f:e24e:332d:dc6d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::8c4f:e24e:332d:dc6d%3]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022 10:53:38 +0000 From: Akhil Goyal To: Zhangfei Gao , Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella , "thomas@monjalon.net" CC: "dev@dpdk.org" , "acc@openeuler.org" Subject: RE: [EXT] [PATCH v7 0/6] crypto/uadk: introduce uadk crypto driver Thread-Topic: [EXT] [PATCH v7 0/6] crypto/uadk: introduce uadk crypto driver Thread-Index: AQHY6bSsueQyPuO+kkWvQpSbMvUzo64iER8g Date: Thu, 27 Oct 2022 10:53:38 +0000 Message-ID: References: <20221027032505.1948351-1-zhangfei.gao@linaro.org> In-Reply-To: <20221027032505.1948351-1-zhangfei.gao@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SJ0PR18MB3884:EE_ x-ms-office365-filtering-correlation-id: 81bfd380-b044-4062-7d10-08dab8098101 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3DnKtSGx5yNQvd9RK8nqzJPVyeUtapk+cqL7FRHFqxRFtRTAkxu350T3KCxiXW0UdJZEn9WNrYfbPrIfxJi/6SCIy2OU5FLecMGJ2MePDTuwUUlNeCq0HEtc/53mscB26s+uzxooDAfqDfKf3xZ52fmwXi+Yk/MMFCdLFxZMtQ7fLYNHY6a6gu7XKIdUVILLsAWuSBgO1EX3+gdk29c17jC7syEZBZY8VOqr0v4Ncb0du3otkTdeO0uYXuWT8CCbAV/DDRrRDV+sQ5ZNJmTizvH1yhUKG4hS7XrE9rYKfuZZqWY3Ye58/KYxIBqGc97B9T9quFpfPcg+KaLUqVtP4h1yWbOVWjVhoV9zFncV2jP554kmR8kJxZFW7NOiSnQo5mPQ0eDSSubQKdqqH7rtDqSNWFHoP7nbdH/UWZMgEpBEPrVYsnDLWWs446EmOROaCuANEmn1b88TRQ1KuyN6x96CbIpKfUe6rKpcXj3caEOeLRatEZNxYY/KT9R+CRmsxMSquEr9EMnpxNzol7MOiSX21iTuGg8du8gnp/piQ9c3bAUySr4/uNzibeIXFzxvLDy6cOhZnAPllztDagoGklLj6KKT0BWG9GExsJ9wR0eeWImw8WpSJoeeRoiinaNzAZe3AaJB+4B1DNxPWjH4bvSS6IytnNeXWkrR4Aal+tYmvXRp1Xc/2s4YR/QKvopZGBp1Nxh6CusVqMhU+bNrJfsqbsMJIQgj1SCFlJymBWsyUy6+Y0wZSKiw3AhJFc1US/2xwoN1vypdvB6LhkZbqKE1/tb3FMRHuOSSHn/gxuA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199015)(66899015)(33656002)(86362001)(122000001)(4326008)(41300700001)(8676002)(66446008)(38070700005)(966005)(83380400001)(64756008)(186003)(316002)(55236004)(2906002)(19627235002)(38100700002)(6506007)(8936002)(76116006)(478600001)(55016003)(7696005)(71200400001)(52536014)(9686003)(66476007)(66556008)(26005)(66946007)(5660300002)(110136005)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BijkN8+BY/8pg2+OjI8z48hqI14UfVSwj31WDOs/aQfGE7eoGw/KWb7Ukfbd?= =?us-ascii?Q?fifvMFTvDhajYrU95RpstUHO5tG5fBxDyfMZNGaxe1JtTR46lM3+K93TU/Eu?= =?us-ascii?Q?z4yRqmX4axkNTKrw2sRAKXsRjl/guq3NLJcD/H+HZwQL7wMZPftk6wXY3W3M?= =?us-ascii?Q?6MBqi2arJVFxV4/QEZXgLFWazrGOMTd81qyPE3EIlxY1QRFtlUev79vWgsx3?= =?us-ascii?Q?6WZ5t4vtVSpXYSEV2qFKlS9kiDVmFxP8lHros4Cps8cPCTpGKHMfGY4k7H4x?= =?us-ascii?Q?lgExg9wzbGfJBFqzeAH7+f631YxAuhbb3HfHf7TIMdZ0rwJu2OCx9ACAphuu?= =?us-ascii?Q?MzK9eKIfItYTyuoDOHwbZRKGIXif7jfv2oSk/iwqej+GJtjUN+8KA6oJz28M?= =?us-ascii?Q?IaWbUg9N+0Iut7+fVlhbfQAHMmpEKp1IQq95mwfyTwFWJTUO05vZK5CzqkS4?= =?us-ascii?Q?3350yyX37gol0TYInsh/budCw5k/bBkMmOawb5E4+/qQ/+BeOerdGhUFTMaR?= =?us-ascii?Q?NOUBTN5o/jVfTGaIqronke4PWEUHhibTHaKnpNk2h/wxvyllg55gcGbJELOY?= =?us-ascii?Q?FUAxs+1yLS6/PMqmUm8TQil637Vv/GE6XPnnozxCdHQW7anwOiXp7CIv1CmN?= =?us-ascii?Q?1o302agRTJyMLYX6AF9CGkRQFIol1nTQ/Jzua/8THi1foSLkGh92vGLomZ29?= =?us-ascii?Q?uMh9FFPSuXwv9N1dc3Dosi2uRQ8Y4K3nAJ3dgqhlea2vvlT22MEURiGKAv8S?= =?us-ascii?Q?wPdw+UW+ke1jgDIm+PjK7Y8mDVfNIY8SDbQZudWH56k/yo5SDt85Jjs22mDN?= =?us-ascii?Q?OEIVrsU1nWZUHNw2Pr1eusn6Xhh/hv7mxYNi8IF57v+6OfSokZFKXfRYXYgh?= =?us-ascii?Q?xL6z154jyIqUsS2WjxtGlAhJs0BGcV2yMv5vD3B5XOXZSwh58M4I1rEmBgCH?= =?us-ascii?Q?8b+F/5ko6IaT3PnrMKM80ehBLIWYdZcNGnniV21CUD0eRrsLTJSkryEUeW+i?= =?us-ascii?Q?8toqhz33YSWypey1nASHyJMiGiUlvjHW3gCmwSUrDBU4NMkGJdC2wzVyqm4A?= =?us-ascii?Q?9b/vr+O+ltdMrcZ5hrx5d+lV8eZCG+fIi3iv+2PK75sq4GjvOeHnpOg6eTvQ?= =?us-ascii?Q?xtjQWqNR0zvIh2zJToG4cHq/bRBreuqWFH92LwqCNW3+WCJZqCaUxjopZACi?= =?us-ascii?Q?Pnh2IsSE7ICXFMrYNMQ7WcayzdsU67b2IF6k+gOL4JzTPCoZGRW7yp7Ufc5Q?= =?us-ascii?Q?A0fgXs+zgE6m/SXckmRgfG30zsKPKZC5RJwl4rsqGXLS/lp1MbWILWvaVIqr?= =?us-ascii?Q?BEavh6AdPog+F1IElJ9ChUMr69iInamc6myymCA1FIuibDjBAYKCEtlcfQ6Q?= =?us-ascii?Q?KBLQrVF4FG0+EsrxMusu6mjV50ENsdjfvs9EOdtsV4xk7o0Z4SiF6tEDvHLj?= =?us-ascii?Q?hUeLcgRbDFeDDMgGRC+QFVQOs8/Vz31uKRhI2Q9s4JZFQwmwmzzKJsMwEiT4?= =?us-ascii?Q?XZLJMsnGTbhsQVlELcPqwuUdilD/xSQiCNCeTPevaK7sAEb7MMtIuSCgxnpd?= =?us-ascii?Q?gb5FIAVT7TcQ43FOF8/ArTKUfJX3cOC07Xw+p66o?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81bfd380-b044-4062-7d10-08dab8098101 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 10:53:38.4608 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eN7CZpisffRXXuv3RsO83DkV0G0P99adevHrudkGy4pPc4X5b3OTNhvSOH9mVs/FL25Fnx+3SuTNqJLnX54JAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3884 X-Proofpoint-ORIG-GUID: HQ0Gvf81jHL4XYHEdinthAbvWdSX_FDO X-Proofpoint-GUID: HQ0Gvf81jHL4XYHEdinthAbvWdSX_FDO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-27_05,2022-10-27_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. >=20 > UADK is a framework for user applications to access hardware accelerators= . > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > the same page table between IOMMU and MMU. > Thereby user application can directly use virtual address for device dma, > which enhances the performance as well as easy usability. >=20 > [1] https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__github.com_Linaro_uadk&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDn > L7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DAwapMJzvfUDL49W9f > mtmvIGZMarGUdjRSliBhG4tep6Uh5wN2zYrZRJ4JpbrVolg&s=3DMxSabEjMMkeRr0L > Z7c1gSmaJmJ1_dIdJIKrst98pKzk&e=3D >=20 > Test: > sudo dpdk-test --vdev=3Dcrypto_uadk (--log-level=3D6) > RTE>>cryptodev_uadk_autotest > RTE>>quit >=20 > Update in v7: > 05: fix key_size of SHA384 HMAC >=20 > Update in v6: > Akhil helped review the v5, and address all the comments from Akhil > 01: add rel_notes info, update uadk.rst, put struct in header, etc. > 02: move struct to header > 04: move struct to header, remove RTE_CRYPTODEV_FF_SYM_SESSIONLESS > 05: fixed key_size in HMAC mode > 06: updated app/test/meson.build and uadk.rst in the mean time. >=20 > Update in v5 > Patch 1 fix the build issue when uadk is installed to specific folder > And update doc accordingly >=20 > Update in v4: > Akril suggest dpdk use pkg-config, So > Enable uadk support x86 local build, and support pkg-config. > Use pkg-config feature for the uadk crypto pmd. > Add build uadk library steps in doc > Test on both x86 and arm. > x86 can build and install, but can not test since no device. >=20 > Resend v3: > Rebase on next/for-main, which just merged the series > "cryptodev: rework session framework". >=20 > Update in v3: > Split patches according to Akhil's suggestions > Please split the patches as below. > 1. introduce driver - create files with meson.build and with probe/remove > and device ops defined but not implemented. > You do not need to write empty functions. > Add basic documentation also which defines what the driver is. > You can explain the build dependency here. > 2. define queue structs and setup/remove APIs > 3. Add data path > 4. implement cipher op. Add capabilities and documentation of what is > supported in each of the patches. Add feature flags etc. > 5. implement auth, add capabilities and documentation > 6. test app changes. >=20 > Update in v2: > Change uadk_supported_platform to uadk_crypto_version, which matches > better > than platform. > enum uadk_crypto_version { > UADK_CRYPTO_V2, > UADK_CRYPTO_V3, > }; >=20 > Update in v1, compared with rfc >=20 > Suggested from Akhil Goyal > Only consider crypto PMD first > Split patch into small (individually compiled) patches. > Update MAINTAINERS and doc/guides/cryptodevs/features/uadk.ini >=20 > Zhangfei Gao (6): > crypto/uadk: introduce uadk crypto driver > crypto/uadk: support basic operations > crypto/uadk: support enqueue/dequeue operations > crypto/uadk: support cipher algorithms > crypto/uadk: support auth algorithms > test/crypto: support uadk PMD >=20 > MAINTAINERS | 6 + > app/test/meson.build | 1 + > app/test/test_cryptodev.c | 7 + > app/test/test_cryptodev.h | 1 + > doc/guides/cryptodevs/features/uadk.ini | 55 + > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/cryptodevs/uadk.rst | 96 ++ > doc/guides/rel_notes/release_22_11.rst | 6 + > drivers/crypto/meson.build | 1 + > drivers/crypto/uadk/meson.build | 30 + > drivers/crypto/uadk/uadk_crypto_pmd.c | 1081 +++++++++++++++++ > drivers/crypto/uadk/uadk_crypto_pmd_private.h | 79 ++ > drivers/crypto/uadk/version.map | 3 + > 13 files changed, 1367 insertions(+) > create mode 100644 doc/guides/cryptodevs/features/uadk.ini > create mode 100644 doc/guides/cryptodevs/uadk.rst > create mode 100644 drivers/crypto/uadk/meson.build > create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c > create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd_private.h > create mode 100644 drivers/crypto/uadk/version.map Series Applied to dpdk-next-crypto Welcome to dpdk. Thanks.