From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E53D42B89; Wed, 24 May 2023 09:21:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4459940ED8; Wed, 24 May 2023 09:21:40 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 7B2B64067E for <dev@dpdk.org>; Wed, 24 May 2023 09:21:38 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34O4qHDM025077; Wed, 24 May 2023 00:21:36 -0700 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2046.outbound.protection.outlook.com [104.47.57.46]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qsbxerghs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 May 2023 00:21:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jrq6thrl4L0ITak8v18WkUD0iiHl7TiwxlEkVXqToV+lrVRnlQddVwg5pcPj/myH1GKgBxadg5HokZG3AIoT7EvHwBViDuLeM7X+Qopjp4au+Qpt4t+UMHlNn7HFPXKd+L1MUyb5ndj27BWyMG7OySSTz5aSYlQerWVCynKaLe0r96TRQ48MO6OHHwgtJ6s2YHDwq91M61k425xaEwlHQoWhpOV88m6XMLlHOXB5Oew7rNp8MtTwaQUqSRdxcbCVOgYo9YeEN/ABxeej8r22J09h34nPVScs0vM2AmDu+fX6IEXFt/at52WxsI1BH8B1xiPZ5xQlToj9WiIAvk2EZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QeNuaP8nNpgZfrA+auObsAqKedhveJ5C8zmt9fh+Tn4=; b=F44Qp/ev5xfWCWjttD3oJBFzO2/Zllx/BOF/9ub1JU2uR4FfTCc/nfuPZnXQnb6gd6hSuA9OK09ErvmgDBN0OjTMDDHI7+F2AAgCEzPD+FszOaNXqLzACynM7ms28aQuHSpSaaveJJmhgGkqGPxFQaBC0cMec2cncNe6/re+L86kbx+YnIMn1yqtsr4s/cIlcP8uuDEZDFw2lny2WgQ/6qu9GvMJVe1DA2kvo4JmYS47EIjw3wKfC9LN901gRAc/LR4c2KkzxYHkvfgQ59NOqoT4qi104d21E5+fakneyKlyU1JurgBp+xiBs1aV4VEvNpYxfQhorXCzPtTicEj8pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QeNuaP8nNpgZfrA+auObsAqKedhveJ5C8zmt9fh+Tn4=; b=jHWqRyWhhkHtSHN3AzJerT2xs/Xp4MNMa/kfg+GWYsxtuypgBfEb6SSMZxfREKy86yME2B8NsthCyNnw3gUhZGvWmNn3n6V9YhoCZc+d9ho42045aIwJYwGBF2f+tJIIzOEIeHL13N1ayXJOHtrshSHriTnREt28065vEd/Y4Is= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MW5PR18MB5151.namprd18.prod.outlook.com (2603:10b6:303:1c9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 07:21:34 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::831b:85d2:9a45:8489]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::831b:85d2:9a45:8489%6]) with mapi id 15.20.6433.013; Wed, 24 May 2023 07:21:34 +0000 From: Akhil Goyal <gakhil@marvell.com> To: Stephen Hemminger <stephen@networkplumber.org> CC: Kamil Godzwon <kamilx.godzwon@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Fan Zhang <fanzhang.oss@gmail.com> Subject: RE: [EXT] Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning Thread-Topic: [EXT] Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning Thread-Index: AQHZjPPnXz6FYqq4eUK5FCVob4XvMK9ngCSggACFXICAAP9RkA== Date: Wed, 24 May 2023 07:21:34 +0000 Message-ID: <CO6PR18MB4484DE31873042EC3059A74BD8419@CO6PR18MB4484.namprd18.prod.outlook.com> References: <20230522184951.452626-1-kamilx.godzwon@intel.com> <20230522190453.453281-1-kamilx.godzwon@intel.com> <20230522142510.3952adc5@hermes.local> <CO6PR18MB448402F53FD93D86F66D6EBCD8409@CO6PR18MB4484.namprd18.prod.outlook.com> <20230523090033.145f635b@hermes.local> In-Reply-To: <20230523090033.145f635b@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcZ2FraGlsXGFw?= =?us-ascii?Q?cGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0YmEy?= =?us-ascii?Q?OWUzNWJcbXNnc1xtc2ctOWE2YWEzYTgtZmEwMy0xMWVkLWEwOTMtOTRlNmY3?= =?us-ascii?Q?NjYxOTA3XGFtZS10ZXN0XDlhNmFhM2FhLWZhMDMtMTFlZC1hMDkzLTk0ZTZm?= =?us-ascii?Q?NzY2MTkwN2JvZHkudHh0IiBzej0iMTU3OCIgdD0iMTMzMjkzODY0OTExMjMz?= =?us-ascii?Q?NzA5IiBoPSJqWG83RkduaDF3VCt4ZWRmVFZyZFhZejhDQUU9IiBpZD0iIiBi?= =?us-ascii?Q?bD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFONFBBQUN0?= =?us-ascii?Q?NHNWY0VJN1pBZm54U3h2ZlUvWisrZkZMRzk5VDluNFpBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBSEFBQUFCdUR3QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?RUFBUUVCQUFBQUk3cVRwQUNBQVFBQUFBQUFBQUFBQUo0QUFBQmhBR1FBWkFC?= =?us-ascii?Q?eUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFF?= =?us-ascii?Q?QUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFGOEFjQUJs?= =?us-ascii?Q?QUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFB?= =?us-ascii?Q?QUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFB?= =?us-ascii?Q?RzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFj?= =?us-ascii?Q?d0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlBTUFBeUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01B?= =?us-ascii?Q?ZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4QWNnQmtB?= =?us-ascii?Q?SE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFY?= =?us-ascii?Q?d0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VBY2dCZkFI?= =?us-ascii?Q?WUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFB?= =?us-ascii?Q?QUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1QUY4QWN3?= =?us-ascii?Q?QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFH?= =?us-ascii?Q?UUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFC?= =?us-ascii?Q?ekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3?= =?us-ascii?Q?QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFI?= =?us-ascii?Q?UUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFC?= =?us-ascii?Q?c0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFB?= =?us-ascii?Q?QUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJ?= =?us-ascii?Q?QVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFRQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFD?= =?us-ascii?Q?ZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISUFid0JxQUdVQVl3QjBBRjhB?= =?us-ascii?Q?YmdCaEFHMEFaUUJ6QUY4QVl3QnZBRzRBWmdCcEFHUUFaUUJ1QUhRQWFRQmhB?= =?us-ascii?Q?R3dBWHdCaEFHd0Fid0J1QUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFHRUFjZ0Iy?= =?us-ascii?Q?QUdVQWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QnVBR0VBYlFCbEFITUFY?= =?us-ascii?Q?d0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQUY4QVlRQnNBRzhBYmdCbEFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVB?= =?us-ascii?Q?QUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUY4QWNBQnlB?= =?us-ascii?Q?RzhBYWdCbEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFISUFaUUJ6QUhRQWNn?= =?us-ascii?Q?QnBBR01BZEFCbEFHUUFYd0JvQUdVQWVBQmpBRzhBWkFCbEFITUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFB?= =?us-ascii?Q?QUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUdFQWNnQnRBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refthree: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlB?= =?us-ascii?Q?QUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFad0J2QUc4QVp3QnNB?= =?us-ascii?Q?R1VBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHMEFZ?= =?us-ascii?Q?UUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQVl3QjBBRjhBWXdCdkFH?= =?us-ascii?Q?UUFaUUJ6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBYlFCaEFISUFkZ0JsQUd3QWJB?= =?us-ascii?Q?QmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QmpBRzhBWkFCbEFITUFYd0JrQUdr?= =?us-ascii?Q?QVl3QjBBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFB?= =?us-ascii?Q?SUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QWNBQnlBRzhBYWdC?= =?us-ascii?Q?bEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFHTUFid0J1QUdZQWFRQmtBR1VB?= =?us-ascii?Q?YmdCMEFHa0FZUUJzQUY4QWJRQmhBSElBZGdCbEFHd0FiQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcw?= =?us-ascii?Q?QVlRQnlBSFlBWlFCc0FHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFGOEFiZ0Jo?= =?us-ascii?Q?QUcwQVpRQnpBRjhBWXdCdkFHNEFaZ0JwQUdRQVpRQnVBSFFBYVFCaEFHd0FY?= =?us-ascii?Q?d0J0QUdFQWNnQjJBR1VBYkFCc0FGOEFid0J5QUY4QVlRQnlBRzBBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFB?= =?us-ascii?Q?QUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpRQmpBSFFBWHdC?= =?us-ascii?Q?dUFHRUFiUUJsQUhNQVh3QmpBRzhBYmdCbUFHa0FaQUJsQUc0QWRBQnBBR0VB?= =?us-ascii?Q?YkFCZkFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCdkFISUFYd0JuQUc4QWJ3Qm5B?= =?us-ascii?Q?R3dBWlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdV?= =?us-ascii?Q?QWJBQnNBRjhBY0FCeUFHOEFhZ0JsQUdNQWRBQmZBRzRBWVFCdEFHVUFjd0Jm?= =?us-ascii?Q?QUhJQVpRQnpBSFFBY2dCcEFHTUFkQUJsQUdRQVh3QnRBR0VBY2dCMkFHVUFi?= =?us-ascii?Q?QUJzQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFB?= =?us-ascii?Q?QUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QndBSElB?= =?us-ascii?Q?YndCcUFHVUFZd0IwQUY4QWJnQmhBRzBBWlFCekFGOEFjZ0JsQUhNQWRBQnlB?= =?us-ascii?Q?R2tBWXdCMEFHVUFaQUJmQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J2QUhJQVh3?= =?us-ascii?Q?QmhBSElBYlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNl?= =?us-ascii?Q?QUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhRQVpRQnlBRzBBYVFCdUFIVUFj?= =?us-ascii?Q?d0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJB?= =?us-ascii?Q?R1VBYkFCc0FGOEFkd0J2QUhJQVpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFB?= =?us-ascii?Q?QUFBQUFBQUFnQUFBQUFBIi8+PC9tZXRhPg=3D=3D?= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|MW5PR18MB5151:EE_ x-ms-office365-filtering-correlation-id: 99693994-83c5-44ca-ba00-08db5c278110 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fyjBTwMq61EZAZmMSmSIHqNy8b/mP2daySqCl8NwVfKA42ao7ciK1TQGjWyyBKyIWef0PXKXSvdBf50gitgccxgfB1AclOH2lO6IVOhcfZfR+EnSUVYpqi8GBoLwKEqHIg2tEFp6Tih2xCnB4J5OhVSb2oWuB/u+VJnXVLozkHYnK0FogiKdiRtz7DcLRXgBvuo/X9JOc8QoKBW1KGDMtxCPUais+UvPOUHhsdsiaW+Ek3bj/ljZzpMceGSHJF0ZFVx/TW+7JrQCRsmTzLaWsww4KXlg2RbYEyTINyvavwBYpfrv1Xk80dm2dUoWcRSaRiXPfPPLx47ZAclLXmNCqMoqm+HxEL9AqJAUYuDrVfPvXkdMKN1lfWnEaE0akStBBqJ9oajZT9AzxRxlk7DSDwQ7ekv/R9+QiAde447snMGOL0+zgwSPaVjCUYAjBtnEH8JFmo97ZwsMnf0b8F14GwiaKXHhFQuuwWQ9ze9TcN2ve/5rgHcyxAxaY1Gh+90AdgJdPdMzMP5kKXOnYxGpf7Ad0L+N9imu8ApOdVykyxtWjXVp980iMosfgQK+1Bl74LXb62d1ZvKcE4wx94CirWrOFdHEUlZK2bM4t2K84HqzkkUqj8kHX6Sb0Z9aw9Ey x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(366004)(376002)(39860400002)(346002)(451199021)(66946007)(66556008)(66476007)(66446008)(64756008)(6916009)(4326008)(76116006)(7696005)(41300700001)(55016003)(71200400001)(316002)(54906003)(5660300002)(8936002)(52536014)(8676002)(478600001)(38070700005)(86362001)(38100700002)(122000001)(26005)(33656002)(9686003)(6506007)(55236004)(186003)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gWLFwFEvbtrW8VX/GTjvTLt8c0L8bmqEwLlBesrYmxdAeXQcvxemNervzu5E?= =?us-ascii?Q?2nDSt8miV51oavZPGja7avvQ01izqCBbzASnMdeA/aMm0NvuD9PQcAqKm/Wt?= =?us-ascii?Q?0MFrdtybrR7B5CUiff7yAY68zJ+1Srin0WHEYL2CFEgDZ+tryS7b3WsKLLN1?= =?us-ascii?Q?JFfTC5ovVZLU2aZVm/Wk+HIKKTrn+u2Oy+3BaCUByc3e1RurgLfoelv/k8ty?= =?us-ascii?Q?1rcf2amuLrAOwL1T4+CwP8wmJzOYu4bC2hYImyVdf1gjTgtaSwdhKka3LXOs?= =?us-ascii?Q?XINygLPRSxT4wfsmbPnB2fWGmdEs+xayPwCw71xtxycxrRe/MTJk+NBqqIAj?= =?us-ascii?Q?JfoIuH5QjMvTybiDcIeFmYK4K3WPNCBARcnY7Ccq06ZcAw8dnnW0itvyCPU0?= =?us-ascii?Q?0K7EpNZJhKN298sH2nE+0Jmwwi7AFIT38X1w8QoPMd+jsxpRox3AbfFXJfwZ?= =?us-ascii?Q?caVSpyd7YIo0dJTXsd7dflSNNsekCoYVZ3xceizrQWRCyvsoEdJ87uFjPUFd?= =?us-ascii?Q?DRPn0b3gVh2T5DBHZeUDh2BsZv+C/Cn9UvhtRNV9ORH+Nnfh6sws2uDJtJ/2?= =?us-ascii?Q?wkainj9UPPk32BxqbDlDB/v1LR7ncse/0TdYOT3kHat7w9tAfYC5FXAWoQLs?= =?us-ascii?Q?raOdrVe0Rc8uBHZ+q6dn+PZOidc4TeGqtREO7BiycqqnQ+K7Uxe/zn9HRBb6?= =?us-ascii?Q?G0eZIHkNpv1sBqO/nWleY2GUlnyAJ/52gwqmzJpezAlytDJCiShbShzMLjDp?= =?us-ascii?Q?vtJr41WxueXQzrvk8MoFLnbU7j1cn6HMQVrQqnCv8SE+HVqc5tu9Q/H9t9WV?= =?us-ascii?Q?4qN40lasyuU6neanyIDm8uTWwWr2hOU5sgDGCkzD4AJlnRn9JxrwHLnAdGfD?= =?us-ascii?Q?qLz0kkjAwbTPoUhf4OuFZ96rcnglRVX68qxzsFLuJic4QNnArlqnSbvNhLFe?= =?us-ascii?Q?LmOsBiQSKAQxY7qIe2tiFsfk8WXnsmXEI0SMNPgFH8J3bUPGPCj/zqBckhWj?= =?us-ascii?Q?r0af8BshJjq4CwijZ9w5Iogpo9ARJs8BwEIxCn+Ch+DynJk+SjmDlAe/FL3E?= =?us-ascii?Q?VghhbDxEF00WnjNLU0eAsWpCiURir9LJ9q8XD4yhoUfN0s+SrRY8Sc5IZi+x?= =?us-ascii?Q?2P+++yX/H+k4Ttn+qnaPqUg0rmFGJiruylBOUT02Dlsu03bKIUG8Urnn8gvP?= =?us-ascii?Q?nCudoZqIpJ+0T8hduPxiu5qHEpoVgb3EneB8Qzra2oLUFEX2qKues+m7PWBM?= =?us-ascii?Q?LePaxNkdF1GAtSDu4drSXVxpdL24fmNhiSAPvwS3SutvcQBDECtzuAZzTZMD?= =?us-ascii?Q?3OhQItSc4pxLBCI/9aG7S+rRQrCuY+ulMtjyXIHyRwafzqJjE9Vss8XzfZle?= =?us-ascii?Q?Oz5qP/U5UDY5Xl2XcBSekOP610t7kO8VEDBcZkcsqDj+nS+TSDHidfhbNjnT?= =?us-ascii?Q?MzY515IgKAPSHa3rrD8e4cfJYXDYQyU325bkpkPXCPCEElPCSmxctLG1u6xM?= =?us-ascii?Q?n7jkAX48wv40IXaJfHLuc0jYKhMX8lJTlNL0whdAAGAd6cplSm9Al9GDcOuU?= =?us-ascii?Q?SWRR8gYLH63OoU1pbJjVI2HvKVCJaq3ycdY8qJV3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99693994-83c5-44ca-ba00-08db5c278110 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 07:21:34.1557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iB2bVAQXlIyCiUJaPpzcM+Y7tQyIYVnYIr/p6Uunlw61dVlE8XjOZ9KxlSrYDdHWll3J3qknNIbWbVv85JWhCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR18MB5151 X-Proofpoint-ORIG-GUID: mg1f6cJ0kd7tNJuXJ5WjI9W8rfo6JFsF X-Proofpoint-GUID: mg1f6cJ0kd7tNJuXJ5WjI9W8rfo6JFsF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-24_02,2023-05-23_02,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > On Tue, 23 May 2023 08:12:28 +0000 > Akhil Goyal <gakhil@marvell.com> wrote: >=20 > > > > > > This could happen if the passed in length to this routine was larger = than > > > the amount of data in the mbuf. Should the function check and return = an > error? > > > > > > Panic should only be reserved for seriously corrupted input (like inv= alid > mbuf). > > > > > > Also, this is a big enough function that it really should not be inli= ned. > > > > This is a datapath API. RTE_ASSERT is normally not enabled in release b= uild. > > So, this assert is not doing any check for normal scenario. > > We normally avoid these type of error checks in the datapath. > > And while building in debug mode, we need these asserts to give a backt= race > also > > To debug the rootcause of the issue. > > > > I would suggest fixing the assert itself instead of adding a check. > > Current patch will affect performance. > > > > Agreed, that the function is big for being an inline function, > > but that is what all the datapath APIs are and > > we keep them inline to improve the performance. >=20 > Inline is not a magic go fast switch. Turns out that the compilers and cp= u's > already do good job with functions. Using LTO helps too. Inline perform better in cases of small functions. For big functions like the above one, it may not be much beneficial, but it won't cause any harm as well. Yes, LTO can be explored. Thanks for the suggestion.