From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54F84A0C4E; Thu, 22 Jul 2021 09:46:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D19304014D; Thu, 22 Jul 2021 09:46:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 671BB40040 for ; Thu, 22 Jul 2021 09:46:04 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16M7eUka010832; Thu, 22 Jul 2021 00:46:01 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by mx0a-0016f401.pphosted.com with ESMTP id 39y25bgfx0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jul 2021 00:46:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TxB4jkcm4Hoat0Ecyoqter7+uAmKoOz2oEFaOyUEmtBxGo6AVWQ/tQGEmtDIMZFdIf/I+ppantX2DdoxYpe8RL3qwOlqIvn/YHxzSu7LEKY7bTjqjrTDktPLS0Tfu9cC23sz0nOhdtNNIUXE1eSEY3IVx9pkCIc2OTsb5C9RkR5s5ybIPdjWL+02jcb3oWmVtNBYj2pUdQTk13S/oNq4sTifh/dCd+QkP0KYLq57f5OvI5N717B2/ch+5wi54sarq17x3gwbTkJ371kr4vphTedNb0h2dt5kZ9EWLrKp/7oxjO6BQPy09zDxvLlm/Op1ZLtSEzji+gApszDN6jY9uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A1cRJRFCp+pSCtNG260waIOtf9v+BNo3YV9mH/eHjaA=; b=NBEC9T1FruIkUIWE6oVzHvroL7KNb/bneBUsh9efAaSholl7KSKpkPbph9oA0OPzJT6bvRkIvAMlmFcxPYZFER2XT+6REM2qYGftpgnHEJj0Y/l3uC3e2woRvVIQV+ZfJzaaKLdnvlQYOMiKlhIgVff4qdujiznl4WLer69ghqUVdU2H70KdXAA0MdGE27gWSb6MoI9gMyUFr1HmkEQJ7/e7hBLrwRR6MATSLGtMhlCtT0W6rKwc3y0BjSEjzh1ezy0ggwbsHpgjxgZC6+wzHaA5goLduvCEwQYW/P4Ts9IKYaTWNwcl0eBXnKOeoQnCNKM7imOO1/qbJQ9YftqayA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A1cRJRFCp+pSCtNG260waIOtf9v+BNo3YV9mH/eHjaA=; b=NtkcFlGbgZ5N1s4pBS9oWl0/1uBQwKmWegL8FSOGc8ctBoQjocjIYT143XKWTUmo90M+6Ukpy/XLn7vBt8IXxxhiBy/rGNXRn6X6weRQFXPJjHwQIybBm6MmYo21cseeWKzKgj9cX5VJ233GEdM4ueMlR7Bi7v7QCXagE0nt/ZA= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4468.namprd18.prod.outlook.com (2603:10b6:303:13a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25; Thu, 22 Jul 2021 07:45:59 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%7]) with mapi id 15.20.4352.026; Thu, 22 Jul 2021 07:45:58 +0000 From: Akhil Goyal To: Thomas Monjalon , David Marchand CC: "dev@dpdk.org" , Ray Kinsella , Pavan Nikhilesh Bhagavatula , Anoob Joseph , Abhinandan Gujjar , Ankur Dwivedi , Jerin Jacob Kollanukkaran , Aaron Conole , dpdklab , Lincoln Lavoie , Shijith Thotton Thread-Topic: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework Thread-Index: AQHXfhT3GAcE6pE4tUmIb02Tp6UnlqtOni6A Date: Thu, 22 Jul 2021 07:45:57 +0000 Message-ID: References: <6005170.NIlMa9dU7d@thomas> In-Reply-To: <6005170.NIlMa9dU7d@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b731b7a5-8770-4896-0c42-08d94ce4be83 x-ms-traffictypediagnostic: CO6PR18MB4468: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S44Xso3Nk7G/A6jB9XtgAr4IUq9K+8L77esUGM/ns49oZdgXq5ZiBFLsvFeUMzJkgAjV6qDxXpIJEeVI5HSZHfmR7jQzqY1ihpMEo/b8GeNvcH/uF5z0ybdJQscpXqzFWMXH6geOWAlMd4Sen3LtTeiyAdWObqLtZ0iMGwNVItrn/Z1HcyV6ivg1dCVhFt7UoqQXdX6sBbJC1i2reOEzuSDQlBB48OMVKz1DArw18uz9KzRAu4aMIx/MMBEvKHzDPMmWImTLvTdADdF3rv6ke6dRg7di1vtCdJkxM/vO0Vokmj6yPoIWR8FkB/jd+nlwb39towstCRNz0azEo271EAPCSzg55v0VMFAd81Yuv8fC58ZiiER6vac5W7Pp6AShHPmaBxQXTUhAiY5YFVevbpCGoZvzVFwiFbv2HptOkw/+pIZbWpGrBmk+xPDXX20l8wChnjndMj6pZZyvRSsTuC2xL4+1sZx7IDO94lLJ+6QS75Kc0dDunfcfuNbcvKda97Y3BRxgN8RzJ0QehhIXYgm1ITX/vgcyOeLRWFKYDQiH2429om3W8G+NYyoCgQ5w19fizzAKOkvblzqxvGqj2JvR0azaZ6E0q6BFPp1Phjsk9Z/duRxc3p5/6LcJSzj3of+t4W19tyarPNiwz3GjqEx76/jJDfk9r3RKRxFg7gnbXAAS4GesqEwvXrS8vZ0ffyur61pLrwk8Ko3RKW5MAALq/ig5kqcNcnuP4CCt2mAYzXz9PrfEqqEmsjAF3FrQgOOsIR8UPH32vA1yWsDvIGjr/5y4eU1IW/IYijfPIT5+ioIajd5q8r6wQ3bNajtm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39850400004)(396003)(346002)(376002)(33656002)(9686003)(19627235002)(107886003)(8936002)(4326008)(38100700002)(26005)(2906002)(122000001)(71200400001)(110136005)(966005)(316002)(55016002)(186003)(5660300002)(66476007)(54906003)(64756008)(66556008)(66446008)(53546011)(6506007)(478600001)(76116006)(8676002)(86362001)(7696005)(66946007)(52536014)(83380400001)(55236004)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DuIdEyjIoiFKxU7jGKv9xVZ5TZneaR2ugqI222wMTJv07gy2Kx1Iul/DzUOp?= =?us-ascii?Q?Agcuy1QGzNO8BfmSTZcsPf8zPiYa16ey4X8sVsQxDfbiHesoZQhltcl0v+ZK?= =?us-ascii?Q?I5KDofAlAYOw4R81HzthFJ9dcYH7RNri9+UX+BTS6sF8reKnjDPq/dxyb7Rn?= =?us-ascii?Q?Bwx/kcfss8Hqj8xN3DrHA3sEUcF1eKoCGJxP1wcC56pTneMfzE3LVVUmdNsu?= =?us-ascii?Q?gEPAEz+T0EIdbu7ZTp702ve/xD3S6VAmOcvwThLMMIAszlXLfikcn1M61glZ?= =?us-ascii?Q?hNoUe9ZLlzLEFDqCXc4sZnsEMZYmzVwE/xl2Td/WfIT0giDdt9jMIZv3ztEe?= =?us-ascii?Q?JWf4hWRrq+mfiRRxtaPI8fX2sReYpN0Qt/2bAkLhxkcOc7WE4HjeYcg9B6Rq?= =?us-ascii?Q?tmdWxqv67oyJXYbgI/Q9r8j7Yrp44IWo4rzK3wYIMct5QX7yTa9Wsn9F3esd?= =?us-ascii?Q?fTPQ5eHNKkwsoo+aN/oLVdvEtcGdBC/+/llNhc1YYNq2t5BLT4oKKmBfH79h?= =?us-ascii?Q?PSv6OEaM/vGrUlQ8ylzE1T+7FOWIMz3+KhEvhYaY1TSWYIVrltqUUTC7Qhlt?= =?us-ascii?Q?d9p56fYmJhx3IMRWglRSOUvOZTqt0Gsfb5aRwq/+q7gmuDKETSI4EkEV2gRV?= =?us-ascii?Q?2Fld1ix3hLNgTLdWYubQb4TVWASfYuZv3Tf0kbW2BHrY96QYjWHlhD+Z3oNG?= =?us-ascii?Q?+LXhcEhX+RA9mQCXVxNFqZTvEUx0EvxWdBWGvkq0ljEzs9nxVRM9+G1jjslC?= =?us-ascii?Q?ZaAr4t+aSUixa4OAbV9RqVYvDf636ldjHMWxPZiPuji+jQErczALO+w2Pp5I?= =?us-ascii?Q?ts925Lnj4QBLgkMmY3OCZYxO2IhaDmSkarhEH8RX9G58uzbD1UcQjQ87A6Oc?= =?us-ascii?Q?FMchIaR6GEBEgYjxSjvZkdRM/Ek408f5fvutMrZ2BYcyPhEG4SJjmjZ2K10T?= =?us-ascii?Q?f9MA9nPLF0GnbVhSLCODV5Je0rshmQR0ZGz0wjcxx2i6TYS89YVCle4ZkePJ?= =?us-ascii?Q?nD0S2nQP8cYX0Z4DRJw9kJvVxr5mSVtlM0z/QOm7dWQjERmSOY8bodbSXE/R?= =?us-ascii?Q?7t2XHCB/c427SWWSN9jQAbjqBJMNbbNJ4mc/XRpQpyIK6N+RcJe2UE2Ye6mU?= =?us-ascii?Q?la3P8mE7ibCQd5pwKrjK/uJ+Do4UXRWh2Q+YXN2m77vRCIFo0fIMj0ZcStTM?= =?us-ascii?Q?NlrvmTCS8YtlNnAZDXsfA0gPhJa/tZMoct2TpoUfM5NAB5arqsT6wNtQ4VAC?= =?us-ascii?Q?Uf5w1r8HFkP+wHomORa5Eil25lPCVhc11131MA8lX5gMCq/kQshjeB4fPCTb?= =?us-ascii?Q?3Qra6i1HOnC77icvKHGYVmmY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b731b7a5-8770-4896-0c42-08d94ce4be83 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2021 07:45:57.9441 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /B3+cCJ6yiW7EPTO4GSye0cuPg2zKdsr9H+FY+rcEGNAgZLb7vHjJUXJNvn0NBviIWcHwmiV0exTGy71EYlEqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4468 X-Proofpoint-ORIG-GUID: Lh-L98TVb7pdfhLLJOx2OIgm9EtBHaJk X-Proofpoint-GUID: Lh-L98TVb7pdfhLLJOx2OIgm9EtBHaJk X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-22_03:2021-07-22, 2021-07-22 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 20/07/2021 14:14, David Marchand: > > On Tue, Jul 20, 2021 at 1:59 PM Akhil Goyal wrote: > > > > > > Hi David, > > > > > > > > > > deps +=3D ['common_octeontx', 'mempool_octeontx', 'bus_vdev', > > > > > 'net_octeontx'] > > > > > > +deps +=3D ['crypto_octeontx'] > > > > > > > > > > This extra dependency resulted in disabling the event/octeontx dr= iver > > > > > in FreeBSD, since crypto/octeontx only builds on Linux. > > > > > Removing hw support triggers a ABI failure for FreeBSD. > > > > > > > > > > > > > > > - This had been reported by UNH CI: > > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttp- > 3A__mails.dpdk.org_archives_test-2Dreport_2021- > 2DJune_200637.html&d=3DDwICAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2 > wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DzikYn88P- > Q3H517Go0NWLsokSeUCheJhQyY-Rh- > DAWQ&s=3Dv6vmJJNBDxjoA81J4rpuxvgPhR8DCT6qizgAkXauZIY&e=3D > > > > > It seems the result has been ignored but it should have at least > > > > > raised some discussion. > > > > > > > > > This was highlighted to CI ML > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttp- > 3A__patches.dpdk.org_project_dpdk_patch_0686a7c3fb3a22e37378a8545b > &d=3DDwICAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2wl_PRwpZ9TWey3eu6 > 8gBzn7DkPwuqhd6WNyo&m=3DzikYn88P-Q3H517Go0NWLsokSeUCheJhQyY- > Rh-DAWQ&s=3D68Xkwo5J0d3BngYD0gxM0JKIgDzd58pypXyJrprGIgA&e=3D > > > > c37bce04f4c391.1624481225.git.sthotton@marvell.com/ > > > > > > > > but I think I missed to take the follow up with Brandon and applied= the > patch > > > > as it did not look an issue to me as octeon drivers are not current= ly built > on > > > > FreeBSD. > > > > Not sure why event driver is getting built there. > > > > > > > > > > > > > > - I asked UNH to stop testing FreeBSD abi for now, waiting to get= the > > > > > main branch fixed. > > > > > > > > > > I don't have the time to look at this, please can you work on it? > > > > > > > > > > Several options: > > > > > * crypto/octeontx is made so that it compiles on FreeBSD, > > > > > * the abi check is extended to have exceptions per OS, > > > > > * the FreeBSD abi reference is regenerated at UNH not to have tho= se > > > > > drivers in it (not sure it is doable), > > > > > > > > Thanks for the suggestions, we are working on it to resolve this as= soon > as > > > > possible. > > > > We may need to add exception in ABI checking so that it does not sh= out > if a > > > > PMD > > > > is not compiled. > > > Can we have below change? Will it work to disable compilation of > > > event/octeontx2 for FreeBSD? I believe this was done by mistake earli= er > > > as all other octeontx2 drivers are compiled off on platforms other th= an > Linux. > > > > > > diff --git a/drivers/event/octeontx2/meson.build > b/drivers/event/octeontx2/meson.build > > > index 96ebb1f2e7..1ebc51f73f 100644 > > > --- a/drivers/event/octeontx2/meson.build > > > +++ b/drivers/event/octeontx2/meson.build > > > @@ -2,7 +2,7 @@ > > > # Copyright(C) 2019 Marvell International Ltd. > > > # > > > > > > -if not dpdk_conf.get('RTE_ARCH_64') > > > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') > > > build =3D false > > > reason =3D 'only supported on 64-bit' > > > subdir_done() > > > > I did not suggest this possibility. > > That's the same as for other octeon drivers, such change has been > > deferred to 21.11. > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__patches.dpdk.org_project_dpdk_list_-3Fseries- > 3D15885&d=3DDwICAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2wl_PRwpZ9T > Wey3eu68gBzn7DkPwuqhd6WNyo&m=3DzikYn88P- > Q3H517Go0NWLsokSeUCheJhQyY-Rh- > DAWQ&s=3DA5fHouoeBcH2sL_xt5dtzRwfA8Fq__eBUYc-J9ANBIg&e=3D > > > > > > > > Or of this does not work, then we would need to add exception in ABI > checking. > > > Any suggestions how to do this? > > > > Sorry, no good idea from me. >=20 > We would need to revert the change breaking the ABI test. > But I don't understand why it seems passing in recent CI runs? >=20 It is passing because FreeBSD is currently skipped. Right David? BTW, no need to revert, we would be sending a patch to enable compilation of crypto/octeontx