DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Tejasree Kondoj <ktejasree@marvell.com>,
	Fan Zhang <fanzhang.oss@gmail.com>
Cc: Anoob Joseph <anoobj@marvell.com>,
	Ciara Power <ciara.power@intel.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Aakash Sasidharan <asasidharan@marvell.com>,
	Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
	Vidya Sagar Velumuri <vvelumuri@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] test/crypto: fix IPsec AES CCM test vector
Date: Tue, 16 May 2023 10:18:10 +0000	[thread overview]
Message-ID: <CO6PR18MB4484EED82DAAFFE38229A9B9D8799@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230512125933.1131522-1-ktejasree@marvell.com>

> Subject: [PATCH] test/crypto: fix IPsec AES CCM test vector
> 
> Fixing IPsec AES-CCM test vector IV length.

Please add appropriate description.

> 
> Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> ---
>  app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_cryptodev_security_ipsec_test_vectors.h
> b/app/test/test_cryptodev_security_ipsec_test_vectors.h
> index 2686bbeb62..462cef6785 100644
> --- a/app/test/test_cryptodev_security_ipsec_test_vectors.h
> +++ b/app/test/test_cryptodev_security_ipsec_test_vectors.h
> @@ -417,7 +417,7 @@ struct ipsec_test_data pkt_aes_256_ccm = {
>  				.op = RTE_CRYPTO_AEAD_OP_ENCRYPT,
>  				.algo = RTE_CRYPTO_AEAD_AES_CCM,
>  				.key.length = 32,
> -				.iv.length = 12,
> +				.iv.length = 11,

Add a comment here that IV includes 3 bytes of salt and 8 bytes of IV.

>  				.iv.offset = IV_OFFSET,
>  				.digest_length = 16,
>  				.aad_length = 12,
> --
> 2.25.1


  parent reply	other threads:[~2023-05-16 10:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 12:59 Tejasree Kondoj
2023-05-12 14:02 ` Anoob Joseph
2023-05-16 10:18 ` Akhil Goyal [this message]
2023-05-24 12:51 ` [PATCH v2] " Tejasree Kondoj
2023-05-24 21:29   ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB4484EED82DAAFFE38229A9B9D8799@CO6PR18MB4484.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=asasidharan@marvell.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=fanzhang.oss@gmail.com \
    --cc=gmuthukrishn@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=ktejasree@marvell.com \
    --cc=stable@dpdk.org \
    --cc=vvelumuri@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).