From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E9AB43CA0; Wed, 13 Mar 2024 15:50:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 299E1406BC; Wed, 13 Mar 2024 15:50:22 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 161B0402B8 for ; Wed, 13 Mar 2024 15:50:20 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42D9WgO7022020; Wed, 13 Mar 2024 07:50:20 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2040.outbound.protection.outlook.com [104.47.56.40]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wu9kvs1pn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 07:50:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gozrUoYnHgedtG5rm1w3uOOh82oIdpawScFs5pGw7w7JtJ903H7z0vOwWB9qitSsABwG44lATbFz3gl4F56YE5MXwSH7O9xYUbQzlBeXtLQFgUTiGRbEEDu1eAhVEouk2fBbEeH55vRoypll2ywznc2bSR9uWnXbVtuarGlizhjKS9Mnqki6bdgmAW2e6Lpm/aVTo0MnPNmp4qSe/IMxECe37rI5GhXRaZ2R8Bb90JMYN3UylSUKlTeNtBECDBdN47VSy2mHKmsFgg7swfWDyVBAakBjUpJfDqJ3jHqAf5USxHBTyiIiQGOBVJE8O36WPuQVj1ySLfLaVJQ00dvr6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PHlkAjBru+XGnFpZzS0kAFIrr8VnDdPIRFgsLs534Qc=; b=NepbvBflGq6DLXzn9HgXzhnSQ87ZM6fv6lqMwafuR4ZcQEmgGxyyf4K9jYF01HOrLzoZAL4/TlqyxM99SG0Y9gmJxQuhujy1z98zFizlA5N0Ldzv5pjOA4/dvscXHtR6bGKgz0S3Eina/LbcnJaWBXOdvXON8Qn9UDnzPE8qy+m7ui/FFLhlBNgnoLVW/ktiqYbQjF3uePX/t+XMBe5FPLqxZheisNcnrHcJMQCFZ6m8U9Ic1UF40mFK4kI/FXfqYBeUz7iRH+tN/pS4VjfRfcmMmhxzK9ryiHwR1Bijmyoll7A3kuRD+KYcQyTe2etDM+Oi5SqrqGKbgAu057xhNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PHlkAjBru+XGnFpZzS0kAFIrr8VnDdPIRFgsLs534Qc=; b=qb6O189MJSj+ISX3UrvxDqsDSIhHvC6dt0h0ckKOv20TmIqutTD4P7+lvNOvBukM78L873yZFYqIkhS+UNp6Og5d5Wfb9Frnv1LOHpQe5czo4SWtDZ/ncMOE2ukQWrk+lCeJ4Hql+ZQ/5+75PgQtk4Ksf2fYbKGkCTgtKyGPvTw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SN7PR18MB4046.namprd18.prod.outlook.com (2603:10b6:806:f5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20; Wed, 13 Mar 2024 14:50:16 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149%4]) with mapi id 15.20.7386.017; Wed, 13 Mar 2024 14:50:16 +0000 From: Akhil Goyal To: Nagadheeraj Rottela , "fanzhang.oss@gmail.com" , Ashish Gupta CC: "dev@dpdk.org" , Nagadheeraj Rottela Subject: RE: [PATCH] compress/nitrox: fix dereference after null check Thread-Topic: [PATCH] compress/nitrox: fix dereference after null check Thread-Index: AQHadQwN/Yluw6MuFEGJHZQ0b63XAbE1wVVQ Date: Wed, 13 Mar 2024 14:50:16 +0000 Message-ID: References: <20240313060208.17791-1-rnagadheeraj@marvell.com> In-Reply-To: <20240313060208.17791-1-rnagadheeraj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SN7PR18MB4046:EE_ x-ms-office365-filtering-correlation-id: 1fb6c0a9-8121-40b7-76b4-08dc436ce58b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6ncdyxavlex+Iwso8ZP6SU+uCAP+Krol7xYeACNEWOfsVAkrt7hHbq75Xk/RLIUU3fFI5vTOAkL1YXlDLbSe2YIR0Di1AAc86/f1/2qoqwU91RLDzxk4YlYTrwpsDPBdxh/wo2Tka8sskZv0+wajC4au/Ez83jxktKIlvJVi9MJ7JBnrQnADutXp1DPT85M6XCP5s72QReVKTG8fQ2uxcoIdWK25H7klyt3fUf6itUG6FGaYUogw1qDnv3ZCeVGtjlvTtl5EGQ++lXeGuTTlVXETQtNxFvwQpsrHs9cBmIoP9FbP7Danvyp5uDo0mMWYUACHYq7Uzj9eW1pJB9fhtF2cISpzcK+dNSee9PolNwQzdztuurS8VcznX0Qo8GMtkGCA+FyqTHOSNMlo3xJAjUQS39SEYeJ3/OznYl4/HP46GBnTJETgmq9849mhCtRxk/watLFfFXLIPItmI5K27NMqBHZ29kMnzWJW0B3dUCGX33FEfmMHEOniq3R4Eau6LfGFV41FLh57Q5UvPIfrpJpV1uwHKtmgdWj1EqBYYVIdqFKxzqU4+HeKvGcPC3vuTCQTcufKuajb4Bif89ScZDkSFbYygjn6A09Tm8OIhhW1H+BhezDsrsBJQbPzhwbAn6dPohJlILktlbSEk+wy8D4hQ48igSDzhSz/9gr58/iu1Ub8PleqUJGFczGYAPHA7g8wLadITO8eUHBZUtdoqg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TuvgmW9nw8iMjtuF1pyfqV4qGXF2zaWrVSVzizU9Ci/X1QaCAx1te7uyEJRF?= =?us-ascii?Q?LgSKFF4kodVQnNbgGQKhh64Clcq9/zLJLHw33bJiAwjD2kG6ynYuF1nZXwCc?= =?us-ascii?Q?+gNnqlTg3/YG8loexFZ22rXf8zfimH3ZJbTQp1cWOopTZSJhC/kv4bzgLy+J?= =?us-ascii?Q?UFa2Vyg028Mk/t7xOgEobVjnCZx/zaxaUIoSH73Nx/tUPqUeW9n39aeeG5+n?= =?us-ascii?Q?l5foSKN7oLBV7kd1n8cpY7Q+xZs0komBAhHUU3zTUZU351BgaVo5Uj+S005b?= =?us-ascii?Q?0SAkJouXEPJBIowp0z2PXOJUTNO6EgULLJ0nmXlcmH2gTW1zqwjprBJGIoPD?= =?us-ascii?Q?gGYtUrbKUnSLi9vbyeHmkS12BJWLOs12MyWC62gtUYe9kjjeldhhCA08mEsa?= =?us-ascii?Q?L0Oiq2jt6AOdXBtVKH7u/310CCA6jp12cF9tAJBRXjdIgqyR9RHJi66WNnL3?= =?us-ascii?Q?8IF1tE4x7TK140ZX3ZGD2J3OeWr00HICiTmB+LLU5pWdjIG2e68c4hFbAm2Q?= =?us-ascii?Q?j/K/+1WqDtslxv4ggAkw0l+oWByg21+BHjPC/s8o1kwqoe49MtNB9/dD5G0W?= =?us-ascii?Q?TzRx0tl4YfW4mwBqi6lvL16+Kcz2mml4ihtF2Izx7EDz8xflbQUBgApfrt4c?= =?us-ascii?Q?+DE8MD257oNKUNdYCodxsjTCH2djzL8nCo1Xm22alTe6ZdhHRj11cAbHMXPS?= =?us-ascii?Q?isz49N+Gp0SdCQ1LKzbI+K0o91w3SWkJAbWEssjXPeX0jIu7ak6td01wewuI?= =?us-ascii?Q?VfvIvzdlZvsE+BNiAaZtOYQ3lSoI00SqaDqoSTDfFIAeumKOlIwxIg9771rc?= =?us-ascii?Q?0WqE1/NK23Ec78ZqtmeU7uAk9dw6BPPzg/89/emXqwqNyyNjMa1AyqvH255n?= =?us-ascii?Q?rCF8bnkfrMWt6GM6l+eIc5YkZGk7yb1NIK3hk2g0JdUcE0gGtG8zx+sOamvq?= =?us-ascii?Q?0jCHew6XqYCFTH1lmhsNQlTYANHTxXNcipA/GBo0XhiJIN33Qnygj9z4K+yu?= =?us-ascii?Q?JlyPSuEy2MkdPtsB2Er/TQxD/iLFquk+5M5u8n/Tm2YeanbDrOc8+9rv4XIt?= =?us-ascii?Q?Tagz+LDaKgT6BohZU19WIE9wY0tFgNakuxHehXDjlQ7oPhGtIW9kpIPCe9sQ?= =?us-ascii?Q?fcrtEw/q3XN0wtMybdagRMqX2VqafsrWWTYsl9/fvNPSg/PTn1WXaGTtJwzp?= =?us-ascii?Q?r6tds2wri6iPFhrvSM56r1t7lDo7bRvyIZKSXQ1BrbMZ5sOeWYgraDN1Qr5D?= =?us-ascii?Q?DoTa9KGlYRL1tji+A6whytZYDMRTCXiiqleeR6QudNRPWxTlIqP46FUXcL3A?= =?us-ascii?Q?E5nwr75aF9pPL8OvnuXJJt7vTppyfVUDC3lsRcMgJARg92mmgf9zsCTYPBiO?= =?us-ascii?Q?U+q3s6apaz9w7NpU2iqyBzTMEH4RiMx+c7AWuEKqon/LPQN3DdQJf3cSdK+z?= =?us-ascii?Q?9eZFSA58r6jReC5BoTXpbsyJTYiA32wwge5NyNVcwBQ6rlWrsS0bjculod3M?= =?us-ascii?Q?JM2znz76CXEkBk6WwAQaSuBrngMpgTEQLuvOWGnXyprEEk+sZUBr5v1rNRPD?= =?us-ascii?Q?uulVttv0woft585ILUA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fb6c0a9-8121-40b7-76b4-08dc436ce58b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 14:50:16.5870 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QNel6N5CUK4L5gXa22vYFFGHFyad1hC9xVu/PWZBX2h4BSeJ/XBqnaOUbGtcc/qdFj3FGNdFY3rz3axSacC5aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB4046 X-Proofpoint-GUID: F_YRw4kAPrlpkNBBPMD3aXOtEL1fPJlQ X-Proofpoint-ORIG-GUID: F_YRw4kAPrlpkNBBPMD3aXOtEL1fPJlQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-13_09,2024-03-13_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH] compress/nitrox: fix dereference after null check >=20 > In nitrox_check_comp_req() while updating the last byte during FINAL > flush there is possibility of accessing null mbuf in two rare cases. > First case is when the application changes the dst mbuf between > enqueue and dequeue. Second case is when data length reported by > hardware is greater than the mbuf length. Fix this issue by adding > mbuf null checks. >=20 > Coverity issue: 415046 > Fixes: f008628a6d08 ("compress/nitrox: support stateless request") > Signed-off-by: Nagadheeraj Rottela Applied to dpdk-next-crypto Thanks.