From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F091A00C2; Mon, 26 Sep 2022 12:12:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3181B4069B; Mon, 26 Sep 2022 12:12:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C5C8040695 for ; Mon, 26 Sep 2022 12:12:30 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28PNPfmO024507; Mon, 26 Sep 2022 03:12:24 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jsy8r5p2h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 03:12:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m5I+Sh526I3AYp4Eahkya31mWwcRQCNMVNQ8RAlSbnPbMMpSn6llCV5IAOSCkkzw0uD1RxUCSHM42k4+wE0Cn5rUDWImSgtBpcKLSsJTWKWWxlw4YtNApid+KWIL99pQUN0fdzBq8SLZbHvAVnXZmlElZevsIoOqMqIprh/A3cXihXBDbUC6HitimIX2jmTXwH26ZCIBgQvmBpFx0y7LDnl2U1XpnaX1m30hnuD50hx5gAwESX+KCdFgI8VjpHaDWXi+RgBWqNI5YJ/eVRVg4gisLo09DxwKy/XiJeJ6e0gN3v1+8KH2izdIPjfHhtThkD+po/duls/X5FJpj9wadA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IcOr19Ups3EnN/Qk7YGi3AXbMfiNzCWsAfTN5AACA5w=; b=VP9KFw19+Z6pRHjO/FHORaBMxHyKWDsbNS8AeBDvpPpk9V0NqcAs5LkJetBx6IvHvClr1RWSVCT+d2KYWc6wX1tWGg8RDPV1zhnWRxAK/b8qxg1M8Q6ff+tyHNdUCopqyOpIMu+xqnSPHEHaSkkgpqEYoSC+ac8rXawwFFfNhFu1bsbJxceL4GB4AuFYiJ6Ej7ChlBOQn0tjL2g4Sd8Ta1OA9MH9ATUvhyjla1QXOq7Xn4uJTxXuRvAoYQ1HOrI2sk+KAKF0H6LhNS460q1s5t5Lia+4B0mjav9g9XELBazeRGaXfdqOol6ghnKnQJm4ahmnT8hSolhXMw+zFcOYVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IcOr19Ups3EnN/Qk7YGi3AXbMfiNzCWsAfTN5AACA5w=; b=udc2SP9Yvp+CuwdoWA/+etekQjF8LrFLYA2xWbqG4YbsTqcOyTHk1ne5P6X34QMt3IagQkjh8DIClqoivpRnsZoBXJDeYTXCwypkg6OIcMqtM6PAumFKabdIFE1hQr3j/qqqzsvL7iobIlW3QAY94WqWmwHy+iMOgz8h+YVtsHw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH7PR18MB5102.namprd18.prod.outlook.com (2603:10b6:510:158::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 10:12:21 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::7cea:d050:5433:8c74]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::7cea:d050:5433:8c74%8]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 10:12:21 +0000 From: Akhil Goyal To: Ruifeng Wang , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Vamsi Krishna Attunuru , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" , "konstantin.v.ananyev@yandex.ru" , "jiawenwu@trustnetic.com" , "yisen.zhuang@huawei.com" , Igor Russkikh , Jerin Jacob Kollanukkaran , Ankur Dwivedi , "maxime.coquelin@redhat.com" , "chandu@amd.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , Anoob Joseph , "pablo.de.lara.guarch@intel.com" , "matan@nvidia.com" , "g.singh@nxp.com" , "qiming.yang@intel.com" , "wenjun1.wu@intel.com" , "jianwang@trustnetic.com" , "jingjing.wu@intel.com" , "beilei.xing@intel.com" , Nithin Kumar Dabilpuram , "roy.fan.zhang@intel.com" , nd Subject: RE: [PATCH v3 0/6] crypto/security session framework rework Thread-Topic: [PATCH v3 0/6] crypto/security session framework rework Thread-Index: AQHY0DO5sLijOEVBgkeVF+tzJgPuyK3xf8YAgAAATWA= Date: Mon, 26 Sep 2022 10:12:20 +0000 Message-ID: References: <20220921150258.2061702-1-gakhil@marvell.com> <20220924163542.4159562-1-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|PH7PR18MB5102:EE_ x-ms-office365-filtering-correlation-id: 1882dcc5-2892-4ab6-9f73-08da9fa7997d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G9DZsvzOjhlohDEUCRjH92fkD2vzwt3NhfiFmm25uPQJ4LxBAxm3YY5lGIo91YGIZUqfRI8OWfMw61+KsKCVaNJVTf59+JUgC6+Z9jp9LCRCK3HZkwyrjqXWn3qRLp3b7F23+W7JQKvRGPiCMPF1AL3ZBGRL1Hz35nH3CDV1ixsYaOJHsYwx50lt7KwvMecfRkQ16YSxvqpxaWRqd1zFTv5u0dMTiaU2V86NKfocti+1Rhxy6C1AjfOGRhsIxPtP4S6kUlbpu9KlWeNdhpQDIBJnwn6MS5UCSAh73ojamTlN3qwYTqav0YN8k+OcsRrinIbmRwqId77jlCaRvc41zHyMMy1PObsN4jzis4kKdqviiHvCpFncddjc+3bNSk8E+69uNiE2oa4hlNGumZWjUYWzVIazzovpU9qxyReo/M46UFP/t7eGj6d3rGMgcleIgVEHdHd5eASGIIXeN14KmeGAK41nb07s7+qcLp30FC2CBM7BySq1P9UUpKlnu4LmfL5tIt+GwKdxEbvOw8x8LSEmeD2/2kUzYqOxKZw9Ocn4R7hQJBErUyl1Kc4qGHO94hHFkMVBPMmm9e5skkETYATW3cFPF0Jy0M4+Zv6rOLJ8qbqrItrJFyu9gKjysmPhgbpSHCezqyGkm8bn6gwMzQFrr3z1oa+gFSUAP6kI9VM8cwJLej9sJfitQNPjwIjaPkKK/hMbJH6qWnMGb10wZ5NSQ0WdVVMC49a8l9ToUeJnTLymjUeEidd8uHgbYbmSQ3GpoZgRpIJr9360P4vM0f1jSEtfdyPwFSgFM7eBmzM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(39860400002)(366004)(396003)(346002)(451199015)(478600001)(71200400001)(6506007)(7696005)(55236004)(966005)(41300700001)(83380400001)(9686003)(186003)(26005)(5660300002)(2906002)(7416002)(15650500001)(55016003)(110136005)(54906003)(52536014)(66476007)(8936002)(66446008)(66946007)(66556008)(76116006)(4326008)(8676002)(64756008)(316002)(38100700002)(86362001)(122000001)(38070700005)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4C/sNyGB1JGInMnvReXqmlk7YeQi/ko6rJWg6C2Vvnji61zV3TK/SU+8+Jit?= =?us-ascii?Q?Hh73/KpntFjYaB+meeytyCiOZPgAFm16zX+X2GDaBNvim+7r3KXqFAlPClie?= =?us-ascii?Q?4km76JxKuLcNuHA3wUeNqlmqRwqCKjqZ8486bRO22pugv6vHqKokCVq2iAXn?= =?us-ascii?Q?97Voza4nwjx64OmRBTCtrXjP/oYscdJSOEu6wjJpsIxWPVJrQ+xGg+c1FHCf?= =?us-ascii?Q?pa9apBefpMk7hoirjVq8+zGQYYeveUvoCKgi7vVUxkz+jCSNikVdcgg8i/de?= =?us-ascii?Q?sOnYlt/ETG1ewIV/NdNkPBtO/2Nxzwl/AUK5CP4DdgTO2NJTuomBERuZO3pq?= =?us-ascii?Q?qA/7HG0nakGGBTVq/tBOYtb3Kh0gAdmcjVMtZWUKGXn8/r4Awatv9Sy0jcH1?= =?us-ascii?Q?IwlOXR5o9gcqOp0+ydpoVgSHWK/7C45+mJs87HFKrntb6H3XenvsSy06sr7R?= =?us-ascii?Q?2PmRV4mrA4d5QjA0AaGKmJm79Ovqh7hhQfQ/rABkvNXXwLWjjHIqY0o1H4l0?= =?us-ascii?Q?gXUlAICDuj2kmnYZ2m554OGK9XZDcbCyHqXfcTyvADoErjEpeUu7H3IV+LOh?= =?us-ascii?Q?u2HZ5x0gaNuBDAbtELaJzEuxaY9qXj18WEz9GzWQycta9OGHRqMgDxNorCU3?= =?us-ascii?Q?F3h+ABMbg7SVngvSxtXFDcaT21d/dnqumEBMDGEbDa3puhtficgqj5yFL2TD?= =?us-ascii?Q?JNDm2zltmnbiiAdZTloWgBvl0LU77VAvRs477J2xWMidkNs1Nbu8IIjN/63b?= =?us-ascii?Q?pO8dWr/+J2WBRxqQ2qWEhzXX0TFm4BrhAfmt3kRJqs3LUDFk9SuK4tpNIq0V?= =?us-ascii?Q?l7b8wOvzLlV+DG6WeaQOoEexmtoN7x673ASE+SPrUg/20oCW5/jNk6wpWAuT?= =?us-ascii?Q?8Timig5ZpUfUj8LD9zd2bwvVuepyc77+Cgfow0vXUPIqZjsTo+qxWGh1Gf3i?= =?us-ascii?Q?p8qoliarnV1nb5qAi46EqrXqZycy/Bxfx24CBvWf1xkwj7fmJ1Zq/VFB0ASq?= =?us-ascii?Q?OLbhHwV9HvyPLDQnXO77+HXwf18WcxDb7PgmFf3SzmQRlWwJzp5eLwGL9ydp?= =?us-ascii?Q?O6yAaHScxKA/IJGoxOK4TMnuSXASlcPYpniCXsE5fWDDI2deXrciEXMVzBYQ?= =?us-ascii?Q?zvCJc0fc48VslNSt2L0Dc3LSkb8+EGle06eg+OvTL2X3Zb0YkBOfPEDmCxxS?= =?us-ascii?Q?QVjDe+Dxz0tnrmunRYjSCudPIAanHBd0aljfE6E8p2oDv+s2Wsxb9e0yZsL2?= =?us-ascii?Q?0d/iW65ZB6TwVUdlYp1VupK2c9h3PLg8lbO9PJs6cCVnz0uDAjImBT7m90TA?= =?us-ascii?Q?BwmUD33AM6tRSwG7tvUEqIb9A5LTTE0+Qor0950jH0BnD3ct2qDL6ITPqd6B?= =?us-ascii?Q?cEM7M/OgfmQkJkBjSs34gGeEUE51ZVoZSQwxR0ystIRIL7i9/rXas6tQjvn/?= =?us-ascii?Q?h3SwLIMhkyhAyUdaVYBztpu+cGMsa9RWKkwD27R6Ae1o0VqYBQ9Nc6hANSkL?= =?us-ascii?Q?JhrUjCxXfi9umQmDESFtAqCJ5poc/Yz4wHsU7hMwE7vnFND8m8lswjrsGfxp?= =?us-ascii?Q?/enSF/qtx053pnwqgEHe7xCxYoVZ4BrytxlTC2Tm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1882dcc5-2892-4ab6-9f73-08da9fa7997d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 10:12:20.9535 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sLpnVeVl8nXbxbzKpcSavd8O7jpiiCrvtOve282M/f7mVKEHKEH4A3/epwa+HGgr1NUbMyVAKgnQX92483uMPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR18MB5102 X-Proofpoint-GUID: IWEk0ndT2YSmSgMWbHeaDDBLr-SsYCV6 X-Proofpoint-ORIG-GUID: IWEk0ndT2YSmSgMWbHeaDDBLr-SsYCV6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-26_08,2022-09-22_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Subject: [PATCH v3 0/6] crypto/security session framework rework > > > > This patchset reworks the symmetric crypto and security session data st= ructure > to use a > > single virtual/physical contiguous buffer for symmetric crypto/security= session > and driver > > private data. > > In addition the session data structure is now private. > > The session is represented as an opaque pointer in the application. > > > > With the change the session is no longer supported to be accessed by mu= ltiple > device > > drivers. For the same reason rte_cryptodev_sym_session_init/clear APIs = are > deprecated as > > rte_cryptodev_sym_session_create/free will initialize and clear the dri= ver > specific data > > field. > > > > The change was also submitted last year during DPDK 21.11 timeframe als= o[1], > but was not > > applied due to lack of feedback from community. Please help in getting = this > cleanup merged > > in this cycle. > > > > Now the similar work was already done for asymmetric crypto. > > This patchset is rebased over current tree and fixes all the issues rep= orted so > far. > > > > Changes in v3: > > - Updated release notes > > - fixed checkpatch issues > > - renamed macro to get sess priv data to align with crypto macro > > - added acked-by/tested-by > > >=20 > Hi Akhil, >=20 > Thanks for the changes. > Armv8 crypo PMD has build issue with this series. > I updated code based on your series to fix the build. And an issue found > in unit test is also fixed. > http://patches.dpdk.org/project/dpdk/cover/20220926100120.3980185-1-ruife= ng.wang@arm.com/>=20 > Could you merge my changes into your series? >=20 Sure I will. Thanks for bringing this into my notice. Armv8 is by default n= ot enabled on my build machine. So it got skipped.