DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>,
	Anoob Joseph <anoobj@marvell.com>,
	Radu Nicolau <radu.nicolau@intel.com>
Cc: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 1/2] examples/ipsec-secgw: fix width of variables
Date: Tue, 9 Jan 2024 17:38:33 +0000	[thread overview]
Message-ID: <CO6PR18MB4484FBECD55FA7CF8D54E20DD86A2@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <4f07890503b24e50adeb56a6b36066f5@huawei.com>

> 
> > 'rte_eth_rx_burst' returns uint16_t. The same value need to be passed
> > to 'process_packets' functions which performs further processing. Having
> > this function use 'uint8_t' can result in issues when MAX_PKT_BURST is
> > larger.
> >
> > The route functions (route4_pkts & route6_pkts) take uint8_t as the
> > argument. The caller can pass larger values as the field that is passed
> > is of type uint32_t. And the function can work with uint32_t as it loops
> > through the packets and sends it out. Using uint8_t can result in silent
> > packet drops.
> >
> > Fixes: 4fbfa6c7c921 ("examples/ipsec-secgw: update eth header during route
> lookup")

Cc: stable@dpdk.org

> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied to dpdk-next-crypto
 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Email Id shows warning in mailmap
Contributor name/email mismatch with .mailmap:
        Konstantin Ananyev <konstantin.ananyev@huawei.com> is not the primary email address

I believe Konstantin is using both email ids, but mailmap is taking the first one as primary one.
Konstantin,
Is it possible for you to use a single email ID and update mailmap accordingly?



      reply	other threads:[~2024-01-09 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  5:29 Anoob Joseph
2023-12-19  5:29 ` [PATCH 2/2] examples/ipsec-secgw: update stats when freeing packets Anoob Joseph
2023-12-19 17:18   ` Stephen Hemminger
2023-12-20 13:10     ` [EXT] " Anoob Joseph
2023-12-19  9:51 ` [PATCH 1/2] examples/ipsec-secgw: fix width of variables Konstantin Ananyev
2024-01-09 17:38   ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB4484FBECD55FA7CF8D54E20DD86A2@CO6PR18MB4484.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=konstantin.ananyev@huawei.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=radu.nicolau@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).