From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2AC3A00C3; Fri, 13 May 2022 11:50:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4EAC40E64; Fri, 13 May 2022 11:50:01 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id B12A040DDE for ; Fri, 13 May 2022 11:49:59 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24CNceCh010302; Fri, 13 May 2022 02:49:59 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g1c379vvw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 May 2022 02:49:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BDDD2b20N3NWWBiB/AvLag/dvvxUmFeeaNI5Dyytwa+461jWbZJLOaJdQaOSX/+m1qT1C9gt9HI6hjiDhHAcS/QXwGvdmtbMIjQA9KAzLBFvmQnSv4StEU0T/tBAQS4YcFjb05/v0qbZc14AdO7E4o1b3rnjGcVT1H4mHkiIeLMs/5o0seoFq3i57ZeL6P77RJSdFnoLfTkJKFKXCkF+hLEmPngkVOE9ofxoayHG53HYWHXjmOeiTmi8A9zdllQmBcUYcIiBrcphG4w7mV1rTm1PgHuOwvgXgBxDUR8kreRGT2uNfXlsYIbGu45mSdUXPoM/vlh4OMs4q2ZQvSJ/Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p78z/7Itlx55vqgF6xH/4IGiwzN/QEJFrev2FN56Fq0=; b=UHTMhpIKQSA+zm008QYQK0i/PkVFOOqTGs+N9WiLKmLvS/FNdfCVo4x0oq+7dhiSojZSlgBMXNNFzeeCem9ShnkfeOfdXJTgIRwBsjYqI8zVFKlGSV1RSupfMS/8GAqazcGeVBsqt0LSpdgR2+yufIRRcfTiL3G0rwsJENl/yUYGcsgzr6M1uUi7IcGbRTX8swIhamPmOI+DSXTepz+vkLPaeebnm4atVz+d8ItFg+yO7cIQ5WmjixJc2ptUQy6YHHOv916eVcfZlAorur4isfdGm5x4kT9JaS1Ca+REO6iiD5/pJf+nvik4PfaT6jgyxD2kp7CM4PKbD5nPYzpJGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p78z/7Itlx55vqgF6xH/4IGiwzN/QEJFrev2FN56Fq0=; b=LpKwzQh0jqLmprgdSdQoS6WGn9+VzqsXBG75ZUJ9Z/JbVKio31WQP3DVh87bfYU/mRRGa9O5zdPaSVwoxbNO9/gfHCNj41MwO0DvS8INqKhiTPuVnkhPEtaYQIJLoDfT5Uxl2fYKf7iIGUO7n+u2Z3op7GhQqClZT1tANgfvTKE= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH0PR18MB4781.namprd18.prod.outlook.com (2603:10b6:510:ca::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.16; Fri, 13 May 2022 09:49:56 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9c76:3b01:eb04:db4d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9c76:3b01:eb04:db4d%6]) with mapi id 15.20.5250.015; Fri, 13 May 2022 09:49:56 +0000 From: Akhil Goyal To: Gagandeep Singh , "dev@dpdk.org" Subject: RE: [EXT] [PATCH 2/8] app/test-crypto-perf: support SDAP for PDCP operations Thread-Topic: [EXT] [PATCH 2/8] app/test-crypto-perf: support SDAP for PDCP operations Thread-Index: AQHYWFsMoPF9OCXupkqSbFp3RC/SHq0crCWw Date: Fri, 13 May 2022 09:49:56 +0000 Message-ID: References: <20220425041423.2232034-1-g.singh@nxp.com> <20220425041423.2232034-2-g.singh@nxp.com> In-Reply-To: <20220425041423.2232034-2-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1886cc82-7585-43e6-3674-08da34c5efe4 x-ms-traffictypediagnostic: PH0PR18MB4781:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hqGqUCQfco/ZkEHJ8e5eLCmxxparHOrF61GUMBEr751JgZhdRrOXp19OlsPKj11E2tu3+h/HFQW7nlZ/EWcdYgl98TS1GC8eq2ommj3Rm+alEtsi/OzDJH8C8Z4sh/exFOwjvrHZgj9NEVU9f5ANHcHaTfgqiRUs2GN20wiAwLD34t7H2TTqeK2oqiJCGxns1d5xIAqCkK8XCcS7lahtwnbDEGsDOtDP0TdIfFskGcsaev3rpRQEIk138YOAK47LKbmrCzFuT1aPKbLgQD3YxfUEQ6J6Ms5tfRx6pK/OKqcHf82I0rzeMWky+Vz/xn582e+P0vffth5VtIBhUNo4Thh9qkfjgtYGR00nMZ6Pteqf+Psv3+yNsFRG/g9X6mzL9HLG9N4IbojqHUVjUzx5DyQW/8tkfeB8iD49q2cFNlU8B9ZSSaP4bGqI7IXe8LBQ3j+kJtUkOmMQk0cWni+fdALQcgvExkw/3ywAd7P993wbxCXPgYg6XqUZym3YwHNCML1axoTf3ML0t0YEo2rvwKOJ2rU7NOeBgj6DVM+Fs02kxfZetTgQrXS3OO8naeuZEFkwkZOpgnzhLqoFPn8USQcN2sXEhFpBEh2XuHCfOiTLzctjuW3iHiIfGKtmEI4ynf0EAqKqOjCooCbK2iRa9/CvF4MA8KQwwcJD5FHRKhu+2bFGTvGerYS/0Jvhn6kpeGaANnfAfy/63FfQvw4IQw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(55236004)(26005)(7696005)(83380400001)(2906002)(33656002)(9686003)(55016003)(8936002)(5660300002)(52536014)(38070700005)(38100700002)(64756008)(66446008)(66476007)(122000001)(66556008)(66946007)(76116006)(8676002)(71200400001)(86362001)(110136005)(186003)(508600001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fZXA+GWN4b/c2zyF5tO0u9BNQwUt5xIRbz9RMmJ+cf/t9thTBpSWTPbFOS3P?= =?us-ascii?Q?031MPkxlWhDF6JYfxV8FZ3043JN0qMe3xvjRI0WrPBZuWAa3RBzJKfm+mMTH?= =?us-ascii?Q?qw6FTWJWl+DQBtg2tEYYelcl//P7e+qibaQ22WREx3qWVb6GcpmWcNeQ7D2u?= =?us-ascii?Q?D0E9V2ldVrFnCXwBKPJIEYbIeBRKgDkQKRVNyhHyPS0DSqgI3/7eFLZGzNuO?= =?us-ascii?Q?SL2end+uekvi9hl/sebTS+e9sCDFd6cxWGO6PcEXSy5mTHWAldvl/V2z+lCU?= =?us-ascii?Q?vbXAnSckB3TSEmqjH3RJlJ1bxb4hDCfEjIDX/0b5saKtLmwcjgHVKX2AduMU?= =?us-ascii?Q?6o2jPyXzsVPFEZC7R8P+fXKaF19yr9Mus13eLpC44g/HRtm9tSDiXhnIDZaV?= =?us-ascii?Q?AcAltE3tZgZcrwoOe6ZORaDHwrQsAl8V7m4DsAc87lOXw8dVu3rTXBcQcX4W?= =?us-ascii?Q?iRPNscXUIh7oxwKn/hUGV8MiUTJSwf3S3DV15xdujgwMfndatiIXO5oPPB9y?= =?us-ascii?Q?jeLU/55tCeMlsCZzefyOx7MzQveE8gjzkLY9mx5mBCU2LqDHr1M23cytMfJz?= =?us-ascii?Q?i4qqEgRIiY6fIm32yzseLB3OFUXM23bhsRE8ZC7aP3ZrIcjQ7ZSEZbOcug5m?= =?us-ascii?Q?SJHUiA/fk41ELr3lak498X3y7hkvqVO6RoeVQ0BoMETCanBk3he3Ak8xXAJv?= =?us-ascii?Q?P4u0eL+w4MpwPy2qoH+a43ohUQ4tIsUTwNsLNDUXy1YG7srj8cxdGaTGQ0cx?= =?us-ascii?Q?DVJFpryxQIu1yUnk4A2mEeI4vq4igQg3PLhHkkUIaNobzxvLzDMaK+v3EblG?= =?us-ascii?Q?NVQKoBtoqv3aNajjcwHfByFDhy6tj8Jm/PQktNu2ElNlsOKwEeQshHw+qdU0?= =?us-ascii?Q?abobmizXBpd0z9DKiel+9fmDD+Xv/6LjkNXYVvSrX0vLdZRJwYNWJpVCRSW2?= =?us-ascii?Q?3dCHtIrMV5pnIKPi1iAVJJuH25DiMNiwi3orWcx/igjJkHZ14Iqi4gbiPI59?= =?us-ascii?Q?0utoQsQJVHPWPbxaXAM/LZq7LE97j7kOr6GphNVCgcJIJee6sCy9GCu0MLMf?= =?us-ascii?Q?kLQWxt6QkFltgoQ7fuaXkA14kWkch7ZlpyHtQHRabA1NAsy0hSoxIybFGEwF?= =?us-ascii?Q?OdhORgl55a5k7TeK5cpkPC2qTUHM/y2Zn0giv4mj+B+Y1Z29GKD1FdtjBmQM?= =?us-ascii?Q?OerrDqnafs5rQzCsiR79d9B5izSMEV2DYvP6uPtDLQaYkRCVzt+mrdNiQivk?= =?us-ascii?Q?S7P9MQQ9iDzKygLsJisuL7k+BxDiGFpB4mtlrMuIcdn9yuUKpMGZtMsBG1r6?= =?us-ascii?Q?SeKTtaSlzFc4vP3/KClD+BaV9ai7rhl898XTZPGrgpuHLuy0Y/xIbcAU3Thq?= =?us-ascii?Q?0aRysHH6KllQ5Gol2RJypDkx4G9lGbqDPMZ2YQnlxoP4QUAYZ9pDZeZLdYG0?= =?us-ascii?Q?4rbIKeHkj9wti6oydt49iFxOjRtcluaimsmwA/2Nxg8zFoqnNLXDWoZp9sT3?= =?us-ascii?Q?fURqImUqEYXzeWIWvJHuppVcjzd20HTnPW9YJTix9kGDp+vJrG2wJlJ7W2ay?= =?us-ascii?Q?R+aaRJDJpQvImOK25EHdkuMFSIB0cN5dVUvb5JWxLKcekjvnm9EBUr0C6/pp?= =?us-ascii?Q?ZUPllQlQAFy8XBN/VeQmCDq78pS6tBANZNFM1IylOR8/PLW39KPGO0blHkCv?= =?us-ascii?Q?s51+5oE50nPfQ8VUBp6v+lvqD6ZfQ6LnqhURg2iFVzmpyJUxLbdrmyxbOb/V?= =?us-ascii?Q?AeT1GlK2eQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1886cc82-7585-43e6-3674-08da34c5efe4 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 09:49:56.3634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jVBTmJroSkQ4kziFjiZKPk+egHcaVJC0NAp3Z3OAc94g5qnBO+4FzBtgyJD+D23zAM1tXWlnZlAIYynzSWRZyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4781 X-Proofpoint-GUID: HxM1AsYb4hePgRd00Y352W9gWG8GWqEH X-Proofpoint-ORIG-GUID: HxM1AsYb4hePgRd00Y352W9gWG8GWqEH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-13_04,2022-05-12_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Add a command line option "--enable-sdap" to enable > Service Data Adaptation Protocol. >=20 > example command: > ./dpdk-test-crypto-perf -c 0xc --log-level=3D8 -- > --devtype crypto_dpaa2_sec --optype pdcp --cipher-algo aes-ctr > --cipher-op encrypt --auth-algo zuc-eia3 --auth-op generate > --auth-key-sz 16 --ptest throughput --total-ops 100000 --burst-sz 64 > --buffer-sz 64,390,1512 --pool-sz 4096 --silent --pdcp-sn-sz 12 > --pdcp-domain control --enable-sdap >=20 > Signed-off-by: Gagandeep Singh > --- > app/test-crypto-perf/cperf_ops.c | 1 + > app/test-crypto-perf/cperf_options.h | 2 ++ > app/test-crypto-perf/cperf_options_parsing.c | 12 ++++++++++++ > 3 files changed, 15 insertions(+) Missing documentation update for the new option added. >=20 > diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cper= f_ops.c > index 8baee12e45..67a7a0ac4f 100644 > --- a/app/test-crypto-perf/cperf_ops.c > +++ b/app/test-crypto-perf/cperf_ops.c > @@ -860,6 +860,7 @@ cperf_create_session(struct rte_mempool *sess_mp, > .hfn =3D options->pdcp_ses_hfn_en ? > PDCP_DEFAULT_HFN : 0, > .hfn_threshold =3D 0x70C0A, > + .sdap_enabled =3D options->pdcp_sdap, > .hfn_ovrd =3D !(options->pdcp_ses_hfn_en), > } }, > .crypto_xform =3D &cipher_xform > diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto- > perf/cperf_options.h > index 031b238b20..fffa6a2162 100644 > --- a/app/test-crypto-perf/cperf_options.h > +++ b/app/test-crypto-perf/cperf_options.h > @@ -13,6 +13,7 @@ >=20 > #define CPERF_PTEST_TYPE ("ptest") > #define CPERF_SILENT ("silent") > +#define CPERF_ENABLE_SDAP ("enable-sdap") >=20 > #define CPERF_POOL_SIZE ("pool-sz") > #define CPERF_TOTAL_OPS ("total-ops") > @@ -128,6 +129,7 @@ struct cperf_options { > #ifdef RTE_LIB_SECURITY > uint16_t pdcp_sn_sz; > uint16_t pdcp_ses_hfn_en; > + uint16_t pdcp_sdap; > enum rte_security_pdcp_domain pdcp_domain; > uint16_t docsis_hdr_sz; > #endif > diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-cryp= to- > perf/cperf_options_parsing.c > index 59a9dc596a..48cd1b5ba2 100644 > --- a/app/test-crypto-perf/cperf_options_parsing.c > +++ b/app/test-crypto-perf/cperf_options_parsing.c > @@ -61,6 +61,7 @@ usage(char *progname) > " --pdcp-sn-sz N: set PDCP SN size N <5/7/12/15/18>\n" > " --pdcp-domain DOMAIN: set PDCP domain \n" > " --pdcp-ses-hfn-en: enable session based fixed HFN\n" > + " --enable-sdap: enable sdap\n" > " --docsis-hdr-sz: set DOCSIS header size\n" > #endif > " -h: prints this help\n", > @@ -535,6 +536,15 @@ parse_silent(struct cperf_options *opts, > return 0; > } >=20 > +static int > +parse_enable_sdap(struct cperf_options *opts, > + const char *arg __rte_unused) > +{ > + opts->pdcp_sdap =3D 1; > + > + return 0; > +} > + > static int > parse_cipher_algo(struct cperf_options *opts, const char *arg) > { > @@ -865,6 +875,7 @@ static struct option lgopts[] =3D { > { CPERF_PDCP_SN_SZ, required_argument, 0, 0 }, > { CPERF_PDCP_DOMAIN, required_argument, 0, 0 }, > { CPERF_PDCP_SES_HFN_EN, no_argument, 0, 0 }, > + { CPERF_ENABLE_SDAP, no_argument, 0, 0 }, > { CPERF_DOCSIS_HDR_SZ, required_argument, 0, 0 }, > #endif > { CPERF_CSV, no_argument, 0, 0}, > @@ -978,6 +989,7 @@ cperf_opts_parse_long(int opt_idx, struct cperf_optio= ns > *opts) > { CPERF_PDCP_SN_SZ, parse_pdcp_sn_sz }, > { CPERF_PDCP_DOMAIN, parse_pdcp_domain }, > { CPERF_PDCP_SES_HFN_EN, parse_pdcp_ses_hfn_en }, > + { CPERF_ENABLE_SDAP, parse_enable_sdap }, Follow similar formatting as other options. > { CPERF_DOCSIS_HDR_SZ, parse_docsis_hdr_sz }, > #endif > { CPERF_CSV, parse_csv_friendly}, > -- > 2.25.1