You may skip the ones which is common between kernel and DPDK and fix the ones which are specific to DPDK.

From: Boyer, Andrew <Andrew.Boyer@amd.com>
Sent: Wednesday, June 5, 2024 6:57 AM
To: Akhil Goyal <gakhil@marvell.com>
Cc: Boyer, Andrew <Andrew.Boyer@amd.com>; dev@dpdk.org
Subject: Re: [EXTERNAL] [PATCH v2 1/9] crypto/ionic: introduce AMD Pensando ionic crypto driver




On May 30, 2024, at 8:02 AM, Akhil Goyal <gakhil@marvell.com<mailto:gakhil@marvell.com>> wrote:

diff --git a/drivers/common/ionic/ionic_common_uio.c
b/drivers/common/ionic/ionic_common_uio.c
index e5c73faf96..c647b22eaf 100644
--- a/drivers/common/ionic/ionic_common_uio.c
+++ b/drivers/common/ionic/ionic_common_uio.c
@@ -23,10 +23,12 @@

#define IONIC_MDEV_UNK      "mdev_unknown"
#define IONIC_MNIC          "cpu_mnic"
+#define IONIC_MCRYPT        "cpu_mcrypt"

Any specific reason for using the word mcrypt. Can we use mcrypto everywhere?

I will address the others, but we will decline this one because it has kernel change and upgrade/downgrade implications.

-Andrew