[dpdk-dev] RES: RES: hw.nic_uio.bdfs

[Fred Pedrisa <fredhps10@hotmail.com>]

Hello,

Anyways, here is my proposition for this code :

static void
nic_uio_load(void)
{
        char *remaining;
        long bus = 0, device = 0, function = 0;
        char bdf_str[1024];
        int i, j, len;
        device_t dev;

        memset(bdf_str, 0, sizeof(bdf_str));
        TUNABLE_STR_FETCH("hw.nic_uio.bdfs", bdf_str, sizeof(bdf_str));
        remaining = bdf_str;
        len = strlen(remaining);

        for (i = 0; remaining && len >= 5 && i < len;i+=6) {
                if ( remaining[i + 1] == ':' && remaining[i + 3] == ':' ) {
                        bus = strtol(&remaining[i + 0],NULL,0);
                        device = strtol(&remaining[i + 2],NULL,0);
                        function = strtol(&remaining[i + 4],NULL,0);

                        dev = pci_find_bsf(bus, device, function);
                        if (dev != NULL) {
                                for (j = 0; j < NUM_DEVICES; j++) {
                                        if (pci_get_vendor(dev) ==
devices[j].vend && pci_get_device(dev) == devices[j].dev) {
                                                        device_detach(dev);
}
                                }
                        }
                }
        }
}

I think it looks better this way.

-----Mensagem original-----
De: dev [mailto:dev-bounces@dpdk.org] Em nome de Fred Pedrisa
Enviada em: quarta-feira, 26 de março de 2014 03:50
Para: 'Masaru Oki'
Cc: dev@dpdk.org
Assunto: [dpdk-dev] RES: hw.nic_uio.bdfs

Hello,

 

By default nic_uio takes all the NICs for itself…

 

So in theory, you needed an option to reserve some NIC ports to your system,
without DPDK taking it for itself…

 

De: Masaru Oki [mailto:m-oki@stratosphere.co.jp] Enviada em: quarta-feira,
26 de março de 2014 03:43
Para: Fred Pedrisa
Cc: dev@dpdk.org
Assunto: Re: [dpdk-dev] hw.nic_uio.bdfs

 

avoid??? want you hw.nic_uio.avoid_bdfs?


nic_uio behavior I guessed
1. detach kernel driver specified by hw.nic_uio.bdfs

2. attach nic_uio driver for all NICs not attached.

but 2. is not correct, I think.

 

 

2014-03-26 15:20 GMT+09:00 Fred Pedrisa <fredhps10@hotmail.com>:

Hello,

 

You did not understand the purpose of that parameter, it is made to ‘avoid’
nic_uio from pursuing the wanted NICs... so they are free to be used in the
system :)

 

Right now the code to handle it is wrong and I am trying to fix it myself.

 

De: Masaru Oki [mailto:m-oki@stratosphere.co.jp] Enviada em: quarta-feira,
26 de março de 2014 03:16
Para: Fred Pedrisa
Cc: dev@dpdk.org
Assunto: Re: [dpdk-dev] hw.nic_uio.bdfs

 

Hi,

I tried with Intel version 1.6.0 and FreeBSD 9.2-RELEASE on VMware Player.

kldload nic_uio by hand, works fine.
But kldunload nic_uio only detach uio driver, don't re-attach kernel driver.

[oki@ ~]$ cat /boot/loader.conf
##############################################################
###  User settings  ##########################################
##############################################################
hw.contigmem.num_buffers=64
hw.contigmem.buffer_size=2097152
hw.nic_uio.bdfs="2:5:0,2:6:0"
contigmem_load="YES"
#nic_uio_load="YES"
[oki@ ~]$ pciconf -l | egrep '(em|uio)'
em0@pci0:2:1:0: class=0x020000 card=0x075015ad chip=0x100f8086 rev=0x01
hdr=0x00
em1@pci0:2:5:0: class=0x020000 card=0x075015ad chip=0x100f8086 rev=0x01
hdr=0x00
em2@pci0:2:6:0: class=0x020000 card=0x075015ad chip=0x100f8086 rev=0x01
hdr=0x00
[oki@ ~]$ kenv hw.nic_uio.bdfs
2:5:0,2:6:0
[oki@ ~]$ sudo kldload nic_uio
Password:
[oki@ ~]$ pciconf -l | egrep '(em|uio)'
em0@pci0:2:1:0: class=0x020000 card=0x075015ad chip=0x100f8086 rev=0x01
hdr=0x00
nic_uio0@pci0:2:5:0:    class=0x020000 card=0x075015ad chip=0x100f8086
rev=0x01 hdr=0x00
nic_uio1@pci0:2:6:0:    class=0x020000 card=0x075015ad chip=0x100f8086
rev=0x01 hdr=0x00
[oki@ ~]$ sudo kldunload nic_uio
[oki@ ~]$ pciconf -l | egrep '(em|uio)'
em0@pci0:2:1:0: class=0x020000 card=0x075015ad chip=0x100f8086 rev=0x01
hdr=0x00
[oki@ ~]$

 

2014-03-26 14:35 GMT+09:00 Fred Pedrisa <fredhps10@hotmail.com>:

Hi, guys.





This variable is not working as intended for FreeBSD :(



It does not dettach nic_uio from the wanted ports :/