From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC0FD42486; Wed, 25 Jan 2023 14:50:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 890F142D3E; Wed, 25 Jan 2023 14:50:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9BCD542D31 for <dev@dpdk.org>; Wed, 25 Jan 2023 14:50:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674654605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xYjmY7jQUplUQ+jiZ+BvyIR56nb+MZj4ByE1hZG5lHM=; b=OLn+kwCtrtbGhKnpLgGShH1VaaWY2QF+o/uOUPSaXmrArPNOE0HBKHPC5iIoLlGeGPr5YK g066h/2w2ZEStDi8wra0moA5oOAbiCpDS4EHbnB2lWZLN2pheqPEeqZtKD98HTAUTgGU9e TjZgXPIKLxyhbVVUCujZe4Ha/u4sYaE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-221-jHPdm8wpO92GOGui03T_pw-1; Wed, 25 Jan 2023 08:50:03 -0500 X-MC-Unique: jHPdm8wpO92GOGui03T_pw-1 Received: by mail-wm1-f71.google.com with SMTP id p1-20020a05600c1d8100b003daff82f5edso10940029wms.8 for <dev@dpdk.org>; Wed, 25 Jan 2023 05:50:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xYjmY7jQUplUQ+jiZ+BvyIR56nb+MZj4ByE1hZG5lHM=; b=THit5V4Dary80h7uDzaEBiB6Fxpp4h2Ui5t0hVwitjMJmFqFQirDc/uf84KSk0sjy1 qU8mYHlfvyTOa8klSsaYwUu5Nji62UEolHGHu1p+Im9DyZ5V338l0TZP9z0kCTgOy8p8 VvGQ9UV5QzRbGd8HhdvEOVoZsOrCweb8Y+m9yrtQJ9xPOSluXJDS3QTg2azxkz65HHRV 8SVCg609aP1ZejQOaIuW6pCRDbEP3o/kUbwpgGJ8Rh7YXIhhw5mRKiYuYB1V8dbx5FHN qOvFhlxRhmF1sSNZoPaADrPeLXw+mTUJ7tuFi2A4LJJLuxdUf6FEUG0ck3he2uvkHila jPWg== X-Gm-Message-State: AFqh2kquchUi3UM+d2QaIFGFy/1/+/dsovfWWPtbA2LnPcZ8iG9l8GXv iRhakmjB9ULy55nasjk0P+q4O6UL8AwELi2283NY3e4L6bWZ1plvvxRdmxUM1yex7LYdkGZDyMx rf4c= X-Received: by 2002:a05:600c:1c23:b0:3db:b9f:f2e with SMTP id j35-20020a05600c1c2300b003db0b9f0f2emr29763363wms.14.1674654602843; Wed, 25 Jan 2023 05:50:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXs4e6AmgDc0s6SyYU17MLg+Fotol061Kwfe82wNDkecSMKw2yx5LNRS2xH+IYZqwdljCSX5uQ== X-Received: by 2002:a05:600c:1c23:b0:3db:b9f:f2e with SMTP id j35-20020a05600c1c2300b003db0b9f0f2emr29763347wms.14.1674654602658; Wed, 25 Jan 2023 05:50:02 -0800 (PST) Received: from localhost (2a01cb000f483e0055ae3800781b5cbc.ipv6.abo.wanadoo.fr. [2a01:cb00:f48:3e00:55ae:3800:781b:5cbc]) by smtp.gmail.com with ESMTPSA id r20-20020a05600c35d400b003db16770bc5sm2169508wmq.6.2023.01.25.05.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 05:50:02 -0800 (PST) Mime-Version: 1.0 Date: Wed, 25 Jan 2023 14:50:01 +0100 Message-Id: <CQ1BIFG4W9BF.321UNERKH9E31@ringo> Cc: "Ferruh Yigit" <ferruh.yigit@amd.com>, "Aman Singh" <aman.deep.singh@intel.com>, "Yuying Zhang" <yuying.zhang@intel.com> Subject: Re: [PATCH 0/6] Testpmd code cleanup From: "Robin Jarry" <rjarry@redhat.com> To: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org> X-Mailer: aerc/0.14.0-35-g8614fef5610d References: <20230124104742.1265439-1-david.marchand@redhat.com> In-Reply-To: <20230124104742.1265439-1-david.marchand@redhat.com> X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org David Marchand, Jan 24, 2023 at 11:47: > Here is a series to reduce code duplication in testpmd. > > This work started from looking at Robin series on reporting lcore busy=20 > cycles in telemetry, which is then added in testpmd [1]. While looking=20 > at the forward engines code, I saw way too much duplicated code. > > Warning: this is only compile tested. > > 1: https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-= rjarry@redhat.com/ Hi David, The code looks good to me. I have made some basic testing, it seems not=20 to break obvious things. Reviewed-by: Robin Jarry <rjarry@redhat.com>