From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0096.outbound.protection.outlook.com [104.47.36.96]) by dpdk.org (Postfix) with ESMTP id 64BB15677 for ; Thu, 21 Jul 2016 18:26:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=BivioNetworks.onmicrosoft.com; s=selector1-bivio-net; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FLn2AV5oK6hnKCZG+2vZh9PLtfzzhdx2M8i72MGBAok=; b=jJBZOH5IDth+lm+UYJjo/lRFirWgSlY1R4+4ezRkpZ6isH7a99M6ytCA8EenpEtK8x+HRExDM/hXaU5t6xqz36MRLrNU1NoYYB4UnRijHTSVA+X1jupqXdsAFTekyd4Vky3n/awLv8cAGlQ/qGW0bZur488I1d/I6rA0f1VDvfQ= Received: from CY1PR0101MB0987.prod.exchangelabs.com (10.160.224.149) by CY1PR0101MB0986.prod.exchangelabs.com (10.160.224.148) with Microsoft SMTP Server (TLS) id 15.1.523.12; Thu, 21 Jul 2016 16:26:10 +0000 Received: from CY1PR0101MB0987.prod.exchangelabs.com ([10.160.224.149]) by CY1PR0101MB0987.prod.exchangelabs.com ([10.160.224.149]) with mapi id 15.01.0539.016; Thu, 21 Jul 2016 16:26:10 +0000 From: Don Provan To: "Ananyev, Konstantin" , Olivier Matz , "dev@dpdk.org" , "yuanhan.liu@linux.intel.com" CC: "Chandran, Sugesh" , "Richardson, Bruce" , "Tan, Jianfeng" , "adrien.mazarguil@6wind.com" Thread-Topic: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum Thread-Index: AQHR4z7i8TkO93xcCEmz8rkI5zHq16AjD/Tw Date: Thu, 21 Jul 2016 16:26:09 +0000 Message-ID: References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com> <1469088510-7552-5-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725836B804B3@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725836B804B3@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dprovan@bivio.net; x-originating-ip: [209.234.132.35] x-ms-office365-filtering-correlation-id: 066fd679-7afc-4706-071c-08d3b183b9e1 x-microsoft-exchange-diagnostics: 1; CY1PR0101MB0986; 6:a0q6W5VEJsZdmnjPeXshw2Wu31lGqauvVqF6z8KUiH7cvhW7XO6bqTGDkWvBmGTgpd0KbKATGnUmpSJ2Hr9Kh1ogoBcvtAAeXUstIaUY7OMp7/tbEvDdNxC8ZSiXWoBpS6HXIJ71N3xQ1pWCvCqGrbRiC/eHJp+Nmleb9Xb2nURE7cycoKLXrZt8ZUAO8L6tjzGgUxDVjVGSR1To9Tuj0U6yoe32oMvdVruduTfaaRcxCQSTQAj5+xoA+DZtqqfgwei+PKbqCXnJGKlDyUO9O+wG9U+a+nWWii9WOWi2ajkkfDxwDZ03+11W45u38pOX; 5:jnBubOZSSY8BrqjP5JyUQ2Fr1yslNPgAG53jymILrVkKgQGbR9ki12YvzBmCfUSlelhqVzc/e5T3v6+GaRRv+lG5z03PrczwC/2EDZXOHkXEL9XwyKcfa8SjKrJo4Za7i4vpTOvufvXPS0SQovO/dQ==; 24:Gj4hoptB/wNwYJGewCSDsGa6icOMejTf4V1CfiO29oO9ZtOsTeKKHX2JOQ4hP6tCEKZ1o8opUd8+XoNm4WJfjAliRF5FT2KMmTawNTAMPnY=; 7:gaMOpcUCx2DJmM3yGLSKSo8lvj5m/wbdqXRrdqBRAzHy7fNuOJBOCy8XWspNpbx5YRuYpoFuWEXtkAM52I0NyEzBwo2j2woF5Kjpl6IuxaHKJSaHJiIc6b8eJxAtZCdvF6ksCp6hmLPUduuRcaKoIjGtW8BS8TgPrpSlhr+V+/ZGVP5wb7j7fWo5n4RBfMj0Q8QUhgRg8xAOjvcqY3FGoQopxim1LutWTeAFfKByMU2jJvyKwVCwr1T1yEYuE16G x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0101MB0986; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040130)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046)(6042046); SRVR:CY1PR0101MB0986; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0101MB0986; x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(199003)(57704003)(377454003)(13464003)(189002)(4326007)(5003600100003)(7696003)(189998001)(305945005)(8936002)(2906002)(92566002)(122556002)(101416001)(19580405001)(19580395003)(87936001)(54356999)(97736004)(74316002)(5002640100001)(9686002)(3280700002)(68736007)(7846002)(3846002)(3660700001)(2900100001)(105586002)(66066001)(2201001)(2501003)(6116002)(106356001)(33656002)(586003)(50986999)(106116001)(2950100001)(81166006)(11100500001)(5001770100001)(10400500002)(86362001)(77096005)(102836003)(76176999)(7736002)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0101MB0986; H:CY1PR0101MB0987.prod.exchangelabs.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: bivio.net does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: bivio.net X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2016 16:26:09.9392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8731bc55-0e76-4eb7-ae4b-401e56037945 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0101MB0986 Subject: Re: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 16:26:15 -0000 > -----Original Message----- > From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com] > Sent: Thursday, July 21, 2016 3:51 AM > Subject: Re: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a > checksum >=20 >... > > + Added a new function ``rte_pktmbuf_cksum()`` to process the checksum > > + of data embedded in an mbuf chain. > >... > > +#include > > As a nit, do we need to introduce a dependency for librte_mbuf on librte_= net? > Might be better to put this functionality into librte_net? That's not a nit at all. This is clearly a net function that has no place i= n the mbuf code. That should be obvious even before we notice this circular dependency. -don dprovan@bivio.net