From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0101.outbound.protection.outlook.com [207.46.100.101]) by dpdk.org (Postfix) with ESMTP id 104ABDE3 for ; Mon, 21 Dec 2015 23:34:32 +0100 (CET) Received: from CY1PR0101MB0985.prod.exchangelabs.com (10.160.224.147) by CY1PR0101MB0905.prod.exchangelabs.com (10.160.139.20) with Microsoft SMTP Server (TLS) id 15.1.355.16; Mon, 21 Dec 2015 22:34:29 +0000 Received: from CY1PR0101MB0987.prod.exchangelabs.com (10.160.224.149) by CY1PR0101MB0985.prod.exchangelabs.com (10.160.224.147) with Microsoft SMTP Server (TLS) id 15.1.361.13; Mon, 21 Dec 2015 22:34:27 +0000 Received: from CY1PR0101MB0987.prod.exchangelabs.com ([10.160.224.149]) by CY1PR0101MB0987.prod.exchangelabs.com ([10.160.224.149]) with mapi id 15.01.0361.006; Mon, 21 Dec 2015 22:34:27 +0000 From: Don Provan To: "Xie, Huawei" , "Wiles, Keith" , Stephen Hemminger , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API Thread-Index: AQHRPAnu0f/7KZu/kEO3j+1GlfyeW57VzUhQ Date: Mon, 21 Dec 2015 22:34:27 +0000 Message-ID: References: <1450049754-33635-1-git-send-email-huawei.xie@intel.com> <1450055682-51953-1-git-send-email-huawei.xie@intel.com> <1450055682-51953-2-git-send-email-huawei.xie@intel.com> <20151217210114.534a7561@xeon-e3> <2601191342CEEE43887BDE71AB97725836AD5AEB@irsmsx105.ger.corp.intel.com> <20151218093206.35e2e3e4@xeon-e3> <8987AF45-5666-42AB-8358-09025143205B@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dprovan@bivio.net; x-originating-ip: [209.234.132.35] x-microsoft-exchange-diagnostics: 1; CY1PR0101MB0985; 5:hOXOavCmcItm6F+lloKYpAmNkQfRVxdiGuqzrMbuVswnLtMFbuAd2mkCbSUcWosBteEVKJFBlSchFtDwfmqRZdB8wK9My+a069fnQHjHERx7ES1uG86RD8CFnedp31oLXa57bdyazo/s0fk/gwK+wQ==; 24:3dCE3X5t+OP7NU4ck1BEEBb5fnbUHmGzur1pTDUwskb+3MxhBHtKjLvEtilZEgRgz9xZz5H4LDZfz6qDKaHAwJxms0rS1eUguuWqcbUhB1Y= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0101MB0985; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001); SRVR:CY1PR0101MB0985; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0101MB0985; x-forefront-prvs: 079756C6B9 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(199003)(377454003)(189002)(66066001)(33656002)(11100500001)(54356999)(10400500002)(76176999)(50986999)(40100003)(97736004)(106116001)(81156007)(5002640100001)(5001960100002)(5003600100002)(77096005)(106356001)(1220700001)(92566002)(105586002)(586003)(6116002)(93886004)(102836003)(87936001)(1096002)(86362001)(3846002)(2900100001)(5001770100001)(122556002)(2950100001)(5008740100001)(101416001)(74316001)(5004730100002)(19580405001)(19580395003)(189998001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0101MB0985; H:CY1PR0101MB0987.prod.exchangelabs.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: bivio.net does not designate permitted sender hosts) spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2015 22:34:27.1526 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8731bc55-0e76-4eb7-ae4b-401e56037945 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0101MB0985 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0101MB0905; 2:YOPEFUx660hn9N2vfxlv+PgEjfmLKnYORoKlixy/wBE6LNi3+tjQs0zVfmQeqfiRsRQEIKMhbJKzI68BeL22yCoxlNuU2Y21N/mS4Ah2JiEK7qLTqb8Xs+qt21ABDYNj18Jm6KS7Tmruc70w6tSncQ==; 23:eqOarPrOy6vfjrcxdJfIKUA5OIO7RI/5yg49zr/gho/l92d5L5M+qZCWbFUgan4ksogSrBVEht4E03ZcSfiSq9HxOsoPXD63fgElq0S5WaE2Pfc+1SIrsw4vs3CvRtmXo+Cm7en9OIO8EL4upDm9ztUePWDSoHm5zNgeOKeXu1CD0yZfBbFjJ1Ghhe3dZJKK X-OriginatorOrg: bivio.net Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2015 22:34:32 -0000 >From: Xie, Huawei [mailto:huawei.xie@intel.com]=20 >Sent: Monday, December 21, 2015 7:22 AM >Subject: Re: [dpdk-dev] [PATCH v2 1/2] mbuf: provide rte_pktmbuf_alloc_bul= k API > >The loop unwinding could give performance gain. The only problem is the sw= itch/loop >combination makes people feel weird at the first glance but soon they will= grasp this style. >Since this is inherited from old famous duff's device, i prefer to keep th= is style which saves >lines of code. You don't really mean "lines of code", of course, since it increases the li= nes of code. It reduces the number of branches. Is Duff's Device used in other "bulk" routines? If not, what justifies maki= ng this a special case? -don provan dprovan@bivio.net