Re: [dpdk-dev] [PATCH] fix testpmd show port info error

[Xuelin Shi <xuelin.shi@freescale.com>]

Hi Olivier,

Would you please help to review the bottom patch?

Thanks,
Shi Xuelin

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xuelin Shi
Sent: Thursday, February 05, 2015 17:27
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fix testpmd show port info error

Hi,

Anybody interested in this patch could have a review or comment on it?
I'm new here. Should I send this patch to some specific maintainer to make this more efficient?

Thanks,
Shi Xuelin

-----Original Message-----
From: xuelin.shi@freescale.com [mailto:xuelin.shi@freescale.com] 
Sent: Monday, February 02, 2015 14:52
To: dev@dpdk.org
Cc: Shi Xuelin-B29237
Subject: [PATCH] fix testpmd show port info error

From: Xuelin Shi <xuelin.shi@freescale.com>

the port number type should be consistent with librte_cmdline, else there is potential endian issue.

Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4beb404..488ac63 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -5568,7 +5568,7 @@ cmdline_parse_token_string_t cmd_showport_what =
 	TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what,
 				 "info#stats#xstats#fdir#stat_qmap");
 cmdline_parse_token_num_t cmd_showport_portnum =
-	TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32);
+	TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT8);
 
 cmdline_parse_inst_t cmd_showport = {
 	.f = cmd_showport_parsed,
--
1.9.1