DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Bly, Mike" <mbly@ciena.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	"Yeddula, Avinash" <ayeddula@ciena.com>,
	"dev@dpdk.org" <dev@dpdk.org>, dev <dev-bounces@dpdk.org>,
	"users@dpdk.org" <users@dpdk.org>
Subject: Re: [dpdk-dev] 17.05 --> 17.11, minimum hash table key size
Date: Fri, 29 Jun 2018 20:00:45 +0000	[thread overview]
Message-ID: <CY1PR04MB20573068762B33C15EE7C8ACCF4E0@CY1PR04MB2057.namprd04.prod.outlook.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E7621D9@IRSMSX108.ger.corp.intel.com>

Cristian,

Thank you. I have done the recommended change. The next thing we have run into is the f_hash selection. We were historically using rte_hash_crc_8byte() from rte_has_crc.h. In looking at DPDK content, I do not see anything close in an rte_*.h file to use with the appropriate input parameter list. I did find use of hash_default_key8() in examples/ip_pipeline/pipeline/hash_func.h. Is there no formal rte_*.h replacement/update for this relative to the hash-table changes in 17.11+? Is the expectation that the implementer will create their own as done with the aforementioned ip_pipeline example?

-MikeB

-----Original Message-----
From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> 
Sent: Friday, June 29, 2018 4:18 AM
To: Yeddula, Avinash <ayeddula@ciena.com>; dev@dpdk.org; dev <dev-bounces@dpdk.org>; users@dpdk.org
Cc: Bly, Mike <mbly@ciena.com>
Subject: [**EXTERNAL**] RE: 17.05 --> 17.11, minimum hash table key size


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yeddula, Avinash
> Sent: Friday, June 29, 2018 1:11 AM
> To: dev@dpdk.org; dev <dev-bounces@dpdk.org>; users@dpdk.org
> Cc: Bly, Mike <mbly@ciena.com>
> Subject: [dpdk-dev] 17.05 --> 17.11, minimum hash table key size
> 
> Hello,
> 
> We are in process of migrating our design from DPDK 17.05 to 17.11 and 
> we ran into a small problem. Within our design, we have some hash 
> tables with 4-byte keys. While going through the changes done in 
> 17.11, we have found there was an added key_size check, which now 
> requires key_size >= 8 bytes (see check_params_create() in 
> rte_table_hash_ext.c). Not seeing any other options, so I was hoping 
> someone could advise on how to support a 4-byte hash key size in 17.11 and on a go forward basis.
> 
> Regards,
> Avinash

Hi Avinash,

Simply declare you key size to be 8 bytes for any key size less or equal to 8 bytes and set the key mask parameter appropriately so that the additional bytes are masked out.

Regards,
Cristian

  reply	other threads:[~2018-06-29 20:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29  0:10 Yeddula, Avinash
2018-06-29 11:17 ` Dumitrescu, Cristian
2018-06-29 20:00   ` Bly, Mike [this message]
2018-07-02  9:33     ` Dumitrescu, Cristian
  -- strict thread matches above, loose matches on Subject: below --
2018-06-29  0:03 Bly, Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY1PR04MB20573068762B33C15EE7C8ACCF4E0@CY1PR04MB2057.namprd04.prod.outlook.com \
    --to=mbly@ciena.com \
    --cc=ayeddula@ciena.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev-bounces@dpdk.org \
    --cc=dev@dpdk.org \
    --cc=users@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).