From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730073.outbound.protection.outlook.com [40.107.73.73]) by dpdk.org (Postfix) with ESMTP id 4D0461BF00 for ; Fri, 6 Jul 2018 15:48:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NkMqjOF7vvAIzti5foakfVFQMXyBDVp1PQhrXvuJHVI=; b=Az5sT9JBMCX+2XR/SIOCFpN8N7NTGd3RLOAW16hH5AJKw5pF6W6JsNoZY2+f77C6YrAHX8fIKYDMmmszj9nvzhn5qHhWLhQFgocvPHlMSF6HyWdn4zHAKtzQ9zT9JarsHJ4l86N/i+ZbB8tfPmtd8N99MAl8Y8xnVe7xAGdrJdA= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3762.namprd07.prod.outlook.com (52.132.102.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.18; Fri, 6 Jul 2018 13:48:47 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0930.016; Fri, 6 Jul 2018 13:48:47 +0000 From: "Verma, Shally" To: "Trahe, Fiona" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Murthy, Nidadavolu" , "Kartha, Umesh" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations Thread-Index: AQHUEuIboNMAAvCHE0e4GxFLk5TBCaSCODKAgAAB/BA= Date: Fri, 6 Jul 2018 13:48:47 +0000 Message-ID: References: <1530631466-26427-1-git-send-email-shally.verma@caviumnetworks.com> <1530631466-26427-3-git-send-email-shally.verma@caviumnetworks.com> <348A99DA5F5B7549AA880327E580B435895C88E3@IRSMSX103.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435895C88E3@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3762; 7:LFrBKFxDiq0G/qVkQHna7WrczzhqoFaC38uMv7hvQpGTb5iQ3teqlKO9rSNrz+58pcEQaEQ95s32YsYjEZSJxN5oYVp2n07HM15UMYT4zQBgxvRs3W/GLpoScTdeWbOAovhKLRUUZQ5epqvgLtw/lMW9tqPeXEf6X3uO+edOm1ybP0lNDHg1kb4e8dwFZ3wXXU84bFilpCpWZBkk0PkaHzuI2WRKc2JIher105UTiZBQawnplRUR6QN3jFRIpkOo x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(39850400004)(136003)(396003)(366004)(376002)(346002)(189003)(199004)(13464003)(66066001)(105586002)(478600001)(305945005)(2900100001)(72206003)(6116002)(25786009)(106356001)(53936002)(2906002)(5660300001)(229853002)(5250100002)(81166006)(6506007)(81156014)(26005)(186003)(8936002)(53546011)(6246003)(7736002)(6436002)(8676002)(55236004)(102836004)(55016002)(107886003)(14454004)(99286004)(9686003)(4326008)(76176011)(68736007)(7696005)(316002)(110136005)(3846002)(97736004)(33656002)(486006)(11346002)(446003)(86362001)(256004)(74316002)(476003)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3762; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: 0404340f-1049-42f0-ed45-08d5e3473286 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3762; x-ms-traffictypediagnostic: CY4PR0701MB3762: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3762; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3762; x-forefront-prvs: 0725D9E8D0 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: KvVt7mOdWrpvva3bNp3x9m5HxJGM0xjfJ1yI+h5dwuaYDauB1JVN5k02EqIDf4Jxy9o6s8BLHdaKyuh7iDrMuYEXiRepwQd0k88DvQSWR46UGq7Snt6L240jYBuiFDdoKrncpawOdj54clTN5NQC/nFSZn5WqOMiLipx8dWqdjshwVeQieNSoqZquXUN9xTwMeZsH/tjbOemSZ+ID8tMlAom4AcXj3K6CZoKty8dNRcCAZnZSdgG7ot3bMwSZ9jzy58ke7vG/+esIAjfWu2BRjOff3qpsA09RUMmaIBHWEGLvDqmpaVmEecfEsRz2rjlioen0NqGDqgdppdJ6oUaGE5UxhE7tPWkayEySDJ4+Bk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0404340f-1049-42f0-ed45-08d5e3473286 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2018 13:48:47.1429 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3762 Subject: Re: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 13:48:49 -0000 Hi Fiona >-----Original Message----- >From: Trahe, Fiona [mailto:fiona.trahe@intel.com] >Sent: 06 July 2018 19:11 >To: Verma, Shally ; De Lara Guarch, Pablo >Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Murthy, Nidadavolu >; Kartha, Umesh ; S= ahu, Sunila ; Gupta, >Ashish ; Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric opera= tions > >External Email > >Hi Shally, Umesh, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shally Verma >> Sent: Tuesday, July 3, 2018 4:24 PM >> To: De Lara Guarch, Pablo >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; nmurthy@caviumnetworks.co= m; Umesh Kartha >> ; Sunila Sahu ; Ashish >> Gupta >> Subject: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operati= ons > > >//snip// >> + >> +int __rte_experimental >> +rte_cryptodev_asym_session_set_private_data( >> + struct rte_cryptodev_asym_session = *sess, >> + void *data, >> + uint16_t size) >> +{ >> + uint16_t off_set =3D sizeof(void *) * nb_drivers; >> + uint8_t *private_data_present =3D (uint8_t *)sess + off_set; >> + >> + if (sess =3D=3D NULL) >> + return -EINVAL; >> + >> + *private_data_present =3D 1; >> + off_set +=3D sizeof(uint8_t); >> + rte_memcpy((uint8_t *)sess + off_set, data, size); >> + return 0; >> +} >> + >> +void * __rte_experimental >> +rte_cryptodev_asym_session_get_app_private_data( >> + struct rte_cryptodev_asym_session *sess) >[Fiona] The set api should be renamed if the get function is renamed. >However, I'd suggest leaving out these functions unless they're really nee= ded for asymm. >Are they just here for consistency with the sym functions? >The sym functions are still experimental and I think the names should be c= hanged to >use user_data instead of private_data. >I've just sent a patch to the mailing list about this - it would be better= to resolve that naming >issue first and add corresponding fns later to this api if needed. Ya . right now they were there for consistency. You prefer to remove them? Thanks Shally