From: "Verma, Shally" <Shally.Verma@cavium.com>
To: "Daly, Lee" <lee.daly@intel.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"pathreay@caviumnetworks.com" <pathreay@caviumnetworks.com>,
"Sahu, Sunila" <Sunila.Sahu@cavium.com>,
"Gupta, Ashish" <Ashish.Gupta@cavium.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops
Date: Mon, 25 Jun 2018 10:07:46 +0000 [thread overview]
Message-ID: <CY4PR0701MB3634252F4118C57E29882CB8F04A0@CY4PR0701MB3634.namprd07.prod.outlook.com> (raw)
In-Reply-To: <F5C6929789601049BEB7272E267355985795ED@IRSMSX106.ger.corp.intel.com>
HI Lee
>-----Original Message-----
>From: Daly, Lee [mailto:lee.daly@intel.com]
>Sent: 25 June 2018 15:35
>To: Verma, Shally <Shally.Verma@cavium.com>
>Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org; pathreay@caviumnetworks.com; Sahu, Sunila <Sunila.Sahu@cavium.com>;
>Gupta, Ashish <Ashish.Gupta@cavium.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>Subject: RE: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops
>
//snip
>> >>+static const struct rte_compressdev_capabilities zlib_pmd_capabilities[]
>> = {
>> >>+ { /* Deflate */
>> >>+ .algo = RTE_COMP_ALGO_DEFLATE,
>> >>+ .comp_feature_flags =
>> RTE_COMP_FF_SHAREABLE_PRIV_XFORM,
>> >[Lee] The priv_xform structure in this case is not shareable, as it
>> >contains your zlib_stream structure, which contains zlibs own zstream
>> >struct. This is not read only, the contents of this zstream will be written to,
>> which means it is not shareable across queue pairs or devices.
>> >
>> [Shally] Per my understanding, SHAREABLE_PRIV_XFORM here means xform
>> is shareable by all ops in one single enqueue_burst() but not across devices
>> or qps by multiple threads in parallel. Does your implementation support
>> such usage of shareable priv_xforms?
>>
>> Thanks for review.
>> Shally
>[Lee]
>Hey Shally, I have just clarified this with Fiona and Pablo and the intended use of Shareable priv xforms is to allow a xform to be shared
>across devices & qps not just all the ops in a burst, yes the ISA-L PMD has a shareable private xform due to all its contents being read
>only.
>
[Shally] Ok. Got that. Will change it accordingly.
Thanks
Shally
>>
>> >>+ .window_size = {
>> >>+ .min = 8,
>> >>+ .max = 15,
>> >>+ .increment = 2
>> >>+ },
>> >>+ },
>> >>+
>> >>+ RTE_COMP_END_OF_CAPABILITIES_LIST()
>> >>+
next prev parent reply other threads:[~2018-06-25 10:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 10:32 [dpdk-dev] [PATCH v1 0/6]compress: add zlib compression PMD Shally Verma
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 1/6] compress/zlib: add ZLIB PMD support Shally Verma
2018-06-15 11:08 ` Daly, Lee
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops Shally Verma
2018-06-15 11:08 ` Daly, Lee
2018-06-22 13:21 ` Verma, Shally
2018-06-25 10:05 ` Daly, Lee
2018-06-25 10:07 ` Verma, Shally [this message]
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 3/6] compress/zlib: add xform and stream create support Shally Verma
2018-06-15 11:09 ` Daly, Lee
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 4/6] compress/zlib: add enq deq apis Shally Verma
2018-06-15 11:09 ` Daly, Lee
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 5/6] test: add ZLIB PMD for compressdev tests Shally Verma
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 6/6] doc: add ZLIB PMD documentation Shally Verma
2018-06-15 11:09 ` Daly, Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR0701MB3634252F4118C57E29882CB8F04A0@CY4PR0701MB3634.namprd07.prod.outlook.com \
--to=shally.verma@cavium.com \
--cc=Ashish.Gupta@cavium.com \
--cc=Sunila.Sahu@cavium.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=lee.daly@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreay@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).