From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0048.outbound.protection.outlook.com [104.47.41.48]) by dpdk.org (Postfix) with ESMTP id 070FC5F2C for ; Mon, 25 Jun 2018 12:07:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f/HkgOhDpkmm7r45ZEBr4ka6ynG6NTSMvcJh/spZCPI=; b=Ux6uYn09bWiuAEyuK41hwpXv+jKXfhKo62oKeUYm2ETG4CFZnsjMEQghu9iIqnWok/wMoynw52i73TQNkZDXV2TxR3AD7NYqtsGnZSnLE3om/Aykr15zizjH5pIFbpVNVAqVBvJluUqkcmkclp5rx749sNPuW9XI4Sovt1w/8/4= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3651.namprd07.prod.outlook.com (52.132.102.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Mon, 25 Jun 2018 10:07:47 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%4]) with mapi id 15.20.0884.024; Mon, 25 Jun 2018 10:07:46 +0000 From: "Verma, Shally" To: "Daly, Lee" CC: "Trahe, Fiona" , "dev@dpdk.org" , "pathreay@caviumnetworks.com" , "Sahu, Sunila" , "Gupta, Ashish" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops Thread-Index: AQHT7Dgou/fNPKY/1kaq6EF706bcK6RhWhSAgAsjOpCABIJLAIAAACtw Date: Mon, 25 Jun 2018 10:07:46 +0000 Message-ID: References: <1526380346-7386-1-git-send-email-shally.verma@caviumnetworks.com> <1526380346-7386-3-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3651; 7:lF5hF9wJo9hLDxNR0DBfpOXf3NXZ8PLFSBnxUwVjVFmpSNzgqUVpJqTR97jfoLNKS0ET6rBxVj1jqSb4skP8NtzicFPaOTtmVf1Hvd65Rh0YIUKNsNHYnRUWik0WCo4HaK8+XBQwFi5yJd/6gF/YDNZlr4pf+/5nxuHeikMmKY/QS88lpSfHQ07R5yqHVFmP9YCsGB2PiktiyhpmCDZSeB1v8rfClhHBZf6utJnzF58x806p3Ufm4s9UU3xTE2Wu x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(346002)(39380400002)(39860400002)(366004)(376002)(189003)(199004)(13464003)(105586002)(8936002)(446003)(54906003)(86362001)(11346002)(93886005)(316002)(33656002)(74316002)(76176011)(102836004)(55236004)(6506007)(68736007)(66066001)(99286004)(106356001)(97736004)(9686003)(5250100002)(8676002)(81166006)(476003)(305945005)(81156014)(7736002)(486006)(55016002)(3660700001)(14454004)(26005)(186003)(25786009)(4326008)(6436002)(6116002)(3846002)(7696005)(6246003)(53936002)(229853002)(6916009)(2900100001)(2906002)(5660300001)(478600001)(72206003)(3280700002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3651; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: d2906719-1dfb-42b3-462c-08d5da837ff8 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3651; x-ms-traffictypediagnostic: CY4PR0701MB3651: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3651; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3651; x-forefront-prvs: 0714841678 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: I4HMU2oIoTx9WDC0ID4+3ba+UyYDlS9N+87EY5VqR+2iw3APvkEgjbPE5gN4/kbbutvE7TF5HGe8aMwDBlR9CsM42Sn0yRVPMhNnr2DMzoipuAX4SpsZPSbbBpZqlNSn2ntdK5x/Q+w16lgWbd8C27eqZQ++nKQxFegq/MnowXDjqnOhi/tGvAe14Btlm5GWvCBcPvgir6GkkH9x0oC9iOxcKvEb+CB7a9ZRKmfTAT6zxxBloTjz8vAl6NDw/0NVoMW1tvpKp5ZSQwu2zOFBvPsu1Z1iFN0b+gaQN54IbAXopWvGCXIdYGzWMwzWJoqJWTnU7nxspgLEveYOdLJeVC4GrDLk2GP+7x0G8oz6LEY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2906719-1dfb-42b3-462c-08d5da837ff8 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2018 10:07:46.3640 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3651 Subject: Re: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 10:07:49 -0000 HI Lee >-----Original Message----- >From: Daly, Lee [mailto:lee.daly@intel.com] >Sent: 25 June 2018 15:35 >To: Verma, Shally >Cc: Trahe, Fiona ; dev@dpdk.org; pathreay@caviumnet= works.com; Sahu, Sunila ; >Gupta, Ashish ; De Lara Guarch, Pablo >Subject: RE: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD= ops > //snip >> >>+static const struct rte_compressdev_capabilities zlib_pmd_capabilitie= s[] >> =3D { >> >>+ { /* Deflate */ >> >>+ .algo =3D RTE_COMP_ALGO_DEFLATE, >> >>+ .comp_feature_flags =3D >> RTE_COMP_FF_SHAREABLE_PRIV_XFORM, >> >[Lee] The priv_xform structure in this case is not shareable, as it >> >contains your zlib_stream structure, which contains zlibs own zstream >> >struct. This is not read only, the contents of this zstream will be wri= tten to, >> which means it is not shareable across queue pairs or devices. >> > >> [Shally] Per my understanding, SHAREABLE_PRIV_XFORM here means xform >> is shareable by all ops in one single enqueue_burst() but not across dev= ices >> or qps by multiple threads in parallel. Does your implementation support >> such usage of shareable priv_xforms? >> >> Thanks for review. >> Shally >[Lee] >Hey Shally, I have just clarified this with Fiona and Pablo and the intend= ed use of Shareable priv xforms is to allow a xform to be shared >across devices & qps not just all the ops in a burst, yes the ISA-L PMD ha= s a shareable private xform due to all its contents being read >only. > [Shally] Ok. Got that. Will change it accordingly. Thanks Shally >> >> >>+ .window_size =3D { >> >>+ .min =3D 8, >> >>+ .max =3D 15, >> >>+ .increment =3D 2 >> >>+ }, >> >>+ }, >> >>+ >> >>+ RTE_COMP_END_OF_CAPABILITIES_LIST() >> >>+