From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0085.outbound.protection.outlook.com [104.47.33.85]) by dpdk.org (Postfix) with ESMTP id 0433F1B447 for ; Thu, 5 Jul 2018 13:12:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rKgJ5DtYwj1Z/QziXFRnMQ50TSqJJHbqM7KxSuSUIKM=; b=M0zORlgBoXJ5khhT5H1VaSTL6PDtK6tqe6gYEbq//0BfNKFI/mwbAy2ZRfk0eomKSfMUPOQoyYqbIB3Og16OPe+g2qT7OrGCxr77kXeCVCHNqhSYBaONkH2OEhOrTgXO2TxG0P+6M71dJTaZbhjhh/kTxmncZa6VrsEAh7mHmTQ= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3620.namprd07.prod.outlook.com (52.132.101.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.19; Thu, 5 Jul 2018 11:12:51 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%4]) with mapi id 15.20.0906.026; Thu, 5 Jul 2018 11:12:51 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" , "Gupta, Ashish" , "Trahe, Fiona" , "Daly, Lee" , "Sahu, Sunila" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUE+SndvECSlPZO0SAjH2oKlC5saSAT3KwgAAo/wCAAAHpAA== Date: Thu, 5 Jul 2018 11:12:50 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-3-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3620; 7:PB83UPagAMlZffdPkdBp4gCO2GugqFWHw6xW/jH30J3pSFhwWLhfp0823G/2uONGXHcR+KGCcbfoLB1NZLl2oAmCgf6wm1ECIKwZFzVsJ4e6++mzHW42jOFM3eW/aGABruAkuqA4xgZbbJcx/5faYQuISkXk/JCckHrBLb6o99KYXcuw1pdZfl16SeIjok5ZD0YibtBPKHInTr4ajFQAIcYU9aev+X+zWR/JK4jxQESI8x0I8KQ0m+uUqLRqWPOc x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(366004)(396003)(39850400004)(346002)(136003)(376002)(13464003)(189003)(57704003)(199004)(4326008)(6436002)(53936002)(55016002)(9686003)(6246003)(446003)(11346002)(476003)(486006)(186003)(26005)(7736002)(305945005)(5250100002)(2906002)(74316002)(25786009)(66066001)(86362001)(72206003)(68736007)(478600001)(33656002)(97736004)(106356001)(3846002)(6116002)(229853002)(2900100001)(14454004)(81166006)(8676002)(81156014)(256004)(53546011)(7696005)(102836004)(55236004)(6506007)(76176011)(6636002)(5660300001)(8936002)(93886005)(105586002)(110136005)(99286004)(316002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3620; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: 0be87d89-6488-424f-7a7b-08d5e2683f5e x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3620; x-ms-traffictypediagnostic: CY4PR0701MB3620: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231254)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3620; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3620; x-forefront-prvs: 0724FCD4CD received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Gc7ejRehaN81MO9ruiNggfAhZWJYEL3CtjCdHXUHxn9sNHgIv1go81xHU1BO6N3P3DWWa6I96vNhXqfn2FzSsWhgWfoIY5Y64SEvqNotyKiwan/7YT7805qReB24bOa7C2587XKBZM1DaCQ6DVy/MCFOr5OuVid4nYq49mN8EbwEpg+SLrmxVWAXvWwwa8XssxrZOK3t+ckd2ZdNOGeaQfXdcfYjT8HsrnX2soTAjMUle25pL2pDMB+YiaSdmOQHsa4j+8Y2qwBGlpoLSEvYk1JK7/jzuyTBpnxZeFslO+bJ3P3R0hOh74muwWHI2dTMH7nZ5ZH3G/gsatO4WOjF2QgPy+gZx/dKp5ErAiGAQo4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0be87d89-6488-424f-7a7b-08d5e2683f5e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2018 11:12:50.8494 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3620 Subject: Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 11:12:53 -0000 >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 05 July 2018 16:36 >To: Verma, Shally ; Gupta, Ashish ; Trahe, Fiona ; >Daly, Lee ; Sahu, Sunila >Cc: dev@dpdk.org >Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag > >External Email > >> -----Original Message----- >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] >> Sent: Thursday, July 5, 2018 9:39 AM >> To: De Lara Guarch, Pablo ; Gupta, Ashis= h >> ; Trahe, Fiona ; Daly, L= ee >> ; Sahu, Sunila >> Cc: dev@dpdk.org >> Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather fla= g >> >> >> >> >-----Original Message----- >> >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com] >> >Sent: 04 July 2018 19:41 >> >To: Verma, Shally ; Gupta, Ashish >> >; fiona.trahe@intel.com; lee.daly@intel.com >> >Cc: dev@dpdk.org; Pablo de Lara >> >Subject: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag >> > >> >External Email >> > >> >The current mbuf scatter gather feature flag is too ambiguous, as it is >> >not clear if input and/or output buffers can be scatter gather mbufs or >> >not. >> > >> >Therefore, three new flags will replace this flag: >> >- RTE_COMP_FF_OOP_SGL_IN_SGL_OUT >> >- RTE_COMP_FF_OOP_SGL_IN_FB_OUT >> >- RTE_COMP_FF_OOP_FB_IN_SGL_OUT >> > >> [Shally] Believe Out of place is default support on current compression = API, so >> why do we need _OOP_ here? > >Hi Shally, > >You are right, but I just wanted to clarify that the scenario is for Out o= f place only. > Ok. But that looks redundant to me. Though not likely, tomorrow if some alg= o support in-place, Then we will end up adding in_place equivalent of same. So would prefer to = keep naming generic of in/out place and specific to Scatter-gather in/out support. >Thanks, >Pablo > >> >> Thanks >> Shally >> >Note that out-of-place flat buffers is supported by default and >> >in-place is not supported by the library. >> > >> >Signed-off-by: Pablo de Lara >> >Acked-by: Fiona Trahe