From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0056.outbound.protection.outlook.com [104.47.38.56]) by dpdk.org (Postfix) with ESMTP id 69F421B014 for ; Mon, 21 May 2018 14:05:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gl2+QjeqavjZc230pFB034pfuFGNtGAhjIwt89O33hY=; b=DDrAp5Tp7woUP9V2D4ExQiTRDTfentzrvxqPlp1kzn4mv6qygsxjAhgCwn7M6OVnO4UWmEtekWS5Bb3/MpJKv1Y4bf6HXVMMsSx7yqlYgnNqWjNVRS5MR636TGIoSJQFLqaxykgB56nRnRBenXR0tyKtWuISKk38sxfAtZfj+n4= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3667.namprd07.prod.outlook.com (52.132.102.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.776.16; Mon, 21 May 2018 12:05:04 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::789f:eecf:a225:7b0d]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::789f:eecf:a225:7b0d%4]) with mapi id 15.20.0776.010; Mon, 21 May 2018 12:05:04 +0000 From: "Verma, Shally" To: Pablo de Lara , "declan.doherty@intel.com" , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 6/6] cryptodev: rename get session size API Thread-Index: AQHT8PPUQQccM6vdhkWW25qaJ0zNlaQ6FF4g Date: Mon, 21 May 2018 12:05:04 +0000 Message-ID: References: <20180126090355.25903-1-pablo.de.lara.guarch@intel.com> <20180521110656.42437-1-pablo.de.lara.guarch@intel.com> <20180521110656.42437-7-pablo.de.lara.guarch@intel.com> In-Reply-To: <20180521110656.42437-7-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3667; 7:awkb5AyK+PKOPOZfCB+BTjFNOEvbw3QHdT/bfcoNXYuYvSlwSKvhbQj89EV5LvJI+WVZ9Nnf1yVwAsDtg1AZUUHYkboVbj3vJjcAatEDM3UlavGJga4vkWzTWX3QzT/oVU/u8v5Mx1jdvRC/6peBlIG+gCX1t229UAAkacUBYYX8QwD/YLXw89z2637cSWLU2fb7AP0JeVysJY1KEtWPXR2ENzvoDjYCdfnuaCS5t7L9trKpzmbErCg6g93i9aD4 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3667; x-ms-traffictypediagnostic: CY4PR0701MB3667: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3667; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3667; x-forefront-prvs: 06793E740F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(396003)(39380400002)(366004)(13464003)(199004)(189003)(478600001)(305945005)(53936002)(55016002)(14454004)(6246003)(55236004)(102836004)(6506007)(8656006)(76176011)(8936002)(8676002)(7696005)(81166006)(6436002)(9686003)(68736007)(33656002)(5660300001)(7736002)(4326008)(316002)(81156014)(229853002)(25786009)(99286004)(74316002)(72206003)(2906002)(476003)(110136005)(86362001)(186003)(3280700002)(105586002)(106356001)(2501003)(2900100001)(446003)(66066001)(6116002)(3846002)(97736004)(2201001)(26005)(5250100002)(11346002)(3660700001)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3667; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: rqLPg+b3Qg+NrWA5fWsKmueG6qFqntuNRRcKb70ZGYJjhhWScz/KoKjztw0DsHSBiUpdkaOZQbG57Q/KJ9yajizqxyy4kgPGos73f02bK8trr+kgXKLJ8ra4v9gYuYL/BHOaGreSYJ6SV0JWgjRLZkoSztpbGqO8taAxqpyNrgeGhy3ngdQguugS0sUjDVgH spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c0a9cc7e-8c77-4b14-ea6e-08d5bf1316b2 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0a9cc7e-8c77-4b14-ea6e-08d5bf1316b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2018 12:05:04.8432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3667 Subject: Re: [dpdk-dev] [PATCH v4 6/6] cryptodev: rename get session size API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 12:05:06 -0000 >-----Original Message----- >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com] >Sent: 21 May 2018 16:37 >To: declan.doherty@intel.com; akhil.goyal@nxp.com; Verma, Shally >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH v4 6/6] cryptodev: rename get session size API > >rte_cryptodev_get_header_session_size() and >rte_cryptodev_get_private_session_size() functions are >targetting symmetric sessions. > >With the future addition of asymmetric operations, >these functions need to be renamed from *_session_* >to *_sym_session_* to be symmetric specific. > >Signed-off-by: Pablo de Lara >--- //snip >diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/r= te_cryptodev.h >index db367a1f8..e02b474d7 100644 >--- a/lib/librte_cryptodev/rte_cryptodev.h >+++ b/lib/librte_cryptodev/rte_cryptodev.h >@@ -969,15 +969,18 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id, > struct rte_cryptodev_sym_session *sess); > > /** >+ * deprecated > * Get the size of the header session, for all registered drivers. > * > * @return > * Size of the header session. > */ >+__rte_deprecated > unsigned int > rte_cryptodev_get_header_session_size(void); > > /** >+ * @deprecated > * Get the size of the private session data for a device. > * > * @param dev_id The device identifier. >@@ -986,9 +989,33 @@ rte_cryptodev_get_header_session_size(void); > * - Size of the private data, if successful > * - 0 if device is invalid or does not have private session > */ >+__rte_deprecated > unsigned int > rte_cryptodev_get_private_session_size(uint8_t dev_id); > >+/** >+ * Get the size of the header session, for all registered drivers. >+ * >+ * @return >+ * Size of the symmetric eader session. >+ */ >+unsigned int >+rte_cryptodev_get_header_sym_session_size(void); >+ [Shally] To keep consistency in naming convention, we can rename API to rte= _cryptodev_sym_get_header_session_size and rte_cryptodev_sym_get_private_s= ession_size =20 Thanks Shally