From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0051.outbound.protection.outlook.com [104.47.42.51]) by dpdk.org (Postfix) with ESMTP id 77CBF8E5E for ; Wed, 9 May 2018 09:34:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ondtw5yMtEd2hiVQTnNT1RiKLl/e2LUaS/4syuvBosk=; b=SxtdT/tN7UcG5m3nRyzYOvJUGMmlNrMeyv/PhtfBY8OfA8mWY7EY3iGZNXw9djR3UQ1nhR8Ft0jxe5JtA1SevR9Sag+DsOITZfqNHV71Pcj4blfl5YBCZfVZ3lxJThy2O8Rmv5Lew+q8aBCBdPUxR7u11tYffuieTOj8XySH1QU= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 9 May 2018 07:34:11 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::b0a9:2be9:bfdf:fc0a]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::b0a9:2be9:bfdf:fc0a%13]) with mapi id 15.20.0755.012; Wed, 9 May 2018 07:34:10 +0000 From: "Verma, Shally" To: "Trahe, Fiona" , "De Lara Guarch, Pablo" CC: "Doherty, Declan" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" , "dev@dpdk.org" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v2 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev Thread-Index: AQHT5t1BH8YRNPs9r0aZbIYuaG6ELKQnAqvw Date: Wed, 9 May 2018 07:34:10 +0000 Message-ID: References: <1522927489-23668-1-git-send-email-shally.verma@caviumnetworks.com> <1522927489-23668-4-git-send-email-shally.verma@caviumnetworks.com> <348A99DA5F5B7549AA880327E580B4358947CD5D@IRSMSX103.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358947CD5D@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3634; 7:VwBdoI6+lbrnLfEHA2Y91rmyPoIYL31HR3qy6hRgJGIgloooTKmCeinX9BJPrRhpcVlndLdgS+rOcKaPzZmXcepAZZHK0vjNDh41JYrd9zOQB3wShDz0jMoEHU13iED459XiVCFWNqT+A0Ne0iqoPUbdwHXtNDS4JeHCwBYLbYqa4CJ0StQySWmVcqZVY/g0bJhzRDH79GA9jeSICp4MZZzoHPcaRpQrmFm9SA7VzCp7IsKxBqv0WxSYw3RHRlem x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(346002)(39380400002)(39850400004)(366004)(376002)(189003)(199004)(13464003)(74316002)(68736007)(66066001)(4326008)(33656002)(3846002)(107886003)(6116002)(97736004)(25786009)(72206003)(7736002)(55016002)(8936002)(6246003)(106356001)(9686003)(53936002)(105586002)(478600001)(81166006)(305945005)(5250100002)(76176011)(2900100001)(99286004)(86362001)(186003)(7696005)(476003)(486006)(11346002)(14454004)(26005)(316002)(59450400001)(54906003)(53546011)(446003)(102836004)(8676002)(110136005)(3280700002)(229853002)(81156014)(6436002)(2906002)(3660700001)(6506007)(5660300001)(55236004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3634; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3634; x-ms-traffictypediagnostic: CY4PR0701MB3634: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR0701MB3634; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3634; x-forefront-prvs: 0667289FF8 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /RhnW+cPK8dgDndUBiZ6ZmPZiXuT1FwM4PDxbD57oGcUtAnuTpXgJBWQWEgeWRniBVKFKaP4xpHHJ56xu6kMpF9Uri7tXaOZZYSO+XOwN51hHaLIwA1iOAQs0IrQYK+2DsRxY1Y40o+oYR07hG0ZDNyAK8jwGCBnQGootPuEjcSX7Naq0yufr9bUmJj0NfVs spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e7763c66-dfa8-4b9a-6a2f-08d5b57f412e X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7763c66-dfa8-4b9a-6a2f-08d5b57f412e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 07:34:10.0734 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3634 Subject: Re: [dpdk-dev] [PATCH v2 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 07:34:14 -0000 >-----Original Message----- >From: Trahe, Fiona [mailto:fiona.trahe@intel.com] >Sent: 08 May 2018 20:30 >To: Verma, Shally ; De Lara Guarch, Pablo >Cc: Doherty, Declan ; Athreya, Narayana Prasad <= NarayanaPrasad.Athreya@cavium.com>; Sahu, Sunila >; Gupta, Ashish ; dev@dpd= k.org; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [PATCH v2 3/6] lib/cryptodev: add asymmetric crypto capabilit= y in cryptodev > >Hi Shally, > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Thursday, April 5, 2018 12:25 PM >> To: De Lara Guarch, Pablo >> Cc: Doherty, Declan ; Trahe, Fiona ; >> pathreya@caviumnetworks.com; ssahu@caviumnetworks.com; agupta@caviumnetw= orks.com; >> dev@dpdk.org; Sunila Sahu ; Ashish Gupta >> >> Subject: [PATCH v2 3/6] lib/cryptodev: add asymmetric crypto capability = in cryptodev >> >> Extend cryptodev with asymmetric capability APIs and >> definitions. >> >> Signed-off-by: Shally Verma >> Signed-off-by: Sunila Sahu >> Signed-off-by: Ashish Gupta >> >> --- >/// snip /// >> +int __rte_experimental >> +rte_cryptodev_asym_xfrm_capability_check_modlen( >> + const struct rte_cryptodev_asymmetric_xfrm_capability *capability, >> + uint16_t modlen) >> +{ >> + /* handle special case of 0 which mean PMD define no limit defined */ >[Fiona] grammar. Maybe "which means PMD doesn't define any limit" > >> + if ((capability->modlen.min !=3D 0) && >> + ((modlen < capability->modlen.min) || >> + (capability->modlen.increment !=3D 0 && >> + (modlen % (capability->modlen.increment))))) >> + return -1; >> + if ((capability->modlen.max !=3D 0) && >> + ((modlen > capability->modlen.max) || >> + (capability->modlen.increment !=3D 0 && >> + (modlen % (capability->modlen.increment))))) >> + return -1; >> + >> + return 0; >> +} >> + >> >> const char * >> rte_cryptodev_get_feature_name(uint64_t flag) >> diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev= /rte_cryptodev.h >> index 68d1ae1..deae3d6 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev.h >> +++ b/lib/librte_cryptodev/rte_cryptodev.h >> @@ -178,6 +178,37 @@ struct rte_cryptodev_symmetric_capability { >> }; >> }; >> >> +/** >> + * Asymmetric Xform Crypto Capability >> + * >> + */ >> +struct rte_cryptodev_asymmetric_xfrm_capability { >> + enum rte_crypto_asym_xform_type xform_type; >> + /**< Transform type: RSA/MODEXP/DH/DSA/MODINV */ >> + >> + uint32_t op_types; >> + /**< bitmask for supported rte_crypto_asym_op_type */ >> + >> + __extension__ >> + union { >> + struct rte_crypto_param_range modlen; >> + /**< Range of modulus length supported by modulus based xform. >> + * Value 0 mean implementation default >> + */ >> + }; >> +}; >> + >> +/** >> + * Asymmetric Crypto Capability >> + * >> + */ >> +struct rte_cryptodev_asymmetric_capability { >> + enum rte_crypto_asym_xform_type xform_type; >> + /**< Transform type: RSA/MODEXP/DH/DSA/MODINV */ >> + struct rte_cryptodev_asymmetric_xfrm_capability xfrm_capa; >> +}; >[Fiona] Is it necessary to have xform_type in both above structures? >Seems like duplication. Or would it be better if both are combined into 1 = struct? > [Shally] Ok. >> + >> + >> /** Structure used to capture a capability of a crypto device */ >> struct rte_cryptodev_capabilities { >> enum rte_crypto_op_type op; >> @@ -187,6 +218,8 @@ struct rte_cryptodev_capabilities { >> union { >> struct rte_cryptodev_symmetric_capability sym; >> /**< Symmetric operation capability parameters */ >> + struct rte_cryptodev_asymmetric_capability asym; >> + /**< Asymmetric operation capability parameters */ >> }; >> }; >/// snip ///