From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730081.outbound.protection.outlook.com [40.107.73.81]) by dpdk.org (Postfix) with ESMTP id 551B65F33 for ; Mon, 18 Jun 2018 07:30:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IDrjyPwlK4VGIRC4GSyU3AKUY2IAwx7dlBHiF92tP8A=; b=dPH7tDCMLCeQNTVJeC+5r4wjvb3qrd7KDs7ub4P4JsmKQ85wTAAyZnN6+8olS2sJmsoDopuUC9IiusizhJsCAUHJPDdqIhxzPILiqj168t6ZrzGXhK4sdvj3bxRDz+6jfl0/cN/CvuOyd9cC9hem+rZFhkG2zURyzv39Xujs+as= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3828.namprd07.prod.outlook.com (52.132.102.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.14; Mon, 18 Jun 2018 05:30:31 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%2]) with mapi id 15.20.0863.016; Mon, 18 Jun 2018 05:30:30 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHUBj6irvnKsPODDEKF52aG05BtfaRkkSqwgABH5ACAAKR6kA== Date: Mon, 18 Jun 2018 05:30:30 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3828; 7:nGh1rPIiXj5q6YIO9rK/v21hiuq/I+ZRusHJBNrRPzyrK7f3hFrVm6nD5BgsYGiSKSCy1JWquWR7Pd7+YSDWwUDSmCsRYKxBGKhECRzKsHyWWjX07nMOAEyqgTMXd6tmAi1bWDItFcLk+e5RC8A6e5SsK68lP8Zwo9RkzlT/5wPIY7vOS1O2dHTjuWKgQXKMVLUxN+bYsGIGqCqSUXGqvf0kTQluJnH/qYLXruAvQSm7++xRl9flTDtNBppJKG3D x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(346002)(376002)(39850400004)(396003)(39380400002)(366004)(13464003)(189003)(199004)(186003)(5250100002)(72206003)(6506007)(7736002)(54906003)(305945005)(3660700001)(6436002)(74316002)(478600001)(3280700002)(316002)(25786009)(76176011)(26005)(66066001)(97736004)(55236004)(86362001)(102836004)(7696005)(5660300001)(8656006)(11346002)(9686003)(486006)(53936002)(476003)(6246003)(107886003)(14454004)(446003)(8936002)(2900100001)(55016002)(33656002)(81156014)(8676002)(81166006)(229853002)(99286004)(2906002)(105586002)(68736007)(93886005)(6116002)(3846002)(106356001)(6916009)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3828; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: b756d719-8cdd-4501-7f17-08d5d4dc9b26 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3828; x-ms-traffictypediagnostic: CY4PR0701MB3828: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3828; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3828; x-forefront-prvs: 0707248B64 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Cki121Lds/OsdZdgNhGBbk9dKmeS7jWsAjrDcM950sFdtQ0OiOwRGD5EedsXsS0Myt7twR3aX4vF1sTbjeSJ315aXsbbUQFyHnkeiby4i6Of+wUCFFxrGMvW2xDksZaHrW5b2JfshfFUWcSWF+Y3T0OfzH/s7klyqlC5CZLCV3/KV4wGDA/rIlTVkKjT549H9U+cGTDgXAiGYcCSf5DUSAQZ194bvy9RIvbBiaqzans03WoY6G3x6kftaqcK/WldSeTD6fcz4Z0U/kFFxAgi54vi+6TjDqEq6+BjRBU50k+I/1ErnU00DxNwIK2McKpwPXtG9CNSZOD7Adf4Qb6YXA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: b756d719-8cdd-4501-7f17-08d5d4dc9b26 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2018 05:30:30.2115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3828 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 05:30:33 -0000 Hi Pablo >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 18 June 2018 01:09 >To: Verma, Shally >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; dev@dpdk.or= g; Athreya, Narayana Prasad >; Sahu, Sunila = ; Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support > >External Email > //snip >> >> struct rte_cryptodev_ops openssl_pmd_ops =3D { >> >> .dev_configure =3D openssl_pmd_config, >> >> .dev_start =3D openssl_pmd_start, >> >> @@ -750,8 +1138,11 @@ struct rte_cryptodev_ops openssl_pmd_ops =3D { >> >> .queue_pair_count =3D openssl_pmd_qp_count, >> >> >> >> .session_get_size =3D openssl_pmd_session_get_siz= e, >> >> + .asym_session_get_size =3D >> >> openssl_pmd_asym_session_get_size, >> >> .session_configure =3D openssl_pmd_session_configu= re, >> >> - .session_clear =3D openssl_pmd_session_clear >> >> + .asym_session_configure =3D >> >> openssl_pmd_asym_session_configure, >> >> + .session_clear =3D openssl_pmd_session_clear, >> >> + .asym_session_clear =3D openssl_pmd_asym_session_cl= ear >> >> }; >> > >> >I think session_get_size, session_configure and session_clear should be >> >renamed to sym_session_*, to avoid confusion. Could you add another pat= ch >> renaming these? >> > >> [Shally] I see in latest cryptodev these typedefs are already named to >> cryptodev_sym_configure_session_t, _sym_get_session_private_size_t and >> _sym_free_.. so these changes would come while rebase. >> or you are referring to change openssl_pmd_session_configure to >> openssl_pmd_sym_session_configure and so others? > >Yes, but the name is still session_configure/clear, not sym_session_config= ure/clear, right? >And also, I think we should rename the OpenSSL functions, openssl_pmd_sess= ion_*, >to openssl_pmd_sym_session_*. > [Shally] Ok. I will look into this. Thanks Shally >Pablo > >> >> Thanks for review. >> >> >Thanks, >> >Pablo >> >