From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0083.outbound.protection.outlook.com [104.47.34.83]) by dpdk.org (Postfix) with ESMTP id 6A29E5F13 for ; Thu, 17 May 2018 08:10:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dzLKiRsCpPU2Pe0dIBsT4ZdOf07grpw8D7sZjdZ9bxc=; b=WvDNmsv7Odj0bsr83jblDW5QwXegqr1n7J04vWME4i+Vw6vedJ5sItOxZ/fh+MhLClAT1rBWQIDG+nehQmoZ074s2/GU8jjeatOvxoDNUHzISxUN2XUNsqgfqu/7IoUbiPm3HFzxkuWHt9dXz+sXxJ5nq050d4zuJYozA71fZho= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3699.namprd07.prod.outlook.com (52.132.102.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Thu, 17 May 2018 06:10:30 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::b0a9:2be9:bfdf:fc0a]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::b0a9:2be9:bfdf:fc0a%13]) with mapi id 15.20.0755.019; Thu, 17 May 2018 06:10:29 +0000 From: "Verma, Shally" To: Fiona Trahe , "dev@dpdk.org" CC: "pablo.de.lara.guarch@intel.com" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation Thread-Index: AQHT7SDfh7nMjBjdMU2SoyC0y5MnTaQzcN9g Date: Thu, 17 May 2018 06:10:29 +0000 Message-ID: References: <1526480339-13056-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: <1526480339-13056-1-git-send-email-fiona.trahe@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3699; 7:OSauHY+XvW+/dEy4/SN9N4C5OCLPgMcnGFepx+AiXm1CWBQv2dmteyGGRwTiU3t6xdEO+CPoRbEgRZZXmwaXPNXJxLMCYFn3mNLx48UVP/IGzrIxQTlKGHf1EeTM5sdT7sb6ePwB7hzBArHM4ocwjLY3M31A+sGrG+Tw4RakxAKxheGxSmfmP/c50Af3NEB8/JC7VjzsQZWPN6+21K4oFL5lJDsEbMAhxxFUVWXrP2LKeDeYWAmS/1uN8z1BQfqE x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(396003)(346002)(376002)(366004)(189003)(199004)(13464003)(110136005)(3660700001)(3280700002)(6116002)(3846002)(5250100002)(66066001)(7696005)(14454004)(2501003)(5660300001)(68736007)(72206003)(2900100001)(478600001)(316002)(25786009)(76176011)(54906003)(99286004)(86362001)(6436002)(74316002)(476003)(55016002)(97736004)(6246003)(6506007)(229853002)(4326008)(102836004)(55236004)(7736002)(81166006)(105586002)(26005)(446003)(186003)(305945005)(106356001)(11346002)(9686003)(33656002)(107886003)(2906002)(8936002)(53936002)(81156014)(486006)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3699; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3699; x-ms-traffictypediagnostic: CY4PR0701MB3699: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3699; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3699; x-forefront-prvs: 067553F396 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: y3wdqDrWLNIqoLAOrWoOv27HOcL7iDi9bzawHiXUdPXTFuXgWYhep0vU5GTCj74QfukFgnLpL+KjWcUfUvJ7dwRpmIonGwkKDCsgs9wL3py4AHsNrZZFh2tconfXu6xF6KUGAcsmBOxMUmSKMzFtxGIZAqbG4sMym44wFbCVEkkMaFxU7ch5hovVm9pBcXev spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: b79577a9-66b0-4796-f213-08d5bbbce3b2 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: b79577a9-66b0-4796-f213-08d5bbbce3b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2018 06:10:29.0569 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3699 Subject: Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 06:10:32 -0000 >-----Original Message----- >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe >Sent: 16 May 2018 19:49 >To: dev@dpdk.org >Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com >Subject: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation > >Signed-off-by: Fiona Trahe >--- > lib/librte_compressdev/rte_comp.h | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > >diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rt= e_comp.h >index 4c802195f..9826086b1 100644 >--- a/lib/librte_compressdev/rte_comp.h >+++ b/lib/librte_compressdev/rte_comp.h >@@ -295,12 +295,19 @@ struct rte_comp_op { > struct rte_mbuf *m_src; > /**< source mbuf > * The total size of the input buffer(s) can be retrieved using >- * rte_pktmbuf_data_len(m_src) >+ * rte_pktmbuf_data_len(m_src). The max data size which can fit in a >+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1. >+ * If the input data is bigger than this it can be passed to the PMD in >+ * a chain of mbufs if the PMD's capabilities indicate it supports this. > */ > struct rte_mbuf *m_dst; > /**< destination mbuf > * The total size of the output buffer(s) can be retrieved using >- * rte_pktmbuf_data_len(m_dst) >+ * rte_pktmbuf_data_len(m_dst). The max data size which can fit in a >+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1. >+ * If the output data is expected to be bigger than this a chain of >+ * mbufs can be passed to the PMD if the PMD's capabilities indicate >+ * it supports this. > */ [Shally] It will be good idea to add bit more clarification regarding src.o= ffset and dst.offset as well, that is, offset is offset from start of very = first segment of m_src and m_dst in chained bufs. > > struct { >-- >2.13.6