From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0065.outbound.protection.outlook.com [104.47.33.65]) by dpdk.org (Postfix) with ESMTP id 354BC1BB0C for ; Sat, 23 Jun 2018 04:47:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gc65nhbD0alNwod2wukVCyqTBYxCIq6puBNw9OYDggw=; b=iDIk4e8zv3w8ecpr4Ux6xXt5GRJ1ASywFqBzXgoNnpKPUOEYtJEikDR2ACJYVgjBYhNP65gocmvf3QDhE2vJUfuI3VCRak8A1/iW4lXr3EYeSrB2twoM9uzoNJF/s6LFxixpsbqVtALqV7fm3N84Y+UV0iYbjys+9risaKDZ778= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3697.namprd07.prod.outlook.com (52.132.102.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.20; Fri, 22 Jun 2018 15:38:52 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%2]) with mapi id 15.20.0863.021; Fri, 22 Jun 2018 15:38:50 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptodev Thread-Index: AQHUBISJn4XNb0gGrEGR0hFud4zi3qRsbcXQ Date: Fri, 22 Jun 2018 15:38:50 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [117.98.211.75] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3697; 7:3mv19ih1IUH9Gi3sTgpmWx6S1yUOzTJI2NQB+tNS4QjU5EKihwhXcf59RiZFgdYlg8Xoenrb8e7VRJPTTU8RrMwkc0J3iP0M549VXhVPW9j7mL2WrGOoxXGSIEmI1iQgKeAbxVQy4wvSNUua0tNsAyNqGaR9Kmmgp202vuantDNq7E/9mALPYkkdq7khbc4RynRuY0KetuxjadXIMCuJbEOxQP42atxpoOdmMwOclm8u5hANRHp3lDZMuyEDrS3G x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(39860400002)(366004)(346002)(39380400002)(376002)(13464003)(199004)(189003)(74316002)(97736004)(8676002)(76176011)(107886003)(68736007)(305945005)(33656002)(7736002)(6246003)(446003)(476003)(11346002)(2900100001)(4326008)(7696005)(14454004)(72206003)(229853002)(486006)(6116002)(54906003)(81156014)(99286004)(25786009)(5660300001)(106356001)(102836004)(53936002)(186003)(8936002)(81166006)(6506007)(478600001)(66066001)(55016002)(6916009)(3846002)(105586002)(8656006)(86362001)(6436002)(3660700001)(5250100002)(2906002)(3280700002)(316002)(26005)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3697; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: b3fd3ab3-981d-4878-bfce-08d5d85640cf x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989114)(4534165)(4627221)(201703031133081)(201702281549075)(8990104)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3697; x-ms-traffictypediagnostic: CY4PR0701MB3697: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3697; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3697; x-forefront-prvs: 071156160B received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: PEAkZZ+sFgDM623nh9of9hHBlKT9WWNRXLIWx4J6AtRvPBW4f9xpbYBXJyBrmSYxPxDdAP0Dz6XC8iviDZeB3W2UiR+B3DBrsZGM7W87NeuMGtcPuSnIwausD2QcwyBWovXOXUcUXU9cE2ZHjY4a2mVNAtDM6JKCQXJ72qYbNmrjUGh2Km8w4WsRAX+K5x33bMTZv9WX2zshxxzcSc+NcL02frVi59lNpp1YrAzhrrstkOpxj1LleT2lvMWeaJuGkRHVp7e6cgkth/OpqoGl9QT0fDjKXuF+8HXAqkhQvRdDcovMzGfraGbuOhkqCXeLmyYfG94OwijfLleSKs/FBA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3fd3ab3-981d-4878-bfce-08d5d85640cf X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2018 15:38:50.8155 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3697 Subject: Re: [dpdk-dev] [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 02:47:48 -0000 Hi Pablo >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 15 June 2018 14:10 >To: Verma, Shally >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; dev@dpdk.or= g; Athreya, Narayana Prasad >; Sahu, Sunila = ; Gupta, Ashish >Subject: RE: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptod= ev > //snip=20 > >... > >> +/** >> + * Asymmetric Cryptographic Operation. >> + * >> + * Structure describing asymmetric crypto operation params. >> + * >> + */ >> +struct rte_crypto_asym_op { >> + struct rte_cryptodev_asym_session *session; >> + /**< Handle for the initialised session context */ >> + > >Looking at the xform structure, it looks like a chain of xforms is possibl= e. >Looking at this union, this case wouldn't be possible, as only one item fr= om the union can be set. [Shally] xforms, which support chaining, would need to have op_type in thei= r respective xform struct. Example struct rte_crypto_dh_xform, where app can chain Deffie-hellman pu= blic and/or shared secret compute and DSA sign compute. +struct rte_crypto_dh_xform { + enum rte_crypto_asym_op_type type; + /**< Setup xform for key generate or shared secret compute */ and DSA xfo= rms struct test_cryptodev_asym illustrates how to setup chained dh+dsa ops. Thanks Shally > //snip