From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0054.outbound.protection.outlook.com [104.47.36.54]) by dpdk.org (Postfix) with ESMTP id 3179F235 for ; Wed, 9 May 2018 09:33:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hZdQEXLArdhAQZEJmK/r10rdNc2MMCrUma1oBqE8sps=; b=KNOxTB3vA+PommrPo+2MfNfBvoOSAdWFd9iDf4SCHHnwmxr9vxlnbqqeWcsD/w1kFZTJkaoxrmrhi7Pwh2ZglHX83M7gR6azyVItfGf1vbhRMpdCctDzEfTVYhByuHVy3cw4wnTCjsuEWRijrHPrXR1x4dlqFUaKALlHZ94z4gU= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3812.namprd07.prod.outlook.com (52.132.102.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 9 May 2018 07:33:40 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::b0a9:2be9:bfdf:fc0a]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::b0a9:2be9:bfdf:fc0a%13]) with mapi id 15.20.0755.012; Wed, 9 May 2018 07:33:32 +0000 From: "Verma, Shally" To: "Trahe, Fiona" , "De Lara Guarch, Pablo" CC: "Doherty, Declan" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" , "dev@dpdk.org" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev Thread-Index: AQHT5tsDFSrVh4CNcUeXkCljiMchyaQm/yyQ Date: Wed, 9 May 2018 07:33:32 +0000 Message-ID: References: <1522927489-23668-1-git-send-email-shally.verma@caviumnetworks.com> <1522927489-23668-3-git-send-email-shally.verma@caviumnetworks.com> <348A99DA5F5B7549AA880327E580B4358947CD2B@IRSMSX103.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358947CD2B@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3812; 7:Z/nRV3dQZ+qteTxidkUJVE1GeMghGf7KvT2oknwx4p46iDCLKQYr1Rr0sta+GLiXi3p0JhielkBu4raN+356rEZnHWMWN3Zx3IGNFFNx5o9HH1ki+LYgUznYjDzZ0c8VCVbRENH2IxiupHvpcPqHZcxy+/oPfcGS4FNP0HvqQ+auzGbuKN83gbbTTKQ6xkGtF5oFrZ/iUqL71OR/k61D4SRxUzU0+zabU4FSbnn6W++jyUN7vEtckWpaLY8jKdVG x-ms-exchange-antispam-srfa-diagnostics: SOS; x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3812; x-ms-traffictypediagnostic: CY4PR0701MB3812: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR0701MB3812; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3812; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(39850400004)(376002)(346002)(39380400002)(13464003)(189003)(199004)(3280700002)(6116002)(5660300001)(25786009)(305945005)(66066001)(107886003)(55016002)(5250100002)(33656002)(2906002)(8676002)(186003)(97736004)(53936002)(2900100001)(486006)(11346002)(54906003)(9686003)(110136005)(86362001)(7736002)(476003)(3846002)(99286004)(316002)(3660700001)(55236004)(6436002)(106356001)(6506007)(53546011)(4326008)(6246003)(478600001)(105586002)(446003)(72206003)(102836004)(14454004)(76176011)(26005)(7696005)(81166006)(229853002)(81156014)(68736007)(8936002)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3812; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: n08ezXGf/xbck0E+bxlmkiMz07bBO8Tf9gTAJnj+FC6BOrOcsHiPIY/zsd4vqZdyfPI12wvIvMePATV0nkPn5md1nZwgjETVZO+FCz3uMJyhYtwRV9QYxaW8D7//qJElDZURKNgKx4Cfra833O+Mq39XX8pCKohsbr48XZp6IZpMMQqr9jxR9cHWOIzM8rI1 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 69ce0340-970f-4986-cea0-08d5b57f2aad X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69ce0340-970f-4986-cea0-08d5b57f2aad X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 07:33:32.2894 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3812 Subject: Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 07:33:42 -0000 >-----Original Message----- >From: Trahe, Fiona [mailto:fiona.trahe@intel.com] >Sent: 08 May 2018 20:14 >To: Verma, Shally ; De Lara Guarch, Pablo >Cc: Doherty, Declan ; Athreya, Narayana Prasad <= NarayanaPrasad.Athreya@cavium.com>; Sahu, Sunila >; Gupta, Ashish ; dev@dpd= k.org; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptode= v > >Hi Shally, > > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Thursday, April 5, 2018 12:25 PM >> To: De Lara Guarch, Pablo >> Cc: Doherty, Declan ; Trahe, Fiona ; >> pathreya@caviumnetworks.com; ssahu@caviumnetworks.com; agupta@caviumnetw= orks.com; >> dev@dpdk.org; Sunila Sahu ; Ashish Gupta >> >> Subject: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev >> >> struct rte_cryptodev_sym_session * >> rte_cryptodev_sym_session_create(struct rte_mempool *mp) >> { >> struct rte_cryptodev_sym_session *sess; >> >> /* Allocate a session structure from the session pool */ >> - if (rte_mempool_get(mp, (void **)&sess)) { >> + if (rte_mempool_get(mp, (void *)&sess)) { >[Fiona] Are you introducing a bug here? >The fn expects a void ** [Shally] Ya. My bad. Missed it. >Also this will need rebasing - the latest code has an extra byte.