Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto

["Verma, Shally" <Shally.Verma@cavium.com>]

Hi

>-----Original Message-----
>From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>Sent: 18 June 2018 12:10
>To: Verma, Shally <Shally.Verma@cavium.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>Cc: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad
><NarayanaPrasad.Athreya@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>
>Subject: Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
>

//snip

>>>>>> +static int
>>>>>> +test_rsa(struct rsa_test_data *t)
>>>>>
>>>>> ...
>>>>>
>>>>>> +     rsa->n =
>>>>>> +             BN_bin2bn(
>>>>>> +                     (const unsigned char *)rsa_xform.rsa.n.data,
>>>>>> +                     rsa_xform.rsa.n.length,
>>>>>> +                     rsa->n);
>>>>>
>>>>> I am getting a compilation error:
>>>>>
>>>>> /test/test/test_cryptodev_asym.c:322:5: error:
>>>>> dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
>>>>>  rsa->n =
>>>>>     ^~
>>>>>
>>>>> My OpenSSL version is 1.1.0h.
>>>>>
>>>> [Shally] This library is tested with version 1.0.2m (mentioned above) and also
>>>> one supported by openssl PMD . So, you need to take similar version.
>>>
>>> I'd say we should support the latest stable version of OpenSSL.
>>> Could you get the latest 1.1.0?
>> [Shally] Openssl PMD uses 1.0.2h. If we move test to 1.1.0 then dpdk would need to be set
>> to link to two different version of libcrypto whenever openssl PMD is enabled which seems like a cumbersome process for users.
>> So I recommend for now to stick to one version.
>>
>
>OpenSSL PMD can get compiled/linked with any of the versions 1.0.2 or
>1.1. We cannot control the above applications which version it is using.
>So we should not add limitation for openssl version. Please check below
>snippet in the PMD if this is suitable in your case.
>
>+#if (OPENSSL_VERSION_NUMBER < 0x10100000L)
>+static HMAC_CTX *HMAC_CTX_new(void)
>+{
>+       HMAC_CTX *ctx = OPENSSL_malloc(sizeof(*ctx));
>+
>+       if (ctx != NULL)
>+               HMAC_CTX_init(ctx);
>+       return ctx;
>+}
>+
>+static void HMAC_CTX_free(HMAC_CTX *ctx)
>+{
>+       if (ctx != NULL) {
>+               HMAC_CTX_cleanup(ctx);
>+               OPENSSL_free(ctx);
>+       }
>+}
>+#endif
>
[Shally] Are we just planning to make PMD/test compatible for all lib versions? Won't it then be too many version compatibility checks in PMD/test and a maintainability issue than having implementation mentioned to be compatible with specific version?

>
>> Thanks
>> Shally
>>
>>>
>>> Thanks,
>>> Pablo