From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0061.outbound.protection.outlook.com [104.47.38.61]) by dpdk.org (Postfix) with ESMTP id 3F15C1BB86 for ; Thu, 5 Jul 2018 13:58:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qygh0sKFoGNgv1+zfyXD0LFqQ+q3h7yZJvwHamilzFc=; b=LvF9Clb4vsVtFFhQDb1RDZOBhHB/B0DRn1Flsl1NSy/9HlMgUcrL7BxVJDva3Hvst64jr686e01chQJBj5eLP+6QG7PMlZya9OnF1KJGh5YWW9UbySLZ3mUzgjODUX0KEBJ2+uY0Qr1sDRzPNhSCdh+qTS917MEfSffooH5ZT9Q= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3716.namprd07.prod.outlook.com (52.132.102.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Thu, 5 Jul 2018 11:58:48 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%4]) with mapi id 15.20.0906.026; Thu, 5 Jul 2018 11:58:47 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" , "Gupta, Ashish" , "Trahe, Fiona" , "Daly, Lee" , "Sahu, Sunila" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUE+SndvECSlPZO0SAjH2oKlC5saSAT3KwgAAo/wCAAAHpAIAAA66AgAACqHA= Date: Thu, 5 Jul 2018 11:58:47 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-3-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3716; 7:PN7fQUm53+19grLh16xPvbzSypahcgbHhdlfXz5QmK4ZH9udEFMKyFQUvcYdl/wQa30m5WWLCSvLz6wetJECRXEMvAG/RTsRmw72n4Prvn5Jd2uFfoKhoS9cT4X87QNSGZojTXZnfY82Wm/yXFKiJzgatl6z32jZYQ+NhJqoL0omMNFXdUYMuLG2sGRIhwEux9KyH7eiWCudEkGqSu2/lfocAbd7m+Quz/aMYKH/shrDaXGpCFf0B3H4+3+VNTwy x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(136003)(376002)(39850400004)(346002)(366004)(396003)(57704003)(13464003)(199004)(189003)(478600001)(6506007)(53546011)(2906002)(476003)(486006)(68736007)(72206003)(14454004)(6636002)(74316002)(102836004)(186003)(76176011)(55236004)(7696005)(7736002)(26005)(305945005)(5660300001)(2900100001)(11346002)(110136005)(446003)(9686003)(86362001)(55016002)(3846002)(97736004)(4326008)(6116002)(6436002)(33656002)(316002)(66066001)(99286004)(53936002)(6246003)(229853002)(25786009)(5250100002)(105586002)(81156014)(8936002)(8676002)(81166006)(93886005)(256004)(14444005)(106356001)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3716; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 6c6c7d1b-3658-4920-ef0a-08d5e26eaa79 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600053)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3716; x-ms-traffictypediagnostic: CY4PR0701MB3716: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3716; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3716; x-forefront-prvs: 0724FCD4CD received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: FmZlVadeqFi17WNHIUHx2fe9SSwCo73JbJPOuBiyZpuVJs6ulefSeNWuYpukoUof7WXDOfeGGrzjzBglPHqOdDxQbwYLv48raUROHk8TKI9DdnYJG+tozNiMKzUxic+13da1fAMcPC00ZmxVfTtpdQTV961XhmQHSUdGMoLZjOreU3m2YqpgvhmQtC1r/m9UDoh1VS4g+X8u7ru65ouJGjHUeeBzlSyQ6NaG/MiaOBeelKyCdWLOJqK2DTeKC6RJ1RWhVwQmXaDl9rLSHuhIjFk+8CbyeZKscYYscTQ9Otzg0OSZ2TOI1KydXyUtA/6Apmc1LwArRN2RNtDqCaioylMObgYiGHIUIwArKAgv42s= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c6c7d1b-3658-4920-ef0a-08d5e26eaa79 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2018 11:58:47.5990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3716 Subject: Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 11:58:50 -0000 >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 05 July 2018 16:56 >To: Verma, Shally ; Gupta, Ashish ; Trahe, Fiona ; >Daly, Lee ; Sahu, Sunila >Cc: dev@dpdk.org >Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag > >External Email > >> -----Original Message----- >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] >> Sent: Thursday, July 5, 2018 12:13 PM >> To: De Lara Guarch, Pablo ; Gupta, Ashis= h >> ; Trahe, Fiona ; Daly, L= ee >> ; Sahu, Sunila >> Cc: dev@dpdk.org >> Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather fla= g >> >> >> >> >-----Original Message----- >> >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >> >Sent: 05 July 2018 16:36 >> >To: Verma, Shally ; Gupta, Ashish >> >; Trahe, Fiona ; Daly, >> >Lee ; Sahu, Sunila >> >Cc: dev@dpdk.org >> >Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather >> >flag >> > >> >External Email >> > >> >> -----Original Message----- >> >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] >> >> Sent: Thursday, July 5, 2018 9:39 AM >> >> To: De Lara Guarch, Pablo ; Gupta, >> >> Ashish ; Trahe, Fiona >> >> ; Daly, Lee ; Sahu, Sunila >> >> >> >> Cc: dev@dpdk.org >> >> Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather >> >> flag >> >> >> >> >> >> >> >> >-----Original Message----- >> >> >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com] >> >> >Sent: 04 July 2018 19:41 >> >> >To: Verma, Shally ; Gupta, Ashish >> >> >; fiona.trahe@intel.com; lee.daly@intel.com >> >> >Cc: dev@dpdk.org; Pablo de Lara >> >> >Subject: [PATCH v3 3/4] compressdev: replace mbuf scatter gather >> >> >flag >> >> > >> >> >External Email >> >> > >> >> >The current mbuf scatter gather feature flag is too ambiguous, as it >> >> >is not clear if input and/or output buffers can be scatter gather >> >> >mbufs or not. >> >> > >> >> >Therefore, three new flags will replace this flag: >> >> >- RTE_COMP_FF_OOP_SGL_IN_SGL_OUT >> >> >- RTE_COMP_FF_OOP_SGL_IN_FB_OUT >> >> >- RTE_COMP_FF_OOP_FB_IN_SGL_OUT >> >> > >> >> [Shally] Believe Out of place is default support on current >> >> compression API, so why do we need _OOP_ here? >> > >> >Hi Shally, >> > >> >You are right, but I just wanted to clarify that the scenario is for Ou= t of place >> only. >> > >> Ok. But that looks redundant to me. Though not likely, tomorrow if some = algo >> support in-place, Then we will end up adding in_place equivalent of same= . So >> would prefer to keep naming generic of in/out place and specific to Scat= ter- >> gather in/out support. > >I think I am not quite following you. Actually, if in the future we suppor= t >In-place, then it is important to have OOP in the macro, to specify that S= GL >is supported for Out-of-place and maybe not in-place (like in cryptodev). >Otherwise, we would need to break the API, which can be avoided now. Ohh okay, now I get it. So these feature flags intend to show input/output = mode supported specifically for in/out of place operations. But then still I see having O= OP isn't required as compression default support is out-of-place and it's just making feature name too big. = Having in-place is exception=20 and if supported, can use convention RTE_COMP_FF_INPLACE_xx Above one comment, as I see it, use of FB in RTE_COMP_FF_OOP_FB_IN_SGL_OUT = didn't give clear indication what it mean. May be replace it by RTE_COMP_FF_OOP_DIRECT/LINEAR_IN_SGL_OUT Just few suggestions. Thanks Shally -=20 > >Thanks, >Pablo > >> >> >Thanks, >> >Pablo >> > >> >> >> >> Thanks >> >> Shally >> >> >Note that out-of-place flat buffers is supported by default and >> >> >in-place is not supported by the library. >> >> > >> >> >Signed-off-by: Pablo de Lara >> >> >Acked-by: Fiona Trahe