From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0064.outbound.protection.outlook.com [104.47.41.64]) by dpdk.org (Postfix) with ESMTP id 35AD71BF30 for ; Tue, 3 Jul 2018 17:14:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jeKxES83CibvuuEdQjT6vYVMawlQF42XKac+dyQ5PeM=; b=larI0zCmGsGHvf9mTahFYBuI2r4HYsjKCurBmtfJ3uV5mQV16QkTBaYL/7Kjef5obxGiLpwmdSW9luIRlT5ffF9aHZhcfyCB9EUFK1ck+KLKp2jAh18Dh9tMXoNTC8dipR5LlN4uH6wt95sfLP8AZoMYmLg912lCFjCYr2EZ4wA= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3619.namprd07.prod.outlook.com (52.132.101.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.24; Tue, 3 Jul 2018 15:14:13 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%4]) with mapi id 15.20.0906.026; Tue, 3 Jul 2018 15:14:13 +0000 From: "Verma, Shally" To: "Trahe, Fiona" , "De Lara Guarch, Pablo" CC: "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHUEt07KGZjFssjA0CuR01IyHXkk6R9lgJAgAAEgICAAAClwA== Date: Tue, 3 Jul 2018 15:14:13 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> <348A99DA5F5B7549AA880327E580B435895BAC50@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B435895BACB9@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435895BACB9@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3619; 7:Q03R+f9Gsu8sJkhXLy7ukFyJ2pPrUd+MqCVU/CxaRkwuSZA3SqX4mMD3D+8foiki0RsjOwbl0z3KqMh017WmH1QTOFrZ5dLxJaUbslNVg8qDBrieZMLP0F9qsUhWLtiqOQKUHITVPuOeLylFBZ3PtI7+tAjUHe0ZTkaoVV9CzFkJ/jZAVnF3zqeZKktucTskQs/l7ECqd8dgBNePFO8q4Yi/7YS3ISXrvMeiagWssJvV78/eFTeJjfCowqsXFila x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(346002)(366004)(376002)(189003)(199004)(13464003)(478600001)(5250100002)(105586002)(6436002)(2900100001)(305945005)(53936002)(2906002)(5660300001)(106356001)(81166006)(25786009)(55236004)(229853002)(81156014)(72206003)(26005)(186003)(8936002)(8676002)(102836004)(6506007)(7736002)(55016002)(6246003)(107886003)(74316002)(9686003)(4326008)(7696005)(76176011)(68736007)(110136005)(97736004)(316002)(3846002)(6116002)(66066001)(33656002)(11346002)(486006)(14454004)(256004)(446003)(54906003)(476003)(93886005)(86362001)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3619; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: dd153610-af1a-478e-76bc-08d5e0f7a297 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600053)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3619; x-ms-traffictypediagnostic: CY4PR0701MB3619: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3619; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3619; x-forefront-prvs: 0722981D2A received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xYJvgPNBdflNxbj9zYUGmQkXmJUrceifOMPU1a+daZ+SM2qaVOtvBrVi7Ve2uwQ7DLbfmYx2gWDtr0Zz00z+srhpp02VkeOVSMMaWiQMUTvX2vkvGAoq7aVj4rpMkAd8Tpus+VuLPYYOWj59JSqNtgUEs/20dFAmQEhQG18IIovD67ARdE7ydz/9+/j/+CqA0irs4qNEIc+Mom87I454lnTLeYbGda0CNHblhpdfJcflNhmUvtli57d8UzQBEQvjp5DOia5aYmsOxl1lU8diIKekvAZarQlKtOE+kITNnbds8rc+bqf8tUscd81mOjCv75A+R4Enrt3pmO7Ir4jDLPwPD693oWJ68tHT5s3Odvo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd153610-af1a-478e-76bc-08d5e0f7a297 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2018 15:14:13.0541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3619 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 15:14:17 -0000 >-----Original Message----- >From: Trahe, Fiona [mailto:fiona.trahe@intel.com] >Sent: 03 July 2018 20:41 >To: Verma, Shally ; De Lara Guarch, Pablo >Cc: akhil.goyal@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad ; Sahu, Sunila >; Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support > >External Email > //snip >> >> +/* process rsa operations */ >> >> +static int process_openssl_rsa_op(struct rte_crypto_op *cop, >> >> + struct openssl_asym_session *sess) >> >> +{ >> >> + int ret =3D 0; >> >> + struct rte_crypto_asym_op *op =3D cop->asym; >> >> + RSA *rsa =3D sess->u.r.rsa; >> >> + uint32_t pad =3D (op->rsa.pad); >> >> + >> >> + switch (pad) { >> >> + case RTE_CRYPTO_RSA_PKCS1_V1_5_BT1: >> >> + case RTE_CRYPTO_RSA_PKCS1_V1_5_BT2: >> >> + pad =3D RSA_PKCS1_PADDING; >> >> + break; >> >> + case RTE_CRYPTO_RSA_PADDING_PSS: >> >> + pad =3D RSA_PKCS1_PSS_PADDING; >> >> + /* fall through */ >> >> + case RTE_CRYPTO_RSA_PADDING_OAEP: >> >> + pad =3D RSA_PKCS1_OAEP_PADDING; >> >> + /* fall through */ >> >> + default: >> >> + pad =3D RSA_NO_PADDING; >> >> + break; >> >[Fiona] Maybe I'm missing something, but won't this fall through to RSA= _NO_PADDING for OAEP and >> PSS cases? >> > >> >//snip// >> Yes. It will because we were not claiming OAEP/PSS support in 1st cut. A= lso, So, made them switched to >> no-padding. >> However, openssl PMD asym changes , as such, is on hold until it is move= d that to 1.1.0. So, we will >> submit PMD and testapp as a separate patches from >> Lib patch series. >> >[Fiona] ok. I'd suggest leaving out the "pad =3D " in the 2 fall-through c= ases. And expanding comment to >"Not supported yet, so fall-through" for more clarity. All right. noted. Thanks Shally