From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700059.outbound.protection.outlook.com [40.107.70.59]) by dpdk.org (Postfix) with ESMTP id 2EAD81C4CF for ; Fri, 6 Jul 2018 10:53:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQRCbd7HxrrpiEU//8qDsBX5nUxBrDd6+UeqzF3Fgrs=; b=QDYoArtxjoul8U0rLaf/35h5+bWeb/u8BZaWlrPvtJjn7r0CYCk9eR8K7BZesMgS/at08lNa7yDEcUw1ES4QxThUIeXBzlWSpVw3z6DVox+4AZJK+T+lVZk3NeVlJoyJIcbNrOXn//SOQ/QcPyVaoP8h9Fa/0h73I9d7CAHoz9c= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3633.namprd07.prod.outlook.com (52.132.101.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.19; Fri, 6 Jul 2018 08:53:10 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0930.016; Fri, 6 Jul 2018 08:53:09 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" , "Gupta, Ashish" , "Trahe, Fiona" , "Daly, Lee" , "Sahu, Sunila" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUE+SndvECSlPZO0SAjH2oKlC5saSAT3KwgAAo/wCAAAHpAIAAA66AgAACqHCAAWFqAIAAAEBw Date: Fri, 6 Jul 2018 08:53:09 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-3-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3633; 7:AUTKT1iyQ5+tuVZGSIoI8z4ASYZ8NSwyGQjaDytRQUyNusz7tFe2GLBagQibP95hwEyxd7442D+D4e9bmHks7u536/H4RhWu30IKMHKBeTISEP4PT4ZYuvM5AC/H4gBeZNHzrdbqNcZ7FaacnY/BGQp2ZAXEVblEv6WuHsvnSLigg2Z9SGfBjieYNqV9lcBIU2gTDy9Pobg8GfmLw1gClVpnKa0CRjuIH8364qRn0CG0V5v/bZOXeCnzDKiJYkpc x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(136003)(346002)(376002)(366004)(396003)(39850400004)(13464003)(189003)(199004)(11346002)(476003)(5250100002)(2906002)(97736004)(446003)(8936002)(66066001)(478600001)(7736002)(25786009)(305945005)(6636002)(229853002)(55016002)(53936002)(3846002)(486006)(33656002)(5660300001)(256004)(6436002)(86362001)(6116002)(2900100001)(55236004)(72206003)(81156014)(106356001)(81166006)(93886005)(186003)(9686003)(105586002)(76176011)(26005)(102836004)(6506007)(6246003)(14454004)(99286004)(7696005)(68736007)(8676002)(74316002)(110136005)(4326008)(316002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3633; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: dd14b9c6-c8ac-4b5b-3158-08d5e31de634 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3633; x-ms-traffictypediagnostic: CY4PR0701MB3633: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3633; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3633; x-forefront-prvs: 0725D9E8D0 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: pipcgO/LlrUJ3lJFUby6ZIhGmBLR4TqEdiT6ShnmAA7DkD926NLDuCz3qUnZgQea5h1kN4vZEeJPN9ZwHABxy56N6Y//b/2lemPJhSC55F1QRSIAMeeaSEeCeekuCASNO+oQkDETKy6Bb3n8Bah67pBAJVKY9K3lnpL0hb+Bs5snxL3e47CY7G/QQbSG2TXQTNI7Y9It0Fj4v2E6zcbzKxYHLOjNTQi5bjbQ9ZWRRiE0+cF/dZjzoN0HSgqlPmftgHxU6+AghRK6Ixude5eCoq3pp3IgsfIdys7krlT5zCEn4YR+1jrzxN9I5cBk6SreunkuOJo1kJvHECUdGXudSIZf1DKfEoKNzOhgfvnzuJo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd14b9c6-c8ac-4b5b-3158-08d5e31de634 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2018 08:53:09.7123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3633 Subject: Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 08:53:12 -0000 >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 06 July 2018 14:10 >To: Verma, Shally ; Gupta, Ashish ; Trahe, Fiona ; >Daly, Lee ; Sahu, Sunila >Cc: dev@dpdk.org >Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag > //snip >> Ohh okay, now I get it. So these feature flags intend to show input/outp= ut mode >> supported specifically for in/out of place operations. But then still I= see having >> OOP isn't required as compression default support is out-of-place and it= 's just >> making feature name too big. Having in-place is exception and if support= ed, can >> use convention RTE_COMP_FF_INPLACE_xx > >I would still prefer having OOP, to be consistent with cryptodev. It is al= so not that long, it is just 3 letters. > >> >> Above one comment, as I see it, use of FB in >> RTE_COMP_FF_OOP_FB_IN_SGL_OUT didn't give clear indication what it mean. >> May be replace it by RTE_COMP_FF_OOP_DIRECT/LINEAR_IN_SGL_OUT > >Linear could be a good option, but it is missing a noun there. What about = LB (linear buffer), so we keep it short too. Ok. LB looks fine. hopefully, that will make apparent to reader, that it's = opposite of Scatter-Gather. Thanks Shally > >Pablo